From: Ondrej Mosnacek <omosnace@redhat.com> To: selinux@vger.kernel.org, Paul Moore <paul@paul-moore.com> Cc: Stephen Smalley <sds@tycho.nsa.gov>, linux-audit@redhat.com, Ondrej Mosnacek <omosnace@redhat.com> Subject: [PATCH v3 3/4] selinux: remove some useless BUG_ONs Date: Fri, 25 Jan 2019 11:06:50 +0100 [thread overview] Message-ID: <20190125100651.21753-4-omosnace@redhat.com> (raw) In-Reply-To: <20190125100651.21753-1-omosnace@redhat.com> These BUG_ONs do not really protect from any catastrophic situation so there is no need to have them there. Signed-off-by: Ondrej Mosnacek <omosnace@redhat.com> --- security/selinux/avc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/security/selinux/avc.c b/security/selinux/avc.c index 5ebad47391c9..478fa4213c25 100644 --- a/security/selinux/avc.c +++ b/security/selinux/avc.c @@ -1044,7 +1044,6 @@ int avc_has_extended_perms(struct selinux_state *state, int rc = 0, rc2; xp_node = &local_xp_node; - BUG_ON(!requested); rcu_read_lock(); @@ -1134,8 +1133,6 @@ inline int avc_has_perm_noaudit(struct selinux_state *state, int rc = 0; u32 denied; - BUG_ON(!requested); - rcu_read_lock(); node = avc_lookup(state->avc, ssid, tsid, tclass); -- 2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: Ondrej Mosnacek <omosnace@redhat.com> To: selinux@vger.kernel.org, Paul Moore <paul@paul-moore.com> Cc: linux-audit@redhat.com, Stephen Smalley <sds@tycho.nsa.gov> Subject: [PATCH v3 3/4] selinux: remove some useless BUG_ONs Date: Fri, 25 Jan 2019 11:06:50 +0100 [thread overview] Message-ID: <20190125100651.21753-4-omosnace@redhat.com> (raw) In-Reply-To: <20190125100651.21753-1-omosnace@redhat.com> These BUG_ONs do not really protect from any catastrophic situation so there is no need to have them there. Signed-off-by: Ondrej Mosnacek <omosnace@redhat.com> --- security/selinux/avc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/security/selinux/avc.c b/security/selinux/avc.c index 5ebad47391c9..478fa4213c25 100644 --- a/security/selinux/avc.c +++ b/security/selinux/avc.c @@ -1044,7 +1044,6 @@ int avc_has_extended_perms(struct selinux_state *state, int rc = 0, rc2; xp_node = &local_xp_node; - BUG_ON(!requested); rcu_read_lock(); @@ -1134,8 +1133,6 @@ inline int avc_has_perm_noaudit(struct selinux_state *state, int rc = 0; u32 denied; - BUG_ON(!requested); - rcu_read_lock(); node = avc_lookup(state->avc, ssid, tsid, tclass); -- 2.20.1
next prev parent reply other threads:[~2019-01-25 10:07 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-01-25 10:06 [PATCH v3 0/4] Report raw context in AVCs + refactoring Ondrej Mosnacek 2019-01-25 10:06 ` Ondrej Mosnacek 2019-01-25 10:06 ` [PATCH v3 1/4] selinux: inline some AVC functions used only once Ondrej Mosnacek 2019-01-25 10:06 ` Ondrej Mosnacek 2019-01-25 14:49 ` Stephen Smalley 2019-01-25 22:11 ` Paul Moore 2019-01-25 22:11 ` Paul Moore 2019-01-25 10:06 ` [PATCH v3 2/4] selinux: replace some BUG_ON()s with a WARN_ON() Ondrej Mosnacek 2019-01-25 10:06 ` Ondrej Mosnacek 2019-01-25 14:52 ` Stephen Smalley 2019-01-25 22:26 ` Paul Moore 2019-01-25 22:26 ` Paul Moore 2019-01-25 10:06 ` Ondrej Mosnacek [this message] 2019-01-25 10:06 ` [PATCH v3 3/4] selinux: remove some useless BUG_ONs Ondrej Mosnacek 2019-01-25 13:52 ` Stephen Smalley 2019-01-25 15:55 ` Ondrej Mosnacek 2019-01-25 15:55 ` Ondrej Mosnacek 2019-01-25 22:36 ` Paul Moore 2019-01-25 22:36 ` Paul Moore 2019-01-25 10:06 ` [PATCH v3 4/4] selinux: log invalid contexts in AVCs Ondrej Mosnacek 2019-01-25 10:06 ` Ondrej Mosnacek 2019-01-25 14:56 ` Stephen Smalley 2019-01-25 14:56 ` Stephen Smalley 2019-01-25 22:35 ` Paul Moore 2019-01-25 22:35 ` Paul Moore
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190125100651.21753-4-omosnace@redhat.com \ --to=omosnace@redhat.com \ --cc=linux-audit@redhat.com \ --cc=paul@paul-moore.com \ --cc=sds@tycho.nsa.gov \ --cc=selinux@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.