From: Mark Brown <broonie@kernel.org>
To: Jonas Bonn <jonas@norrbonn.se>
Cc: Baolin Wang <baolin.wang@linaro.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-spi <linux-spi@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
DTML <devicetree@vger.kernel.org>
Subject: Re: [PATCH 1/2] spi: support inter-word delay requirement for devices
Date: Fri, 25 Jan 2019 17:47:13 +0000 [thread overview]
Message-ID: <20190125174713.GA6939@sirena.org.uk> (raw)
In-Reply-To: <f34151c8-28a3-3d53-a27e-b5ff512d9c94@norrbonn.se>
[-- Attachment #1: Type: text/plain, Size: 1204 bytes --]
On Fri, Jan 25, 2019 at 01:06:45PM +0100, Jonas Bonn wrote:
> On 25/01/2019 12:53, Baolin Wang wrote:
> > On Fri, 25 Jan 2019 at 19:44, Jonas Bonn <jonas@norrbonn.se> wrote:
> > Can we configure it at runtime by the device rather than at DT time by
> > the controller? If yes, we already have a patch for this, please
> > check:
> It's a characteristic of the SPI slave, in the same sense as CPOL/CPHA are,
> and therefore it makes sense to specify it in the device tree.
No, that doesn't follow at all. There's two bits here - where the
configuration gets done and the mechanism by which it gets done. If
something in DT is completely orthogonal to which device it is a
property of.
> Having this as device property rather than a transfer property allows this
> to be configured one time in setup() rather than having to fiddle with the
> configuration register for every transfer.
That doesn't mean that the coniguration should be done in DT though, and
given that this presumably is a property of the device there seems to be
no reason why we'd have it in DT - if every instance of the device is
going to need to set the property we should just figure it out from the
compatble string instead.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-01-25 17:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-25 11:44 [PATCH 0/2] spi: support inter-word delays Jonas Bonn
2019-01-25 11:44 ` [PATCH 1/2] spi: support inter-word delay requirement for devices Jonas Bonn
2019-01-25 11:53 ` Baolin Wang
2019-01-25 12:06 ` Jonas Bonn
2019-01-25 17:47 ` Mark Brown [this message]
2019-01-25 17:50 ` Mark Brown
2019-01-26 7:52 ` Jonas Bonn
2019-01-26 10:25 ` Geert Uytterhoeven
2019-01-26 15:40 ` Jonas Bonn
2019-01-28 7:41 ` Geert Uytterhoeven
2019-01-28 11:47 ` Mark Brown
2019-01-28 11:51 ` Jonas Bonn
2019-01-28 11:54 ` Geert Uytterhoeven
2019-01-25 11:44 ` [PATCH 2/2] spi-atmel: support inter-word delay Jonas Bonn
2019-01-25 11:44 ` Jonas Bonn
2019-01-25 11:47 ` Jonas Bonn
2019-01-25 11:47 ` Jonas Bonn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190125174713.GA6939@sirena.org.uk \
--to=broonie@kernel.org \
--cc=baolin.wang@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jonas@norrbonn.se \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.