All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonas Bonn <jonas@norrbonn.se>
To: Mark Brown <broonie@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Baolin Wang <baolin.wang@linaro.org>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-spi <linux-spi@vger.kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	DTML <devicetree@vger.kernel.org>
Subject: Re: [PATCH 1/2] spi: support inter-word delay requirement for devices
Date: Mon, 28 Jan 2019 12:51:02 +0100	[thread overview]
Message-ID: <94c7514c-de1f-ff70-d2b7-6394f9747942@norrbonn.se> (raw)
In-Reply-To: <20190128114757.GA11699@sirena.org.uk>



On 28/01/2019 12:47, Mark Brown wrote:
> On Mon, Jan 28, 2019 at 08:41:05AM +0100, Geert Uytterhoeven wrote:
>> On Sat, Jan 26, 2019 at 4:40 PM Jonas Bonn <jonas@norrbonn.se> wrote:
> 
>>> spi-3wire: again, only set by MAXIM DS-1302 which always needs this
>>> setting; driver could set this
> 
>> For DS1302, this is probable true.
>> Some devices may support both 4-wire or 3-wire mode?
> 
> IIRC yes.

Just for the record, the datasheet says it's exclusively 3-wire.  But 
it's not important...

/Jonas

> 
>>> Yeah, that one make sense.  But if the DT is only overriding the maximum
>>> device frequency that the driver should otherwise be setting, why is
>>> spi-max-frequency a _required_ property?
> 
>> That's a good question. Legacy?
> 
> It's a documentation error.
> 

  reply	other threads:[~2019-01-28 11:51 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-25 11:44 [PATCH 0/2] spi: support inter-word delays Jonas Bonn
2019-01-25 11:44 ` [PATCH 1/2] spi: support inter-word delay requirement for devices Jonas Bonn
2019-01-25 11:53   ` Baolin Wang
2019-01-25 12:06     ` Jonas Bonn
2019-01-25 17:47       ` Mark Brown
2019-01-25 17:50         ` Mark Brown
2019-01-26  7:52           ` Jonas Bonn
2019-01-26 10:25             ` Geert Uytterhoeven
2019-01-26 15:40               ` Jonas Bonn
2019-01-28  7:41                 ` Geert Uytterhoeven
2019-01-28 11:47                   ` Mark Brown
2019-01-28 11:51                     ` Jonas Bonn [this message]
2019-01-28 11:54                       ` Geert Uytterhoeven
2019-01-25 11:44 ` [PATCH 2/2] spi-atmel: support inter-word delay Jonas Bonn
2019-01-25 11:44   ` Jonas Bonn
2019-01-25 11:47   ` Jonas Bonn
2019-01-25 11:47     ` Jonas Bonn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=94c7514c-de1f-ff70-d2b7-6394f9747942@norrbonn.se \
    --to=jonas@norrbonn.se \
    --cc=baolin.wang@linaro.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.