From: Boris Brezillon <bbrezillon@kernel.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-mtd@lists.infradead.org,
Nguyen An Hoan <na-hoan@jinso.co.jp>,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org
Subject: Re: [PATCH v2 2/2] eeprom: at25: Use spi_message_init_with_transfers() instead of open coding
Date: Sat, 26 Jan 2019 11:06:48 +0100 [thread overview]
Message-ID: <20190126110639.4717ec0e@bbrezillon> (raw)
In-Reply-To: <20190118140525.29189-3-geert+renesas@glider.be>
On Fri, 18 Jan 2019 15:05:25 +0100
Geert Uytterhoeven <geert+renesas@glider.be> wrote:
> Reduce code duplication in at25_ee_read() by using the
> spi_message_init_with_transfers() helper.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Boris Brezillon <bbrezillon@kernel.org>
> ---
> v2:
> - Add Acked-by.
> ---
> drivers/misc/eeprom/at25.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/misc/eeprom/at25.c b/drivers/misc/eeprom/at25.c
> index 2d8e5388e574710d..18a093e14517ab45 100644
> --- a/drivers/misc/eeprom/at25.c
> +++ b/drivers/misc/eeprom/at25.c
> @@ -103,16 +103,15 @@ static int at25_ee_read(void *priv, unsigned int offset,
> *cp++ = offset >> 0;
> }
>
> - spi_message_init(&m);
> memset(t, 0, sizeof(t));
>
> t[0].tx_buf = command;
> t[0].len = at25->addrlen + 1;
> - spi_message_add_tail(&t[0], &m);
>
> t[1].rx_buf = buf;
> t[1].len = count;
> - spi_message_add_tail(&t[1], &m);
> +
> + spi_message_init_with_transfers(&m, t, ARRAY_SIZE(t));
>
> mutex_lock(&at25->lock);
>
WARNING: multiple messages have this Message-ID (diff)
From: Boris Brezillon <bbrezillon@kernel.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
linux-mtd@lists.infradead.org,
Nguyen An Hoan <na-hoan@jinso.co.jp>
Subject: Re: [PATCH v2 2/2] eeprom: at25: Use spi_message_init_with_transfers() instead of open coding
Date: Sat, 26 Jan 2019 11:06:48 +0100 [thread overview]
Message-ID: <20190126110639.4717ec0e@bbrezillon> (raw)
In-Reply-To: <20190118140525.29189-3-geert+renesas@glider.be>
On Fri, 18 Jan 2019 15:05:25 +0100
Geert Uytterhoeven <geert+renesas@glider.be> wrote:
> Reduce code duplication in at25_ee_read() by using the
> spi_message_init_with_transfers() helper.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Boris Brezillon <bbrezillon@kernel.org>
> ---
> v2:
> - Add Acked-by.
> ---
> drivers/misc/eeprom/at25.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/misc/eeprom/at25.c b/drivers/misc/eeprom/at25.c
> index 2d8e5388e574710d..18a093e14517ab45 100644
> --- a/drivers/misc/eeprom/at25.c
> +++ b/drivers/misc/eeprom/at25.c
> @@ -103,16 +103,15 @@ static int at25_ee_read(void *priv, unsigned int offset,
> *cp++ = offset >> 0;
> }
>
> - spi_message_init(&m);
> memset(t, 0, sizeof(t));
>
> t[0].tx_buf = command;
> t[0].len = at25->addrlen + 1;
> - spi_message_add_tail(&t[0], &m);
>
> t[1].rx_buf = buf;
> t[1].len = count;
> - spi_message_add_tail(&t[1], &m);
> +
> + spi_message_init_with_transfers(&m, t, ARRAY_SIZE(t));
>
> mutex_lock(&at25->lock);
>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2019-01-26 10:07 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-18 14:05 [PATCH v2 0/2] eeprom: at25: SPI transfer improvements Geert Uytterhoeven
2019-01-18 14:05 ` Geert Uytterhoeven
2019-01-18 14:05 ` [PATCH v2 1/2] eeprom: at25: Merge "off" and "offset" in at25_ee_write() Geert Uytterhoeven
2019-01-18 14:05 ` Geert Uytterhoeven
2019-01-26 10:06 ` Boris Brezillon
2019-01-26 10:06 ` Boris Brezillon
2019-01-18 14:05 ` [PATCH v2 2/2] eeprom: at25: Use spi_message_init_with_transfers() instead of open coding Geert Uytterhoeven
2019-01-18 14:05 ` Geert Uytterhoeven
2019-01-26 10:06 ` Boris Brezillon [this message]
2019-01-26 10:06 ` Boris Brezillon
2019-01-18 22:07 ` [PATCH v2 0/2] eeprom: at25: SPI transfer improvements Boris Brezillon
2019-01-18 22:07 ` Boris Brezillon
2019-01-23 18:10 ` Geert Uytterhoeven
2019-01-23 18:10 ` Geert Uytterhoeven
2019-01-29 19:02 ` Geert Uytterhoeven
2019-01-29 19:02 ` Geert Uytterhoeven
2019-01-30 14:50 ` Greg Kroah-Hartman
2019-01-30 14:50 ` Greg Kroah-Hartman
2019-01-30 15:08 ` Boris Brezillon
2019-01-30 15:08 ` Boris Brezillon
2019-01-30 19:40 ` Greg Kroah-Hartman
2019-01-30 19:40 ` Greg Kroah-Hartman
2019-01-30 14:55 ` Boris Brezillon
2019-01-30 14:55 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190126110639.4717ec0e@bbrezillon \
--to=bbrezillon@kernel.org \
--cc=arnd@arndb.de \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=na-hoan@jinso.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.