* [PATCH V3 i-g-t] Skip VBlank tests in modules without VBlank
@ 2019-01-27 19:38 ` Rodrigo Siqueira
0 siblings, 0 replies; 6+ messages in thread
From: Rodrigo Siqueira @ 2019-01-27 19:38 UTC (permalink / raw)
To: Petri Latvala, Arkadiusz Hiler; +Cc: igt-dev, intel-gfx
The kms_flip test relies on VBlank support, and this situation may
exclude some virtual drivers to take advantage of this set of tests.
This commit adds a mechanism that checks if a module has VBlank. If the
target module has VBlank support, kms_flip will run all the VBlank
tests; otherwise, the VBlank tests will be skipped. Additionally, this
commit improves the test coverage by checks if the function
drmWaitVBlank() returns EOPNOTSUPP (i.e., no VBlank support).
Changes since V2:
- Add new branch coverage to check if VBlank is enabled or not
- Update commit message
Changes since V1:
Chris Wilson:
- Change function name from igt_there_is_vblank to kms_has_vblank
- Move vblank function check from igt_aux to igt_kms
- Utilizes memset in dummy_vbl variable
- Directly return the result of drmWaitVBlank()
Signed-off-by: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
---
lib/igt_kms.c | 11 +++++++++++
lib/igt_kms.h | 2 ++
tests/kms_flip.c | 27 +++++++++++++++++++++++++--
3 files changed, 38 insertions(+), 2 deletions(-)
diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index 1a91791c..d720762d 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -1652,6 +1652,17 @@ void igt_assert_plane_visible(int fd, enum pipe pipe, bool visibility)
igt_assert_eq(visible, visibility);
}
+int kms_vblank_status(int fd)
+{
+ drmVBlank dummy_vbl;
+
+ memset(&dummy_vbl, 0, sizeof(drmVBlank));
+ dummy_vbl.request.type = DRM_VBLANK_ABSOLUTE;
+
+ drmWaitVBlank(fd, &dummy_vbl);
+ return errno;
+}
+
/*
* A small modeset API
*/
diff --git a/lib/igt_kms.h b/lib/igt_kms.h
index 4a7c3c97..b6c4e228 100644
--- a/lib/igt_kms.h
+++ b/lib/igt_kms.h
@@ -228,6 +228,8 @@ void kmstest_wait_for_pageflip(int fd);
unsigned int kmstest_get_vblank(int fd, int pipe, unsigned int flags);
void igt_assert_plane_visible(int fd, enum pipe pipe, bool visibility);
+int kms_vblank_status(int fd);
+
/*
* A small modeset API
*/
diff --git a/tests/kms_flip.c b/tests/kms_flip.c
index 3c29f47a..4cdb23a6 100755
--- a/tests/kms_flip.c
+++ b/tests/kms_flip.c
@@ -73,6 +73,7 @@
#define TEST_TS_CONT (1 << 27)
#define TEST_BO_TOOBIG (1 << 28)
+#define TEST_NO_VBLANK (1 << 29)
#define TEST_BASIC (1 << 30)
#define EVENT_FLIP (1 << 0)
@@ -125,6 +126,18 @@ struct event_state {
int seq_step;
};
+static bool vblank_dependence(int flags)
+{
+ int vblank_flags = TEST_VBLANK | TEST_VBLANK_BLOCK |
+ TEST_VBLANK_ABSOLUTE | TEST_VBLANK_EXPIRED_SEQ |
+ TEST_TS_CONT | TEST_CHECK_TS | TEST_VBLANK_RACE;
+
+ if (flags & vblank_flags)
+ return true;
+
+ return false;
+}
+
static float timeval_float(const struct timeval *tv)
{
return tv->tv_sec + tv->tv_usec / 1000000.0f;
@@ -493,11 +506,11 @@ static void check_state(const struct test_output *o, const struct event_state *e
/* check only valid if no modeset happens in between, that increments by
* (1 << 23) on each step. This bounding matches the one in
* DRM_IOCTL_WAIT_VBLANK. */
- if (!(o->flags & (TEST_DPMS | TEST_MODESET)))
+ if (!(o->flags & (TEST_DPMS | TEST_MODESET | TEST_NO_VBLANK))) {
igt_assert_f(es->current_seq - (es->last_seq + o->seq_step) <= 1UL << 23,
"unexpected %s seq %u, should be >= %u\n",
es->name, es->current_seq, es->last_seq + o->seq_step);
-
+ }
/* Check that the vblank frame didn't wrap unexpectedly. */
if (o->flags & TEST_TS_CONT) {
/* Ignore seq_step here since vblank waits time out immediately
@@ -1204,6 +1217,7 @@ static void run_test_on_crtc_set(struct test_output *o, int *crtc_idxs,
unsigned bo_size = 0;
uint64_t tiling;
int i;
+ int vblank_status = 0;
switch (crtc_count) {
case 1:
@@ -1297,6 +1311,15 @@ static void run_test_on_crtc_set(struct test_output *o, int *crtc_idxs,
}
igt_assert(fb_is_bound(o, o->fb_ids[0]));
+ vblank_status = kms_vblank_status(drm_fd);
+ if (vblank_status == EOPNOTSUPP) {
+ if (vblank_dependence(o->flags))
+ igt_require_f(!(vblank_status == EOPNOTSUPP),
+ "Vblank: %s\n", strerror(vblank_status));
+ else
+ o->flags |= TEST_NO_VBLANK;
+ }
+
/* quiescent the hw a bit so ensure we don't miss a single frame */
if (o->flags & TEST_CHECK_TS)
calibrate_ts(o, crtc_idxs[0]);
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [igt-dev] [PATCH V3 i-g-t] Skip VBlank tests in modules without VBlank
@ 2019-01-27 19:38 ` Rodrigo Siqueira
0 siblings, 0 replies; 6+ messages in thread
From: Rodrigo Siqueira @ 2019-01-27 19:38 UTC (permalink / raw)
To: Petri Latvala, Arkadiusz Hiler; +Cc: igt-dev, intel-gfx
The kms_flip test relies on VBlank support, and this situation may
exclude some virtual drivers to take advantage of this set of tests.
This commit adds a mechanism that checks if a module has VBlank. If the
target module has VBlank support, kms_flip will run all the VBlank
tests; otherwise, the VBlank tests will be skipped. Additionally, this
commit improves the test coverage by checks if the function
drmWaitVBlank() returns EOPNOTSUPP (i.e., no VBlank support).
Changes since V2:
- Add new branch coverage to check if VBlank is enabled or not
- Update commit message
Changes since V1:
Chris Wilson:
- Change function name from igt_there_is_vblank to kms_has_vblank
- Move vblank function check from igt_aux to igt_kms
- Utilizes memset in dummy_vbl variable
- Directly return the result of drmWaitVBlank()
Signed-off-by: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
---
lib/igt_kms.c | 11 +++++++++++
lib/igt_kms.h | 2 ++
tests/kms_flip.c | 27 +++++++++++++++++++++++++--
3 files changed, 38 insertions(+), 2 deletions(-)
diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index 1a91791c..d720762d 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -1652,6 +1652,17 @@ void igt_assert_plane_visible(int fd, enum pipe pipe, bool visibility)
igt_assert_eq(visible, visibility);
}
+int kms_vblank_status(int fd)
+{
+ drmVBlank dummy_vbl;
+
+ memset(&dummy_vbl, 0, sizeof(drmVBlank));
+ dummy_vbl.request.type = DRM_VBLANK_ABSOLUTE;
+
+ drmWaitVBlank(fd, &dummy_vbl);
+ return errno;
+}
+
/*
* A small modeset API
*/
diff --git a/lib/igt_kms.h b/lib/igt_kms.h
index 4a7c3c97..b6c4e228 100644
--- a/lib/igt_kms.h
+++ b/lib/igt_kms.h
@@ -228,6 +228,8 @@ void kmstest_wait_for_pageflip(int fd);
unsigned int kmstest_get_vblank(int fd, int pipe, unsigned int flags);
void igt_assert_plane_visible(int fd, enum pipe pipe, bool visibility);
+int kms_vblank_status(int fd);
+
/*
* A small modeset API
*/
diff --git a/tests/kms_flip.c b/tests/kms_flip.c
index 3c29f47a..4cdb23a6 100755
--- a/tests/kms_flip.c
+++ b/tests/kms_flip.c
@@ -73,6 +73,7 @@
#define TEST_TS_CONT (1 << 27)
#define TEST_BO_TOOBIG (1 << 28)
+#define TEST_NO_VBLANK (1 << 29)
#define TEST_BASIC (1 << 30)
#define EVENT_FLIP (1 << 0)
@@ -125,6 +126,18 @@ struct event_state {
int seq_step;
};
+static bool vblank_dependence(int flags)
+{
+ int vblank_flags = TEST_VBLANK | TEST_VBLANK_BLOCK |
+ TEST_VBLANK_ABSOLUTE | TEST_VBLANK_EXPIRED_SEQ |
+ TEST_TS_CONT | TEST_CHECK_TS | TEST_VBLANK_RACE;
+
+ if (flags & vblank_flags)
+ return true;
+
+ return false;
+}
+
static float timeval_float(const struct timeval *tv)
{
return tv->tv_sec + tv->tv_usec / 1000000.0f;
@@ -493,11 +506,11 @@ static void check_state(const struct test_output *o, const struct event_state *e
/* check only valid if no modeset happens in between, that increments by
* (1 << 23) on each step. This bounding matches the one in
* DRM_IOCTL_WAIT_VBLANK. */
- if (!(o->flags & (TEST_DPMS | TEST_MODESET)))
+ if (!(o->flags & (TEST_DPMS | TEST_MODESET | TEST_NO_VBLANK))) {
igt_assert_f(es->current_seq - (es->last_seq + o->seq_step) <= 1UL << 23,
"unexpected %s seq %u, should be >= %u\n",
es->name, es->current_seq, es->last_seq + o->seq_step);
-
+ }
/* Check that the vblank frame didn't wrap unexpectedly. */
if (o->flags & TEST_TS_CONT) {
/* Ignore seq_step here since vblank waits time out immediately
@@ -1204,6 +1217,7 @@ static void run_test_on_crtc_set(struct test_output *o, int *crtc_idxs,
unsigned bo_size = 0;
uint64_t tiling;
int i;
+ int vblank_status = 0;
switch (crtc_count) {
case 1:
@@ -1297,6 +1311,15 @@ static void run_test_on_crtc_set(struct test_output *o, int *crtc_idxs,
}
igt_assert(fb_is_bound(o, o->fb_ids[0]));
+ vblank_status = kms_vblank_status(drm_fd);
+ if (vblank_status == EOPNOTSUPP) {
+ if (vblank_dependence(o->flags))
+ igt_require_f(!(vblank_status == EOPNOTSUPP),
+ "Vblank: %s\n", strerror(vblank_status));
+ else
+ o->flags |= TEST_NO_VBLANK;
+ }
+
/* quiescent the hw a bit so ensure we don't miss a single frame */
if (o->flags & TEST_CHECK_TS)
calibrate_ts(o, crtc_idxs[0]);
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for Skip VBlank tests in modules without VBlank (rev3)
2019-01-27 19:38 ` [igt-dev] " Rodrigo Siqueira
(?)
@ 2019-01-27 20:12 ` Patchwork
-1 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2019-01-27 20:12 UTC (permalink / raw)
To: Rodrigo Siqueira; +Cc: igt-dev
== Series Details ==
Series: Skip VBlank tests in modules without VBlank (rev3)
URL : https://patchwork.freedesktop.org/series/48468/
State : success
== Summary ==
CI Bug Log - changes from IGT_4791 -> IGTPW_2301
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/48468/revisions/3/mbox/
Known issues
------------
Here are the changes found in IGTPW_2301 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@cs-compute:
- fi-kbl-8809g: NOTRUN -> FAIL [fdo#108094]
* igt@amdgpu/amd_prime@amd-to-i915:
- fi-kbl-8809g: NOTRUN -> FAIL [fdo#107341]
* igt@gem_exec_suspend@basic-s3:
- fi-blb-e6850: PASS -> INCOMPLETE [fdo#107718]
* igt@kms_busy@basic-flip-b:
- fi-gdg-551: PASS -> FAIL [fdo#103182]
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a:
- fi-byt-clapper: PASS -> FAIL [fdo#107362]
#### Possible fixes ####
* igt@amdgpu/amd_basic@userptr:
- fi-kbl-8809g: DMESG-WARN [fdo#108965] -> PASS
* igt@i915_selftest@live_hangcheck:
- fi-skl-iommu: INCOMPLETE [fdo#108602] / [fdo#108744] -> PASS
* igt@kms_pipe_crc_basic@hang-read-crc-pipe-a:
- fi-byt-clapper: FAIL [fdo#103191] / [fdo#107362] -> PASS
* igt@kms_pipe_crc_basic@read-crc-pipe-a:
- fi-byt-clapper: FAIL [fdo#107362] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#107341]: https://bugs.freedesktop.org/show_bug.cgi?id=107341
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108094]: https://bugs.freedesktop.org/show_bug.cgi?id=108094
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#108602]: https://bugs.freedesktop.org/show_bug.cgi?id=108602
[fdo#108744]: https://bugs.freedesktop.org/show_bug.cgi?id=108744
[fdo#108965]: https://bugs.freedesktop.org/show_bug.cgi?id=108965
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
Participating hosts (41 -> 38)
------------------------------
Additional (1): fi-icl-u3
Missing (4): fi-kbl-soraka fi-ilk-m540 fi-byt-squawks fi-bsw-cyan
Build changes
-------------
* IGT: IGT_4791 -> IGTPW_2301
CI_DRM_5490: 310d38b4b51e06ef7096716430e2ef262c3e45fe @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2301: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2301/
IGT_4791: cf1222ced94328b6c7be9256e6101505b5d3d143 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2301/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
* [igt-dev] ✗ Fi.CI.IGT: failure for Skip VBlank tests in modules without VBlank (rev3)
2019-01-27 19:38 ` [igt-dev] " Rodrigo Siqueira
(?)
(?)
@ 2019-01-27 23:44 ` Patchwork
2019-02-06 17:32 ` Rodrigo Siqueira
-1 siblings, 1 reply; 6+ messages in thread
From: Patchwork @ 2019-01-27 23:44 UTC (permalink / raw)
To: Rodrigo Siqueira; +Cc: igt-dev
== Series Details ==
Series: Skip VBlank tests in modules without VBlank (rev3)
URL : https://patchwork.freedesktop.org/series/48468/
State : failure
== Summary ==
CI Bug Log - changes from IGT_4791_full -> IGTPW_2301_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_2301_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_2301_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/48468/revisions/3/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_2301_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_eio@in-flight-contexts-1us:
- shard-kbl: NOTRUN -> DMESG-WARN
- shard-apl: NOTRUN -> DMESG-WARN
- shard-glk: NOTRUN -> DMESG-WARN
* igt@gem_mmap_gtt@hang:
- shard-kbl: NOTRUN -> FAIL
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* {igt@runner@aborted}:
- shard-apl: ( 3 FAIL ) -> ( 4 FAIL )
Known issues
------------
Here are the changes found in IGTPW_2301_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_workarounds@suspend-resume-fd:
- shard-kbl: PASS -> INCOMPLETE [fdo#103665]
* igt@i915_suspend@shrink:
- shard-hsw: NOTRUN -> DMESG-WARN [fdo#109244]
* igt@kms_available_modes_crc@available_mode_test_crc:
- shard-glk: PASS -> FAIL [fdo#106641]
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
- shard-apl: PASS -> FAIL [fdo#106510] / [fdo#108145]
* igt@kms_cursor_crc@cursor-128x128-random:
- shard-apl: PASS -> FAIL [fdo#103232] +5
- shard-kbl: PASS -> FAIL [fdo#103232] +1
* igt@kms_cursor_crc@cursor-size-change:
- shard-glk: PASS -> FAIL [fdo#103232] +4
* igt@kms_plane@pixel-format-pipe-b-planes-source-clamping:
- shard-glk: PASS -> FAIL [fdo#108948]
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max:
- shard-glk: NOTRUN -> FAIL [fdo#108145]
- shard-apl: NOTRUN -> FAIL [fdo#108145]
- shard-kbl: NOTRUN -> FAIL [fdo#108145]
* igt@kms_plane_multiple@atomic-pipe-b-tiling-y:
- shard-glk: PASS -> FAIL [fdo#103166] +1
* igt@kms_setmode@basic:
- shard-apl: PASS -> FAIL [fdo#99912]
- shard-kbl: PASS -> FAIL [fdo#99912]
* igt@kms_vblank@pipe-a-wait-idle-hang:
- shard-hsw: PASS -> INCOMPLETE [fdo#103540]
* igt@perf_pmu@rc6-runtime-pm-long:
- shard-apl: PASS -> FAIL [fdo#105010]
- shard-glk: PASS -> FAIL [fdo#105010]
- shard-kbl: PASS -> FAIL [fdo#105010]
#### Possible fixes ####
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
- shard-glk: FAIL [fdo#108145] -> PASS
* igt@kms_cursor_crc@cursor-256x256-sliding:
- shard-kbl: FAIL [fdo#103232] -> PASS
* igt@kms_cursor_crc@cursor-64x64-sliding:
- shard-apl: FAIL [fdo#103232] -> PASS +2
* igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic:
- shard-glk: FAIL [fdo#105454] / [fdo#106509] -> PASS
* igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
- shard-glk: FAIL [fdo#103166] -> PASS +6
* igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
- shard-apl: FAIL [fdo#103166] -> PASS +4
- shard-kbl: FAIL [fdo#103166] -> PASS +1
* igt@kms_sequence@queue-idle:
- shard-hsw: INCOMPLETE [fdo#103540] -> PASS
* igt@perf_pmu@rc6:
- shard-kbl: {SKIP} [fdo#109271] -> PASS
* igt@prime_busy@hang-blt:
- shard-hsw: FAIL -> PASS
#### Warnings ####
* igt@i915_suspend@shrink:
- shard-snb: INCOMPLETE [fdo#105411] / [fdo#106886] -> DMESG-WARN [fdo#109244]
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-indfb-plflip-blt:
- shard-snb: {SKIP} [fdo#109271] -> INCOMPLETE [fdo#105411]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#105010]: https://bugs.freedesktop.org/show_bug.cgi?id=105010
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#105454]: https://bugs.freedesktop.org/show_bug.cgi?id=105454
[fdo#106509]: https://bugs.freedesktop.org/show_bug.cgi?id=106509
[fdo#106510]: https://bugs.freedesktop.org/show_bug.cgi?id=106510
[fdo#106641]: https://bugs.freedesktop.org/show_bug.cgi?id=106641
[fdo#106886]: https://bugs.freedesktop.org/show_bug.cgi?id=106886
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108948]: https://bugs.freedesktop.org/show_bug.cgi?id=108948
[fdo#109244]: https://bugs.freedesktop.org/show_bug.cgi?id=109244
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109373]: https://bugs.freedesktop.org/show_bug.cgi?id=109373
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
[k.org#202321]: https://bugzilla.kernel.org/show_bug.cgi?id=202321
Participating hosts (7 -> 5)
------------------------------
Missing (2): shard-skl shard-iclb
Build changes
-------------
* IGT: IGT_4791 -> IGTPW_2301
CI_DRM_5490: 310d38b4b51e06ef7096716430e2ef262c3e45fe @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2301: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2301/
IGT_4791: cf1222ced94328b6c7be9256e6101505b5d3d143 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2301/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [igt-dev] ✗ Fi.CI.IGT: failure for Skip VBlank tests in modules without VBlank (rev3)
2019-01-27 23:44 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
@ 2019-02-06 17:32 ` Rodrigo Siqueira
2019-02-07 8:53 ` Petri Latvala
0 siblings, 1 reply; 6+ messages in thread
From: Rodrigo Siqueira @ 2019-02-06 17:32 UTC (permalink / raw)
To: Petri Latvala, Arkadiusz Hiler; +Cc: igt-dev
[-- Attachment #1.1: Type: text/plain, Size: 7327 bytes --]
On 01/27, Patchwork wrote:
> == Series Details ==
>
> Series: Skip VBlank tests in modules without VBlank (rev3)
> URL : https://patchwork.freedesktop.org/series/48468/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from IGT_4791_full -> IGTPW_2301_full
> ====================================================
>
> Summary
> -------
>
> **FAILURE**
>
> Serious unknown changes coming with IGTPW_2301_full absolutely need to be
> verified manually.
>
> If you think the reported changes have nothing to do with the changes
> introduced in IGTPW_2301_full, please notify your bug team to allow them
> to document this new failure mode, which will reduce false positives in CI.
>
> External URL: https://patchwork.freedesktop.org/api/1.0/series/48468/revisions/3/mbox/
>
> Possible new issues
> -------------------
>
> Here are the unknown changes that may have been introduced in IGTPW_2301_full:
>
> ### IGT changes ###
>
> #### Possible regressions ####
>
> * igt@gem_eio@in-flight-contexts-1us:
> - shard-kbl: NOTRUN -> DMESG-WARN
> - shard-apl: NOTRUN -> DMESG-WARN
> - shard-glk: NOTRUN -> DMESG-WARN
>
> * igt@gem_mmap_gtt@hang:
> - shard-kbl: NOTRUN -> FAIL
>
Hi,
I tried to figure out the reason for the failure described by the CI
[1]; however, I can’t see any relationship between my patch and the
problem reported by the CI. I tried to reproduce the CI results on my
i915, but all the tests passed on my machine.
I suspect this could be a false positive.
> #### Suppressed ####
>
> The following results come from untrusted machines, tests, or statuses.
> They do not affect the overall result.
>
> * {igt@runner@aborted}:
> - shard-apl: ( 3 FAIL ) -> ( 4 FAIL )
>
>
> Known issues
> ------------
>
> Here are the changes found in IGTPW_2301_full that come from known issues:
>
> ### IGT changes ###
>
> #### Issues hit ####
>
> * igt@gem_workarounds@suspend-resume-fd:
> - shard-kbl: PASS -> INCOMPLETE [fdo#103665]
>
> * igt@i915_suspend@shrink:
> - shard-hsw: NOTRUN -> DMESG-WARN [fdo#109244]
>
> * igt@kms_available_modes_crc@available_mode_test_crc:
> - shard-glk: PASS -> FAIL [fdo#106641]
>
> * igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
> - shard-apl: PASS -> FAIL [fdo#106510] / [fdo#108145]
>
> * igt@kms_cursor_crc@cursor-128x128-random:
> - shard-apl: PASS -> FAIL [fdo#103232] +5
> - shard-kbl: PASS -> FAIL [fdo#103232] +1
>
> * igt@kms_cursor_crc@cursor-size-change:
> - shard-glk: PASS -> FAIL [fdo#103232] +4
>
> * igt@kms_plane@pixel-format-pipe-b-planes-source-clamping:
> - shard-glk: PASS -> FAIL [fdo#108948]
>
> * igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max:
> - shard-glk: NOTRUN -> FAIL [fdo#108145]
> - shard-apl: NOTRUN -> FAIL [fdo#108145]
> - shard-kbl: NOTRUN -> FAIL [fdo#108145]
>
> * igt@kms_plane_multiple@atomic-pipe-b-tiling-y:
> - shard-glk: PASS -> FAIL [fdo#103166] +1
>
> * igt@kms_setmode@basic:
> - shard-apl: PASS -> FAIL [fdo#99912]
> - shard-kbl: PASS -> FAIL [fdo#99912]
>
> * igt@kms_vblank@pipe-a-wait-idle-hang:
> - shard-hsw: PASS -> INCOMPLETE [fdo#103540]
>
> * igt@perf_pmu@rc6-runtime-pm-long:
> - shard-apl: PASS -> FAIL [fdo#105010]
> - shard-glk: PASS -> FAIL [fdo#105010]
> - shard-kbl: PASS -> FAIL [fdo#105010]
>
>
> #### Possible fixes ####
>
> * igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
> - shard-glk: FAIL [fdo#108145] -> PASS
>
> * igt@kms_cursor_crc@cursor-256x256-sliding:
> - shard-kbl: FAIL [fdo#103232] -> PASS
>
> * igt@kms_cursor_crc@cursor-64x64-sliding:
> - shard-apl: FAIL [fdo#103232] -> PASS +2
>
> * igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic:
> - shard-glk: FAIL [fdo#105454] / [fdo#106509] -> PASS
>
> * igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
> - shard-glk: FAIL [fdo#103166] -> PASS +6
>
> * igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
> - shard-apl: FAIL [fdo#103166] -> PASS +4
> - shard-kbl: FAIL [fdo#103166] -> PASS +1
>
> * igt@kms_sequence@queue-idle:
> - shard-hsw: INCOMPLETE [fdo#103540] -> PASS
>
> * igt@perf_pmu@rc6:
> - shard-kbl: {SKIP} [fdo#109271] -> PASS
>
> * igt@prime_busy@hang-blt:
> - shard-hsw: FAIL -> PASS
>
>
> #### Warnings ####
>
> * igt@i915_suspend@shrink:
> - shard-snb: INCOMPLETE [fdo#105411] / [fdo#106886] -> DMESG-WARN [fdo#109244]
>
> * igt@kms_frontbuffer_tracking@psr-1p-primscrn-indfb-plflip-blt:
> - shard-snb: {SKIP} [fdo#109271] -> INCOMPLETE [fdo#105411]
>
>
> {name}: This element is suppressed. This means it is ignored when computing
> the status of the difference (SUCCESS, WARNING, or FAILURE).
>
> [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
> [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
> [fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
> [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
> [fdo#105010]: https://bugs.freedesktop.org/show_bug.cgi?id=105010
> [fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
> [fdo#105454]: https://bugs.freedesktop.org/show_bug.cgi?id=105454
> [fdo#106509]: https://bugs.freedesktop.org/show_bug.cgi?id=106509
> [fdo#106510]: https://bugs.freedesktop.org/show_bug.cgi?id=106510
> [fdo#106641]: https://bugs.freedesktop.org/show_bug.cgi?id=106641
> [fdo#106886]: https://bugs.freedesktop.org/show_bug.cgi?id=106886
> [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
> [fdo#108948]: https://bugs.freedesktop.org/show_bug.cgi?id=108948
> [fdo#109244]: https://bugs.freedesktop.org/show_bug.cgi?id=109244
> [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
> [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
> [fdo#109373]: https://bugs.freedesktop.org/show_bug.cgi?id=109373
> [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
> [k.org#202321]: https://bugzilla.kernel.org/show_bug.cgi?id=202321
>
>
> Participating hosts (7 -> 5)
> ------------------------------
>
> Missing (2): shard-skl shard-iclb
>
>
> Build changes
> -------------
>
> * IGT: IGT_4791 -> IGTPW_2301
>
> CI_DRM_5490: 310d38b4b51e06ef7096716430e2ef262c3e45fe @ git://anongit.freedesktop.org/gfx-ci/linux
> IGTPW_2301: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2301/
> IGT_4791: cf1222ced94328b6c7be9256e6101505b5d3d143 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
>
> == Logs ==
>
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2301/
--
Rodrigo Siqueira
https://siqueira.tech
Graduate Student
Department of Computer Science
University of São Paulo
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [igt-dev] ✗ Fi.CI.IGT: failure for Skip VBlank tests in modules without VBlank (rev3)
2019-02-06 17:32 ` Rodrigo Siqueira
@ 2019-02-07 8:53 ` Petri Latvala
0 siblings, 0 replies; 6+ messages in thread
From: Petri Latvala @ 2019-02-07 8:53 UTC (permalink / raw)
To: Rodrigo Siqueira; +Cc: igt-dev
On Wed, Feb 06, 2019 at 03:32:49PM -0200, Rodrigo Siqueira wrote:
> On 01/27, Patchwork wrote:
> > == Series Details ==
> >
> > Series: Skip VBlank tests in modules without VBlank (rev3)
> > URL : https://patchwork.freedesktop.org/series/48468/
> > State : failure
> >
> > == Summary ==
> >
> > CI Bug Log - changes from IGT_4791_full -> IGTPW_2301_full
> > ====================================================
> >
> > Summary
> > -------
> >
> > **FAILURE**
> >
> > Serious unknown changes coming with IGTPW_2301_full absolutely need to be
> > verified manually.
> >
> > If you think the reported changes have nothing to do with the changes
> > introduced in IGTPW_2301_full, please notify your bug team to allow them
> > to document this new failure mode, which will reduce false positives in CI.
> >
> > External URL: https://patchwork.freedesktop.org/api/1.0/series/48468/revisions/3/mbox/
> >
> > Possible new issues
> > -------------------
> >
> > Here are the unknown changes that may have been introduced in IGTPW_2301_full:
> >
> > ### IGT changes ###
> >
> > #### Possible regressions ####
> >
> > * igt@gem_eio@in-flight-contexts-1us:
> > - shard-kbl: NOTRUN -> DMESG-WARN
> > - shard-apl: NOTRUN -> DMESG-WARN
> > - shard-glk: NOTRUN -> DMESG-WARN
These are https://bugs.freedesktop.org/show_bug.cgi?id=109467 I think
> >
> > * igt@gem_mmap_gtt@hang:
> > - shard-kbl: NOTRUN -> FAIL
And this is https://bugs.freedesktop.org/show_bug.cgi?id=109469
> I tried to figure out the reason for the failure described by the CI
> [1]; however, I can’t see any relationship between my patch and the
> problem reported by the CI. I tried to reproduce the CI results on my
> i915, but all the tests passed on my machine.
>
> I suspect this could be a false positive.
Yep, all false positives.
--
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-02-07 8:53 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-27 19:38 [PATCH V3 i-g-t] Skip VBlank tests in modules without VBlank Rodrigo Siqueira
2019-01-27 19:38 ` [igt-dev] " Rodrigo Siqueira
2019-01-27 20:12 ` [igt-dev] ✓ Fi.CI.BAT: success for Skip VBlank tests in modules without VBlank (rev3) Patchwork
2019-01-27 23:44 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2019-02-06 17:32 ` Rodrigo Siqueira
2019-02-07 8:53 ` Petri Latvala
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.