* [U-Boot] [PATCH] ihs_video_out: Fix error handling
@ 2019-01-28 8:50 Mario Six
2019-01-28 20:31 ` Anatolij Gustschin
0 siblings, 1 reply; 2+ messages in thread
From: Mario Six @ 2019-01-28 8:50 UTC (permalink / raw)
To: u-boot
The ihs_video_out driver's error handling is incorrect in two places
(one is a missing negation, and in one place a error should be ignored).
Fix these two instances.
Signed-off-by: Mario Six <mario.six@gdsys.cc>
---
drivers/video/ihs_video_out.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/video/ihs_video_out.c b/drivers/video/ihs_video_out.c
index 5cdf17aec14..0af7c2bf44a 100644
--- a/drivers/video/ihs_video_out.c
+++ b/drivers/video/ihs_video_out.c
@@ -238,8 +238,8 @@ int ihs_video_out_probe(struct udevice *dev)
int res;
res = regmap_init_mem(dev_ofnode(dev), &priv->map);
- if (!res) {
- debug("%s: Could initialize regmap (err = %d)\n", dev->name,
+ if (res) {
+ debug("%s: Could not initialize regmap (err = %d)\n", dev->name,
res);
return res;
}
@@ -322,7 +322,7 @@ int ihs_video_out_probe(struct udevice *dev)
}
res = display_enable(priv->video_tx, 8, &timing);
- if (res) {
+ if (res && res != -EIO) { /* Ignore missing DP sink error */
debug("%s: Could not enable the display (err = %d)\n",
dev->name, res);
return res;
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [U-Boot] [PATCH] ihs_video_out: Fix error handling
2019-01-28 8:50 [U-Boot] [PATCH] ihs_video_out: Fix error handling Mario Six
@ 2019-01-28 20:31 ` Anatolij Gustschin
0 siblings, 0 replies; 2+ messages in thread
From: Anatolij Gustschin @ 2019-01-28 20:31 UTC (permalink / raw)
To: u-boot
On Mon, 28 Jan 2019 09:50:58 +0100
Mario Six mario.six at gdsys.cc wrote:
> The ihs_video_out driver's error handling is incorrect in two places
> (one is a missing negation, and in one place a error should be ignored).
>
> Fix these two instances.
>
> Signed-off-by: Mario Six <mario.six@gdsys.cc>
> ---
> drivers/video/ihs_video_out.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Applied to u-boot-video/master, thanks!
--
Anatolij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-28 20:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-28 8:50 [U-Boot] [PATCH] ihs_video_out: Fix error handling Mario Six
2019-01-28 20:31 ` Anatolij Gustschin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.