* [PATCH] nft_counter: remove wrong __percpu of nft_counter_resest()'s arg
@ 2019-01-19 21:50 Luc Van Oostenryck
2019-01-28 10:20 ` Pablo Neira Ayuso
0 siblings, 1 reply; 2+ messages in thread
From: Luc Van Oostenryck @ 2019-01-19 21:50 UTC (permalink / raw)
To: Pablo Neira Ayuso
Cc: Jozsef Kadlecsik, Florian Westphal, netfilter-devel, coreteam,
linux-kernel, Luc Van Oostenryck
nft_counter_rest() has its first argument declared as
struct nft_counter_percpu_priv __percpu *priv
but this structure is not percpu (it only countains
a member 'counter' which is, correctly, a pointer to a
percpu struct nft_counter).
So, remove the '__percpu' from the argument's declaration.
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
---
net/netfilter/nft_counter.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/netfilter/nft_counter.c b/net/netfilter/nft_counter.c
index a61d7edfc..1a6b06ce6 100644
--- a/net/netfilter/nft_counter.c
+++ b/net/netfilter/nft_counter.c
@@ -104,7 +104,7 @@ static void nft_counter_obj_destroy(const struct nft_ctx *ctx,
nft_counter_do_destroy(priv);
}
-static void nft_counter_reset(struct nft_counter_percpu_priv __percpu *priv,
+static void nft_counter_reset(struct nft_counter_percpu_priv *priv,
struct nft_counter *total)
{
struct nft_counter *this_cpu;
--
2.20.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] nft_counter: remove wrong __percpu of nft_counter_resest()'s arg
2019-01-19 21:50 [PATCH] nft_counter: remove wrong __percpu of nft_counter_resest()'s arg Luc Van Oostenryck
@ 2019-01-28 10:20 ` Pablo Neira Ayuso
0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2019-01-28 10:20 UTC (permalink / raw)
To: Luc Van Oostenryck
Cc: Jozsef Kadlecsik, Florian Westphal, netfilter-devel, coreteam,
linux-kernel
On Sat, Jan 19, 2019 at 10:50:24PM +0100, Luc Van Oostenryck wrote:
> nft_counter_rest() has its first argument declared as
> struct nft_counter_percpu_priv __percpu *priv
> but this structure is not percpu (it only countains
> a member 'counter' which is, correctly, a pointer to a
> percpu struct nft_counter).
>
> So, remove the '__percpu' from the argument's declaration.
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-28 10:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-19 21:50 [PATCH] nft_counter: remove wrong __percpu of nft_counter_resest()'s arg Luc Van Oostenryck
2019-01-28 10:20 ` Pablo Neira Ayuso
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.