* [PATCH] purgatory: Use standalond CFLAGS
@ 2019-01-28 10:50 Kairui Song
2019-01-28 10:58 ` Simon Horman
0 siblings, 1 reply; 3+ messages in thread
From: Kairui Song @ 2019-01-28 10:50 UTC (permalink / raw)
To: kexec; +Cc: Simon Horman, Dave Young, Kairui Song, Baoquan He
There has been a lot of workarounds for purgatory disabling many
specified CFLAGS that will break purgatory. It will be better to not
let the CFLAGS used to compile purgatory honor the CFLAGS from
environment variables. So we will have stable CFLAGS for purgatory.
If anyone still wants to change purgatory CFLAGS, PURGATORY_EXTRA_CFLAGS
is still honored.
---
purgatory/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/purgatory/Makefile b/purgatory/Makefile
index 49ce80a..2dd6c47 100644
--- a/purgatory/Makefile
+++ b/purgatory/Makefile
@@ -45,7 +45,7 @@ purgatory/sha256.o: $(srcdir)/util_lib/sha256.c
$(COMPILE.c) -o $@ $^
$(PURGATORY): CC=$(TARGET_CC)
-$(PURGATORY): CFLAGS+=$(PURGATORY_EXTRA_CFLAGS) \
+$(PURGATORY): CFLAGS=$(PURGATORY_EXTRA_CFLAGS) \
$($(ARCH)_PURGATORY_EXTRA_CFLAGS) \
-Os -fno-builtin -ffreestanding \
-fno-zero-initialized-in-bss \
--
2.20.1
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] purgatory: Use standalond CFLAGS
2019-01-28 10:50 [PATCH] purgatory: Use standalond CFLAGS Kairui Song
@ 2019-01-28 10:58 ` Simon Horman
2019-02-05 14:21 ` Simon Horman
0 siblings, 1 reply; 3+ messages in thread
From: Simon Horman @ 2019-01-28 10:58 UTC (permalink / raw)
To: Kairui Song; +Cc: Dave Young, kexec, Baoquan He
On Mon, Jan 28, 2019 at 06:50:40PM +0800, Kairui Song wrote:
> There has been a lot of workarounds for purgatory disabling many
> specified CFLAGS that will break purgatory. It will be better to not
> let the CFLAGS used to compile purgatory honor the CFLAGS from
> environment variables. So we will have stable CFLAGS for purgatory.
>
> If anyone still wants to change purgatory CFLAGS, PURGATORY_EXTRA_CFLAGS
> is still honored.
Thanks, this seems reasonable to me.
But I'd like to wait to see if there is feedback from others before applying.
>
> ---
> purgatory/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/purgatory/Makefile b/purgatory/Makefile
> index 49ce80a..2dd6c47 100644
> --- a/purgatory/Makefile
> +++ b/purgatory/Makefile
> @@ -45,7 +45,7 @@ purgatory/sha256.o: $(srcdir)/util_lib/sha256.c
> $(COMPILE.c) -o $@ $^
>
> $(PURGATORY): CC=$(TARGET_CC)
> -$(PURGATORY): CFLAGS+=$(PURGATORY_EXTRA_CFLAGS) \
> +$(PURGATORY): CFLAGS=$(PURGATORY_EXTRA_CFLAGS) \
> $($(ARCH)_PURGATORY_EXTRA_CFLAGS) \
> -Os -fno-builtin -ffreestanding \
> -fno-zero-initialized-in-bss \
> --
> 2.20.1
>
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] purgatory: Use standalond CFLAGS
2019-01-28 10:58 ` Simon Horman
@ 2019-02-05 14:21 ` Simon Horman
0 siblings, 0 replies; 3+ messages in thread
From: Simon Horman @ 2019-02-05 14:21 UTC (permalink / raw)
To: Kairui Song; +Cc: kexec, Dave Young, Baoquan He
On Mon, Jan 28, 2019 at 11:58:44AM +0100, Simon Horman wrote:
> On Mon, Jan 28, 2019 at 06:50:40PM +0800, Kairui Song wrote:
> > There has been a lot of workarounds for purgatory disabling many
> > specified CFLAGS that will break purgatory. It will be better to not
> > let the CFLAGS used to compile purgatory honor the CFLAGS from
> > environment variables. So we will have stable CFLAGS for purgatory.
> >
> > If anyone still wants to change purgatory CFLAGS, PURGATORY_EXTRA_CFLAGS
> > is still honored.
>
> Thanks, this seems reasonable to me.
> But I'd like to wait to see if there is feedback from others before applying.
Thanks again, applied.
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-05 14:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-28 10:50 [PATCH] purgatory: Use standalond CFLAGS Kairui Song
2019-01-28 10:58 ` Simon Horman
2019-02-05 14:21 ` Simon Horman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.