* [PATCH] drm: Constify drm_color_lut_check()
@ 2019-01-29 17:06 Ville Syrjala
2019-01-29 17:52 ` Sam Ravnborg
` (3 more replies)
0 siblings, 4 replies; 8+ messages in thread
From: Ville Syrjala @ 2019-01-29 17:06 UTC (permalink / raw)
To: dri-devel; +Cc: intel-gfx
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
drm_color_lut_check() doens't modify the passed in blob so
let's make it const.
Also s/uint32_y/u32/ while at it.
Cc: Matt Roper <matthew.d.roper@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/drm_color_mgmt.c | 6 +++---
include/drm/drm_color_mgmt.h | 4 ++--
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/drm_color_mgmt.c b/drivers/gpu/drm/drm_color_mgmt.c
index 968ca7c91ad8..3c8826a91a03 100644
--- a/drivers/gpu/drm/drm_color_mgmt.c
+++ b/drivers/gpu/drm/drm_color_mgmt.c
@@ -474,10 +474,10 @@ EXPORT_SYMBOL(drm_plane_create_color_properties);
*
* Returns 0 on success, -EINVAL on failure.
*/
-int drm_color_lut_check(struct drm_property_blob *lut,
- uint32_t tests)
+int drm_color_lut_check(const struct drm_property_blob *lut,
+ u32 tests)
{
- struct drm_color_lut *entry;
+ const struct drm_color_lut *entry;
int i;
if (!lut || !tests)
diff --git a/include/drm/drm_color_mgmt.h b/include/drm/drm_color_mgmt.h
index 6affbda6d9cb..58d4b20b5b97 100644
--- a/include/drm/drm_color_mgmt.h
+++ b/include/drm/drm_color_mgmt.h
@@ -96,6 +96,6 @@ enum drm_color_lut_tests {
DRM_COLOR_LUT_NON_DECREASING = BIT(1),
};
-int drm_color_lut_check(struct drm_property_blob *lut,
- uint32_t tests);
+int drm_color_lut_check(const struct drm_property_blob *lut,
+ u32 tests);
#endif
--
2.19.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] drm: Constify drm_color_lut_check()
2019-01-29 17:06 [PATCH] drm: Constify drm_color_lut_check() Ville Syrjala
@ 2019-01-29 17:52 ` Sam Ravnborg
2019-01-29 17:58 ` Ville Syrjälä
2019-01-29 18:05 ` ✓ Fi.CI.BAT: success for " Patchwork
` (2 subsequent siblings)
3 siblings, 1 reply; 8+ messages in thread
From: Sam Ravnborg @ 2019-01-29 17:52 UTC (permalink / raw)
To: Ville Syrjala; +Cc: intel-gfx, dri-devel
Hi Ville.
On Tue, Jan 29, 2019 at 07:06:09PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> drm_color_lut_check() doens't modify the passed in blob so
> let's make it const.
>
> Also s/uint32_y/u32/ while at it.
>
> Cc: Matt Roper <matthew.d.roper@intel.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/drm_color_mgmt.c | 6 +++---
> include/drm/drm_color_mgmt.h | 4 ++--
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_color_mgmt.c b/drivers/gpu/drm/drm_color_mgmt.c
> index 968ca7c91ad8..3c8826a91a03 100644
> --- a/drivers/gpu/drm/drm_color_mgmt.c
> +++ b/drivers/gpu/drm/drm_color_mgmt.c
> @@ -474,10 +474,10 @@ EXPORT_SYMBOL(drm_plane_create_color_properties);
> *
> * Returns 0 on success, -EINVAL on failure.
> */
> -int drm_color_lut_check(struct drm_property_blob *lut,
> - uint32_t tests)
> +int drm_color_lut_check(const struct drm_property_blob *lut,
> + u32 tests)
No need to linewrap this line.
> {
> - struct drm_color_lut *entry;
> + const struct drm_color_lut *entry;
> int i;
>
> if (!lut || !tests)
> diff --git a/include/drm/drm_color_mgmt.h b/include/drm/drm_color_mgmt.h
> index 6affbda6d9cb..58d4b20b5b97 100644
> --- a/include/drm/drm_color_mgmt.h
> +++ b/include/drm/drm_color_mgmt.h
> @@ -96,6 +96,6 @@ enum drm_color_lut_tests {
> DRM_COLOR_LUT_NON_DECREASING = BIT(1),
> };
>
> -int drm_color_lut_check(struct drm_property_blob *lut,
> - uint32_t tests);
> +int drm_color_lut_check(const struct drm_property_blob *lut,
> + u32 tests);
Likewise.
With the linewrap fixed:
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Note: does not apply to my drm-misc tree. Anything I miss here?
Sam
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm: Constify drm_color_lut_check()
2019-01-29 17:52 ` Sam Ravnborg
@ 2019-01-29 17:58 ` Ville Syrjälä
2019-01-29 19:04 ` [Intel-gfx] " Daniel Vetter
0 siblings, 1 reply; 8+ messages in thread
From: Ville Syrjälä @ 2019-01-29 17:58 UTC (permalink / raw)
To: Sam Ravnborg; +Cc: intel-gfx, dri-devel
On Tue, Jan 29, 2019 at 06:52:51PM +0100, Sam Ravnborg wrote:
> Hi Ville.
>
> On Tue, Jan 29, 2019 at 07:06:09PM +0200, Ville Syrjala wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > drm_color_lut_check() doens't modify the passed in blob so
> > let's make it const.
> >
> > Also s/uint32_y/u32/ while at it.
> >
> > Cc: Matt Roper <matthew.d.roper@intel.com>
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> > drivers/gpu/drm/drm_color_mgmt.c | 6 +++---
> > include/drm/drm_color_mgmt.h | 4 ++--
> > 2 files changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/drm_color_mgmt.c b/drivers/gpu/drm/drm_color_mgmt.c
> > index 968ca7c91ad8..3c8826a91a03 100644
> > --- a/drivers/gpu/drm/drm_color_mgmt.c
> > +++ b/drivers/gpu/drm/drm_color_mgmt.c
> > @@ -474,10 +474,10 @@ EXPORT_SYMBOL(drm_plane_create_color_properties);
> > *
> > * Returns 0 on success, -EINVAL on failure.
> > */
> > -int drm_color_lut_check(struct drm_property_blob *lut,
> > - uint32_t tests)
> > +int drm_color_lut_check(const struct drm_property_blob *lut,
> > + u32 tests)
>
> No need to linewrap this line.
> > {
> > - struct drm_color_lut *entry;
> > + const struct drm_color_lut *entry;
> > int i;
> >
> > if (!lut || !tests)
> > diff --git a/include/drm/drm_color_mgmt.h b/include/drm/drm_color_mgmt.h
> > index 6affbda6d9cb..58d4b20b5b97 100644
> > --- a/include/drm/drm_color_mgmt.h
> > +++ b/include/drm/drm_color_mgmt.h
> > @@ -96,6 +96,6 @@ enum drm_color_lut_tests {
> > DRM_COLOR_LUT_NON_DECREASING = BIT(1),
> > };
> >
> > -int drm_color_lut_check(struct drm_property_blob *lut,
> > - uint32_t tests);
> > +int drm_color_lut_check(const struct drm_property_blob *lut,
> > + u32 tests);
> Likewise.
>
> With the linewrap fixed:
> Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Thanks.
>
> Note: does not apply to my drm-misc tree. Anything I miss here?
I think it was merged via drm-intel.
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* ✓ Fi.CI.BAT: success for drm: Constify drm_color_lut_check()
2019-01-29 17:06 [PATCH] drm: Constify drm_color_lut_check() Ville Syrjala
2019-01-29 17:52 ` Sam Ravnborg
@ 2019-01-29 18:05 ` Patchwork
2019-01-29 19:24 ` [PATCH] " Brian Starkey
2019-01-29 20:47 ` ✓ Fi.CI.IGT: success for " Patchwork
3 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2019-01-29 18:05 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
== Series Details ==
Series: drm: Constify drm_color_lut_check()
URL : https://patchwork.freedesktop.org/series/55924/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5501 -> Patchwork_12076
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/55924/revisions/1/mbox/
Known issues
------------
Here are the changes found in Patchwork_12076 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@userptr:
- fi-kbl-8809g: PASS -> DMESG-WARN [fdo#108965]
* igt@kms_busy@basic-flip-a:
- fi-gdg-551: NOTRUN -> FAIL [fdo#103182] +1
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a:
- fi-byt-clapper: PASS -> FAIL [fdo#107362]
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- fi-byt-clapper: PASS -> FAIL [fdo#103191] / [fdo#107362]
#### Possible fixes ####
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b-frame-sequence:
- fi-byt-clapper: FAIL [fdo#103191] / [fdo#107362] -> PASS +1
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#108915]: https://bugs.freedesktop.org/show_bug.cgi?id=108915
[fdo#108965]: https://bugs.freedesktop.org/show_bug.cgi?id=108965
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
Participating hosts (46 -> 41)
------------------------------
Additional (2): fi-icl-y fi-gdg-551
Missing (7): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_5501 -> Patchwork_12076
CI_DRM_5501: 5aac0b69f3a3085b9b8a9924cb19cb94f7860dbe @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4798: 998e0a4aedf10fb5f7c271018cd80d874668bf55 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12076: 4c5ebfc18c9220e99fa8eac8a5abcaec8c0e2ba6 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
4c5ebfc18c92 drm: Constify drm_color_lut_check()
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12076/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH] drm: Constify drm_color_lut_check()
2019-01-29 17:58 ` Ville Syrjälä
@ 2019-01-29 19:04 ` Daniel Vetter
2019-01-29 21:33 ` Ville Syrjälä
0 siblings, 1 reply; 8+ messages in thread
From: Daniel Vetter @ 2019-01-29 19:04 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx, Sam Ravnborg, dri-devel
On Tue, Jan 29, 2019 at 07:58:56PM +0200, Ville Syrjälä wrote:
> On Tue, Jan 29, 2019 at 06:52:51PM +0100, Sam Ravnborg wrote:
> > Hi Ville.
> >
> > On Tue, Jan 29, 2019 at 07:06:09PM +0200, Ville Syrjala wrote:
> > > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > >
> > > drm_color_lut_check() doens't modify the passed in blob so
> > > let's make it const.
> > >
> > > Also s/uint32_y/u32/ while at it.
> > >
> > > Cc: Matt Roper <matthew.d.roper@intel.com>
> > > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > ---
> > > drivers/gpu/drm/drm_color_mgmt.c | 6 +++---
> > > include/drm/drm_color_mgmt.h | 4 ++--
> > > 2 files changed, 5 insertions(+), 5 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/drm_color_mgmt.c b/drivers/gpu/drm/drm_color_mgmt.c
> > > index 968ca7c91ad8..3c8826a91a03 100644
> > > --- a/drivers/gpu/drm/drm_color_mgmt.c
> > > +++ b/drivers/gpu/drm/drm_color_mgmt.c
> > > @@ -474,10 +474,10 @@ EXPORT_SYMBOL(drm_plane_create_color_properties);
> > > *
> > > * Returns 0 on success, -EINVAL on failure.
> > > */
> > > -int drm_color_lut_check(struct drm_property_blob *lut,
> > > - uint32_t tests)
> > > +int drm_color_lut_check(const struct drm_property_blob *lut,
> > > + u32 tests)
> >
> > No need to linewrap this line.
> > > {
> > > - struct drm_color_lut *entry;
> > > + const struct drm_color_lut *entry;
> > > int i;
> > >
> > > if (!lut || !tests)
> > > diff --git a/include/drm/drm_color_mgmt.h b/include/drm/drm_color_mgmt.h
> > > index 6affbda6d9cb..58d4b20b5b97 100644
> > > --- a/include/drm/drm_color_mgmt.h
> > > +++ b/include/drm/drm_color_mgmt.h
> > > @@ -96,6 +96,6 @@ enum drm_color_lut_tests {
> > > DRM_COLOR_LUT_NON_DECREASING = BIT(1),
> > > };
> > >
> > > -int drm_color_lut_check(struct drm_property_blob *lut,
> > > - uint32_t tests);
> > > +int drm_color_lut_check(const struct drm_property_blob *lut,
> > > + u32 tests);
> > Likewise.
> >
> > With the linewrap fixed:
> > Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
>
> Thanks.
>
> >
> > Note: does not apply to my drm-misc tree. Anything I miss here?
>
> I think it was merged via drm-intel.
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
for merging through drm-intel then (assuming it goes in before the merge
cutoff), with Sam's suggestions ofc.
-Daniel
>
> --
> Ville Syrjälä
> Intel
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm: Constify drm_color_lut_check()
2019-01-29 17:06 [PATCH] drm: Constify drm_color_lut_check() Ville Syrjala
2019-01-29 17:52 ` Sam Ravnborg
2019-01-29 18:05 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2019-01-29 19:24 ` Brian Starkey
2019-01-29 20:47 ` ✓ Fi.CI.IGT: success for " Patchwork
3 siblings, 0 replies; 8+ messages in thread
From: Brian Starkey @ 2019-01-29 19:24 UTC (permalink / raw)
To: Ville Syrjala; +Cc: intel-gfx, nd, dri-devel
On Tue, Jan 29, 2019 at 07:06:09PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> drm_color_lut_check() doens't modify the passed in blob so
s/doens't/doesn't/
Otherwise, LGTM.
Reviewed-by: <brian.starkey@arm.com>
> let's make it const.
>
> Also s/uint32_y/u32/ while at it.
>
> Cc: Matt Roper <matthew.d.roper@intel.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/drm_color_mgmt.c | 6 +++---
> include/drm/drm_color_mgmt.h | 4 ++--
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_color_mgmt.c b/drivers/gpu/drm/drm_color_mgmt.c
> index 968ca7c91ad8..3c8826a91a03 100644
> --- a/drivers/gpu/drm/drm_color_mgmt.c
> +++ b/drivers/gpu/drm/drm_color_mgmt.c
> @@ -474,10 +474,10 @@ EXPORT_SYMBOL(drm_plane_create_color_properties);
> *
> * Returns 0 on success, -EINVAL on failure.
> */
> -int drm_color_lut_check(struct drm_property_blob *lut,
> - uint32_t tests)
> +int drm_color_lut_check(const struct drm_property_blob *lut,
> + u32 tests)
> {
> - struct drm_color_lut *entry;
> + const struct drm_color_lut *entry;
> int i;
>
> if (!lut || !tests)
> diff --git a/include/drm/drm_color_mgmt.h b/include/drm/drm_color_mgmt.h
> index 6affbda6d9cb..58d4b20b5b97 100644
> --- a/include/drm/drm_color_mgmt.h
> +++ b/include/drm/drm_color_mgmt.h
> @@ -96,6 +96,6 @@ enum drm_color_lut_tests {
> DRM_COLOR_LUT_NON_DECREASING = BIT(1),
> };
>
> -int drm_color_lut_check(struct drm_property_blob *lut,
> - uint32_t tests);
> +int drm_color_lut_check(const struct drm_property_blob *lut,
> + u32 tests);
> #endif
> --
> 2.19.2
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* ✓ Fi.CI.IGT: success for drm: Constify drm_color_lut_check()
2019-01-29 17:06 [PATCH] drm: Constify drm_color_lut_check() Ville Syrjala
` (2 preceding siblings ...)
2019-01-29 19:24 ` [PATCH] " Brian Starkey
@ 2019-01-29 20:47 ` Patchwork
3 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2019-01-29 20:47 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
== Series Details ==
Series: drm: Constify drm_color_lut_check()
URL : https://patchwork.freedesktop.org/series/55924/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5501_full -> Patchwork_12076_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_12076_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b:
- shard-snb: NOTRUN -> DMESG-WARN [fdo#107956]
* igt@kms_color@pipe-b-degamma:
- shard-apl: PASS -> FAIL [fdo#104782]
* igt@kms_cursor_crc@cursor-256x85-sliding:
- shard-apl: PASS -> FAIL [fdo#103232] +2
* igt@kms_cursor_crc@cursor-64x21-onscreen:
- shard-glk: PASS -> FAIL [fdo#103232] +1
* igt@kms_plane@pixel-format-pipe-a-planes:
- shard-glk: PASS -> FAIL [fdo#103166]
* igt@kms_plane@pixel-format-pipe-c-planes-source-clamping:
- shard-apl: PASS -> FAIL [fdo#108948]
* igt@kms_plane@plane-position-covered-pipe-c-planes:
- shard-apl: PASS -> FAIL [fdo#103166] +2
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max:
- shard-apl: PASS -> FAIL [fdo#108145]
* igt@kms_setmode@basic:
- shard-kbl: PASS -> FAIL [fdo#99912]
#### Possible fixes ####
* igt@kms_color@pipe-b-ctm-max:
- shard-apl: FAIL [fdo#108147] -> PASS
* igt@kms_cursor_crc@cursor-256x256-random:
- shard-glk: FAIL [fdo#103232] -> PASS +1
* igt@kms_cursor_crc@cursor-256x256-suspend:
- shard-apl: FAIL [fdo#103191] / [fdo#103232] -> PASS
* igt@kms_cursor_crc@cursor-64x21-random:
- shard-apl: FAIL [fdo#103232] -> PASS +5
* igt@kms_flip@flip-vs-expired-vblank:
- shard-glk: FAIL [fdo#102887] / [fdo#105363] -> PASS
* igt@kms_plane_multiple@atomic-pipe-b-tiling-x:
- shard-apl: FAIL [fdo#103166] -> PASS +1
* igt@kms_plane_multiple@atomic-pipe-c-tiling-x:
- shard-glk: FAIL [fdo#103166] -> PASS
* igt@kms_setmode@basic:
- shard-apl: FAIL [fdo#99912] -> PASS
* igt@perf_pmu@rc6-runtime-pm-long:
- shard-apl: FAIL [fdo#105010] -> PASS
* igt@prime_busy@hang-bsd:
- shard-hsw: FAIL [fdo#108807] -> PASS
#### Warnings ####
* igt@i915_suspend@shrink:
- shard-glk: DMESG-WARN [fdo#109244] -> INCOMPLETE [fdo#103359] / [fdo#106886] / [k.org#198133]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#102887]: https://bugs.freedesktop.org/show_bug.cgi?id=102887
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
[fdo#105010]: https://bugs.freedesktop.org/show_bug.cgi?id=105010
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#106886]: https://bugs.freedesktop.org/show_bug.cgi?id=106886
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147
[fdo#108807]: https://bugs.freedesktop.org/show_bug.cgi?id=108807
[fdo#108948]: https://bugs.freedesktop.org/show_bug.cgi?id=108948
[fdo#109244]: https://bugs.freedesktop.org/show_bug.cgi?id=109244
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (7 -> 5)
------------------------------
Missing (2): shard-skl shard-iclb
Build changes
-------------
* Linux: CI_DRM_5501 -> Patchwork_12076
CI_DRM_5501: 5aac0b69f3a3085b9b8a9924cb19cb94f7860dbe @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4798: 998e0a4aedf10fb5f7c271018cd80d874668bf55 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12076: 4c5ebfc18c9220e99fa8eac8a5abcaec8c0e2ba6 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12076/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH] drm: Constify drm_color_lut_check()
2019-01-29 19:04 ` [Intel-gfx] " Daniel Vetter
@ 2019-01-29 21:33 ` Ville Syrjälä
0 siblings, 0 replies; 8+ messages in thread
From: Ville Syrjälä @ 2019-01-29 21:33 UTC (permalink / raw)
To: Daniel Vetter; +Cc: intel-gfx, Sam Ravnborg, dri-devel
On Tue, Jan 29, 2019 at 08:04:18PM +0100, Daniel Vetter wrote:
> On Tue, Jan 29, 2019 at 07:58:56PM +0200, Ville Syrjälä wrote:
> > On Tue, Jan 29, 2019 at 06:52:51PM +0100, Sam Ravnborg wrote:
> > > Hi Ville.
> > >
> > > On Tue, Jan 29, 2019 at 07:06:09PM +0200, Ville Syrjala wrote:
> > > > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > >
> > > > drm_color_lut_check() doens't modify the passed in blob so
> > > > let's make it const.
> > > >
> > > > Also s/uint32_y/u32/ while at it.
> > > >
> > > > Cc: Matt Roper <matthew.d.roper@intel.com>
> > > > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > > ---
> > > > drivers/gpu/drm/drm_color_mgmt.c | 6 +++---
> > > > include/drm/drm_color_mgmt.h | 4 ++--
> > > > 2 files changed, 5 insertions(+), 5 deletions(-)
> > > >
> > > > diff --git a/drivers/gpu/drm/drm_color_mgmt.c b/drivers/gpu/drm/drm_color_mgmt.c
> > > > index 968ca7c91ad8..3c8826a91a03 100644
> > > > --- a/drivers/gpu/drm/drm_color_mgmt.c
> > > > +++ b/drivers/gpu/drm/drm_color_mgmt.c
> > > > @@ -474,10 +474,10 @@ EXPORT_SYMBOL(drm_plane_create_color_properties);
> > > > *
> > > > * Returns 0 on success, -EINVAL on failure.
> > > > */
> > > > -int drm_color_lut_check(struct drm_property_blob *lut,
> > > > - uint32_t tests)
> > > > +int drm_color_lut_check(const struct drm_property_blob *lut,
> > > > + u32 tests)
> > >
> > > No need to linewrap this line.
> > > > {
> > > > - struct drm_color_lut *entry;
> > > > + const struct drm_color_lut *entry;
> > > > int i;
> > > >
> > > > if (!lut || !tests)
> > > > diff --git a/include/drm/drm_color_mgmt.h b/include/drm/drm_color_mgmt.h
> > > > index 6affbda6d9cb..58d4b20b5b97 100644
> > > > --- a/include/drm/drm_color_mgmt.h
> > > > +++ b/include/drm/drm_color_mgmt.h
> > > > @@ -96,6 +96,6 @@ enum drm_color_lut_tests {
> > > > DRM_COLOR_LUT_NON_DECREASING = BIT(1),
> > > > };
> > > >
> > > > -int drm_color_lut_check(struct drm_property_blob *lut,
> > > > - uint32_t tests);
> > > > +int drm_color_lut_check(const struct drm_property_blob *lut,
> > > > + u32 tests);
> > > Likewise.
> > >
> > > With the linewrap fixed:
> > > Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
> >
> > Thanks.
> >
> > >
> > > Note: does not apply to my drm-misc tree. Anything I miss here?
> >
> > I think it was merged via drm-intel.
>
> Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> for merging through drm-intel then (assuming it goes in before the merge
> cutoff), with Sam's suggestions ofc.
Fixed up and pushed to dinq. Thanks for the review.
--
Ville Syrjälä
Intel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-01-29 21:33 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-29 17:06 [PATCH] drm: Constify drm_color_lut_check() Ville Syrjala
2019-01-29 17:52 ` Sam Ravnborg
2019-01-29 17:58 ` Ville Syrjälä
2019-01-29 19:04 ` [Intel-gfx] " Daniel Vetter
2019-01-29 21:33 ` Ville Syrjälä
2019-01-29 18:05 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-01-29 19:24 ` [PATCH] " Brian Starkey
2019-01-29 20:47 ` ✓ Fi.CI.IGT: success for " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.