* [PATCH] drm/doc: Task to rename CMA helpers
@ 2019-01-29 13:21 Daniel Vetter
2019-01-29 14:42 ` Noralf Trønnes
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Daniel Vetter @ 2019-01-29 13:21 UTC (permalink / raw)
To: DRI Development; +Cc: Daniel Vetter, Laurent Pinchart, Daniel Vetter
I'm kinda fed up explaining why the have a confusing name :-)
Cc: Noralf Trønnes <noralf@tronnes.org>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
Documentation/gpu/todo.rst | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst
index 38360ede1221..17f1cde6adab 100644
--- a/Documentation/gpu/todo.rst
+++ b/Documentation/gpu/todo.rst
@@ -262,6 +262,16 @@ As a reference, take a look at the conversions already completed in drm core.
Contact: Sean Paul, respective driver maintainers
+Rename CMA helpers to DMA helpers
+---------------------------------
+
+CMA (standing for contiguous memory allocator) is really a bit an accident of
+what these were used for first, a much better name would be DMA helpers. In the
+text these should even be called coherent DMA memory helpers (so maybd CDM, but
+no one knows what that means) since underneath they just use dma_alloc_coherent.
+
+Contact: Laurent Pinchart, Daniel Vetter
+
Core refactorings
=================
--
2.20.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/doc: Task to rename CMA helpers
2019-01-29 13:21 [PATCH] drm/doc: Task to rename CMA helpers Daniel Vetter
@ 2019-01-29 14:42 ` Noralf Trønnes
2019-01-29 18:16 ` Eric Engestrom
2019-01-30 9:03 ` Laurent Pinchart
2 siblings, 0 replies; 4+ messages in thread
From: Noralf Trønnes @ 2019-01-29 14:42 UTC (permalink / raw)
To: Daniel Vetter, DRI Development; +Cc: Daniel Vetter, Laurent Pinchart
Den 29.01.2019 14.21, skrev Daniel Vetter:
> I'm kinda fed up explaining why the have a confusing name :-)
>
> Cc: Noralf Trønnes <noralf@tronnes.org>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
I agree that it's confusing,
Acked-by: Noralf Trønnes <noralf@tronnes.org>
I would also make sense to fold drm_fb_cma_helper into the cma gem
helper since there's only 2 functions left after my refactorings.
Noralf.
> Documentation/gpu/todo.rst | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst
> index 38360ede1221..17f1cde6adab 100644
> --- a/Documentation/gpu/todo.rst
> +++ b/Documentation/gpu/todo.rst
> @@ -262,6 +262,16 @@ As a reference, take a look at the conversions already completed in drm core.
>
> Contact: Sean Paul, respective driver maintainers
>
> +Rename CMA helpers to DMA helpers
> +---------------------------------
> +
> +CMA (standing for contiguous memory allocator) is really a bit an accident of
> +what these were used for first, a much better name would be DMA helpers. In the
> +text these should even be called coherent DMA memory helpers (so maybd CDM, but
> +no one knows what that means) since underneath they just use dma_alloc_coherent.
> +
> +Contact: Laurent Pinchart, Daniel Vetter
> +
> Core refactorings
> =================
>
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/doc: Task to rename CMA helpers
2019-01-29 13:21 [PATCH] drm/doc: Task to rename CMA helpers Daniel Vetter
2019-01-29 14:42 ` Noralf Trønnes
@ 2019-01-29 18:16 ` Eric Engestrom
2019-01-30 9:03 ` Laurent Pinchart
2 siblings, 0 replies; 4+ messages in thread
From: Eric Engestrom @ 2019-01-29 18:16 UTC (permalink / raw)
To: Daniel Vetter; +Cc: Daniel Vetter, Laurent Pinchart, DRI Development
On Tuesday, 2019-01-29 14:21:53 +0100, Daniel Vetter wrote:
> I'm kinda fed up explaining why the have a confusing name :-)
>
> Cc: Noralf Trønnes <noralf@tronnes.org>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
> Documentation/gpu/todo.rst | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst
> index 38360ede1221..17f1cde6adab 100644
> --- a/Documentation/gpu/todo.rst
> +++ b/Documentation/gpu/todo.rst
> @@ -262,6 +262,16 @@ As a reference, take a look at the conversions already completed in drm core.
>
> Contact: Sean Paul, respective driver maintainers
>
> +Rename CMA helpers to DMA helpers
> +---------------------------------
> +
> +CMA (standing for contiguous memory allocator) is really a bit an accident of
> +what these were used for first, a much better name would be DMA helpers. In the
> +text these should even be called coherent DMA memory helpers (so maybd CDM, but
> +no one knows what that means) since underneath they just use dma_alloc_coherent.
s/maybd/maybe/
> +
> +Contact: Laurent Pinchart, Daniel Vetter
> +
> Core refactorings
> =================
>
> --
> 2.20.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/doc: Task to rename CMA helpers
2019-01-29 13:21 [PATCH] drm/doc: Task to rename CMA helpers Daniel Vetter
2019-01-29 14:42 ` Noralf Trønnes
2019-01-29 18:16 ` Eric Engestrom
@ 2019-01-30 9:03 ` Laurent Pinchart
2 siblings, 0 replies; 4+ messages in thread
From: Laurent Pinchart @ 2019-01-30 9:03 UTC (permalink / raw)
To: Daniel Vetter; +Cc: Daniel Vetter, DRI Development
Hi Daniel,
On Tue, Jan 29, 2019 at 02:21:53PM +0100, Daniel Vetter wrote:
> I'm kinda fed up explaining why the have a confusing name :-)
Fully agreed, it's confusing and should definitely be fixed.
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Noralf Trønnes <noralf@tronnes.org>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
> Documentation/gpu/todo.rst | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst
> index 38360ede1221..17f1cde6adab 100644
> --- a/Documentation/gpu/todo.rst
> +++ b/Documentation/gpu/todo.rst
> @@ -262,6 +262,16 @@ As a reference, take a look at the conversions already completed in drm core.
>
> Contact: Sean Paul, respective driver maintainers
>
> +Rename CMA helpers to DMA helpers
> +---------------------------------
> +
> +CMA (standing for contiguous memory allocator) is really a bit an accident of
> +what these were used for first, a much better name would be DMA helpers. In the
> +text these should even be called coherent DMA memory helpers (so maybd CDM, but
> +no one knows what that means) since underneath they just use dma_alloc_coherent.
> +
> +Contact: Laurent Pinchart, Daniel Vetter
> +
> Core refactorings
> =================
>
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-01-30 9:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-29 13:21 [PATCH] drm/doc: Task to rename CMA helpers Daniel Vetter
2019-01-29 14:42 ` Noralf Trønnes
2019-01-29 18:16 ` Eric Engestrom
2019-01-30 9:03 ` Laurent Pinchart
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.