All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Roberto Sassu <roberto.sassu@huawei.com>
Cc: zohar@linux.ibm.com, david.safford@ge.com, monty.wiseman@ge.com,
	matthewgarrett@google.com, linux-integrity@vger.kernel.org,
	linux-security-module@vger.kernel.org,
	linux-kernel@vger.kernel.org, keyrings@vger.kernel.org,
	silviu.vlasceanu@huawei.com
Subject: Re: [PATCH v8 1/7] tpm: dynamically allocate the allocated_banks array
Date: Wed, 30 Jan 2019 12:01:22 +0000	[thread overview]
Message-ID: <20190130120122.GA19191@linux.intel.com> (raw)
In-Reply-To: <ddf3515d-efba-6cf0-e224-90966be9cb18@huawei.com>

On Wed, Jan 30, 2019 at 08:52:40AM +0100, Roberto Sassu wrote:
> On 1/29/2019 8:29 PM, Jarkko Sakkinen wrote:
> > On Thu, Jan 24, 2019 at 04:49:04PM +0100, Roberto Sassu wrote:
> > > +	chip->allocated_banks = kcalloc(1, sizeof(*chip->allocated_banks),
> > > +					GFP_KERNEL);
> > > +	if (!chip->allocated_banks) {
> > > +		rc = -ENOMEM;
> > > +		goto out;
> > > +	}
> > > +
> > > +	chip->allocated_banks[0] = TPM2_ALG_SHA1;
> > > +	chip->nr_allocated_banks = 1;
> > 
> > Everything else looks nice in this patch except this.
> > 
> > You always branch for TPM 1.2, and it will always have just SHA1. This
> > is unnecessary.
> 
> Without this, users of the TPM driver have to call tpm_is_tpm2() first,
> while instead they can look directly at chip->allocated_banks.

I realized this after going through the whole patch set and sleeping
one night :-) You can keep it. I was mistaken here.

/Jarkko

WARNING: multiple messages have this Message-ID (diff)
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Roberto Sassu <roberto.sassu@huawei.com>
Cc: zohar@linux.ibm.com, david.safford@ge.com, monty.wiseman@ge.com,
	matthewgarrett@google.com, linux-integrity@vger.kernel.org,
	linux-security-module@vger.kernel.org,
	linux-kernel@vger.kernel.org, keyrings@vger.kernel.org,
	silviu.vlasceanu@huawei.com
Subject: Re: [PATCH v8 1/7] tpm: dynamically allocate the allocated_banks array
Date: Wed, 30 Jan 2019 14:01:22 +0200	[thread overview]
Message-ID: <20190130120122.GA19191@linux.intel.com> (raw)
In-Reply-To: <ddf3515d-efba-6cf0-e224-90966be9cb18@huawei.com>

On Wed, Jan 30, 2019 at 08:52:40AM +0100, Roberto Sassu wrote:
> On 1/29/2019 8:29 PM, Jarkko Sakkinen wrote:
> > On Thu, Jan 24, 2019 at 04:49:04PM +0100, Roberto Sassu wrote:
> > > +	chip->allocated_banks = kcalloc(1, sizeof(*chip->allocated_banks),
> > > +					GFP_KERNEL);
> > > +	if (!chip->allocated_banks) {
> > > +		rc = -ENOMEM;
> > > +		goto out;
> > > +	}
> > > +
> > > +	chip->allocated_banks[0] = TPM2_ALG_SHA1;
> > > +	chip->nr_allocated_banks = 1;
> > 
> > Everything else looks nice in this patch except this.
> > 
> > You always branch for TPM 1.2, and it will always have just SHA1. This
> > is unnecessary.
> 
> Without this, users of the TPM driver have to call tpm_is_tpm2() first,
> while instead they can look directly at chip->allocated_banks.

I realized this after going through the whole patch set and sleeping
one night :-) You can keep it. I was mistaken here.

/Jarkko

  reply	other threads:[~2019-01-30 12:01 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-24 15:49 [PATCH v8 0/7] tpm: retrieve digest size of unknown algorithms from TPM Roberto Sassu
2019-01-24 15:49 ` Roberto Sassu
2019-01-24 15:49 ` [PATCH v8 1/7] tpm: dynamically allocate the allocated_banks array Roberto Sassu
2019-01-24 15:49   ` Roberto Sassu
2019-01-29 19:29   ` Jarkko Sakkinen
2019-01-29 19:29     ` Jarkko Sakkinen
2019-01-30  7:52     ` Roberto Sassu
2019-01-30  7:52       ` Roberto Sassu
2019-01-30 12:01       ` Jarkko Sakkinen [this message]
2019-01-30 12:01         ` Jarkko Sakkinen
2019-01-24 15:49 ` [PATCH v8 2/7] tpm: add _head suffix to tcg_efi_specid_event and tcg_pcr_event2 Roberto Sassu
2019-01-24 15:49   ` Roberto Sassu
2019-01-29 19:37   ` Jarkko Sakkinen
2019-01-29 19:37     ` Jarkko Sakkinen
2019-01-24 15:49 ` [PATCH v8 3/7] tpm: rename and export tpm2_digest and tpm2_algorithms Roberto Sassu
2019-01-24 15:49   ` Roberto Sassu
2019-01-24 15:49 ` [PATCH v8 4/7] tpm: retrieve digest size of unknown algorithms with PCR read Roberto Sassu
2019-01-24 15:49   ` Roberto Sassu
2019-01-29 20:14   ` Jarkko Sakkinen
2019-01-29 20:14     ` Jarkko Sakkinen
2019-01-24 15:49 ` [PATCH v8 5/7] tpm: move tpm_chip definition to include/linux/tpm.h Roberto Sassu
2019-01-24 15:49   ` Roberto Sassu
2019-01-29 20:34   ` Jarkko Sakkinen
2019-01-29 20:34     ` Jarkko Sakkinen
2019-01-31  7:54     ` Roberto Sassu
2019-01-31  7:54       ` Roberto Sassu
2019-01-31 16:05       ` Jarkko Sakkinen
2019-01-31 16:05         ` Jarkko Sakkinen
2019-01-24 15:49 ` [PATCH v8 6/7] KEYS: trusted: explicitly use tpm_chip structure from tpm_default_chip() Roberto Sassu
2019-01-24 15:49   ` Roberto Sassu
2019-01-29 20:43   ` Jarkko Sakkinen
2019-01-29 20:43     ` Jarkko Sakkinen
2019-01-24 15:49 ` [PATCH v8 7/7] tpm: pass an array of tpm_extend_digest structures to tpm_pcr_extend() Roberto Sassu
2019-01-24 15:49   ` Roberto Sassu
2019-01-29 21:02   ` Jarkko Sakkinen
2019-01-29 21:02     ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190130120122.GA19191@linux.intel.com \
    --to=jarkko.sakkinen@linux.intel.com \
    --cc=david.safford@ge.com \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=matthewgarrett@google.com \
    --cc=monty.wiseman@ge.com \
    --cc=roberto.sassu@huawei.com \
    --cc=silviu.vlasceanu@huawei.com \
    --cc=zohar@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.