* [igt-dev] [PATCH i-g-t] lib/igt_kms: Clear all non-atomic properties in legacy/universal commit correctly.
@ 2019-01-31 8:58 Maarten Lankhorst
2019-01-31 9:28 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Maarten Lankhorst @ 2019-01-31 8:58 UTC (permalink / raw)
To: igt-dev; +Cc: Nicholas Kazlauskas
We used to add them all 1 by 1, but we really only care about not
handling a few.
Only skip unsetting all atomic properties, instead of handling it
through a whitelist.
This fixes kms_busy, which was updating the VRR hint, even though
we already unset it in the legacy path.
Cc: Nicholas Kazlauskas <nkazlaus@amd.com>
Cc: Harry Wentland <harry.wentland@amd.com>
Cc: Leo Li <sunpeng.li@amd.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109490
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
---
lib/igt_kms.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index 58f32911d999..1f98b26fcd79 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -3298,10 +3298,9 @@ display_commit_changed(igt_display_t *display, enum igt_commit_style s)
pipe_obj->values[IGT_CRTC_OUT_FENCE_PTR] = 0;
pipe_obj->changed = 0;
} else {
- igt_pipe_obj_clear_prop_changed(pipe_obj, IGT_CRTC_BACKGROUND);
- igt_pipe_obj_clear_prop_changed(pipe_obj, IGT_CRTC_CTM);
- igt_pipe_obj_clear_prop_changed(pipe_obj, IGT_CRTC_DEGAMMA_LUT);
- igt_pipe_obj_clear_prop_changed(pipe_obj, IGT_CRTC_GAMMA_LUT);
+ for (i = 0; i < IGT_NUM_CRTC_PROPS; i++)
+ if (!is_atomic_prop(i))
+ igt_pipe_obj_clear_prop_changed(pipe_obj, i);
if (s != COMMIT_UNIVERSAL) {
igt_pipe_obj_clear_prop_changed(pipe_obj, IGT_CRTC_MODE_ID);
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for lib/igt_kms: Clear all non-atomic properties in legacy/universal commit correctly.
2019-01-31 8:58 [igt-dev] [PATCH i-g-t] lib/igt_kms: Clear all non-atomic properties in legacy/universal commit correctly Maarten Lankhorst
@ 2019-01-31 9:28 ` Patchwork
2019-01-31 10:26 ` [igt-dev] [PATCH i-g-t] " Petri Latvala
2019-01-31 20:25 ` [igt-dev] ✗ Fi.CI.IGT: failure for " Patchwork
2 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2019-01-31 9:28 UTC (permalink / raw)
To: Maarten Lankhorst; +Cc: igt-dev
== Series Details ==
Series: lib/igt_kms: Clear all non-atomic properties in legacy/universal commit correctly.
URL : https://patchwork.freedesktop.org/series/56037/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5518 -> IGTPW_2326
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/56037/revisions/1/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_2326:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* {igt@runner@aborted}:
- fi-bxt-dsi: NOTRUN -> FAIL
Known issues
------------
Here are the changes found in IGTPW_2326 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_busy@basic-flip-b:
- fi-gdg-551: PASS -> FAIL [fdo#103182]
#### Possible fixes ####
* igt@i915_selftest@live_execlists:
- fi-apl-guc: INCOMPLETE [fdo#103927] -> PASS
* igt@i915_selftest@live_hangcheck:
- fi-skl-iommu: INCOMPLETE [fdo#108602] / [fdo#108744] -> PASS
* igt@kms_busy@basic-flip-a:
- fi-kbl-7567u: {SKIP} [fdo#109271] / [fdo#109278] -> PASS +2
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: FAIL [fdo#109485] -> PASS
* igt@kms_pipe_crc_basic@read-crc-pipe-b-frame-sequence:
- fi-byt-clapper: FAIL [fdo#103191] / [fdo#107362] -> PASS
* igt@pm_rpm@module-reload:
- fi-skl-6770hq: FAIL [fdo#108511] -> PASS
* igt@prime_vgem@basic-fence-flip:
- fi-gdg-551: DMESG-FAIL [fdo#103182] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#108511]: https://bugs.freedesktop.org/show_bug.cgi?id=108511
[fdo#108602]: https://bugs.freedesktop.org/show_bug.cgi?id=108602
[fdo#108744]: https://bugs.freedesktop.org/show_bug.cgi?id=108744
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109485]: https://bugs.freedesktop.org/show_bug.cgi?id=109485
Participating hosts (43 -> 43)
------------------------------
Additional (5): fi-bxt-dsi fi-ivb-3770 fi-bsw-kefka fi-skl-6600u fi-snb-2600
Missing (5): fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-glk-j4005 fi-ivb-3520m
Build changes
-------------
* IGT: IGT_4801 -> IGTPW_2326
CI_DRM_5518: 2369fd28d3a46b865f6d4f1d309a4c6b7b4e6d93 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2326: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2326/
IGT_4801: 6f6bacf12759fb319ade3ba37861ae711f8a5cd9 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2326/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] lib/igt_kms: Clear all non-atomic properties in legacy/universal commit correctly.
2019-01-31 8:58 [igt-dev] [PATCH i-g-t] lib/igt_kms: Clear all non-atomic properties in legacy/universal commit correctly Maarten Lankhorst
2019-01-31 9:28 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2019-01-31 10:26 ` Petri Latvala
2019-01-31 12:05 ` Maarten Lankhorst
2019-01-31 20:25 ` [igt-dev] ✗ Fi.CI.IGT: failure for " Patchwork
2 siblings, 1 reply; 8+ messages in thread
From: Petri Latvala @ 2019-01-31 10:26 UTC (permalink / raw)
To: Maarten Lankhorst; +Cc: igt-dev, Nicholas Kazlauskas
On Thu, Jan 31, 2019 at 09:58:02AM +0100, Maarten Lankhorst wrote:
> We used to add them all 1 by 1, but we really only care about not
> handling a few.
>
> Only skip unsetting all atomic properties, instead of handling it
> through a whitelist.
>
> This fixes kms_busy, which was updating the VRR hint, even though
> we already unset it in the legacy path.
>
> Cc: Nicholas Kazlauskas <nkazlaus@amd.com>
> Cc: Harry Wentland <harry.wentland@amd.com>
> Cc: Leo Li <sunpeng.li@amd.com>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109490
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> ---
> lib/igt_kms.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index 58f32911d999..1f98b26fcd79 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -3298,10 +3298,9 @@ display_commit_changed(igt_display_t *display, enum igt_commit_style s)
> pipe_obj->values[IGT_CRTC_OUT_FENCE_PTR] = 0;
> pipe_obj->changed = 0;
> } else {
> - igt_pipe_obj_clear_prop_changed(pipe_obj, IGT_CRTC_BACKGROUND);
> - igt_pipe_obj_clear_prop_changed(pipe_obj, IGT_CRTC_CTM);
> - igt_pipe_obj_clear_prop_changed(pipe_obj, IGT_CRTC_DEGAMMA_LUT);
> - igt_pipe_obj_clear_prop_changed(pipe_obj, IGT_CRTC_GAMMA_LUT);
> + for (i = 0; i < IGT_NUM_CRTC_PROPS; i++)
> + if (!is_atomic_prop(i))
> + igt_pipe_obj_clear_prop_changed(pipe_obj, i);
Does IGT_CRTC_VRR_ENABLED need to be added to is_atomic_prop?
...
No, that's not a "is this an atomic-only property", is it?
Anyway, the effect matches the second chunk of Nicholas's patch.
Reviewed-by: Petri Latvala <petri.latvala@intel.com>
There's some queue in shards so stand by a couple of hours for their results before merging.
>
> if (s != COMMIT_UNIVERSAL) {
> igt_pipe_obj_clear_prop_changed(pipe_obj, IGT_CRTC_MODE_ID);
> --
> 2.20.1
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] lib/igt_kms: Clear all non-atomic properties in legacy/universal commit correctly.
2019-01-31 10:26 ` [igt-dev] [PATCH i-g-t] " Petri Latvala
@ 2019-01-31 12:05 ` Maarten Lankhorst
2019-01-31 14:38 ` Kazlauskas, Nicholas
0 siblings, 1 reply; 8+ messages in thread
From: Maarten Lankhorst @ 2019-01-31 12:05 UTC (permalink / raw)
To: igt-dev, Petri Latvala; +Cc: Nicholas Kazlauskas
Op 31-01-2019 om 11:26 schreef Petri Latvala:
> On Thu, Jan 31, 2019 at 09:58:02AM +0100, Maarten Lankhorst wrote:
>> We used to add them all 1 by 1, but we really only care about not
>> handling a few.
>>
>> Only skip unsetting all atomic properties, instead of handling it
>> through a whitelist.
>>
>> This fixes kms_busy, which was updating the VRR hint, even though
>> we already unset it in the legacy path.
>>
>> Cc: Nicholas Kazlauskas <nkazlaus@amd.com>
>> Cc: Harry Wentland <harry.wentland@amd.com>
>> Cc: Leo Li <sunpeng.li@amd.com>
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109490
>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>> ---
>> lib/igt_kms.c | 7 +++----
>> 1 file changed, 3 insertions(+), 4 deletions(-)
>>
>> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
>> index 58f32911d999..1f98b26fcd79 100644
>> --- a/lib/igt_kms.c
>> +++ b/lib/igt_kms.c
>> @@ -3298,10 +3298,9 @@ display_commit_changed(igt_display_t *display, enum igt_commit_style s)
>> pipe_obj->values[IGT_CRTC_OUT_FENCE_PTR] = 0;
>> pipe_obj->changed = 0;
>> } else {
>> - igt_pipe_obj_clear_prop_changed(pipe_obj, IGT_CRTC_BACKGROUND);
>> - igt_pipe_obj_clear_prop_changed(pipe_obj, IGT_CRTC_CTM);
>> - igt_pipe_obj_clear_prop_changed(pipe_obj, IGT_CRTC_DEGAMMA_LUT);
>> - igt_pipe_obj_clear_prop_changed(pipe_obj, IGT_CRTC_GAMMA_LUT);
>> + for (i = 0; i < IGT_NUM_CRTC_PROPS; i++)
>> + if (!is_atomic_prop(i))
>> + igt_pipe_obj_clear_prop_changed(pipe_obj, i);
>
> Does IGT_CRTC_VRR_ENABLED need to be added to is_atomic_prop?
The legacy path:
- Performs drmModeSetCrtc on the primary plane to trigger a modeset and connector assignments
- Uses drmModeSetCursor/drmModeMoveCursor to move the cursor plane
- Uses drmModeSetPlane on other planes.
- Uses drmModeConnectorSetProperty to set connector properties.
- Calls drmModeObjectSetProperty to update any non-atomic crtc properties. Probably gamma/etc as well.
Primary and cursor properties are mostly ignored, except with what can be set through setcursor/setcrtc.
The universal path:
- Uses SetPlane on all planes.
- Calls drmModeObjectSetProperty for all not ignored properties on each plane/connector/crtc.
- Can't do modesets.
The atomic path:
- Does a single atomic commit, with all changed properties and their new values. All of the above and more (in/out fence handling)..
Even if it's strictly speaking an atomic property, the fact we clear it in igt_pipe_refresh()
means we have to make sure that tests keep running, and we have to clear the flag in igt_display_commit()
because otherwise even more things break. :)
Probably best to only keep things we absolutely can't reasonably another way than atomic in is_atomic.
> ...
>
> No, that's not a "is this an atomic-only property", is it?
>
>
> Anyway, the effect matches the second chunk of Nicholas's patch.
>
>
> Reviewed-by: Petri Latvala <petri.latvala@intel.com>
>
> There's some queue in shards so stand by a couple of hours for their results before merging.
>
>
>
>>
>> if (s != COMMIT_UNIVERSAL) {
>> igt_pipe_obj_clear_prop_changed(pipe_obj, IGT_CRTC_MODE_ID);
>> --
>> 2.20.1
>>
>> _______________________________________________
>> igt-dev mailing list
>> igt-dev@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] lib/igt_kms: Clear all non-atomic properties in legacy/universal commit correctly.
2019-01-31 12:05 ` Maarten Lankhorst
@ 2019-01-31 14:38 ` Kazlauskas, Nicholas
0 siblings, 0 replies; 8+ messages in thread
From: Kazlauskas, Nicholas @ 2019-01-31 14:38 UTC (permalink / raw)
To: Maarten Lankhorst, igt-dev, Petri Latvala
On 1/31/19 7:05 AM, Maarten Lankhorst wrote:
> Op 31-01-2019 om 11:26 schreef Petri Latvala:
>> On Thu, Jan 31, 2019 at 09:58:02AM +0100, Maarten Lankhorst wrote:
>>> We used to add them all 1 by 1, but we really only care about not
>>> handling a few.
>>>
>>> Only skip unsetting all atomic properties, instead of handling it
>>> through a whitelist.
>>>
>>> This fixes kms_busy, which was updating the VRR hint, even though
>>> we already unset it in the legacy path.
>>>
>>> Cc: Nicholas Kazlauskas <nkazlaus@amd.com>
>>> Cc: Harry Wentland <harry.wentland@amd.com>
>>> Cc: Leo Li <sunpeng.li@amd.com>
>>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109490
>>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
This is a much more elegant solution to just clearing VRR_ENABLED by
itself like I was doing in my other patch. Also helps guard against
forgetting to clear new properties in the future (like my original patch
did).
I'll update my "lib/igt_kms: Don't reset VRR_ENABLED on every commit"
based on this commit. Thanks!
>>> ---
>>> lib/igt_kms.c | 7 +++----
>>> 1 file changed, 3 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
>>> index 58f32911d999..1f98b26fcd79 100644
>>> --- a/lib/igt_kms.c
>>> +++ b/lib/igt_kms.c
>>> @@ -3298,10 +3298,9 @@ display_commit_changed(igt_display_t *display, enum igt_commit_style s)
>>> pipe_obj->values[IGT_CRTC_OUT_FENCE_PTR] = 0;
>>> pipe_obj->changed = 0;
>>> } else {
>>> - igt_pipe_obj_clear_prop_changed(pipe_obj, IGT_CRTC_BACKGROUND);
>>> - igt_pipe_obj_clear_prop_changed(pipe_obj, IGT_CRTC_CTM);
>>> - igt_pipe_obj_clear_prop_changed(pipe_obj, IGT_CRTC_DEGAMMA_LUT);
>>> - igt_pipe_obj_clear_prop_changed(pipe_obj, IGT_CRTC_GAMMA_LUT);
>>> + for (i = 0; i < IGT_NUM_CRTC_PROPS; i++)
>>> + if (!is_atomic_prop(i))
>>> + igt_pipe_obj_clear_prop_changed(pipe_obj, i);
>>
>> Does IGT_CRTC_VRR_ENABLED need to be added to is_atomic_prop?
>
> The legacy path:
> - Performs drmModeSetCrtc on the primary plane to trigger a modeset and connector assignments
> - Uses drmModeSetCursor/drmModeMoveCursor to move the cursor plane
> - Uses drmModeSetPlane on other planes.
> - Uses drmModeConnectorSetProperty to set connector properties.
> - Calls drmModeObjectSetProperty to update any non-atomic crtc properties. Probably gamma/etc as well.
> Primary and cursor properties are mostly ignored, except with what can be set through setcursor/setcrtc.
>
> The universal path:
> - Uses SetPlane on all planes.
> - Calls drmModeObjectSetProperty for all not ignored properties on each plane/connector/crtc.
> - Can't do modesets.
>
> The atomic path:
> - Does a single atomic commit, with all changed properties and their new values. All of the above and more (in/out fence handling)..
>
> Even if it's strictly speaking an atomic property, the fact we clear it in igt_pipe_refresh()
> means we have to make sure that tests keep running, and we have to clear the flag in igt_display_commit()
> because otherwise even more things break. :)
>
> Probably best to only keep things we absolutely can't reasonably another way than atomic in is_atomic.
>
>> ...
>>
>> No, that's not a "is this an atomic-only property", is it?
It's a property that's only exposed on atomic drivers but isn't marked
as atomic only so that legacy userspace could still use it. It shouldn't
be in the is_atomic_prop list at least.
>>
>>
>> Anyway, the effect matches the second chunk of Nicholas's patch.
>>
>>
>> Reviewed-by: Petri Latvala <petri.latvala@intel.com>
>>
>> There's some queue in shards so stand by a couple of hours for their results before merging.
>>
>>
>>
>>>
>>> if (s != COMMIT_UNIVERSAL) {
>>> igt_pipe_obj_clear_prop_changed(pipe_obj, IGT_CRTC_MODE_ID);
>>> --
>>> 2.20.1
>>>
>>> _______________________________________________
>>> igt-dev mailing list
>>> igt-dev@lists.freedesktop.org
>>> https://lists.freedesktop.org/mailman/listinfo/igt-dev
>
>
Nicholas Kazlauskas
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
* [igt-dev] ✗ Fi.CI.IGT: failure for lib/igt_kms: Clear all non-atomic properties in legacy/universal commit correctly.
2019-01-31 8:58 [igt-dev] [PATCH i-g-t] lib/igt_kms: Clear all non-atomic properties in legacy/universal commit correctly Maarten Lankhorst
2019-01-31 9:28 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-01-31 10:26 ` [igt-dev] [PATCH i-g-t] " Petri Latvala
@ 2019-01-31 20:25 ` Patchwork
2019-02-01 9:29 ` Petri Latvala
2 siblings, 1 reply; 8+ messages in thread
From: Patchwork @ 2019-01-31 20:25 UTC (permalink / raw)
To: Maarten Lankhorst; +Cc: igt-dev
== Series Details ==
Series: lib/igt_kms: Clear all non-atomic properties in legacy/universal commit correctly.
URL : https://patchwork.freedesktop.org/series/56037/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_5518_full -> IGTPW_2326_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_2326_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_2326_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/56037/revisions/1/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_2326_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-apl: PASS -> DMESG-WARN
Known issues
------------
Here are the changes found in IGTPW_2326_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_schedule@pi-ringfull-render:
- shard-apl: NOTRUN -> FAIL [fdo#103158]
* igt@kms_ccs@pipe-b-crc-sprite-planes-basic:
- shard-apl: PASS -> FAIL [fdo#106510] / [fdo#108145]
- shard-kbl: PASS -> FAIL [fdo#107725] / [fdo#108145]
* igt@kms_color@pipe-b-legacy-gamma:
- shard-apl: PASS -> FAIL [fdo#104782]
* igt@kms_cursor_crc@cursor-128x42-random:
- shard-glk: PASS -> FAIL [fdo#103232]
- shard-kbl: PASS -> FAIL [fdo#103232]
* igt@kms_cursor_crc@cursor-64x64-dpms:
- shard-apl: PASS -> FAIL [fdo#103232] +2
* igt@kms_cursor_crc@cursor-64x64-suspend:
- shard-apl: PASS -> FAIL [fdo#103191] / [fdo#103232]
* igt@kms_plane@pixel-format-pipe-b-planes-source-clamping:
- shard-glk: PASS -> FAIL [fdo#108948]
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max:
- shard-glk: PASS -> FAIL [fdo#108145] +2
* igt@kms_plane_multiple@atomic-pipe-a-tiling-none:
- shard-apl: NOTRUN -> FAIL [fdo#103166]
* igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
- shard-glk: PASS -> FAIL [fdo#103166] +1
- shard-kbl: PASS -> FAIL [fdo#103166]
* igt@kms_plane_multiple@atomic-pipe-b-tiling-none:
- shard-apl: PASS -> FAIL [fdo#103166] +2
* igt@kms_rotation_crc@multiplane-rotation-cropping-bottom:
- shard-kbl: PASS -> DMESG-FAIL [fdo#105763]
* igt@kms_setmode@basic:
- shard-kbl: PASS -> FAIL [fdo#99912]
#### Possible fixes ####
* igt@gem_eio@reset-stress:
- shard-hsw: INCOMPLETE [fdo#103540] / [fdo#109482] -> PASS
* igt@gem_workarounds@suspend-resume:
- shard-kbl: INCOMPLETE [fdo#103665] -> PASS
* igt@kms_available_modes_crc@available_mode_test_crc:
- shard-apl: FAIL [fdo#106641] -> PASS
- shard-glk: FAIL [fdo#106641] -> PASS
- shard-kbl: FAIL [fdo#106641] -> PASS
* igt@kms_busy@basic-modeset-a:
- shard-apl: FAIL [fdo#109490] -> PASS +3
- shard-glk: FAIL [fdo#109490] -> PASS +3
- shard-snb: FAIL [fdo#109490] -> PASS +2
* igt@kms_busy@basic-modeset-b:
- shard-kbl: FAIL [fdo#109490] -> PASS +3
* igt@kms_color@pipe-b-ctm-max:
- shard-apl: FAIL [fdo#108147] -> PASS
* igt@kms_cursor_crc@cursor-256x256-suspend:
- shard-hsw: INCOMPLETE [fdo#103540] -> PASS
* igt@kms_cursor_crc@cursor-256x85-onscreen:
- shard-apl: FAIL [fdo#103232] -> PASS +2
* igt@kms_cursor_crc@cursor-64x64-sliding:
- shard-glk: FAIL [fdo#103232] -> PASS
- shard-kbl: FAIL [fdo#103232] -> PASS
* igt@kms_flip@flip-vs-blocking-wf-vblank:
- shard-snb: DMESG-WARN [fdo#107469] -> PASS
* igt@kms_flip@flip-vs-panning-interruptible:
- shard-hsw: DMESG-WARN [fdo#102614] -> PASS
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max:
- shard-glk: FAIL [fdo#108145] -> PASS +1
* igt@kms_plane_multiple@atomic-pipe-a-tiling-yf:
- shard-glk: FAIL [fdo#103166] -> PASS +2
* igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
- shard-apl: FAIL [fdo#103166] -> PASS +3
- shard-kbl: FAIL [fdo#103166] -> PASS +2
* igt@kms_vblank@crtc-id:
- shard-hsw: FAIL [fdo#109490] -> PASS +3
* igt@sw_sync@sync_busy_fork:
- shard-snb: INCOMPLETE [fdo#105411] -> PASS
#### Warnings ####
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b:
- shard-snb: {SKIP} [fdo#109271] / [fdo#109278] -> DMESG-WARN [fdo#107956]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
[fdo#103158]: https://bugs.freedesktop.org/show_bug.cgi?id=103158
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
[fdo#106510]: https://bugs.freedesktop.org/show_bug.cgi?id=106510
[fdo#106641]: https://bugs.freedesktop.org/show_bug.cgi?id=106641
[fdo#107469]: https://bugs.freedesktop.org/show_bug.cgi?id=107469
[fdo#107725]: https://bugs.freedesktop.org/show_bug.cgi?id=107725
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147
[fdo#108948]: https://bugs.freedesktop.org/show_bug.cgi?id=108948
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109482]: https://bugs.freedesktop.org/show_bug.cgi?id=109482
[fdo#109490]: https://bugs.freedesktop.org/show_bug.cgi?id=109490
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (7 -> 5)
------------------------------
Missing (2): shard-skl shard-iclb
Build changes
-------------
* IGT: IGT_4801 -> IGTPW_2326
* Piglit: piglit_4509 -> None
CI_DRM_5518: 2369fd28d3a46b865f6d4f1d309a4c6b7b4e6d93 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2326: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2326/
IGT_4801: 6f6bacf12759fb319ade3ba37861ae711f8a5cd9 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2326/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [igt-dev] ✗ Fi.CI.IGT: failure for lib/igt_kms: Clear all non-atomic properties in legacy/universal commit correctly.
2019-01-31 20:25 ` [igt-dev] ✗ Fi.CI.IGT: failure for " Patchwork
@ 2019-02-01 9:29 ` Petri Latvala
2019-02-01 9:56 ` Maarten Lankhorst
0 siblings, 1 reply; 8+ messages in thread
From: Petri Latvala @ 2019-02-01 9:29 UTC (permalink / raw)
To: igt-dev
On Thu, Jan 31, 2019 at 08:25:45PM +0000, Patchwork wrote:
> == Series Details ==
>
> Series: lib/igt_kms: Clear all non-atomic properties in legacy/universal commit correctly.
> URL : https://patchwork.freedesktop.org/series/56037/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_5518_full -> IGTPW_2326_full
> ====================================================
>
> Summary
> -------
>
> **FAILURE**
>
> Serious unknown changes coming with IGTPW_2326_full absolutely need to be
> verified manually.
>
> If you think the reported changes have nothing to do with the changes
> introduced in IGTPW_2326_full, please notify your bug team to allow them
> to document this new failure mode, which will reduce false positives in CI.
>
> External URL: https://patchwork.freedesktop.org/api/1.0/series/56037/revisions/1/mbox/
>
> Possible new issues
> -------------------
>
> Here are the unknown changes that may have been introduced in IGTPW_2326_full:
>
> ### IGT changes ###
>
> #### Possible regressions ####
>
> * igt@kms_vblank@pipe-c-ts-continuation-suspend:
> - shard-apl: PASS -> DMESG-WARN
<3> [123.565629] [drm:lspcon_wait_mode [i915]] *ERROR* LSPCON mode hasn't settled
<3> [123.663710] [drm:lspcon_change_mode.constprop.4 [i915]] *ERROR* Error reading LSPCON mode
<3> [123.663786] [drm:intel_dp_encoder_reset [i915]] *ERROR* LSPCON resume failed
Good old LSPCON. Martin CC'd, not caused by this patch.
--
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [igt-dev] ✗ Fi.CI.IGT: failure for lib/igt_kms: Clear all non-atomic properties in legacy/universal commit correctly.
2019-02-01 9:29 ` Petri Latvala
@ 2019-02-01 9:56 ` Maarten Lankhorst
0 siblings, 0 replies; 8+ messages in thread
From: Maarten Lankhorst @ 2019-02-01 9:56 UTC (permalink / raw)
To: igt-dev, Martin Peres
Op 01-02-2019 om 10:29 schreef Petri Latvala:
> On Thu, Jan 31, 2019 at 08:25:45PM +0000, Patchwork wrote:
>> == Series Details ==
>>
>> Series: lib/igt_kms: Clear all non-atomic properties in legacy/universal commit correctly.
>> URL : https://patchwork.freedesktop.org/series/56037/
>> State : failure
>>
>> == Summary ==
>>
>> CI Bug Log - changes from CI_DRM_5518_full -> IGTPW_2326_full
>> ====================================================
>>
>> Summary
>> -------
>>
>> **FAILURE**
>>
>> Serious unknown changes coming with IGTPW_2326_full absolutely need to be
>> verified manually.
>>
>> If you think the reported changes have nothing to do with the changes
>> introduced in IGTPW_2326_full, please notify your bug team to allow them
>> to document this new failure mode, which will reduce false positives in CI.
>>
>> External URL: https://patchwork.freedesktop.org/api/1.0/series/56037/revisions/1/mbox/
>>
>> Possible new issues
>> -------------------
>>
>> Here are the unknown changes that may have been introduced in IGTPW_2326_full:
>>
>> ### IGT changes ###
>>
>> #### Possible regressions ####
>>
>> * igt@kms_vblank@pipe-c-ts-continuation-suspend:
>> - shard-apl: PASS -> DMESG-WARN
>
> <3> [123.565629] [drm:lspcon_wait_mode [i915]] *ERROR* LSPCON mode hasn't settled
> <3> [123.663710] [drm:lspcon_change_mode.constprop.4 [i915]] *ERROR* Error reading LSPCON mode
> <3> [123.663786] [drm:intel_dp_encoder_reset [i915]] *ERROR* LSPCON resume failed
>
>
> Good old LSPCON. Martin CC'd, not caused by this patch.
>
>
Thanks, pushed. :)
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-02-01 9:56 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-31 8:58 [igt-dev] [PATCH i-g-t] lib/igt_kms: Clear all non-atomic properties in legacy/universal commit correctly Maarten Lankhorst
2019-01-31 9:28 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-01-31 10:26 ` [igt-dev] [PATCH i-g-t] " Petri Latvala
2019-01-31 12:05 ` Maarten Lankhorst
2019-01-31 14:38 ` Kazlauskas, Nicholas
2019-01-31 20:25 ` [igt-dev] ✗ Fi.CI.IGT: failure for " Patchwork
2019-02-01 9:29 ` Petri Latvala
2019-02-01 9:56 ` Maarten Lankhorst
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.