* [PATCH net-next] macvlan: use netif_is_macvlan_port()
@ 2019-01-31 9:48 Julian Wiedmann
2019-01-31 17:26 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Julian Wiedmann @ 2019-01-31 9:48 UTC (permalink / raw)
To: David Miller; +Cc: Julian Wiedmann, netdev
Replace the macvlan_port_exists() macro with its twin from netdevice.h
Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
---
drivers/net/macvlan.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c
index cf22a79af66b..26e53832b095 100644
--- a/drivers/net/macvlan.c
+++ b/drivers/net/macvlan.c
@@ -119,8 +119,6 @@ static struct macvlan_port *macvlan_port_get_rtnl(const struct net_device *dev)
return rtnl_dereference(dev->rx_handler_data);
}
-#define macvlan_port_exists(dev) (dev->priv_flags & IFF_MACVLAN_PORT)
-
static struct macvlan_dev *macvlan_hash_lookup(const struct macvlan_port *port,
const unsigned char *addr)
{
@@ -1378,7 +1376,7 @@ int macvlan_common_newlink(struct net *src_net, struct net_device *dev,
if (!tb[IFLA_ADDRESS])
eth_hw_addr_random(dev);
- if (!macvlan_port_exists(lowerdev)) {
+ if (!netif_is_macvlan_port(lowerdev)) {
err = macvlan_port_create(lowerdev);
if (err < 0)
return err;
@@ -1638,7 +1636,7 @@ static int macvlan_device_event(struct notifier_block *unused,
struct macvlan_port *port;
LIST_HEAD(list_kill);
- if (!macvlan_port_exists(dev))
+ if (!netif_is_macvlan_port(dev))
return NOTIFY_DONE;
port = macvlan_port_get_rtnl(dev);
--
2.16.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] macvlan: use netif_is_macvlan_port()
2019-01-31 9:48 [PATCH net-next] macvlan: use netif_is_macvlan_port() Julian Wiedmann
@ 2019-01-31 17:26 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-01-31 17:26 UTC (permalink / raw)
To: jwi; +Cc: netdev
From: Julian Wiedmann <jwi@linux.ibm.com>
Date: Thu, 31 Jan 2019 10:48:10 +0100
> Replace the macvlan_port_exists() macro with its twin from netdevice.h
>
> Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Looks great, applied.
Thanks for cleaning this up.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-31 17:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-31 9:48 [PATCH net-next] macvlan: use netif_is_macvlan_port() Julian Wiedmann
2019-01-31 17:26 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.