From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: armbru@redhat.com, pbonzini@redhat.com, pkrempa@redhat.com,
berrange@redhat.com, eblake@redhat.com, libvir-list@redhat.com,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/3] scsi-disk: Device Identification fixes
Date: Fri, 1 Feb 2019 13:51:20 +0100 [thread overview]
Message-ID: <20190201125120.GF5730@localhost.localdomain> (raw)
In-Reply-To: <20190125174653.4604-1-kwolf@redhat.com>
Am 25.01.2019 um 18:46 hat Kevin Wolf geschrieben:
> The vendor specific designator in the Device Identification VPD page has
> two problems:
>
> 1. It defaults to the BlockBackend name (-drive id=...), which everyone
> expected to be a host detail that the guest never sees
>
> 2. With -blockdev based setups it defaults to an empty string; if this
> default is used with more than one disk, the guest OS will interpret
> this as a single multipath disk.
>
> We can address problem 2 immediately, and start running the deprecation
> clock for problem 1.
>
> Related bug reports:
> https://bugzilla.redhat.com/show_bug.cgi?id=1669446
> https://bugzilla.redhat.com/show_bug.cgi?id=1668248
Applied patches 1 and 2 to the block branch so that the bug is fixed.
I'll try to rewrite patch 3 along the lines Dan suggested.
Kevin
prev parent reply other threads:[~2019-02-01 12:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-25 17:46 [Qemu-devel] [PATCH 0/3] scsi-disk: Device Identification fixes Kevin Wolf
2019-01-25 17:46 ` [Qemu-devel] [PATCH 1/3] scsi-disk: Don't use empty string as device id Kevin Wolf
2019-01-29 12:30 ` Philippe Mathieu-Daudé
2019-01-29 16:37 ` Markus Armbruster
2019-01-30 11:39 ` Kevin Wolf
2019-01-25 17:46 ` [Qemu-devel] [PATCH 2/3] scsi-disk: Add device_id property Kevin Wolf
2019-01-28 8:50 ` Peter Krempa
2019-01-28 9:08 ` Peter Krempa
2019-01-28 14:41 ` Kevin Wolf
2019-01-28 16:55 ` Markus Armbruster
2019-01-28 17:49 ` Kevin Wolf
2019-01-29 7:10 ` Markus Armbruster
2019-01-29 12:25 ` [Qemu-devel] [libvirt] " Peter Krempa
2019-01-29 9:40 ` [Qemu-devel] " Peter Krempa
2019-01-25 17:46 ` [Qemu-devel] [PATCH 3/3] scsi-disk: Deprecate device_id fallback to BlockBackend name Kevin Wolf
2019-01-29 15:58 ` Daniel P. Berrangé
2019-02-04 9:56 ` Kevin Wolf
2019-02-04 10:06 ` Daniel P. Berrangé
2019-01-25 20:52 ` [Qemu-devel] [PATCH 0/3] scsi-disk: Device Identification fixes Eric Blake
2019-02-01 12:51 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190201125120.GF5730@localhost.localdomain \
--to=kwolf@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=libvir-list@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pkrempa@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.