From: Markus Armbruster <armbru@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Peter Krempa <pkrempa@redhat.com>,
qemu-block@nongnu.org, libvir-list@redhat.com,
qemu-devel@nongnu.org, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH 2/3] scsi-disk: Add device_id property
Date: Mon, 28 Jan 2019 17:55:14 +0100 [thread overview]
Message-ID: <87tvhszpql.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20190128144147.GA5756@localhost.localdomain> (Kevin Wolf's message of "Mon, 28 Jan 2019 15:41:47 +0100")
Kevin Wolf <kwolf@redhat.com> writes:
> Am 28.01.2019 um 09:50 hat Peter Krempa geschrieben:
[...]
>> 2) Is actually using 'scsi-cd'/'scsi-hd' the better option than
>> 'scsi-disk'?
>
> Yes, scsi-disk is a legacy device. Maybe we should formally deprecate
> it.
There's an internal use in scsi_bus_legacy_add_drive(), which in turn
powers two legacy features:
1. -drive if=scsi
Creates scsi-disk frontends.
Only works with onboard HBAs since commit 14545097267, v2.12.0.
2. -device usb-storage
Bad magic: usb-storage pretends to be a block device, but it's really
a SCSI bus that can serve only a single device, which it creates
automatically.
If we deprecate scsi-disk, we should deprecate these, too. Can't say
whether that's practical right now.
>> 3) Since upstream libvirt supports qemu-1.5 and newer and 'scsi-cd' is
>> already supported there, can we assume that all newer versions support
>> it? (Basically the question is whether it can be compiled out by
>> upstream means).
>
> I think so.
Compiling out scsi-hd or scsi-cd, but not scsi-disk would be silly. All
three devices are in scsi-disk.c. You'd have to hack that up to be
silly.
next prev parent reply other threads:[~2019-01-28 16:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-25 17:46 [Qemu-devel] [PATCH 0/3] scsi-disk: Device Identification fixes Kevin Wolf
2019-01-25 17:46 ` [Qemu-devel] [PATCH 1/3] scsi-disk: Don't use empty string as device id Kevin Wolf
2019-01-29 12:30 ` Philippe Mathieu-Daudé
2019-01-29 16:37 ` Markus Armbruster
2019-01-30 11:39 ` Kevin Wolf
2019-01-25 17:46 ` [Qemu-devel] [PATCH 2/3] scsi-disk: Add device_id property Kevin Wolf
2019-01-28 8:50 ` Peter Krempa
2019-01-28 9:08 ` Peter Krempa
2019-01-28 14:41 ` Kevin Wolf
2019-01-28 16:55 ` Markus Armbruster [this message]
2019-01-28 17:49 ` Kevin Wolf
2019-01-29 7:10 ` Markus Armbruster
2019-01-29 12:25 ` [Qemu-devel] [libvirt] " Peter Krempa
2019-01-29 9:40 ` [Qemu-devel] " Peter Krempa
2019-01-25 17:46 ` [Qemu-devel] [PATCH 3/3] scsi-disk: Deprecate device_id fallback to BlockBackend name Kevin Wolf
2019-01-29 15:58 ` Daniel P. Berrangé
2019-02-04 9:56 ` Kevin Wolf
2019-02-04 10:06 ` Daniel P. Berrangé
2019-01-25 20:52 ` [Qemu-devel] [PATCH 0/3] scsi-disk: Device Identification fixes Eric Blake
2019-02-01 12:51 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tvhszpql.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=libvir-list@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pkrempa@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.