[PATCH i-g-t] i915/query: Update topology info to match reality

[PATCH i-g-t] i915/query: Update topology info to match reality

[Chris Wilson]

CI has a HSW GT1 with a single subslice. Accept this a possible truth
value.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106600
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
---
 tests/i915/query.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/i915/query.c b/tests/i915/query.c
index 764adc8fc..949858812 100644
--- a/tests/i915/query.c
+++ b/tests/i915/query.c
@@ -456,7 +456,7 @@ test_query_topology_known_pci_ids(int fd, int devid)
 	switch (dev_info->gt) {
 	case 1:
 		igt_assert_eq(n_slices, 1);
-		igt_assert(n_subslices == 2 || n_subslices == 3);
+		igt_assert(n_sublices == 1 || n_subslices == 2 || n_subslices == 3);
 		break;
 	case 2:
 		igt_assert_eq(n_slices, 1);
-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH i-g-t] i915/query: Update topology info to match reality

[Chris Wilson]

CI has a HSW GT1 with a single subslice. Accept this a possible truth
value.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106600
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
---
 tests/i915/query.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/i915/query.c b/tests/i915/query.c
index 764adc8fc..949858812 100644
--- a/tests/i915/query.c
+++ b/tests/i915/query.c
@@ -456,7 +456,7 @@ test_query_topology_known_pci_ids(int fd, int devid)
 	switch (dev_info->gt) {
 	case 1:
 		igt_assert_eq(n_slices, 1);
-		igt_assert(n_subslices == 2 || n_subslices == 3);
+		igt_assert(n_sublices == 1 || n_subslices == 2 || n_subslices == 3);
 		break;
 	case 2:
 		igt_assert_eq(n_slices, 1);
-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[igt-dev] ✗ Fi.CI.BAT: failure for i915/query: Update topology info to match reality

[Patchwork]

== Series Details ==

Series: i915/query: Update topology info to match reality
URL   : https://patchwork.freedesktop.org/series/56085/
State : failure

== Summary ==

IGT patchset build failed on latest successful build
973367176b61e81b5ca811620adb0467f6570aec debugfs: Fix writing an extra zero out of bounds in igt_crc_to_string_extended()

[209/461] Linking target tests/prime_mmap_kms.
[210/461] Linking target tests/prime_udl.
[211/461] Linking target tests/prime_vgem.
[212/461] Linking target tests/sw_sync.
[213/461] Linking target tests/syncobj_wait.
[214/461] Linking target tests/syncobj_basic.
[215/461] Linking target tests/template.
[216/461] Linking target tests/tools_test.
[217/461] Linking target tests/v3d_get_param.
[218/461] Linking target tests/v3d_get_bo_offset.
[219/461] Linking target tests/v3d_mmap.
[220/461] Linking target tests/vc4_dmabuf_poll.
[221/461] Linking target tests/vc4_create_bo.
[222/461] Linking target tests/vc4_lookup_fail.
[223/461] Linking target tests/vc4_label_bo.
[224/461] Linking target tests/vc4_purgeable_bo.
[225/461] Linking target tests/vc4_wait_bo.
[226/461] Linking target tests/vc4_tiling.
[227/461] Linking target tests/vc4_wait_seqno.
[228/461] Linking target tests/vgem_basic.
[229/461] Linking target tests/vgem_slow.
[230/461] Linking target tests/prime_nv_pcopy.
[231/461] Linking target tests/prime_nv_api.
[232/461] Linking target tests/prime_nv_test.
[233/461] Linking target tests/kms_chamelium.
[234/461] Linking target tests/i915_fb_tiling.
[235/461] Linking target tests/i915_getparams_basic.
[236/461] Linking target tests/i915_missed_irq.
[237/461] Linking target tests/i915_hangman.
[238/461] Linking target tests/i915_module_load.
[239/461] Compiling C object 'tests/i915_query@exe/i915_query.c.o'.
FAILED: tests/i915_query@exe/i915_query.c.o 
ccache cc  -Itests/i915_query@exe -Itests -I../tests -I. -I../ -I../lib/stubs/syscalls -Ilib -I../lib -I../include/drm-uapi -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/libpng16 -I/usr/include/freetype2 -I/usr/include/libpng12 -I/opt/igt/include -I/opt/igt/include/libdrm -I/usr/include/x86_64-linux-gnu -I/usr/include -I/usr/include/libdrm -I/usr/include/libdrm/nouveau -I/home/cidrm/kernel_headers/include -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O0 -g -D_GNU_SOURCE -include config.h -Wbad-function-cast -Wdeclaration-after-statement -Wformat=2 -Wimplicit-fallthrough=0 -Wlogical-op -Wmissing-declarations -Wmissing-format-attribute -Wmissing-noreturn -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wuninitialized -Wunused -Wno-clobbered -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-pointer-arith -Wno-sign-compare -Wno-type-limits -Wno-unused-parameter -Wno-unused-result -Werror=address -Werror=array-bounds -Werror=implicit -Werror=init-self -Werror=int-to-pointer-cast -Werror=main -Werror=missing-braces -Werror=nonnull -Werror=pointer-to-int-cast -Werror=return-type -Werror=sequence-point -Werror=trigraphs -Werror=write-strings -pthread -MD -MQ 'tests/i915_query@exe/i915_query.c.o' -MF 'tests/i915_query@exe/i915_query.c.o.d' -o 'tests/i915_query@exe/i915_query.c.o' -c ../tests/i915/query.c
In file included from ../lib/drmtest.h:39:0,
                 from ../lib/igt.h:27,
                 from ../tests/i915/query.c:24:
../tests/i915/query.c: In function ‘test_query_topology_known_pci_ids’:
../tests/i915/query.c:459:14: error: ‘n_sublices’ undeclared (first use in this function); did you mean ‘n_subslices’?
   igt_assert(n_sublices == 1 || n_subslices == 2 || n_subslices == 3);
              ^
../lib/igt_core.h:370:13: note: in definition of macro ‘igt_assert’
  do { if (!(expr)) \
             ^~~~
../tests/i915/query.c:459:14: note: each undeclared identifier is reported only once for each function it appears in
   igt_assert(n_sublices == 1 || n_subslices == 2 || n_subslices == 3);
              ^
../lib/igt_core.h:370:13: note: in definition of macro ‘igt_assert’
  do { if (!(expr)) \
             ^~~~
ninja: build stopped: subcommand failed.

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[PATCH i-g-t] i915/query: Update topology info to match reality

[Chris Wilson]

CI has a HSW GT1 with a single subslice. Accept this a possible truth
value.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106600
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
---
 tests/i915/query.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/i915/query.c b/tests/i915/query.c
index 764adc8fc..9ddd81f10 100644
--- a/tests/i915/query.c
+++ b/tests/i915/query.c
@@ -456,7 +456,7 @@ test_query_topology_known_pci_ids(int fd, int devid)
 	switch (dev_info->gt) {
 	case 1:
 		igt_assert_eq(n_slices, 1);
-		igt_assert(n_subslices == 2 || n_subslices == 3);
+		igt_assert(n_subslices == 1 || n_subslices == 2 || n_subslices == 3);
 		break;
 	case 2:
 		igt_assert_eq(n_slices, 1);
-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[igt-dev] [PATCH i-g-t] i915/query: Update topology info to match reality

[Chris Wilson]

CI has a HSW GT1 with a single subslice. Accept this a possible truth
value.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106600
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
---
 tests/i915/query.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/i915/query.c b/tests/i915/query.c
index 764adc8fc..9ddd81f10 100644
--- a/tests/i915/query.c
+++ b/tests/i915/query.c
@@ -456,7 +456,7 @@ test_query_topology_known_pci_ids(int fd, int devid)
 	switch (dev_info->gt) {
 	case 1:
 		igt_assert_eq(n_slices, 1);
-		igt_assert(n_subslices == 2 || n_subslices == 3);
+		igt_assert(n_subslices == 1 || n_subslices == 2 || n_subslices == 3);
 		break;
 	case 2:
 		igt_assert_eq(n_slices, 1);
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for i915/query: Update topology info to match reality (rev2)

[Patchwork]

== Series Details ==

Series: i915/query: Update topology info to match reality (rev2)
URL   : https://patchwork.freedesktop.org/series/56085/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5525 -> IGTPW_2333
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/56085/revisions/2/mbox/

Known issues
------------

  Here are the changes found in IGTPW_2333 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@kms_pipe_crc_basic@read-crc-pipe-b-frame-sequence:
    - fi-byt-clapper:     PASS -> FAIL [fdo#103191] / [fdo#107362]

  
#### Possible fixes ####

  * igt@gem_exec_suspend@basic-s3:
    - fi-blb-e6850:       INCOMPLETE [fdo#107718] -> PASS

  * igt@i915_selftest@live_execlists:
    - fi-apl-guc:         INCOMPLETE [fdo#103927] -> PASS

  * igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
    - fi-byt-clapper:     FAIL [fdo#103191] / [fdo#107362] -> PASS

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
  [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
  [fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
  [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278


Participating hosts (49 -> 43)
------------------------------

  Additional (1): fi-cfl-8109u 
  Missing    (7): fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-gdg-551 fi-pnv-d510 fi-icl-y 


Build changes
-------------

    * IGT: IGT_4803 -> IGTPW_2333

  CI_DRM_5525: 6d10b00ff86e70c4590724262c30ec8388174d38 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2333: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2333/
  IGT_4803: 973367176b61e81b5ca811620adb0467f6570aec @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2333/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.IGT: success for i915/query: Update topology info to match reality (rev2)

[Patchwork]

== Series Details ==

Series: i915/query: Update topology info to match reality (rev2)
URL   : https://patchwork.freedesktop.org/series/56085/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5525_full -> IGTPW_2333_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/56085/revisions/2/mbox/

Known issues
------------

  Here are the changes found in IGTPW_2333_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@kms_available_modes_crc@available_mode_test_crc:
    - shard-apl:          PASS -> FAIL [fdo#106641]
    - shard-glk:          PASS -> FAIL [fdo#106641]

  * igt@kms_busy@extended-modeset-hang-newfb-render-c:
    - shard-glk:          NOTRUN -> DMESG-WARN [fdo#107956]

  * igt@kms_ccs@pipe-b-crc-sprite-planes-basic:
    - shard-glk:          PASS -> FAIL [fdo#108145]

  * igt@kms_cursor_crc@cursor-128x42-sliding:
    - shard-kbl:          PASS -> FAIL [fdo#103232] +1

  * igt@kms_cursor_crc@cursor-256x85-random:
    - shard-apl:          PASS -> FAIL [fdo#103232] +4

  * igt@kms_cursor_crc@cursor-64x64-suspend:
    - shard-kbl:          PASS -> FAIL [fdo#103191] / [fdo#103232]

  * igt@kms_draw_crc@draw-method-xrgb8888-render-ytiled:
    - shard-glk:          PASS -> FAIL [fdo#103232] +2

  * igt@kms_flip@modeset-vs-vblank-race:
    - shard-kbl:          PASS -> FAIL [fdo#103060]

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-onoff:
    - shard-kbl:          PASS -> FAIL [fdo#103167]

  * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-move:
    - shard-glk:          PASS -> FAIL [fdo#103167] +7

  * igt@kms_plane@pixel-format-pipe-b-planes-source-clamping:
    - shard-glk:          PASS -> FAIL [fdo#108948]

  * igt@kms_plane@plane-position-covered-pipe-a-planes:
    - shard-glk:          PASS -> FAIL [fdo#103166] +3

  * igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
    - shard-apl:          PASS -> FAIL [fdo#103166] +1

  
#### Possible fixes ####

  * igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
    - shard-apl:          FAIL [fdo#106510] / [fdo#108145] -> PASS

  * igt@kms_color@pipe-b-ctm-max:
    - shard-apl:          FAIL [fdo#108147] -> PASS +1
    - shard-kbl:          FAIL [fdo#108147] -> PASS +1

  * igt@kms_color@pipe-b-legacy-gamma:
    - shard-apl:          FAIL [fdo#104782] -> PASS

  * igt@kms_cursor_crc@cursor-128x128-sliding:
    - shard-kbl:          FAIL [fdo#103232] -> PASS +2

  * igt@kms_cursor_crc@cursor-256x85-onscreen:
    - shard-apl:          FAIL [fdo#103232] -> PASS +5

  * igt@kms_cursor_crc@cursor-256x85-sliding:
    - shard-glk:          FAIL [fdo#103232] -> PASS

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt:
    - shard-apl:          FAIL [fdo#103167] -> PASS +2
    - shard-kbl:          FAIL [fdo#103167] -> PASS

  * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff:
    - shard-glk:          FAIL [fdo#103167] -> PASS +3

  * igt@kms_frontbuffer_tracking@fbc-2p-rte:
    - shard-glk:          FAIL [fdo#103167] / [fdo#105682] -> PASS

  * igt@kms_plane@plane-position-covered-pipe-c-planes:
    - shard-apl:          FAIL [fdo#103166] -> PASS +4

  * igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max:
    - shard-glk:          FAIL [fdo#108145] -> PASS +1

  * igt@kms_plane_multiple@atomic-pipe-b-tiling-none:
    - shard-glk:          FAIL [fdo#103166] -> PASS +5

  * igt@kms_plane_multiple@atomic-pipe-c-tiling-x:
    - shard-kbl:          FAIL [fdo#103166] -> PASS +2

  
#### Warnings ####

  * igt@i915_suspend@shrink:
    - shard-snb:          INCOMPLETE [fdo#105411] / [fdo#106886] -> DMESG-WARN [fdo#109244]

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#103060]: https://bugs.freedesktop.org/show_bug.cgi?id=103060
  [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
  [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
  [fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
  [fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
  [fdo#105682]: https://bugs.freedesktop.org/show_bug.cgi?id=105682
  [fdo#106510]: https://bugs.freedesktop.org/show_bug.cgi?id=106510
  [fdo#106641]: https://bugs.freedesktop.org/show_bug.cgi?id=106641
  [fdo#106886]: https://bugs.freedesktop.org/show_bug.cgi?id=106886
  [fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
  [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
  [fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147
  [fdo#108948]: https://bugs.freedesktop.org/show_bug.cgi?id=108948
  [fdo#109244]: https://bugs.freedesktop.org/show_bug.cgi?id=109244
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278


Participating hosts (7 -> 5)
------------------------------

  Missing    (2): shard-skl shard-iclb 


Build changes
-------------

    * IGT: IGT_4803 -> IGTPW_2333
    * Piglit: piglit_4509 -> None

  CI_DRM_5525: 6d10b00ff86e70c4590724262c30ec8388174d38 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2333: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2333/
  IGT_4803: 973367176b61e81b5ca811620adb0467f6570aec @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2333/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [PATCH i-g-t] i915/query: Update topology info to match reality

[Lionel Landwerlin]

On 01/02/2019 13:07, Chris Wilson wrote:
> CI has a HSW GT1 with a single subslice. Accept this a possible truth
> value.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106600
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>


Thanks Chris, I see it in the documented configurations :

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>


> ---
>   tests/i915/query.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/i915/query.c b/tests/i915/query.c
> index 764adc8fc..9ddd81f10 100644
> --- a/tests/i915/query.c
> +++ b/tests/i915/query.c
> @@ -456,7 +456,7 @@ test_query_topology_known_pci_ids(int fd, int devid)
>   	switch (dev_info->gt) {
>   	case 1:
>   		igt_assert_eq(n_slices, 1);
> -		igt_assert(n_subslices == 2 || n_subslices == 3);
> +		igt_assert(n_subslices == 1 || n_subslices == 2 || n_subslices == 3);
>   		break;
>   	case 2:
>   		igt_assert_eq(n_slices, 1);


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [igt-dev] [PATCH i-g-t] i915/query: Update topology info to match reality

[Lionel Landwerlin]

On 01/02/2019 13:07, Chris Wilson wrote:
> CI has a HSW GT1 with a single subslice. Accept this a possible truth
> value.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106600
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>


Thanks Chris, I see it in the documented configurations :

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>


> ---
>   tests/i915/query.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/i915/query.c b/tests/i915/query.c
> index 764adc8fc..9ddd81f10 100644
> --- a/tests/i915/query.c
> +++ b/tests/i915/query.c
> @@ -456,7 +456,7 @@ test_query_topology_known_pci_ids(int fd, int devid)
>   	switch (dev_info->gt) {
>   	case 1:
>   		igt_assert_eq(n_slices, 1);
> -		igt_assert(n_subslices == 2 || n_subslices == 3);
> +		igt_assert(n_subslices == 1 || n_subslices == 2 || n_subslices == 3);
>   		break;
>   	case 2:
>   		igt_assert_eq(n_slices, 1);


_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev