All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Pirko <jiri@resnulli.us>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
	thomas.lendacky@amd.com, f.fainelli@gmail.com,
	ariel.elior@cavium.com, michael.chan@broadcom.com,
	santosh@chelsio.com, madalin.bucur@nxp.com,
	yisen.zhuang@huawei.com, salil.mehta@huawei.com,
	jeffrey.t.kirsher@intel.com, tariqt@mellanox.com,
	saeedm@mellanox.com, jiri@mellanox.com, idosch@mellanox.com,
	jakub.kicinski@netronome.com, peppe.cavallaro@st.com,
	grygorii.strashko@ti.com, andrew@lunn.ch,
	vivien.didelot@savoirfairelinux.com, alexandre.torgue@st.com,
	joabreu@synopsys.com, linux-net-drivers@solarflare.com,
	ganeshgr@chelsio.com, ogerlitz@mellanox.com,
	Manish.Chopra@cavium.com, marcelo.leitner@gmail.com,
	mkubecek@suse.cz, venkatkumar.duvvuru@broadcom.com,
	julia.lawall@lip6.fr, john.fastabend@gmail.com,
	netfilter-devel@vger.kernel.org, cphealy@gmail.com
Subject: Re: [PATCH 01/12 net-next,v7] flow_offload: add flow_rule and flow_match structures and use them
Date: Sat, 2 Feb 2019 16:19:14 +0100	[thread overview]
Message-ID: <20190202151914.GA2778@nanopsycho> (raw)
In-Reply-To: <20190202115054.4880-2-pablo@netfilter.org>

Sat, Feb 02, 2019 at 12:50:43PM CET, pablo@netfilter.org wrote:
>This patch wraps the dissector key and mask - that flower uses to
>represent the matching side - around the flow_match structure.
>
>To avoid a follow up patch that would edit the same LoCs in the drivers,
>this patch also wraps this new flow match structure around the flow rule
>object. This new structure will also contain the flow actions in follow
>up patches.
>
>This introduces two new interfaces:
>
>	bool flow_rule_match_key(rule, dissector_id)
>
>that returns true if a given matching key is set on, and:
>
>	flow_rule_match_XYZ(rule, &match);
>
>To fetch the matching side XYZ into the match container structure, to
>retrieve the key and the mask with one single call.
>
>Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
>---
>v7: rebase on top of net-next. Dropping previous Acked-by tags since
>    this one is slightly large, and it would be good another look after
>    this rebase.

Looks good to me.

Acked-by: Jiri Pirko <jiri@mellanox.com>

WARNING: multiple messages have this Message-ID (diff)
From: Jiri Pirko <jiri@resnulli.us>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
	thomas.lendacky@amd.com, f.fainelli@gmail.com,
	ariel.elior@cavium.com, michael.chan@broadcom.com,
	santosh@chelsio.com, madalin.bucur@nxp.com,
	yisen.zhuang@huawei.com, salil.mehta@huawei.com,
	jeffrey.t.kirsher@intel.com, tariqt@mellanox.com,
	saeedm@mellanox.com, jiri@mellanox.com, idosch@mellanox.com,
	jakub.kicinski@netronome.com, peppe.cavallaro@st.com,
	grygorii.strashko@ti.com, andrew@lunn.ch,
	vivien.didelot@savoirfairelinux.com, alexandre.torgue@st.com,
	joabreu@synopsys.com, linux-net-drivers@solarflare.com,
	ganeshgr@chelsio.com, ogerlitz@mellanox.com,
	Manish.Chopra@cavium.com, marcelo.leitner@gmail.com,
	mkubecek@suse.cz, venkatkumar.duvvuru@broadcom.com,
	julia.lawall@lip6.fr, john.fastabend@gmail.com,
	netfilter-devel@v
Subject: Re: [PATCH 01/12 net-next,v7] flow_offload: add flow_rule and flow_match structures and use them
Date: Sat, 2 Feb 2019 16:19:14 +0100	[thread overview]
Message-ID: <20190202151914.GA2778@nanopsycho> (raw)
In-Reply-To: <20190202115054.4880-2-pablo@netfilter.org>

Sat, Feb 02, 2019 at 12:50:43PM CET, pablo@netfilter.org wrote:
>This patch wraps the dissector key and mask - that flower uses to
>represent the matching side - around the flow_match structure.
>
>To avoid a follow up patch that would edit the same LoCs in the drivers,
>this patch also wraps this new flow match structure around the flow rule
>object. This new structure will also contain the flow actions in follow
>up patches.
>
>This introduces two new interfaces:
>
>	bool flow_rule_match_key(rule, dissector_id)
>
>that returns true if a given matching key is set on, and:
>
>	flow_rule_match_XYZ(rule, &match);
>
>To fetch the matching side XYZ into the match container structure, to
>retrieve the key and the mask with one single call.
>
>Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
>---
>v7: rebase on top of net-next. Dropping previous Acked-by tags since
>    this one is slightly large, and it would be good another look after
>    this rebase.

Looks good to me.

Acked-by: Jiri Pirko <jiri@mellanox.com>

  reply	other threads:[~2019-02-02 15:28 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-02 11:50 [PATCH 00/12 net-next,v7] add flow_rule infrastructure Pablo Neira Ayuso
2019-02-02 11:50 ` Pablo Neira Ayuso
2019-02-02 11:50 ` [PATCH 01/12 net-next,v7] flow_offload: add flow_rule and flow_match structures and use them Pablo Neira Ayuso
2019-02-02 11:50   ` Pablo Neira Ayuso
2019-02-02 15:19   ` Jiri Pirko [this message]
2019-02-02 15:19     ` Jiri Pirko
2019-02-02 11:50 ` [PATCH 02/12 net-next,v7] net/mlx5e: support for two independent packet edit actions Pablo Neira Ayuso
2019-02-02 11:50   ` Pablo Neira Ayuso
2019-02-02 15:09   ` Tonghao Zhang
2019-02-02 15:09     ` Tonghao Zhang
2019-02-02 21:40     ` Or Gerlitz
2019-02-02 21:40       ` Or Gerlitz
2019-02-02 21:43     ` Or Gerlitz
2019-02-02 21:43       ` Or Gerlitz
2019-02-02 11:50 ` [PATCH 03/12 net-next,v7] flow_offload: add flow action infrastructure Pablo Neira Ayuso
2019-02-02 11:50   ` Pablo Neira Ayuso
2019-02-02 11:50 ` [PATCH 04/12 net-next,v7] cls_api: add translator to flow_action representation Pablo Neira Ayuso
2019-02-02 11:50   ` Pablo Neira Ayuso
2019-02-02 11:50 ` [PATCH 05/12 net-next,v7] flow_offload: add statistics retrieval infrastructure and use it Pablo Neira Ayuso
2019-02-02 11:50   ` Pablo Neira Ayuso
2019-02-02 11:50 ` [PATCH 06/12 net-next,v7] drivers: net: use flow action infrastructure Pablo Neira Ayuso
2019-02-02 11:50   ` Pablo Neira Ayuso
2019-02-02 15:44   ` Jiri Pirko
2019-02-02 15:44     ` Jiri Pirko
2019-02-02 11:50 ` [PATCH 07/12 net-next,v7] cls_flower: don't expose TC actions to drivers anymore Pablo Neira Ayuso
2019-02-02 11:50   ` Pablo Neira Ayuso
2019-02-02 11:50 ` [PATCH 08/12 net-next,v7] flow_offload: add wake-up-on-lan and queue to flow_action Pablo Neira Ayuso
2019-02-02 11:50   ` Pablo Neira Ayuso
2019-02-02 11:50 ` [PATCH 09/12 net-next,v7] ethtool: add ethtool_rx_flow_spec to flow_rule structure translator Pablo Neira Ayuso
2019-02-02 11:50   ` Pablo Neira Ayuso
2019-02-02 11:50 ` [PATCH 10/12 net-next,v7] dsa: bcm_sf2: use flow_rule infrastructure Pablo Neira Ayuso
2019-02-02 11:50   ` Pablo Neira Ayuso
2019-02-02 11:50 ` [PATCH 11/12 net-next,v7] qede: place ethtool_rx_flow_spec after code after TC flower codebase Pablo Neira Ayuso
2019-02-02 11:50   ` Pablo Neira Ayuso
2019-02-02 11:50 ` [PATCH 12/12 net-next,v7] qede: use ethtool_rx_flow_rule() to remove duplicated parser code Pablo Neira Ayuso
2019-02-02 11:50   ` Pablo Neira Ayuso
2019-02-06 18:39 ` [PATCH 00/12 net-next,v7] add flow_rule infrastructure David Miller
2019-02-06 18:39   ` David Miller
2019-02-06 20:44   ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190202151914.GA2778@nanopsycho \
    --to=jiri@resnulli.us \
    --cc=Manish.Chopra@cavium.com \
    --cc=alexandre.torgue@st.com \
    --cc=andrew@lunn.ch \
    --cc=ariel.elior@cavium.com \
    --cc=cphealy@gmail.com \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=ganeshgr@chelsio.com \
    --cc=grygorii.strashko@ti.com \
    --cc=idosch@mellanox.com \
    --cc=jakub.kicinski@netronome.com \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=jiri@mellanox.com \
    --cc=joabreu@synopsys.com \
    --cc=john.fastabend@gmail.com \
    --cc=julia.lawall@lip6.fr \
    --cc=linux-net-drivers@solarflare.com \
    --cc=madalin.bucur@nxp.com \
    --cc=marcelo.leitner@gmail.com \
    --cc=michael.chan@broadcom.com \
    --cc=mkubecek@suse.cz \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=ogerlitz@mellanox.com \
    --cc=pablo@netfilter.org \
    --cc=peppe.cavallaro@st.com \
    --cc=saeedm@mellanox.com \
    --cc=salil.mehta@huawei.com \
    --cc=santosh@chelsio.com \
    --cc=tariqt@mellanox.com \
    --cc=thomas.lendacky@amd.com \
    --cc=venkatkumar.duvvuru@broadcom.com \
    --cc=vivien.didelot@savoirfairelinux.com \
    --cc=yisen.zhuang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.