* [PATCH v2] cpufreq: tegra124: add missing of_node_put()
@ 2019-02-04 7:48 Yangtao Li
2019-02-04 8:18 ` Thierry Reding
0 siblings, 1 reply; 3+ messages in thread
From: Yangtao Li @ 2019-02-04 7:48 UTC (permalink / raw)
To: rjw, viresh.kumar, thierry.reding, jonathanh
Cc: linux-pm, linux-tegra, linux-kernel, stable, Yangtao Li
of_cpu_device_node_get() will increase the refcount of device_node,
it is necessary to call of_node_put() at the end to release the
refcount.
Fixes: 9eb15dbbfa1a2 ("cpufreq: Add cpufreq driver for Tegra124")
Cc: <stable@vger.kernel.org> # 4.4+
Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
---
v2:
- move of_node_put() to the very end
---
drivers/cpufreq/tegra124-cpufreq.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/cpufreq/tegra124-cpufreq.c b/drivers/cpufreq/tegra124-cpufreq.c
index 43530254201a..4bb154f6c54c 100644
--- a/drivers/cpufreq/tegra124-cpufreq.c
+++ b/drivers/cpufreq/tegra124-cpufreq.c
@@ -134,6 +134,8 @@ static int tegra124_cpufreq_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, priv);
+ of_node_put(np);
+
return 0;
out_switch_to_pllx:
--
2.17.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] cpufreq: tegra124: add missing of_node_put()
2019-02-04 7:48 [PATCH v2] cpufreq: tegra124: add missing of_node_put() Yangtao Li
@ 2019-02-04 8:18 ` Thierry Reding
2019-02-04 8:56 ` Viresh Kumar
0 siblings, 1 reply; 3+ messages in thread
From: Thierry Reding @ 2019-02-04 8:18 UTC (permalink / raw)
To: Yangtao Li
Cc: rjw, viresh.kumar, jonathanh, linux-pm, linux-tegra,
linux-kernel, stable
[-- Attachment #1: Type: text/plain, Size: 569 bytes --]
On Mon, Feb 04, 2019 at 02:48:54AM -0500, Yangtao Li wrote:
> of_cpu_device_node_get() will increase the refcount of device_node,
> it is necessary to call of_node_put() at the end to release the
> refcount.
>
> Fixes: 9eb15dbbfa1a2 ("cpufreq: Add cpufreq driver for Tegra124")
> Cc: <stable@vger.kernel.org> # 4.4+
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
> v2:
> - move of_node_put() to the very end
> ---
> drivers/cpufreq/tegra124-cpufreq.c | 2 ++
> 1 file changed, 2 insertions(+)
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] cpufreq: tegra124: add missing of_node_put()
2019-02-04 8:18 ` Thierry Reding
@ 2019-02-04 8:56 ` Viresh Kumar
0 siblings, 0 replies; 3+ messages in thread
From: Viresh Kumar @ 2019-02-04 8:56 UTC (permalink / raw)
To: Thierry Reding
Cc: Yangtao Li, rjw, jonathanh, linux-pm, linux-tegra, linux-kernel, stable
On 04-02-19, 09:18, Thierry Reding wrote:
> On Mon, Feb 04, 2019 at 02:48:54AM -0500, Yangtao Li wrote:
> > of_cpu_device_node_get() will increase the refcount of device_node,
> > it is necessary to call of_node_put() at the end to release the
> > refcount.
> >
> > Fixes: 9eb15dbbfa1a2 ("cpufreq: Add cpufreq driver for Tegra124")
> > Cc: <stable@vger.kernel.org> # 4.4+
> > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> > ---
> > v2:
> > - move of_node_put() to the very end
> > ---
> > drivers/cpufreq/tegra124-cpufreq.c | 2 ++
> > 1 file changed, 2 insertions(+)
>
> Acked-by: Thierry Reding <treding@nvidia.com>
Applied. Thanks.
--
viresh
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-04 8:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-04 7:48 [PATCH v2] cpufreq: tegra124: add missing of_node_put() Yangtao Li
2019-02-04 8:18 ` Thierry Reding
2019-02-04 8:56 ` Viresh Kumar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.