All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Vasundhara Volam <vasundhara-v.volam@broadcom.com>
Cc: Michal Kubecek <mkubecek@suse.cz>,
	Netdev <netdev@vger.kernel.org>,
	David Miller <davem@davemloft.net>,
	"michael.chan@broadcom.com" <michael.chan@broadcom.com>,
	Jiri Pirko <jiri@mellanox.com>
Subject: Re: [PATCH net-next v7 0/8] devlink: Add configuration parameters support for devlink_port
Date: Mon, 4 Feb 2019 18:56:26 -0800	[thread overview]
Message-ID: <20190204185626.3c7a162b@cakuba.netronome.com> (raw)
In-Reply-To: <CAACQVJpVHLCeeE1KhJanYv_kDXzE=KX_OAPiCnFfjotf3K1+TA@mail.gmail.com>

On Mon, 4 Feb 2019 12:25:13 +0530, Vasundhara Volam wrote:
> > > IMHO this is not really a problem. We can either use an additional flag
> > > telling kernel/driver if we are setting runtime or persistent WoL mask
> > > or we can pass (up to) two bitmaps.  
> Jakub, I will add another two bitmask parameters for WoL named as
> wake_on_lan_runtime
> and wake_on_lan_persistent. This will give information about what
> types are runtime and
> what types are persistent, does the device support for any given WoL types.
> 
> Does that sound good?

No?  We were talking about using the soon-too-come ethtool netlink
API with additional indication that given configuration request is
supposed to be persisted.  Adding more devlink parameters is exactly 
the opposite of what you should be doing.

  reply	other threads:[~2019-02-05  2:56 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-18  7:09 [PATCH net-next v7 0/8] devlink: Add configuration parameters support for devlink_port Vasundhara Volam
2019-01-18  7:09 ` [PATCH net-next v7 1/8] devlink: Add devlink_param for port register and unregister Vasundhara Volam
2019-01-23  8:25   ` Jiri Pirko
2019-01-23  9:13     ` Vasundhara Volam
2019-01-18  7:09 ` [PATCH net-next v7 2/8] devlink: Add port param get command Vasundhara Volam
2019-01-23  8:53   ` Jiri Pirko
2019-01-18  7:09 ` [PATCH net-next v7 3/8] devlink: Add port param set command Vasundhara Volam
2019-01-23 11:03   ` Jiri Pirko
2019-01-18  7:09 ` [PATCH net-next v7 4/8] devlink: Add support for driverinit get value for devlink_port Vasundhara Volam
2019-01-23 11:08   ` Jiri Pirko
2019-01-23 11:36     ` Vasundhara Volam
2019-01-18  7:09 ` [PATCH net-next v7 5/8] devlink: Add support for driverinit set " Vasundhara Volam
2019-01-18  7:09 ` [PATCH net-next v7 6/8] devlink: Add devlink notifications support for port params Vasundhara Volam
2019-01-18  7:09 ` [PATCH net-next v7 7/8] devlink: Add a generic wake_on_lan port parameter Vasundhara Volam
2019-01-18  7:09 ` [PATCH net-next v7 8/8] bnxt_en: Add bnxt_en initial port params table and register it Vasundhara Volam
2019-01-18 14:33 ` [PATCH net-next v7 0/8] devlink: Add configuration parameters support for devlink_port Michal Kubecek
2019-01-22 22:18   ` Jakub Kicinski
2019-01-24  9:46     ` Vasundhara Volam
2019-01-24 18:50       ` Jakub Kicinski
2019-01-27 23:07     ` Michal Kubecek
2019-01-28  3:45       ` David Miller
2019-02-04  6:55     ` Vasundhara Volam
2019-02-05  2:56       ` Jakub Kicinski [this message]
2019-02-05  4:23         ` Vasundhara Volam
2019-02-05 16:51           ` Michal Kubecek
2019-02-06 10:13             ` Vasundhara Volam
2019-01-24  9:42   ` Vasundhara Volam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190204185626.3c7a162b@cakuba.netronome.com \
    --to=jakub.kicinski@netronome.com \
    --cc=davem@davemloft.net \
    --cc=jiri@mellanox.com \
    --cc=michael.chan@broadcom.com \
    --cc=mkubecek@suse.cz \
    --cc=netdev@vger.kernel.org \
    --cc=vasundhara-v.volam@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.