* [PATCH 01/20] ALSA: atmel: Drop superfluous PCM preallocation error checks
2019-02-05 19:42 [PATCH 00/20] ALSA: Drop superfluous PCM preallocation error checks Takashi Iwai
@ 2019-02-05 19:42 ` Takashi Iwai
2019-02-05 19:42 ` [PATCH 02/20] ALSA: parisc: " Takashi Iwai
` (19 subsequent siblings)
20 siblings, 0 replies; 26+ messages in thread
From: Takashi Iwai @ 2019-02-05 19:42 UTC (permalink / raw)
To: alsa-devel; +Cc: Mark Brown
snd_pcm_lib_preallocate_pages() and co always succeed, so the error
check is simply redundant. Drop it.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
sound/atmel/ac97c.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/sound/atmel/ac97c.c b/sound/atmel/ac97c.c
index 380025887aef..33c87a0547a9 100644
--- a/sound/atmel/ac97c.c
+++ b/sound/atmel/ac97c.c
@@ -603,11 +603,9 @@ static int atmel_ac97c_pcm_new(struct atmel_ac97c *chip)
snd_pcm_set_ops(pcm, SNDRV_PCM_STREAM_CAPTURE, &atmel_ac97_capture_ops);
snd_pcm_set_ops(pcm, SNDRV_PCM_STREAM_PLAYBACK, &atmel_ac97_playback_ops);
- retval = snd_pcm_lib_preallocate_pages_for_all(pcm, SNDRV_DMA_TYPE_DEV,
+ snd_pcm_lib_preallocate_pages_for_all(pcm, SNDRV_DMA_TYPE_DEV,
&chip->pdev->dev, hw.periods_min * hw.period_bytes_min,
hw.buffer_bytes_max);
- if (retval)
- return retval;
pcm->private_data = chip;
pcm->info_flags = 0;
--
2.16.4
^ permalink raw reply related [flat|nested] 26+ messages in thread* [PATCH 02/20] ALSA: parisc: Drop superfluous PCM preallocation error checks
2019-02-05 19:42 [PATCH 00/20] ALSA: Drop superfluous PCM preallocation error checks Takashi Iwai
2019-02-05 19:42 ` [PATCH 01/20] ALSA: atmel: " Takashi Iwai
@ 2019-02-05 19:42 ` Takashi Iwai
2019-02-05 19:42 ` [PATCH 03/20] ALSA: pci: " Takashi Iwai
` (18 subsequent siblings)
20 siblings, 0 replies; 26+ messages in thread
From: Takashi Iwai @ 2019-02-05 19:42 UTC (permalink / raw)
To: alsa-devel; +Cc: Mark Brown
snd_pcm_lib_preallocate_pages() and co always succeed, so the error
check is simply redundant. Drop it.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
sound/parisc/harmony.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/sound/parisc/harmony.c b/sound/parisc/harmony.c
index f36e7006e00c..a4264b8943f0 100644
--- a/sound/parisc/harmony.c
+++ b/sound/parisc/harmony.c
@@ -669,14 +669,8 @@ snd_harmony_pcm_init(struct snd_harmony *h)
}
/* pre-allocate space for DMA */
- err = snd_pcm_lib_preallocate_pages_for_all(pcm, h->dma.type,
- h->dma.dev,
- MAX_BUF_SIZE,
- MAX_BUF_SIZE);
- if (err < 0) {
- printk(KERN_ERR PFX "buffer allocation error: %d\n", err);
- return err;
- }
+ snd_pcm_lib_preallocate_pages_for_all(pcm, h->dma.type, h->dma.dev,
+ MAX_BUF_SIZE, MAX_BUF_SIZE);
h->st.format = snd_harmony_set_data_format(h,
SNDRV_PCM_FORMAT_S16_BE, 1);
--
2.16.4
^ permalink raw reply related [flat|nested] 26+ messages in thread* [PATCH 03/20] ALSA: pci: Drop superfluous PCM preallocation error checks
2019-02-05 19:42 [PATCH 00/20] ALSA: Drop superfluous PCM preallocation error checks Takashi Iwai
2019-02-05 19:42 ` [PATCH 01/20] ALSA: atmel: " Takashi Iwai
2019-02-05 19:42 ` [PATCH 02/20] ALSA: parisc: " Takashi Iwai
@ 2019-02-05 19:42 ` Takashi Iwai
2019-02-05 19:42 ` [PATCH 04/20] ALSA: ppc: " Takashi Iwai
` (17 subsequent siblings)
20 siblings, 0 replies; 26+ messages in thread
From: Takashi Iwai @ 2019-02-05 19:42 UTC (permalink / raw)
To: alsa-devel; +Cc: Mark Brown
snd_pcm_lib_preallocate_pages() and co always succeed, so the error
check is simply redundant. Drop it.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
sound/pci/ad1889.c | 7 +------
sound/pci/aw2/aw2-alsa.c | 40 ++++++++++++----------------------------
sound/pci/bt87x.c | 10 +++++-----
sound/pci/ca0106/ca0106_main.c | 16 ++++++----------
sound/pci/echoaudio/echoaudio.c | 16 +++++++---------
sound/pci/emu10k1/emupcm.c | 22 +++++++++++++++-------
sound/pci/emu10k1/p16v.c | 17 +++++++----------
sound/pci/lx6464es/lx6464es.c | 8 +++-----
sound/pci/rme9652/hdspm.c | 20 ++++----------------
sound/pci/via82xx_modem.c | 8 +++-----
10 files changed, 63 insertions(+), 101 deletions(-)
diff --git a/sound/pci/ad1889.c b/sound/pci/ad1889.c
index d9c54c08e2db..410fefe5ebde 100644
--- a/sound/pci/ad1889.c
+++ b/sound/pci/ad1889.c
@@ -644,16 +644,11 @@ snd_ad1889_pcm_init(struct snd_ad1889 *chip, int device)
chip->psubs = NULL;
chip->csubs = NULL;
- err = snd_pcm_lib_preallocate_pages_for_all(pcm, SNDRV_DMA_TYPE_DEV,
+ snd_pcm_lib_preallocate_pages_for_all(pcm, SNDRV_DMA_TYPE_DEV,
snd_dma_pci_data(chip->pci),
BUFFER_BYTES_MAX / 2,
BUFFER_BYTES_MAX);
- if (err < 0) {
- dev_err(chip->card->dev, "buffer allocation error: %d\n", err);
- return err;
- }
-
return 0;
}
diff --git a/sound/pci/aw2/aw2-alsa.c b/sound/pci/aw2/aw2-alsa.c
index 9a49e4243a9c..b07c5fc1da56 100644
--- a/sound/pci/aw2/aw2-alsa.c
+++ b/sound/pci/aw2/aw2-alsa.c
@@ -624,15 +624,10 @@ static int snd_aw2_new_pcm(struct aw2 *chip)
/* pre-allocation of buffers */
/* Preallocate continuous pages. */
- err = snd_pcm_lib_preallocate_pages_for_all(pcm_playback_ana,
- SNDRV_DMA_TYPE_DEV,
- snd_dma_pci_data
- (chip->pci),
- 64 * 1024, 64 * 1024);
- if (err)
- dev_err(chip->card->dev,
- "snd_pcm_lib_preallocate_pages_for_all error (0x%X)\n",
- err);
+ snd_pcm_lib_preallocate_pages_for_all(pcm_playback_ana,
+ SNDRV_DMA_TYPE_DEV,
+ snd_dma_pci_data(chip->pci),
+ 64 * 1024, 64 * 1024);
err = snd_pcm_new(chip->card, "Audiowerk2 digital playback", 1, 1, 0,
&pcm_playback_num);
@@ -661,15 +656,10 @@ static int snd_aw2_new_pcm(struct aw2 *chip)
/* pre-allocation of buffers */
/* Preallocate continuous pages. */
- err = snd_pcm_lib_preallocate_pages_for_all(pcm_playback_num,
- SNDRV_DMA_TYPE_DEV,
- snd_dma_pci_data
- (chip->pci),
- 64 * 1024, 64 * 1024);
- if (err)
- dev_err(chip->card->dev,
- "snd_pcm_lib_preallocate_pages_for_all error (0x%X)\n",
- err);
+ snd_pcm_lib_preallocate_pages_for_all(pcm_playback_num,
+ SNDRV_DMA_TYPE_DEV,
+ snd_dma_pci_data(chip->pci),
+ 64 * 1024, 64 * 1024);
err = snd_pcm_new(chip->card, "Audiowerk2 capture", 2, 0, 1,
&pcm_capture);
@@ -699,16 +689,10 @@ static int snd_aw2_new_pcm(struct aw2 *chip)
/* pre-allocation of buffers */
/* Preallocate continuous pages. */
- err = snd_pcm_lib_preallocate_pages_for_all(pcm_capture,
- SNDRV_DMA_TYPE_DEV,
- snd_dma_pci_data
- (chip->pci),
- 64 * 1024, 64 * 1024);
- if (err)
- dev_err(chip->card->dev,
- "snd_pcm_lib_preallocate_pages_for_all error (0x%X)\n",
- err);
-
+ snd_pcm_lib_preallocate_pages_for_all(pcm_capture,
+ SNDRV_DMA_TYPE_DEV,
+ snd_dma_pci_data(chip->pci),
+ 64 * 1024, 64 * 1024);
/* Create control */
err = snd_ctl_add(chip->card, snd_ctl_new1(&aw2_control, chip));
diff --git a/sound/pci/bt87x.c b/sound/pci/bt87x.c
index ba971042f871..0adcba10c067 100644
--- a/sound/pci/bt87x.c
+++ b/sound/pci/bt87x.c
@@ -714,11 +714,11 @@ static int snd_bt87x_pcm(struct snd_bt87x *chip, int device, char *name)
pcm->private_data = chip;
strcpy(pcm->name, name);
snd_pcm_set_ops(pcm, SNDRV_PCM_STREAM_CAPTURE, &snd_bt87x_pcm_ops);
- return snd_pcm_lib_preallocate_pages_for_all(pcm,
- SNDRV_DMA_TYPE_DEV_SG,
- snd_dma_pci_data(chip->pci),
- 128 * 1024,
- ALIGN(255 * 4092, 1024));
+ snd_pcm_lib_preallocate_pages_for_all(pcm, SNDRV_DMA_TYPE_DEV_SG,
+ snd_dma_pci_data(chip->pci),
+ 128 * 1024,
+ ALIGN(255 * 4092, 1024));
+ return 0;
}
static int snd_bt87x_create(struct snd_card *card,
diff --git a/sound/pci/ca0106/ca0106_main.c b/sound/pci/ca0106/ca0106_main.c
index 3d1b0bbff33b..11ef0d636405 100644
--- a/sound/pci/ca0106/ca0106_main.c
+++ b/sound/pci/ca0106/ca0106_main.c
@@ -1402,21 +1402,17 @@ static int snd_ca0106_pcm(struct snd_ca0106 *emu, int device)
for(substream = pcm->streams[SNDRV_PCM_STREAM_PLAYBACK].substream;
substream;
substream = substream->next) {
- if ((err = snd_pcm_lib_preallocate_pages(substream,
- SNDRV_DMA_TYPE_DEV,
- snd_dma_pci_data(emu->pci),
- 64*1024, 64*1024)) < 0) /* FIXME: 32*1024 for sound buffer, between 32and64 for Periods table. */
- return err;
+ snd_pcm_lib_preallocate_pages(substream, SNDRV_DMA_TYPE_DEV,
+ snd_dma_pci_data(emu->pci),
+ 64*1024, 64*1024);
}
for (substream = pcm->streams[SNDRV_PCM_STREAM_CAPTURE].substream;
substream;
substream = substream->next) {
- if ((err = snd_pcm_lib_preallocate_pages(substream,
- SNDRV_DMA_TYPE_DEV,
- snd_dma_pci_data(emu->pci),
- 64*1024, 64*1024)) < 0)
- return err;
+ snd_pcm_lib_preallocate_pages(substream, SNDRV_DMA_TYPE_DEV,
+ snd_dma_pci_data(emu->pci),
+ 64*1024, 64*1024);
}
err = snd_pcm_add_chmap_ctls(pcm, SNDRV_PCM_STREAM_PLAYBACK, map, 2,
diff --git a/sound/pci/echoaudio/echoaudio.c b/sound/pci/echoaudio/echoaudio.c
index 18d30d479b6b..ea876b0b02b9 100644
--- a/sound/pci/echoaudio/echoaudio.c
+++ b/sound/pci/echoaudio/echoaudio.c
@@ -884,17 +884,15 @@ static const struct snd_pcm_ops digital_capture_ops = {
static int snd_echo_preallocate_pages(struct snd_pcm *pcm, struct device *dev)
{
struct snd_pcm_substream *ss;
- int stream, err;
+ int stream;
for (stream = 0; stream < 2; stream++)
- for (ss = pcm->streams[stream].substream; ss; ss = ss->next) {
- err = snd_pcm_lib_preallocate_pages(ss, SNDRV_DMA_TYPE_DEV_SG,
- dev,
- ss->number ? 0 : 128<<10,
- 256<<10);
- if (err < 0)
- return err;
- }
+ for (ss = pcm->streams[stream].substream; ss; ss = ss->next)
+ snd_pcm_lib_preallocate_pages(ss, SNDRV_DMA_TYPE_DEV_SG,
+ dev,
+ ss->number ? 0 : 128<<10,
+ 256<<10);
+
return 0;
}
diff --git a/sound/pci/emu10k1/emupcm.c b/sound/pci/emu10k1/emupcm.c
index 30b3472d0b75..f6b4cb9ac75c 100644
--- a/sound/pci/emu10k1/emupcm.c
+++ b/sound/pci/emu10k1/emupcm.c
@@ -1427,11 +1427,14 @@ int snd_emu10k1_pcm(struct snd_emu10k1 *emu, int device)
emu->pcm = pcm;
for (substream = pcm->streams[SNDRV_PCM_STREAM_PLAYBACK].substream; substream; substream = substream->next)
- if ((err = snd_pcm_lib_preallocate_pages(substream, SNDRV_DMA_TYPE_DEV_SG, snd_dma_pci_data(emu->pci), 64*1024, 64*1024)) < 0)
- return err;
+ snd_pcm_lib_preallocate_pages(substream, SNDRV_DMA_TYPE_DEV_SG,
+ snd_dma_pci_data(emu->pci),
+ 64*1024, 64*1024);
for (substream = pcm->streams[SNDRV_PCM_STREAM_CAPTURE].substream; substream; substream = substream->next)
- snd_pcm_lib_preallocate_pages(substream, SNDRV_DMA_TYPE_DEV, snd_dma_pci_data(emu->pci), 64*1024, 64*1024);
+ snd_pcm_lib_preallocate_pages(substream, SNDRV_DMA_TYPE_DEV,
+ snd_dma_pci_data(emu->pci),
+ 64*1024, 64*1024);
return 0;
}
@@ -1455,8 +1458,9 @@ int snd_emu10k1_pcm_multi(struct snd_emu10k1 *emu, int device)
emu->pcm_multi = pcm;
for (substream = pcm->streams[SNDRV_PCM_STREAM_PLAYBACK].substream; substream; substream = substream->next)
- if ((err = snd_pcm_lib_preallocate_pages(substream, SNDRV_DMA_TYPE_DEV_SG, snd_dma_pci_data(emu->pci), 64*1024, 64*1024)) < 0)
- return err;
+ snd_pcm_lib_preallocate_pages(substream, SNDRV_DMA_TYPE_DEV_SG,
+ snd_dma_pci_data(emu->pci),
+ 64*1024, 64*1024);
return 0;
}
@@ -1489,7 +1493,9 @@ int snd_emu10k1_pcm_mic(struct snd_emu10k1 *emu, int device)
strcpy(pcm->name, "Mic Capture");
emu->pcm_mic = pcm;
- snd_pcm_lib_preallocate_pages_for_all(pcm, SNDRV_DMA_TYPE_DEV, snd_dma_pci_data(emu->pci), 64*1024, 64*1024);
+ snd_pcm_lib_preallocate_pages_for_all(pcm, SNDRV_DMA_TYPE_DEV,
+ snd_dma_pci_data(emu->pci),
+ 64*1024, 64*1024);
return 0;
}
@@ -1862,7 +1868,9 @@ int snd_emu10k1_pcm_efx(struct snd_emu10k1 *emu, int device)
if (err < 0)
return err;
- snd_pcm_lib_preallocate_pages_for_all(pcm, SNDRV_DMA_TYPE_DEV, snd_dma_pci_data(emu->pci), 64*1024, 64*1024);
+ snd_pcm_lib_preallocate_pages_for_all(pcm, SNDRV_DMA_TYPE_DEV,
+ snd_dma_pci_data(emu->pci),
+ 64*1024, 64*1024);
return 0;
}
diff --git a/sound/pci/emu10k1/p16v.c b/sound/pci/emu10k1/p16v.c
index 4948b95f6665..672017cac4c7 100644
--- a/sound/pci/emu10k1/p16v.c
+++ b/sound/pci/emu10k1/p16v.c
@@ -656,11 +656,10 @@ int snd_p16v_pcm(struct snd_emu10k1 *emu, int device)
for(substream = pcm->streams[SNDRV_PCM_STREAM_PLAYBACK].substream;
substream;
substream = substream->next) {
- if ((err = snd_pcm_lib_preallocate_pages(substream,
- SNDRV_DMA_TYPE_DEV,
- snd_dma_pci_data(emu->pci),
- ((65536 - 64) * 8), ((65536 - 64) * 8))) < 0)
- return err;
+ snd_pcm_lib_preallocate_pages(substream, SNDRV_DMA_TYPE_DEV,
+ snd_dma_pci_data(emu->pci),
+ (65536 - 64) * 8,
+ (65536 - 64) * 8);
/*
dev_dbg(emu->card->dev,
"preallocate playback substream: err=%d\n", err);
@@ -670,11 +669,9 @@ int snd_p16v_pcm(struct snd_emu10k1 *emu, int device)
for (substream = pcm->streams[SNDRV_PCM_STREAM_CAPTURE].substream;
substream;
substream = substream->next) {
- if ((err = snd_pcm_lib_preallocate_pages(substream,
- SNDRV_DMA_TYPE_DEV,
- snd_dma_pci_data(emu->pci),
- 65536 - 64, 65536 - 64)) < 0)
- return err;
+ snd_pcm_lib_preallocate_pages(substream, SNDRV_DMA_TYPE_DEV,
+ snd_dma_pci_data(emu->pci),
+ 65536 - 64, 65536 - 64);
/*
dev_dbg(emu->card->dev,
"preallocate capture substream: err=%d\n", err);
diff --git a/sound/pci/lx6464es/lx6464es.c b/sound/pci/lx6464es/lx6464es.c
index 54f6252faca6..52ea0da1fe73 100644
--- a/sound/pci/lx6464es/lx6464es.c
+++ b/sound/pci/lx6464es/lx6464es.c
@@ -854,11 +854,9 @@ static int lx_pcm_create(struct lx6464es *chip)
pcm->nonatomic = true;
strcpy(pcm->name, card_name);
- err = snd_pcm_lib_preallocate_pages_for_all(pcm, SNDRV_DMA_TYPE_DEV,
- snd_dma_pci_data(chip->pci),
- size, size);
- if (err < 0)
- return err;
+ snd_pcm_lib_preallocate_pages_for_all(pcm, SNDRV_DMA_TYPE_DEV,
+ snd_dma_pci_data(chip->pci),
+ size, size);
chip->pcm = pcm;
chip->capture_stream.is_capture = 1;
diff --git a/sound/pci/rme9652/hdspm.c b/sound/pci/rme9652/hdspm.c
index 679ad0415e3b..3e66df7b5d1f 100644
--- a/sound/pci/rme9652/hdspm.c
+++ b/sound/pci/rme9652/hdspm.c
@@ -6411,7 +6411,6 @@ static int snd_hdspm_create_hwdep(struct snd_card *card,
------------------------------------------------------------*/
static int snd_hdspm_preallocate_memory(struct hdspm *hdspm)
{
- int err;
struct snd_pcm *pcm;
size_t wanted;
@@ -6419,21 +6418,10 @@ static int snd_hdspm_preallocate_memory(struct hdspm *hdspm)
wanted = HDSPM_DMA_AREA_BYTES;
- err =
- snd_pcm_lib_preallocate_pages_for_all(pcm,
- SNDRV_DMA_TYPE_DEV_SG,
- snd_dma_pci_data(hdspm->pci),
- wanted,
- wanted);
- if (err < 0) {
- dev_dbg(hdspm->card->dev,
- "Could not preallocate %zd Bytes\n", wanted);
-
- return err;
- } else
- dev_dbg(hdspm->card->dev,
- " Preallocated %zd Bytes\n", wanted);
-
+ snd_pcm_lib_preallocate_pages_for_all(pcm, SNDRV_DMA_TYPE_DEV_SG,
+ snd_dma_pci_data(hdspm->pci),
+ wanted, wanted);
+ dev_dbg(hdspm->card->dev, " Preallocated %zd Bytes\n", wanted);
return 0;
}
diff --git a/sound/pci/via82xx_modem.c b/sound/pci/via82xx_modem.c
index 3f59e0279058..3b3768acf7e1 100644
--- a/sound/pci/via82xx_modem.c
+++ b/sound/pci/via82xx_modem.c
@@ -865,11 +865,9 @@ static int snd_via686_pcm_new(struct via82xx_modem *chip)
init_viadev(chip, 0, VIA_REG_MO_STATUS, 0);
init_viadev(chip, 1, VIA_REG_MI_STATUS, 1);
- if ((err = snd_pcm_lib_preallocate_pages_for_all(pcm, SNDRV_DMA_TYPE_DEV_SG,
- snd_dma_pci_data(chip->pci),
- 64*1024, 128*1024)) < 0)
- return err;
-
+ snd_pcm_lib_preallocate_pages_for_all(pcm, SNDRV_DMA_TYPE_DEV_SG,
+ snd_dma_pci_data(chip->pci),
+ 64*1024, 128*1024);
return 0;
}
--
2.16.4
^ permalink raw reply related [flat|nested] 26+ messages in thread* [PATCH 04/20] ALSA: ppc: Drop superfluous PCM preallocation error checks
2019-02-05 19:42 [PATCH 00/20] ALSA: Drop superfluous PCM preallocation error checks Takashi Iwai
` (2 preceding siblings ...)
2019-02-05 19:42 ` [PATCH 03/20] ALSA: pci: " Takashi Iwai
@ 2019-02-05 19:42 ` Takashi Iwai
2019-02-05 19:42 ` [PATCH 05/20] ALSA: sh: " Takashi Iwai
` (16 subsequent siblings)
20 siblings, 0 replies; 26+ messages in thread
From: Takashi Iwai @ 2019-02-05 19:42 UTC (permalink / raw)
To: alsa-devel; +Cc: Mark Brown
snd_pcm_lib_preallocate_pages() and co always succeed, so the error
check is simply redundant. Drop it.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
sound/ppc/snd_ps3.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/sound/ppc/snd_ps3.c b/sound/ppc/snd_ps3.c
index abe031c9d592..521236efcc4d 100644
--- a/sound/ppc/snd_ps3.c
+++ b/sound/ppc/snd_ps3.c
@@ -1024,15 +1024,11 @@ static int snd_ps3_driver_probe(struct ps3_system_bus_device *dev)
the_card.pcm->info_flags = SNDRV_PCM_INFO_NONINTERLEAVED;
/* pre-alloc PCM DMA buffer*/
- ret = snd_pcm_lib_preallocate_pages_for_all(the_card.pcm,
+ snd_pcm_lib_preallocate_pages_for_all(the_card.pcm,
SNDRV_DMA_TYPE_DEV,
&dev->core,
SND_PS3_PCM_PREALLOC_SIZE,
SND_PS3_PCM_PREALLOC_SIZE);
- if (ret < 0) {
- pr_info("%s: prealloc failed\n", __func__);
- goto clean_card;
- }
/*
* allocate null buffer
--
2.16.4
^ permalink raw reply related [flat|nested] 26+ messages in thread* [PATCH 05/20] ALSA: sh: Drop superfluous PCM preallocation error checks
2019-02-05 19:42 [PATCH 00/20] ALSA: Drop superfluous PCM preallocation error checks Takashi Iwai
` (3 preceding siblings ...)
2019-02-05 19:42 ` [PATCH 04/20] ALSA: ppc: " Takashi Iwai
@ 2019-02-05 19:42 ` Takashi Iwai
2019-02-05 19:42 ` [PATCH 06/20] ALSA: sparc: " Takashi Iwai
` (15 subsequent siblings)
20 siblings, 0 replies; 26+ messages in thread
From: Takashi Iwai @ 2019-02-05 19:42 UTC (permalink / raw)
To: alsa-devel; +Cc: Mark Brown
snd_pcm_lib_preallocate_pages() and co always succeed, so the error
check is simply redundant. Drop it.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
sound/sh/aica.c | 14 ++++++--------
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/sound/sh/aica.c b/sound/sh/aica.c
index 2b26311405a4..e7fef3fce44a 100644
--- a/sound/sh/aica.c
+++ b/sound/sh/aica.c
@@ -464,14 +464,12 @@ static int __init snd_aicapcmchip(struct snd_card_aica
snd_pcm_set_ops(pcm, SNDRV_PCM_STREAM_PLAYBACK,
&snd_aicapcm_playback_ops);
/* Allocate the DMA buffers */
- err =
- snd_pcm_lib_preallocate_pages_for_all(pcm,
- SNDRV_DMA_TYPE_CONTINUOUS,
- snd_dma_continuous_data
- (GFP_KERNEL),
- AICA_BUFFER_SIZE,
- AICA_BUFFER_SIZE);
- return err;
+ snd_pcm_lib_preallocate_pages_for_all(pcm,
+ SNDRV_DMA_TYPE_CONTINUOUS,
+ snd_dma_continuous_data(GFP_KERNEL),
+ AICA_BUFFER_SIZE,
+ AICA_BUFFER_SIZE);
+ return 0;
}
/* Mixer controls */
--
2.16.4
^ permalink raw reply related [flat|nested] 26+ messages in thread* [PATCH 06/20] ALSA: sparc: Drop superfluous PCM preallocation error checks
2019-02-05 19:42 [PATCH 00/20] ALSA: Drop superfluous PCM preallocation error checks Takashi Iwai
` (4 preceding siblings ...)
2019-02-05 19:42 ` [PATCH 05/20] ALSA: sh: " Takashi Iwai
@ 2019-02-05 19:42 ` Takashi Iwai
2019-02-05 19:42 ` [PATCH 07/20] ALSA: spi: " Takashi Iwai
` (14 subsequent siblings)
20 siblings, 0 replies; 26+ messages in thread
From: Takashi Iwai @ 2019-02-05 19:42 UTC (permalink / raw)
To: alsa-devel; +Cc: Mark Brown
snd_pcm_lib_preallocate_pages() and co always succeed, so the error
check is simply redundant. Drop it.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
sound/sparc/dbri.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/sound/sparc/dbri.c b/sound/sparc/dbri.c
index 7609eceba1a2..fc34c863b93c 100644
--- a/sound/sparc/dbri.c
+++ b/sound/sparc/dbri.c
@@ -2243,12 +2243,9 @@ static int snd_dbri_pcm(struct snd_card *card)
pcm->info_flags = 0;
strcpy(pcm->name, card->shortname);
- if ((err = snd_pcm_lib_preallocate_pages_for_all(pcm,
- SNDRV_DMA_TYPE_CONTINUOUS,
- snd_dma_continuous_data(GFP_KERNEL),
- 64 * 1024, 64 * 1024)) < 0)
- return err;
-
+ snd_pcm_lib_preallocate_pages_for_all(pcm, SNDRV_DMA_TYPE_CONTINUOUS,
+ snd_dma_continuous_data(GFP_KERNEL),
+ 64 * 1024, 64 * 1024);
return 0;
}
--
2.16.4
^ permalink raw reply related [flat|nested] 26+ messages in thread* [PATCH 07/20] ALSA: spi: Drop superfluous PCM preallocation error checks
2019-02-05 19:42 [PATCH 00/20] ALSA: Drop superfluous PCM preallocation error checks Takashi Iwai
` (5 preceding siblings ...)
2019-02-05 19:42 ` [PATCH 06/20] ALSA: sparc: " Takashi Iwai
@ 2019-02-05 19:42 ` Takashi Iwai
2019-02-05 19:42 ` [PATCH 08/20] ALSA: usb: " Takashi Iwai
` (13 subsequent siblings)
20 siblings, 0 replies; 26+ messages in thread
From: Takashi Iwai @ 2019-02-05 19:42 UTC (permalink / raw)
To: alsa-devel; +Cc: Mark Brown
snd_pcm_lib_preallocate_pages() and co always succeed, so the error
check is simply redundant. Drop it.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
sound/spi/at73c213.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/spi/at73c213.c b/sound/spi/at73c213.c
index 1ef52edeb538..8707e0108471 100644
--- a/sound/spi/at73c213.c
+++ b/sound/spi/at73c213.c
@@ -350,7 +350,7 @@ static int snd_at73c213_pcm_new(struct snd_at73c213 *chip, int device)
snd_pcm_set_ops(pcm, SNDRV_PCM_STREAM_PLAYBACK, &at73c213_playback_ops);
- retval = snd_pcm_lib_preallocate_pages_for_all(chip->pcm,
+ snd_pcm_lib_preallocate_pages_for_all(chip->pcm,
SNDRV_DMA_TYPE_DEV, &chip->ssc->pdev->dev,
64 * 1024, 64 * 1024);
out:
--
2.16.4
^ permalink raw reply related [flat|nested] 26+ messages in thread* [PATCH 08/20] ALSA: usb: Drop superfluous PCM preallocation error checks
2019-02-05 19:42 [PATCH 00/20] ALSA: Drop superfluous PCM preallocation error checks Takashi Iwai
` (6 preceding siblings ...)
2019-02-05 19:42 ` [PATCH 07/20] ALSA: spi: " Takashi Iwai
@ 2019-02-05 19:42 ` Takashi Iwai
2019-02-05 19:42 ` [PATCH 09/20] ASoC: amd: " Takashi Iwai
` (12 subsequent siblings)
20 siblings, 0 replies; 26+ messages in thread
From: Takashi Iwai @ 2019-02-05 19:42 UTC (permalink / raw)
To: alsa-devel; +Cc: Mark Brown
snd_pcm_lib_preallocate_pages() and co always succeed, so the error
check is simply redundant. Drop it.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
sound/usb/usx2y/usbusx2yaudio.c | 21 ++++++++++-----------
sound/usb/usx2y/usx2yhwdeppcm.c | 19 ++++++++-----------
2 files changed, 18 insertions(+), 22 deletions(-)
diff --git a/sound/usb/usx2y/usbusx2yaudio.c b/sound/usb/usx2y/usbusx2yaudio.c
index 2b833054e3b0..58974d094b27 100644
--- a/sound/usb/usx2y/usbusx2yaudio.c
+++ b/sound/usb/usx2y/usbusx2yaudio.c
@@ -981,18 +981,17 @@ static int usX2Y_audio_stream_new(struct snd_card *card, int playback_endpoint,
sprintf(pcm->name, NAME_ALLCAPS" Audio #%d", usX2Y(card)->pcm_devs);
- if ((playback_endpoint &&
- 0 > (err = snd_pcm_lib_preallocate_pages(pcm->streams[SNDRV_PCM_STREAM_PLAYBACK].substream,
- SNDRV_DMA_TYPE_CONTINUOUS,
- snd_dma_continuous_data(GFP_KERNEL),
- 64*1024, 128*1024))) ||
- 0 > (err = snd_pcm_lib_preallocate_pages(pcm->streams[SNDRV_PCM_STREAM_CAPTURE].substream,
- SNDRV_DMA_TYPE_CONTINUOUS,
- snd_dma_continuous_data(GFP_KERNEL),
- 64*1024, 128*1024))) {
- snd_usX2Y_pcm_private_free(pcm);
- return err;
+ if (playback_endpoint) {
+ snd_pcm_lib_preallocate_pages(pcm->streams[SNDRV_PCM_STREAM_PLAYBACK].substream,
+ SNDRV_DMA_TYPE_CONTINUOUS,
+ snd_dma_continuous_data(GFP_KERNEL),
+ 64*1024, 128*1024);
}
+
+ snd_pcm_lib_preallocate_pages(pcm->streams[SNDRV_PCM_STREAM_CAPTURE].substream,
+ SNDRV_DMA_TYPE_CONTINUOUS,
+ snd_dma_continuous_data(GFP_KERNEL),
+ 64*1024, 128*1024);
usX2Y(card)->pcm_devs++;
return 0;
diff --git a/sound/usb/usx2y/usx2yhwdeppcm.c b/sound/usb/usx2y/usx2yhwdeppcm.c
index 4fd9276b8e50..714cf50d4a4c 100644
--- a/sound/usb/usx2y/usx2yhwdeppcm.c
+++ b/sound/usb/usx2y/usx2yhwdeppcm.c
@@ -736,17 +736,14 @@ int usX2Y_hwdep_pcm_new(struct snd_card *card)
pcm->info_flags = 0;
sprintf(pcm->name, NAME_ALLCAPS" hwdep Audio");
- if (0 > (err = snd_pcm_lib_preallocate_pages(pcm->streams[SNDRV_PCM_STREAM_PLAYBACK].substream,
- SNDRV_DMA_TYPE_CONTINUOUS,
- snd_dma_continuous_data(GFP_KERNEL),
- 64*1024, 128*1024)) ||
- 0 > (err = snd_pcm_lib_preallocate_pages(pcm->streams[SNDRV_PCM_STREAM_CAPTURE].substream,
- SNDRV_DMA_TYPE_CONTINUOUS,
- snd_dma_continuous_data(GFP_KERNEL),
- 64*1024, 128*1024))) {
- return err;
- }
-
+ snd_pcm_lib_preallocate_pages(pcm->streams[SNDRV_PCM_STREAM_PLAYBACK].substream,
+ SNDRV_DMA_TYPE_CONTINUOUS,
+ snd_dma_continuous_data(GFP_KERNEL),
+ 64*1024, 128*1024);
+ snd_pcm_lib_preallocate_pages(pcm->streams[SNDRV_PCM_STREAM_CAPTURE].substream,
+ SNDRV_DMA_TYPE_CONTINUOUS,
+ snd_dma_continuous_data(GFP_KERNEL),
+ 64*1024, 128*1024);
return 0;
}
--
2.16.4
^ permalink raw reply related [flat|nested] 26+ messages in thread* [PATCH 09/20] ASoC: amd: Drop superfluous PCM preallocation error checks
2019-02-05 19:42 [PATCH 00/20] ALSA: Drop superfluous PCM preallocation error checks Takashi Iwai
` (7 preceding siblings ...)
2019-02-05 19:42 ` [PATCH 08/20] ALSA: usb: " Takashi Iwai
@ 2019-02-05 19:42 ` Takashi Iwai
2019-02-05 19:42 ` [PATCH 10/20] ASoC: dwc: " Takashi Iwai
` (11 subsequent siblings)
20 siblings, 0 replies; 26+ messages in thread
From: Takashi Iwai @ 2019-02-05 19:42 UTC (permalink / raw)
To: alsa-devel; +Cc: Mark Brown
snd_pcm_lib_preallocate_pages() and co always succeed, so the error
check is simply redundant. Drop it.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
sound/soc/amd/acp-pcm-dma.c | 26 +++++++++++---------------
sound/soc/amd/raven/acp3x-pcm-dma.c | 9 ++++-----
2 files changed, 15 insertions(+), 20 deletions(-)
diff --git a/sound/soc/amd/acp-pcm-dma.c b/sound/soc/amd/acp-pcm-dma.c
index f4011bebc7ec..2391c7f1dd2d 100644
--- a/sound/soc/amd/acp-pcm-dma.c
+++ b/sound/soc/amd/acp-pcm-dma.c
@@ -1142,7 +1142,6 @@ static int acp_dma_trigger(struct snd_pcm_substream *substream, int cmd)
static int acp_dma_new(struct snd_soc_pcm_runtime *rtd)
{
- int ret;
struct snd_soc_component *component = snd_soc_rtdcom_lookup(rtd,
DRV_NAME);
struct audio_drv_data *adata = dev_get_drvdata(component->dev);
@@ -1150,24 +1149,21 @@ static int acp_dma_new(struct snd_soc_pcm_runtime *rtd)
switch (adata->asic_type) {
case CHIP_STONEY:
- ret = snd_pcm_lib_preallocate_pages_for_all(rtd->pcm,
- SNDRV_DMA_TYPE_DEV,
- parent,
- ST_MIN_BUFFER,
- ST_MAX_BUFFER);
+ snd_pcm_lib_preallocate_pages_for_all(rtd->pcm,
+ SNDRV_DMA_TYPE_DEV,
+ parent,
+ ST_MIN_BUFFER,
+ ST_MAX_BUFFER);
break;
default:
- ret = snd_pcm_lib_preallocate_pages_for_all(rtd->pcm,
- SNDRV_DMA_TYPE_DEV,
- parent,
- MIN_BUFFER,
- MAX_BUFFER);
+ snd_pcm_lib_preallocate_pages_for_all(rtd->pcm,
+ SNDRV_DMA_TYPE_DEV,
+ parent,
+ MIN_BUFFER,
+ MAX_BUFFER);
break;
}
- if (ret < 0)
- dev_err(component->dev,
- "buffer preallocation failure error:%d\n", ret);
- return ret;
+ return 0;
}
static int acp_dma_close(struct snd_pcm_substream *substream)
diff --git a/sound/soc/amd/raven/acp3x-pcm-dma.c b/sound/soc/amd/raven/acp3x-pcm-dma.c
index 3e7d4099364c..1a2e15ff1456 100644
--- a/sound/soc/amd/raven/acp3x-pcm-dma.c
+++ b/sound/soc/amd/raven/acp3x-pcm-dma.c
@@ -367,11 +367,10 @@ static snd_pcm_uframes_t acp3x_dma_pointer(struct snd_pcm_substream *substream)
static int acp3x_dma_new(struct snd_soc_pcm_runtime *rtd)
{
- return snd_pcm_lib_preallocate_pages_for_all(rtd->pcm,
- SNDRV_DMA_TYPE_DEV,
- rtd->pcm->card->dev,
- MIN_BUFFER,
- MAX_BUFFER);
+ snd_pcm_lib_preallocate_pages_for_all(rtd->pcm, SNDRV_DMA_TYPE_DEV,
+ rtd->pcm->card->dev,
+ MIN_BUFFER, MAX_BUFFER);
+ return 0;
}
static int acp3x_dma_hw_free(struct snd_pcm_substream *substream)
--
2.16.4
^ permalink raw reply related [flat|nested] 26+ messages in thread* [PATCH 10/20] ASoC: dwc: Drop superfluous PCM preallocation error checks
2019-02-05 19:42 [PATCH 00/20] ALSA: Drop superfluous PCM preallocation error checks Takashi Iwai
` (8 preceding siblings ...)
2019-02-05 19:42 ` [PATCH 09/20] ASoC: amd: " Takashi Iwai
@ 2019-02-05 19:42 ` Takashi Iwai
2019-02-05 19:42 ` [PATCH 11/20] ASoC: intel: " Takashi Iwai
` (10 subsequent siblings)
20 siblings, 0 replies; 26+ messages in thread
From: Takashi Iwai @ 2019-02-05 19:42 UTC (permalink / raw)
To: alsa-devel; +Cc: Mark Brown
snd_pcm_lib_preallocate_pages() and co always succeed, so the error
check is simply redundant. Drop it.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
sound/soc/dwc/dwc-pcm.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/sound/soc/dwc/dwc-pcm.c b/sound/soc/dwc/dwc-pcm.c
index 2cc9632024fc..a9ae91c4597f 100644
--- a/sound/soc/dwc/dwc-pcm.c
+++ b/sound/soc/dwc/dwc-pcm.c
@@ -249,9 +249,10 @@ static int dw_pcm_new(struct snd_soc_pcm_runtime *rtd)
{
size_t size = dw_pcm_hardware.buffer_bytes_max;
- return snd_pcm_lib_preallocate_pages_for_all(rtd->pcm,
+ snd_pcm_lib_preallocate_pages_for_all(rtd->pcm,
SNDRV_DMA_TYPE_CONTINUOUS,
snd_dma_continuous_data(GFP_KERNEL), size, size);
+ return 0;
}
static void dw_pcm_free(struct snd_pcm *pcm)
--
2.16.4
^ permalink raw reply related [flat|nested] 26+ messages in thread* [PATCH 11/20] ASoC: intel: Drop superfluous PCM preallocation error checks
2019-02-05 19:42 [PATCH 00/20] ALSA: Drop superfluous PCM preallocation error checks Takashi Iwai
` (9 preceding siblings ...)
2019-02-05 19:42 ` [PATCH 10/20] ASoC: dwc: " Takashi Iwai
@ 2019-02-05 19:42 ` Takashi Iwai
2019-02-05 19:42 ` [PATCH 12/20] ASoC: mediatek: " Takashi Iwai
` (9 subsequent siblings)
20 siblings, 0 replies; 26+ messages in thread
From: Takashi Iwai @ 2019-02-05 19:42 UTC (permalink / raw)
To: alsa-devel; +Cc: Mark Brown
snd_pcm_lib_preallocate_pages() and co always succeed, so the error
check is simply redundant. Drop it.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
sound/soc/intel/atom/sst-mfld-platform-pcm.c | 9 ++-------
sound/soc/intel/baytrail/sst-baytrail-pcm.c | 15 ++++-----------
sound/soc/intel/haswell/sst-haswell-pcm.c | 10 ++--------
sound/soc/intel/skylake/skl-pcm.c | 9 ++-------
4 files changed, 10 insertions(+), 33 deletions(-)
diff --git a/sound/soc/intel/atom/sst-mfld-platform-pcm.c b/sound/soc/intel/atom/sst-mfld-platform-pcm.c
index 91a2436ce952..985abda3bfbb 100644
--- a/sound/soc/intel/atom/sst-mfld-platform-pcm.c
+++ b/sound/soc/intel/atom/sst-mfld-platform-pcm.c
@@ -687,20 +687,15 @@ static int sst_pcm_new(struct snd_soc_pcm_runtime *rtd)
{
struct snd_soc_dai *dai = rtd->cpu_dai;
struct snd_pcm *pcm = rtd->pcm;
- int retval = 0;
if (dai->driver->playback.channels_min ||
dai->driver->capture.channels_min) {
- retval = snd_pcm_lib_preallocate_pages_for_all(pcm,
+ snd_pcm_lib_preallocate_pages_for_all(pcm,
SNDRV_DMA_TYPE_CONTINUOUS,
snd_dma_continuous_data(GFP_DMA),
SST_MIN_BUFFER, SST_MAX_BUFFER);
- if (retval) {
- dev_err(rtd->dev, "dma buffer allocation failure\n");
- return retval;
- }
}
- return retval;
+ return 0;
}
static int sst_soc_probe(struct snd_soc_component *component)
diff --git a/sound/soc/intel/baytrail/sst-baytrail-pcm.c b/sound/soc/intel/baytrail/sst-baytrail-pcm.c
index aabb35bf6b96..aa358073ac0f 100644
--- a/sound/soc/intel/baytrail/sst-baytrail-pcm.c
+++ b/sound/soc/intel/baytrail/sst-baytrail-pcm.c
@@ -327,23 +327,16 @@ static int sst_byt_pcm_new(struct snd_soc_pcm_runtime *rtd)
size_t size;
struct snd_soc_component *component = snd_soc_rtdcom_lookup(rtd, DRV_NAME);
struct sst_pdata *pdata = dev_get_platdata(component->dev);
- int ret = 0;
if (pcm->streams[SNDRV_PCM_STREAM_PLAYBACK].substream ||
pcm->streams[SNDRV_PCM_STREAM_CAPTURE].substream) {
size = sst_byt_pcm_hardware.buffer_bytes_max;
- ret = snd_pcm_lib_preallocate_pages_for_all(pcm,
- SNDRV_DMA_TYPE_DEV,
- pdata->dma_dev,
- size, size);
- if (ret) {
- dev_err(rtd->dev, "dma buffer allocation failed %d\n",
- ret);
- return ret;
- }
+ snd_pcm_lib_preallocate_pages_for_all(pcm, SNDRV_DMA_TYPE_DEV,
+ pdata->dma_dev,
+ size, size);
}
- return ret;
+ return 0;
}
static struct snd_soc_dai_driver byt_dais[] = {
diff --git a/sound/soc/intel/haswell/sst-haswell-pcm.c b/sound/soc/intel/haswell/sst-haswell-pcm.c
index fe2c826e710c..f21a7f2c11c2 100644
--- a/sound/soc/intel/haswell/sst-haswell-pcm.c
+++ b/sound/soc/intel/haswell/sst-haswell-pcm.c
@@ -946,27 +946,21 @@ static int hsw_pcm_new(struct snd_soc_pcm_runtime *rtd)
struct sst_pdata *pdata = dev_get_platdata(component->dev);
struct hsw_priv_data *priv_data = dev_get_drvdata(component->dev);
struct device *dev = pdata->dma_dev;
- int ret = 0;
if (pcm->streams[SNDRV_PCM_STREAM_PLAYBACK].substream ||
pcm->streams[SNDRV_PCM_STREAM_CAPTURE].substream) {
- ret = snd_pcm_lib_preallocate_pages_for_all(pcm,
+ snd_pcm_lib_preallocate_pages_for_all(pcm,
SNDRV_DMA_TYPE_DEV_SG,
dev,
hsw_pcm_hardware.buffer_bytes_max,
hsw_pcm_hardware.buffer_bytes_max);
- if (ret) {
- dev_err(rtd->dev, "dma buffer allocation failed %d\n",
- ret);
- return ret;
- }
}
if (pcm->streams[SNDRV_PCM_STREAM_PLAYBACK].substream)
priv_data->pcm[rtd->cpu_dai->id][SNDRV_PCM_STREAM_PLAYBACK].hsw_pcm = pcm;
if (pcm->streams[SNDRV_PCM_STREAM_CAPTURE].substream)
priv_data->pcm[rtd->cpu_dai->id][SNDRV_PCM_STREAM_CAPTURE].hsw_pcm = pcm;
- return ret;
+ return 0;
}
#define HSW_FORMATS \
diff --git a/sound/soc/intel/skylake/skl-pcm.c b/sound/soc/intel/skylake/skl-pcm.c
index 557f80c0bfe5..20c88c677473 100644
--- a/sound/soc/intel/skylake/skl-pcm.c
+++ b/sound/soc/intel/skylake/skl-pcm.c
@@ -1289,7 +1289,6 @@ static int skl_pcm_new(struct snd_soc_pcm_runtime *rtd)
struct hdac_bus *bus = dev_get_drvdata(dai->dev);
struct snd_pcm *pcm = rtd->pcm;
unsigned int size;
- int retval = 0;
struct skl *skl = bus_to_skl(bus);
if (dai->driver->playback.channels_min ||
@@ -1298,17 +1297,13 @@ static int skl_pcm_new(struct snd_soc_pcm_runtime *rtd)
size = CONFIG_SND_HDA_PREALLOC_SIZE * 1024;
if (size > MAX_PREALLOC_SIZE)
size = MAX_PREALLOC_SIZE;
- retval = snd_pcm_lib_preallocate_pages_for_all(pcm,
+ snd_pcm_lib_preallocate_pages_for_all(pcm,
SNDRV_DMA_TYPE_DEV_SG,
snd_dma_pci_data(skl->pci),
size, MAX_PREALLOC_SIZE);
- if (retval) {
- dev_err(dai->dev, "dma buffer allocation fail\n");
- return retval;
- }
}
- return retval;
+ return 0;
}
static int skl_get_module_info(struct skl *skl, struct skl_module_cfg *mconfig)
--
2.16.4
^ permalink raw reply related [flat|nested] 26+ messages in thread* [PATCH 12/20] ASoC: mediatek: Drop superfluous PCM preallocation error checks
2019-02-05 19:42 [PATCH 00/20] ALSA: Drop superfluous PCM preallocation error checks Takashi Iwai
` (10 preceding siblings ...)
2019-02-05 19:42 ` [PATCH 11/20] ASoC: intel: " Takashi Iwai
@ 2019-02-05 19:42 ` Takashi Iwai
2019-02-05 19:42 ` [PATCH 13/20] ASoC: meson: " Takashi Iwai
` (8 subsequent siblings)
20 siblings, 0 replies; 26+ messages in thread
From: Takashi Iwai @ 2019-02-05 19:42 UTC (permalink / raw)
To: alsa-devel; +Cc: Mark Brown
snd_pcm_lib_preallocate_pages() and co always succeed, so the error
check is simply redundant. Drop it.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
sound/soc/mediatek/common/mtk-afe-platform-driver.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/sound/soc/mediatek/common/mtk-afe-platform-driver.c b/sound/soc/mediatek/common/mtk-afe-platform-driver.c
index 697aa50aff9a..3ce527ce30ce 100644
--- a/sound/soc/mediatek/common/mtk-afe-platform-driver.c
+++ b/sound/soc/mediatek/common/mtk-afe-platform-driver.c
@@ -126,9 +126,9 @@ int mtk_afe_pcm_new(struct snd_soc_pcm_runtime *rtd)
struct mtk_base_afe *afe = snd_soc_component_get_drvdata(component);
size = afe->mtk_afe_hardware->buffer_bytes_max;
- return snd_pcm_lib_preallocate_pages_for_all(pcm, SNDRV_DMA_TYPE_DEV,
- afe->dev,
- size, size);
+ snd_pcm_lib_preallocate_pages_for_all(pcm, SNDRV_DMA_TYPE_DEV,
+ afe->dev, size, size);
+ return 0;
}
EXPORT_SYMBOL_GPL(mtk_afe_pcm_new);
--
2.16.4
^ permalink raw reply related [flat|nested] 26+ messages in thread* [PATCH 13/20] ASoC: meson: Drop superfluous PCM preallocation error checks
2019-02-05 19:42 [PATCH 00/20] ALSA: Drop superfluous PCM preallocation error checks Takashi Iwai
` (11 preceding siblings ...)
2019-02-05 19:42 ` [PATCH 12/20] ASoC: mediatek: " Takashi Iwai
@ 2019-02-05 19:42 ` Takashi Iwai
2019-02-05 19:42 ` [PATCH 14/20] ASoC: sh: " Takashi Iwai
` (7 subsequent siblings)
20 siblings, 0 replies; 26+ messages in thread
From: Takashi Iwai @ 2019-02-05 19:42 UTC (permalink / raw)
To: alsa-devel; +Cc: Mark Brown
snd_pcm_lib_preallocate_pages() and co always succeed, so the error
check is simply redundant. Drop it.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
sound/soc/meson/axg-fifo.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/sound/soc/meson/axg-fifo.c b/sound/soc/meson/axg-fifo.c
index 0e4f65e654c4..75e5e480fda2 100644
--- a/sound/soc/meson/axg-fifo.c
+++ b/sound/soc/meson/axg-fifo.c
@@ -267,9 +267,10 @@ int axg_fifo_pcm_new(struct snd_soc_pcm_runtime *rtd, unsigned int type)
struct snd_card *card = rtd->card->snd_card;
size_t size = axg_fifo_hw.buffer_bytes_max;
- return snd_pcm_lib_preallocate_pages(rtd->pcm->streams[type].substream,
- SNDRV_DMA_TYPE_DEV, card->dev,
- size, size);
+ snd_pcm_lib_preallocate_pages(rtd->pcm->streams[type].substream,
+ SNDRV_DMA_TYPE_DEV, card->dev,
+ size, size);
+ return 0;
}
EXPORT_SYMBOL_GPL(axg_fifo_pcm_new);
--
2.16.4
^ permalink raw reply related [flat|nested] 26+ messages in thread* [PATCH 14/20] ASoC: sh: Drop superfluous PCM preallocation error checks
2019-02-05 19:42 [PATCH 00/20] ALSA: Drop superfluous PCM preallocation error checks Takashi Iwai
` (12 preceding siblings ...)
2019-02-05 19:42 ` [PATCH 13/20] ASoC: meson: " Takashi Iwai
@ 2019-02-05 19:42 ` Takashi Iwai
2019-02-06 5:51 ` Kuninori Morimoto
2019-02-05 19:42 ` [PATCH 15/20] ASoC: stm: " Takashi Iwai
` (6 subsequent siblings)
20 siblings, 1 reply; 26+ messages in thread
From: Takashi Iwai @ 2019-02-05 19:42 UTC (permalink / raw)
To: alsa-devel; +Cc: Mark Brown
snd_pcm_lib_preallocate_pages() and co always succeed, so the error
check is simply redundant. Drop it.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
sound/soc/sh/fsi.c | 3 ++-
sound/soc/sh/rcar/core.c | 5 +----
sound/soc/sh/siu_pcm.c | 13 +------------
3 files changed, 4 insertions(+), 17 deletions(-)
diff --git a/sound/soc/sh/fsi.c b/sound/soc/sh/fsi.c
index aa7e902f0c02..285afbafa662 100644
--- a/sound/soc/sh/fsi.c
+++ b/sound/soc/sh/fsi.c
@@ -1768,11 +1768,12 @@ static const struct snd_pcm_ops fsi_pcm_ops = {
static int fsi_pcm_new(struct snd_soc_pcm_runtime *rtd)
{
- return snd_pcm_lib_preallocate_pages_for_all(
+ snd_pcm_lib_preallocate_pages_for_all(
rtd->pcm,
SNDRV_DMA_TYPE_DEV,
rtd->card->snd_card->dev,
PREALLOC_BUFFER, PREALLOC_BUFFER_MAX);
+ return 0;
}
/*
diff --git a/sound/soc/sh/rcar/core.c b/sound/soc/sh/rcar/core.c
index 59e250cc2e9d..29213b90755f 100644
--- a/sound/soc/sh/rcar/core.c
+++ b/sound/soc/sh/rcar/core.c
@@ -1575,7 +1575,6 @@ static int rsnd_preallocate_pages(struct snd_soc_pcm_runtime *rtd,
struct rsnd_priv *priv = rsnd_io_to_priv(io);
struct device *dev = rsnd_priv_to_dev(priv);
struct snd_pcm_substream *substream;
- int err;
/*
* use Audio-DMAC dev if we can use IPMMU
@@ -1588,12 +1587,10 @@ static int rsnd_preallocate_pages(struct snd_soc_pcm_runtime *rtd,
for (substream = rtd->pcm->streams[stream].substream;
substream;
substream = substream->next) {
- err = snd_pcm_lib_preallocate_pages(substream,
+ snd_pcm_lib_preallocate_pages(substream,
SNDRV_DMA_TYPE_DEV,
dev,
PREALLOC_BUFFER, PREALLOC_BUFFER_MAX);
- if (err < 0)
- return err;
}
return 0;
diff --git a/sound/soc/sh/siu_pcm.c b/sound/soc/sh/siu_pcm.c
index 23384c477740..78c3145b4109 100644
--- a/sound/soc/sh/siu_pcm.c
+++ b/sound/soc/sh/siu_pcm.c
@@ -541,15 +541,9 @@ static int siu_pcm_new(struct snd_soc_pcm_runtime *rtd)
if (ret < 0)
return ret;
- ret = snd_pcm_lib_preallocate_pages_for_all(pcm,
+ snd_pcm_lib_preallocate_pages_for_all(pcm,
SNDRV_DMA_TYPE_DEV, card->dev,
SIU_BUFFER_BYTES_MAX, SIU_BUFFER_BYTES_MAX);
- if (ret < 0) {
- dev_err(card->dev,
- "snd_pcm_lib_preallocate_pages_for_all() err=%d",
- ret);
- goto fail;
- }
(*port_info)->pcm = pcm;
@@ -562,11 +556,6 @@ static int siu_pcm_new(struct snd_soc_pcm_runtime *rtd)
dev_info(card->dev, "SuperH SIU driver initialized.\n");
return 0;
-
-fail:
- siu_free_port(siu_ports[pdev->id]);
- dev_err(card->dev, "SIU: failed to initialize.\n");
- return ret;
}
static void siu_pcm_free(struct snd_pcm *pcm)
--
2.16.4
^ permalink raw reply related [flat|nested] 26+ messages in thread* Re: [PATCH 14/20] ASoC: sh: Drop superfluous PCM preallocation error checks
2019-02-05 19:42 ` [PATCH 14/20] ASoC: sh: " Takashi Iwai
@ 2019-02-06 5:51 ` Kuninori Morimoto
0 siblings, 0 replies; 26+ messages in thread
From: Kuninori Morimoto @ 2019-02-06 5:51 UTC (permalink / raw)
To: Takashi Iwai; +Cc: alsa-devel, Mark Brown
Hi
> snd_pcm_lib_preallocate_pages() and co always succeed, so the error
> check is simply redundant. Drop it.
>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> ---
> sound/soc/sh/fsi.c | 3 ++-
> sound/soc/sh/rcar/core.c | 5 +----
> sound/soc/sh/siu_pcm.c | 13 +------------
> 3 files changed, 4 insertions(+), 17 deletions(-)
Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Best regards
---
Kuninori Morimoto
^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH 15/20] ASoC: stm: Drop superfluous PCM preallocation error checks
2019-02-05 19:42 [PATCH 00/20] ALSA: Drop superfluous PCM preallocation error checks Takashi Iwai
` (13 preceding siblings ...)
2019-02-05 19:42 ` [PATCH 14/20] ASoC: sh: " Takashi Iwai
@ 2019-02-05 19:42 ` Takashi Iwai
2019-02-05 19:42 ` [PATCH 16/20] ASoC: txx9: " Takashi Iwai
` (5 subsequent siblings)
20 siblings, 0 replies; 26+ messages in thread
From: Takashi Iwai @ 2019-02-05 19:42 UTC (permalink / raw)
To: alsa-devel; +Cc: Mark Brown
snd_pcm_lib_preallocate_pages() and co always succeed, so the error
check is simply redundant. Drop it.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
sound/soc/stm/stm32_adfsdm.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/sound/soc/stm/stm32_adfsdm.c b/sound/soc/stm/stm32_adfsdm.c
index 706ff005234f..47901983a6ff 100644
--- a/sound/soc/stm/stm32_adfsdm.c
+++ b/sound/soc/stm/stm32_adfsdm.c
@@ -262,8 +262,9 @@ static int stm32_adfsdm_pcm_new(struct snd_soc_pcm_runtime *rtd)
snd_soc_dai_get_drvdata(rtd->cpu_dai);
unsigned int size = DFSDM_MAX_PERIODS * DFSDM_MAX_PERIOD_SIZE;
- return snd_pcm_lib_preallocate_pages_for_all(pcm, SNDRV_DMA_TYPE_DEV,
- priv->dev, size, size);
+ snd_pcm_lib_preallocate_pages_for_all(pcm, SNDRV_DMA_TYPE_DEV,
+ priv->dev, size, size);
+ return 0;
}
static void stm32_adfsdm_pcm_free(struct snd_pcm *pcm)
--
2.16.4
^ permalink raw reply related [flat|nested] 26+ messages in thread* [PATCH 16/20] ASoC: txx9: Drop superfluous PCM preallocation error checks
2019-02-05 19:42 [PATCH 00/20] ALSA: Drop superfluous PCM preallocation error checks Takashi Iwai
` (14 preceding siblings ...)
2019-02-05 19:42 ` [PATCH 15/20] ASoC: stm: " Takashi Iwai
@ 2019-02-05 19:42 ` Takashi Iwai
2019-02-05 19:42 ` [PATCH 17/20] ASoC: uniphier: " Takashi Iwai
` (4 subsequent siblings)
20 siblings, 0 replies; 26+ messages in thread
From: Takashi Iwai @ 2019-02-05 19:42 UTC (permalink / raw)
To: alsa-devel; +Cc: Mark Brown
snd_pcm_lib_preallocate_pages() and co always succeed, so the error
check is simply redundant. Drop it.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
sound/soc/txx9/txx9aclc.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/sound/soc/txx9/txx9aclc.c b/sound/soc/txx9/txx9aclc.c
index 8d31fe628e2f..089bd7518606 100644
--- a/sound/soc/txx9/txx9aclc.c
+++ b/sound/soc/txx9/txx9aclc.c
@@ -313,8 +313,10 @@ static int txx9aclc_pcm_new(struct snd_soc_pcm_runtime *rtd)
if (ret)
goto exit;
}
- return snd_pcm_lib_preallocate_pages_for_all(pcm, SNDRV_DMA_TYPE_DEV,
+
+ snd_pcm_lib_preallocate_pages_for_all(pcm, SNDRV_DMA_TYPE_DEV,
card->dev, 64 * 1024, 4 * 1024 * 1024);
+ return 0;
exit:
for (i = 0; i < 2; i++) {
--
2.16.4
^ permalink raw reply related [flat|nested] 26+ messages in thread* [PATCH 17/20] ASoC: uniphier: Drop superfluous PCM preallocation error checks
2019-02-05 19:42 [PATCH 00/20] ALSA: Drop superfluous PCM preallocation error checks Takashi Iwai
` (15 preceding siblings ...)
2019-02-05 19:42 ` [PATCH 16/20] ASoC: txx9: " Takashi Iwai
@ 2019-02-05 19:42 ` Takashi Iwai
2019-02-05 19:42 ` [PATCH 18/20] ASoC: xtensa: " Takashi Iwai
` (3 subsequent siblings)
20 siblings, 0 replies; 26+ messages in thread
From: Takashi Iwai @ 2019-02-05 19:42 UTC (permalink / raw)
To: alsa-devel; +Cc: Mark Brown
snd_pcm_lib_preallocate_pages() and co always succeed, so the error
check is simply redundant. Drop it.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
sound/soc/uniphier/aio-dma.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/sound/soc/uniphier/aio-dma.c b/sound/soc/uniphier/aio-dma.c
index 4ec6b65bfb44..fa001d3c1a88 100644
--- a/sound/soc/uniphier/aio-dma.c
+++ b/sound/soc/uniphier/aio-dma.c
@@ -235,10 +235,11 @@ static int uniphier_aiodma_new(struct snd_soc_pcm_runtime *rtd)
if (ret)
return ret;
- return snd_pcm_lib_preallocate_pages_for_all(pcm,
+ snd_pcm_lib_preallocate_pages_for_all(pcm,
SNDRV_DMA_TYPE_DEV, dev,
uniphier_aiodma_hw.buffer_bytes_max,
uniphier_aiodma_hw.buffer_bytes_max);
+ return 0;
}
static void uniphier_aiodma_free(struct snd_pcm *pcm)
--
2.16.4
^ permalink raw reply related [flat|nested] 26+ messages in thread* [PATCH 18/20] ASoC: xtensa: Drop superfluous PCM preallocation error checks
2019-02-05 19:42 [PATCH 00/20] ALSA: Drop superfluous PCM preallocation error checks Takashi Iwai
` (16 preceding siblings ...)
2019-02-05 19:42 ` [PATCH 17/20] ASoC: uniphier: " Takashi Iwai
@ 2019-02-05 19:42 ` Takashi Iwai
2019-02-05 19:42 ` [PATCH 19/20] ASoC: dmaengine: " Takashi Iwai
` (2 subsequent siblings)
20 siblings, 0 replies; 26+ messages in thread
From: Takashi Iwai @ 2019-02-05 19:42 UTC (permalink / raw)
To: alsa-devel; +Cc: Mark Brown
snd_pcm_lib_preallocate_pages() and co always succeed, so the error
check is simply redundant. Drop it.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
sound/soc/xtensa/xtfpga-i2s.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/sound/soc/xtensa/xtfpga-i2s.c b/sound/soc/xtensa/xtfpga-i2s.c
index 503560916620..2f20a02c8d46 100644
--- a/sound/soc/xtensa/xtfpga-i2s.c
+++ b/sound/soc/xtensa/xtfpga-i2s.c
@@ -469,9 +469,9 @@ static int xtfpga_pcm_new(struct snd_soc_pcm_runtime *rtd)
struct snd_card *card = rtd->card->snd_card;
size_t size = xtfpga_pcm_hardware.buffer_bytes_max;
- return snd_pcm_lib_preallocate_pages_for_all(rtd->pcm,
- SNDRV_DMA_TYPE_DEV,
- card->dev, size, size);
+ snd_pcm_lib_preallocate_pages_for_all(rtd->pcm, SNDRV_DMA_TYPE_DEV,
+ card->dev, size, size);
+ return 0;
}
static const struct snd_pcm_ops xtfpga_pcm_ops = {
--
2.16.4
^ permalink raw reply related [flat|nested] 26+ messages in thread* [PATCH 19/20] ASoC: dmaengine: Drop superfluous PCM preallocation error checks
2019-02-05 19:42 [PATCH 00/20] ALSA: Drop superfluous PCM preallocation error checks Takashi Iwai
` (17 preceding siblings ...)
2019-02-05 19:42 ` [PATCH 18/20] ASoC: xtensa: " Takashi Iwai
@ 2019-02-05 19:42 ` Takashi Iwai
2019-02-05 19:42 ` [PATCH 20/20] ALSA: pcm: Define snd_pcm_lib_preallocate_*() as returning void Takashi Iwai
2019-02-06 9:07 ` [PATCH 00/20] ALSA: Drop superfluous PCM preallocation error checks Jaroslav Kysela
20 siblings, 0 replies; 26+ messages in thread
From: Takashi Iwai @ 2019-02-05 19:42 UTC (permalink / raw)
To: alsa-devel; +Cc: Mark Brown
snd_pcm_lib_preallocate_pages() and co always succeed, so the error
check is simply redundant. Drop it.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
sound/soc/soc-generic-dmaengine-pcm.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/sound/soc/soc-generic-dmaengine-pcm.c b/sound/soc/soc-generic-dmaengine-pcm.c
index 30e791a53352..46252b13d3b3 100644
--- a/sound/soc/soc-generic-dmaengine-pcm.c
+++ b/sound/soc/soc-generic-dmaengine-pcm.c
@@ -270,7 +270,6 @@ static int dmaengine_pcm_new(struct snd_soc_pcm_runtime *rtd)
size_t prealloc_buffer_size;
size_t max_buffer_size;
unsigned int i;
- int ret;
if (config && config->prealloc_buffer_size) {
prealloc_buffer_size = config->prealloc_buffer_size;
@@ -303,13 +302,11 @@ static int dmaengine_pcm_new(struct snd_soc_pcm_runtime *rtd)
return -EINVAL;
}
- ret = snd_pcm_lib_preallocate_pages(substream,
+ snd_pcm_lib_preallocate_pages(substream,
SNDRV_DMA_TYPE_DEV_IRAM,
dmaengine_dma_dev(pcm, substream),
prealloc_buffer_size,
max_buffer_size);
- if (ret)
- return ret;
if (!dmaengine_pcm_can_report_residue(dev, pcm->chan[i]))
pcm->flags |= SND_DMAENGINE_PCM_FLAG_NO_RESIDUE;
--
2.16.4
^ permalink raw reply related [flat|nested] 26+ messages in thread* [PATCH 20/20] ALSA: pcm: Define snd_pcm_lib_preallocate_*() as returning void
2019-02-05 19:42 [PATCH 00/20] ALSA: Drop superfluous PCM preallocation error checks Takashi Iwai
` (18 preceding siblings ...)
2019-02-05 19:42 ` [PATCH 19/20] ASoC: dmaengine: " Takashi Iwai
@ 2019-02-05 19:42 ` Takashi Iwai
2019-02-06 9:07 ` [PATCH 00/20] ALSA: Drop superfluous PCM preallocation error checks Jaroslav Kysela
20 siblings, 0 replies; 26+ messages in thread
From: Takashi Iwai @ 2019-02-05 19:42 UTC (permalink / raw)
To: alsa-devel; +Cc: Mark Brown
Now all callers no longer check the return value from
snd_pcm_lib_preallocate_pages() and co, let's make them to return
void, so that any new code won't fall into the same pitfall.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
include/sound/pcm.h | 8 ++++----
sound/core/pcm_memory.c | 29 ++++++++---------------------
2 files changed, 12 insertions(+), 25 deletions(-)
diff --git a/include/sound/pcm.h b/include/sound/pcm.h
index ca20f80f8976..465d7d033c4c 100644
--- a/include/sound/pcm.h
+++ b/include/sound/pcm.h
@@ -1185,12 +1185,12 @@ static inline void snd_pcm_gettime(struct snd_pcm_runtime *runtime,
* Memory
*/
-int snd_pcm_lib_preallocate_free(struct snd_pcm_substream *substream);
-int snd_pcm_lib_preallocate_free_for_all(struct snd_pcm *pcm);
-int snd_pcm_lib_preallocate_pages(struct snd_pcm_substream *substream,
+void snd_pcm_lib_preallocate_free(struct snd_pcm_substream *substream);
+void snd_pcm_lib_preallocate_free_for_all(struct snd_pcm *pcm);
+void snd_pcm_lib_preallocate_pages(struct snd_pcm_substream *substream,
int type, struct device *data,
size_t size, size_t max);
-int snd_pcm_lib_preallocate_pages_for_all(struct snd_pcm *pcm,
+void snd_pcm_lib_preallocate_pages_for_all(struct snd_pcm *pcm,
int type, void *data,
size_t size, size_t max);
int snd_pcm_lib_malloc_pages(struct snd_pcm_substream *substream, size_t size);
diff --git a/sound/core/pcm_memory.c b/sound/core/pcm_memory.c
index 9a98bc61461f..049d65cad54a 100644
--- a/sound/core/pcm_memory.c
+++ b/sound/core/pcm_memory.c
@@ -87,13 +87,10 @@ static void snd_pcm_lib_preallocate_dma_free(struct snd_pcm_substream *substream
* @substream: the pcm substream instance
*
* Releases the pre-allocated buffer of the given substream.
- *
- * Return: Zero if successful, or a negative error code on failure.
*/
-int snd_pcm_lib_preallocate_free(struct snd_pcm_substream *substream)
+void snd_pcm_lib_preallocate_free(struct snd_pcm_substream *substream)
{
snd_pcm_lib_preallocate_dma_free(substream);
- return 0;
}
/**
@@ -101,10 +98,8 @@ int snd_pcm_lib_preallocate_free(struct snd_pcm_substream *substream)
* @pcm: the pcm instance
*
* Releases all the pre-allocated buffers on the given pcm.
- *
- * Return: Zero if successful, or a negative error code on failure.
*/
-int snd_pcm_lib_preallocate_free_for_all(struct snd_pcm *pcm)
+void snd_pcm_lib_preallocate_free_for_all(struct snd_pcm *pcm)
{
struct snd_pcm_substream *substream;
int stream;
@@ -112,7 +107,6 @@ int snd_pcm_lib_preallocate_free_for_all(struct snd_pcm *pcm)
for (stream = 0; stream < 2; stream++)
for (substream = pcm->streams[stream].substream; substream; substream = substream->next)
snd_pcm_lib_preallocate_free(substream);
- return 0;
}
EXPORT_SYMBOL(snd_pcm_lib_preallocate_free_for_all);
@@ -215,7 +209,7 @@ static inline void preallocate_info_init(struct snd_pcm_substream *substream)
/*
* pre-allocate the buffer and create a proc file for the substream
*/
-static int snd_pcm_lib_preallocate_pages1(struct snd_pcm_substream *substream,
+static void snd_pcm_lib_preallocate_pages1(struct snd_pcm_substream *substream,
size_t size, size_t max)
{
@@ -226,7 +220,6 @@ static int snd_pcm_lib_preallocate_pages1(struct snd_pcm_substream *substream,
substream->buffer_bytes_max = substream->dma_buffer.bytes;
substream->dma_max = max;
preallocate_info_init(substream);
- return 0;
}
@@ -239,16 +232,14 @@ static int snd_pcm_lib_preallocate_pages1(struct snd_pcm_substream *substream,
* @max: the max. allowed pre-allocation size
*
* Do pre-allocation for the given DMA buffer type.
- *
- * Return: Zero if successful, or a negative error code on failure.
*/
-int snd_pcm_lib_preallocate_pages(struct snd_pcm_substream *substream,
+void snd_pcm_lib_preallocate_pages(struct snd_pcm_substream *substream,
int type, struct device *data,
size_t size, size_t max)
{
substream->dma_buffer.dev.type = type;
substream->dma_buffer.dev.dev = data;
- return snd_pcm_lib_preallocate_pages1(substream, size, max);
+ snd_pcm_lib_preallocate_pages1(substream, size, max);
}
EXPORT_SYMBOL(snd_pcm_lib_preallocate_pages);
@@ -262,21 +253,17 @@ EXPORT_SYMBOL(snd_pcm_lib_preallocate_pages);
*
* Do pre-allocation to all substreams of the given pcm for the
* specified DMA type.
- *
- * Return: Zero if successful, or a negative error code on failure.
*/
-int snd_pcm_lib_preallocate_pages_for_all(struct snd_pcm *pcm,
+void snd_pcm_lib_preallocate_pages_for_all(struct snd_pcm *pcm,
int type, void *data,
size_t size, size_t max)
{
struct snd_pcm_substream *substream;
- int stream, err;
+ int stream;
for (stream = 0; stream < 2; stream++)
for (substream = pcm->streams[stream].substream; substream; substream = substream->next)
- if ((err = snd_pcm_lib_preallocate_pages(substream, type, data, size, max)) < 0)
- return err;
- return 0;
+ snd_pcm_lib_preallocate_pages(substream, type, data, size, max);
}
EXPORT_SYMBOL(snd_pcm_lib_preallocate_pages_for_all);
--
2.16.4
^ permalink raw reply related [flat|nested] 26+ messages in thread* Re: [PATCH 00/20] ALSA: Drop superfluous PCM preallocation error checks
2019-02-05 19:42 [PATCH 00/20] ALSA: Drop superfluous PCM preallocation error checks Takashi Iwai
` (19 preceding siblings ...)
2019-02-05 19:42 ` [PATCH 20/20] ALSA: pcm: Define snd_pcm_lib_preallocate_*() as returning void Takashi Iwai
@ 2019-02-06 9:07 ` Jaroslav Kysela
2019-02-06 9:27 ` Takashi Iwai
2019-02-06 14:50 ` Mark Brown
20 siblings, 2 replies; 26+ messages in thread
From: Jaroslav Kysela @ 2019-02-06 9:07 UTC (permalink / raw)
To: Takashi Iwai, alsa-devel; +Cc: Mark Brown
Dne 5.2.2019 v 20:42 Takashi Iwai napsal(a):
> Hi,
>
> this is yet another patchset for trivial cleanups.
> At this time, it's about the superfluous error check from
> snd_pcm_lib_preallocate_pages() and co. They always succeed and never
> return a failure although many codes do the error check. The patches
> simply remove the error checks and finally change the function to be
> void function.
>
> The patches are applied on top of my previous NULL device fix patches,
> so not applicable to ASoC tree, I guess. As all these are trivial,
> applying through my tree altogether would be simpler.
>
> So, Mark, please give your ACK if the changes to ASoC drivers are OK.
With all respects, do we really need to split those elementary changes
to single patches inside the sound tree? I would really prefer to have
this inside one patch or maybe few patches (core/pci/asoc/others). Just
my two cents.
Reviewed-by: Jaroslav Kysela <perex@perex.cz>
Jaroslav
--
Jaroslav Kysela <perex@perex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.
^ permalink raw reply [flat|nested] 26+ messages in thread* Re: [PATCH 00/20] ALSA: Drop superfluous PCM preallocation error checks
2019-02-06 9:07 ` [PATCH 00/20] ALSA: Drop superfluous PCM preallocation error checks Jaroslav Kysela
@ 2019-02-06 9:27 ` Takashi Iwai
2019-02-06 14:50 ` Mark Brown
1 sibling, 0 replies; 26+ messages in thread
From: Takashi Iwai @ 2019-02-06 9:27 UTC (permalink / raw)
To: Jaroslav Kysela; +Cc: alsa-devel, Mark Brown
On Wed, 06 Feb 2019 10:07:21 +0100,
Jaroslav Kysela wrote:
>
> Dne 5.2.2019 v 20:42 Takashi Iwai napsal(a):
> > Hi,
> >
> > this is yet another patchset for trivial cleanups.
> > At this time, it's about the superfluous error check from
> > snd_pcm_lib_preallocate_pages() and co. They always succeed and never
> > return a failure although many codes do the error check. The patches
> > simply remove the error checks and finally change the function to be
> > void function.
> >
> > The patches are applied on top of my previous NULL device fix patches,
> > so not applicable to ASoC tree, I guess. As all these are trivial,
> > applying through my tree altogether would be simpler.
> >
> > So, Mark, please give your ACK if the changes to ASoC drivers are OK.
>
> With all respects, do we really need to split those elementary changes
> to single patches inside the sound tree? I would really prefer to have
> this inside one patch or maybe few patches (core/pci/asoc/others). Just
> my two cents.
>
> Reviewed-by: Jaroslav Kysela <perex@perex.cz>
There are both good and bad sides by this kind of fine splits.
A good side is that each reviewer can give ack for particular changes,
and it's easier to backport to older kernels. A bad side is that it
results in more commits, and the relation between all relevant changes
isn't clear from each single commit.
I split at this time, especially about ASoC, since ASoC codes are
managed by more people than other parts in the sound tree. But, yeah,
this could be a single patch, too.
thanks,
Takashi
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 00/20] ALSA: Drop superfluous PCM preallocation error checks
2019-02-06 9:07 ` [PATCH 00/20] ALSA: Drop superfluous PCM preallocation error checks Jaroslav Kysela
2019-02-06 9:27 ` Takashi Iwai
@ 2019-02-06 14:50 ` Mark Brown
2019-02-06 15:35 ` Jaroslav Kysela
1 sibling, 1 reply; 26+ messages in thread
From: Mark Brown @ 2019-02-06 14:50 UTC (permalink / raw)
To: Jaroslav Kysela; +Cc: Takashi Iwai, alsa-devel
[-- Attachment #1.1: Type: text/plain, Size: 685 bytes --]
On Wed, Feb 06, 2019 at 10:07:21AM +0100, Jaroslav Kysela wrote:
> Dne 5.2.2019 v 20:42 Takashi Iwai napsal(a):
> > So, Mark, please give your ACK if the changes to ASoC drivers are OK.
Acked-by: Mark Brown <broonie@kernel.org>
> With all respects, do we really need to split those elementary changes
> to single patches inside the sound tree? I would really prefer to have
> this inside one patch or maybe few patches (core/pci/asoc/others). Just
> my two cents.
FWIW it does mean that life is easier for people doing backports when
things are split up as there's less chance that some file that wasn't
added in the kernel version you were interested in was touched by the
patch.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 00/20] ALSA: Drop superfluous PCM preallocation error checks
2019-02-06 14:50 ` Mark Brown
@ 2019-02-06 15:35 ` Jaroslav Kysela
0 siblings, 0 replies; 26+ messages in thread
From: Jaroslav Kysela @ 2019-02-06 15:35 UTC (permalink / raw)
To: Mark Brown; +Cc: Takashi Iwai, alsa-devel
Dne 6.2.2019 v 15:50 Mark Brown napsal(a):
>> With all respects, do we really need to split those elementary changes
>> to single patches inside the sound tree? I would really prefer to have
>> this inside one patch or maybe few patches (core/pci/asoc/others). Just
>> my two cents.
>
> FWIW it does mean that life is easier for people doing backports when
> things are split up as there's less chance that some file that wasn't
> added in the kernel version you were interested in was touched by the
> patch.
It's only minor thing for the backports. The proper import procedure
covers this. I don't like to have separate patches for
single-line/single-file changes and this change set belongs to this.
Jaroslav
--
Jaroslav Kysela <perex@perex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.
^ permalink raw reply [flat|nested] 26+ messages in thread