From: Laurent Vivier <lvivier@redhat.com> To: linux-kernel@vger.kernel.org Cc: Michael Ellerman <mpe@ellerman.id.au>, linuxppc-dev@lists.ozlabs.org, David Gibson <david@gibson.dropbear.id.au>, Christophe Leroy <christophe.leroy@c-s.fr> Subject: [PATCH v2] powerpc/mm: move a KERN_WARNING message to pr_debug() Date: Tue, 5 Feb 2019 21:21:33 +0100 [thread overview] Message-ID: <20190205202133.5048-1-lvivier@redhat.com> (raw) resize_hpt_for_hotplug() reports a warning when it cannot increase the hash page table ("Unable to resize hash page table to target order") but this is not blocking and can make user thinks something has not worked properly. As we move the message to the debug area, report again the ENODEV error. If the operation cannot be done the real error message will be reported by arch_add_memory() if create_section_mapping() fails. Fixes: 7339390d772dd powerpc/pseries: Don't give a warning when HPT resizing isn't available Signed-off-by: Laurent Vivier <lvivier@redhat.com> --- Notes: v2: - use pr_debug instead of printk(KERN_DEBUG - remove check for ENODEV arch/powerpc/mm/hash_utils_64.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/arch/powerpc/mm/hash_utils_64.c b/arch/powerpc/mm/hash_utils_64.c index 0cc7fbc3bd1c..6a0cc4eb2c83 100644 --- a/arch/powerpc/mm/hash_utils_64.c +++ b/arch/powerpc/mm/hash_utils_64.c @@ -777,10 +777,9 @@ void resize_hpt_for_hotplug(unsigned long new_mem_size) int rc; rc = mmu_hash_ops.resize_hpt(target_hpt_shift); - if (rc && (rc != -ENODEV)) - printk(KERN_WARNING - "Unable to resize hash page table to target order %d: %d\n", - target_hpt_shift, rc); + if (rc) + pr_debug("Unable to resize hash page table to target order %d: %d\n", + target_hpt_shift, rc); } } -- 2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Vivier <lvivier@redhat.com> To: linux-kernel@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org, David Gibson <david@gibson.dropbear.id.au> Subject: [PATCH v2] powerpc/mm: move a KERN_WARNING message to pr_debug() Date: Tue, 5 Feb 2019 21:21:33 +0100 [thread overview] Message-ID: <20190205202133.5048-1-lvivier@redhat.com> (raw) resize_hpt_for_hotplug() reports a warning when it cannot increase the hash page table ("Unable to resize hash page table to target order") but this is not blocking and can make user thinks something has not worked properly. As we move the message to the debug area, report again the ENODEV error. If the operation cannot be done the real error message will be reported by arch_add_memory() if create_section_mapping() fails. Fixes: 7339390d772dd powerpc/pseries: Don't give a warning when HPT resizing isn't available Signed-off-by: Laurent Vivier <lvivier@redhat.com> --- Notes: v2: - use pr_debug instead of printk(KERN_DEBUG - remove check for ENODEV arch/powerpc/mm/hash_utils_64.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/arch/powerpc/mm/hash_utils_64.c b/arch/powerpc/mm/hash_utils_64.c index 0cc7fbc3bd1c..6a0cc4eb2c83 100644 --- a/arch/powerpc/mm/hash_utils_64.c +++ b/arch/powerpc/mm/hash_utils_64.c @@ -777,10 +777,9 @@ void resize_hpt_for_hotplug(unsigned long new_mem_size) int rc; rc = mmu_hash_ops.resize_hpt(target_hpt_shift); - if (rc && (rc != -ENODEV)) - printk(KERN_WARNING - "Unable to resize hash page table to target order %d: %d\n", - target_hpt_shift, rc); + if (rc) + pr_debug("Unable to resize hash page table to target order %d: %d\n", + target_hpt_shift, rc); } } -- 2.20.1
next reply other threads:[~2019-02-05 20:21 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-02-05 20:21 Laurent Vivier [this message] 2019-02-05 20:21 ` [PATCH v2] powerpc/mm: move a KERN_WARNING message to pr_debug() Laurent Vivier 2019-02-07 3:03 ` David Gibson 2019-02-07 3:03 ` David Gibson 2019-02-07 9:25 ` Laurent Vivier 2019-02-07 9:25 ` Laurent Vivier 2019-02-07 4:33 ` Michael Ellerman 2019-02-07 4:33 ` Michael Ellerman 2019-02-07 9:13 ` Laurent Vivier 2019-02-07 9:13 ` Laurent Vivier
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190205202133.5048-1-lvivier@redhat.com \ --to=lvivier@redhat.com \ --cc=christophe.leroy@c-s.fr \ --cc=david@gibson.dropbear.id.au \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=mpe@ellerman.id.au \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.