From: Jonathan Cameron <jonathan.cameron@huawei.com> To: Keith Busch <keith.busch@intel.com> Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Rafael Wysocki <rafael@kernel.org>, Dave Hansen <dave.hansen@intel.com>, Dan Williams <dan.j.williams@intel.com> Subject: Re: [PATCHv5 07/10] acpi/hmat: Register performance attributes Date: Wed, 6 Feb 2019 12:24:58 +0000 [thread overview] Message-ID: <20190206122458.0000793c@huawei.com> (raw) In-Reply-To: <20190124230724.10022-8-keith.busch@intel.com> On Thu, 24 Jan 2019 16:07:21 -0700 Keith Busch <keith.busch@intel.com> wrote: > Register the local attached performace access attributes with the memory's performance > node if HMAT provides the locality table. While HMAT does make it possible > to know performance for all possible initiator-target pairings, we export > only the local and matching pairings at this time. > > Signed-off-by: Keith Busch <keith.busch@intel.com> > --- > drivers/acpi/hmat/Kconfig | 1 + > drivers/acpi/hmat/hmat.c | 14 ++++++++++++++ > 2 files changed, 15 insertions(+) > > diff --git a/drivers/acpi/hmat/Kconfig b/drivers/acpi/hmat/Kconfig > index c9637e2e7514..08e972ead159 100644 > --- a/drivers/acpi/hmat/Kconfig > +++ b/drivers/acpi/hmat/Kconfig > @@ -2,6 +2,7 @@ > config ACPI_HMAT > bool "ACPI Heterogeneous Memory Attribute Table Support" > depends on ACPI_NUMA > + select HMEM_REPORTING > help > If set, this option causes the kernel to set the memory NUMA node > relationships and access attributes in accordance with ACPI HMAT > diff --git a/drivers/acpi/hmat/hmat.c b/drivers/acpi/hmat/hmat.c > index 85fd835c2e23..917e6122b3f0 100644 > --- a/drivers/acpi/hmat/hmat.c > +++ b/drivers/acpi/hmat/hmat.c > @@ -430,6 +430,19 @@ static __init void hmat_register_target_initiators(struct memory_target *target) > hmat_register_if_local(target, initiator); > } > > +static __init void hmat_register_target_perf(struct memory_target *target) > +{ > + unsigned mem_nid = pxm_to_node(target->memory_pxm); > + struct node_hmem_attrs hmem_attrs = { > + .read_bandwidth = target->read_bandwidth, > + .write_bandwidth= target->write_bandwidth, > + .read_latency = target->read_latency, > + .write_latency = target->write_latency, > + }; > + > + node_set_perf_attrs(mem_nid, &hmem_attrs, 0); > +} > + > static __init void hmat_register_targets(void) > { > struct memory_target *target, *tnext; > @@ -439,6 +452,7 @@ static __init void hmat_register_targets(void) > list_for_each_entry_safe(target, tnext, &targets, node) { > list_del(&target->node); > hmat_register_target_initiators(target); > + hmat_register_target_perf(target); > kfree(target); > } >
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jonathan.cameron@huawei.com> To: Keith Busch <keith.busch@intel.com> Cc: <linux-kernel@vger.kernel.org>, <linux-acpi@vger.kernel.org>, <linux-mm@kvack.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, "Rafael Wysocki" <rafael@kernel.org>, Dave Hansen <dave.hansen@intel.com>, "Dan Williams" <dan.j.williams@intel.com> Subject: Re: [PATCHv5 07/10] acpi/hmat: Register performance attributes Date: Wed, 6 Feb 2019 12:24:58 +0000 [thread overview] Message-ID: <20190206122458.0000793c@huawei.com> (raw) In-Reply-To: <20190124230724.10022-8-keith.busch@intel.com> On Thu, 24 Jan 2019 16:07:21 -0700 Keith Busch <keith.busch@intel.com> wrote: > Register the local attached performace access attributes with the memory's performance > node if HMAT provides the locality table. While HMAT does make it possible > to know performance for all possible initiator-target pairings, we export > only the local and matching pairings at this time. > > Signed-off-by: Keith Busch <keith.busch@intel.com> > --- > drivers/acpi/hmat/Kconfig | 1 + > drivers/acpi/hmat/hmat.c | 14 ++++++++++++++ > 2 files changed, 15 insertions(+) > > diff --git a/drivers/acpi/hmat/Kconfig b/drivers/acpi/hmat/Kconfig > index c9637e2e7514..08e972ead159 100644 > --- a/drivers/acpi/hmat/Kconfig > +++ b/drivers/acpi/hmat/Kconfig > @@ -2,6 +2,7 @@ > config ACPI_HMAT > bool "ACPI Heterogeneous Memory Attribute Table Support" > depends on ACPI_NUMA > + select HMEM_REPORTING > help > If set, this option causes the kernel to set the memory NUMA node > relationships and access attributes in accordance with ACPI HMAT > diff --git a/drivers/acpi/hmat/hmat.c b/drivers/acpi/hmat/hmat.c > index 85fd835c2e23..917e6122b3f0 100644 > --- a/drivers/acpi/hmat/hmat.c > +++ b/drivers/acpi/hmat/hmat.c > @@ -430,6 +430,19 @@ static __init void hmat_register_target_initiators(struct memory_target *target) > hmat_register_if_local(target, initiator); > } > > +static __init void hmat_register_target_perf(struct memory_target *target) > +{ > + unsigned mem_nid = pxm_to_node(target->memory_pxm); > + struct node_hmem_attrs hmem_attrs = { > + .read_bandwidth = target->read_bandwidth, > + .write_bandwidth= target->write_bandwidth, > + .read_latency = target->read_latency, > + .write_latency = target->write_latency, > + }; > + > + node_set_perf_attrs(mem_nid, &hmem_attrs, 0); > +} > + > static __init void hmat_register_targets(void) > { > struct memory_target *target, *tnext; > @@ -439,6 +452,7 @@ static __init void hmat_register_targets(void) > list_for_each_entry_safe(target, tnext, &targets, node) { > list_del(&target->node); > hmat_register_target_initiators(target); > + hmat_register_target_perf(target); > kfree(target); > } >
next prev parent reply other threads:[~2019-02-06 12:24 UTC|newest] Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-01-24 23:07 [PATCHv5 00/10] Heterogeneuos memory node attributes Keith Busch 2019-01-24 23:07 ` [PATCHv5 01/10] acpi: Create subtable parsing infrastructure Keith Busch 2019-01-24 23:07 ` [PATCHv5 02/10] acpi: Add HMAT to generic parsing tables Keith Busch 2019-01-24 23:07 ` [PATCHv5 03/10] acpi/hmat: Parse and report heterogeneous memory Keith Busch 2019-02-05 12:12 ` Rafael J. Wysocki 2019-02-05 12:12 ` Rafael J. Wysocki 2019-02-06 12:28 ` Jonathan Cameron 2019-02-06 12:28 ` Jonathan Cameron 2019-02-06 16:06 ` Keith Busch 2019-02-06 16:39 ` Jonathan Cameron 2019-02-06 16:39 ` Jonathan Cameron 2019-01-24 23:07 ` [PATCHv5 04/10] node: Link memory nodes to their compute nodes Keith Busch 2019-02-05 12:33 ` Rafael J. Wysocki 2019-02-05 12:33 ` Rafael J. Wysocki 2019-02-05 14:48 ` Keith Busch 2019-02-05 14:52 ` Greg Kroah-Hartman 2019-02-05 15:17 ` Rafael J. Wysocki 2019-02-05 15:17 ` Rafael J. Wysocki 2019-02-06 23:09 ` Keith Busch 2019-02-06 23:48 ` Rafael J. Wysocki 2019-02-06 23:48 ` Rafael J. Wysocki 2019-02-06 12:26 ` Jonathan Cameron 2019-02-06 12:26 ` Jonathan Cameron 2019-02-06 16:12 ` Keith Busch 2019-02-06 16:47 ` Jonathan Cameron 2019-02-07 11:35 ` Rafael J. Wysocki 2019-02-07 11:35 ` Rafael J. Wysocki 2019-01-24 23:07 ` [PATCHv5 05/10] acpi/hmat: Register processor domain to its memory Keith Busch 2019-02-06 12:26 ` Jonathan Cameron 2019-02-06 12:26 ` Jonathan Cameron 2019-01-24 23:07 ` [PATCHv5 06/10] node: Add heterogenous memory access attributes Keith Busch 2019-01-24 23:07 ` [PATCHv5 07/10] acpi/hmat: Register performance attributes Keith Busch 2019-02-06 12:24 ` Jonathan Cameron [this message] 2019-02-06 12:24 ` Jonathan Cameron 2019-01-24 23:07 ` [PATCHv5 08/10] node: Add memory caching attributes Keith Busch 2019-02-06 12:24 ` Jonathan Cameron 2019-02-06 12:24 ` Jonathan Cameron 2019-01-24 23:07 ` [PATCHv5 09/10] acpi/hmat: Register memory side cache attributes Keith Busch 2019-02-06 12:17 ` Jonathan Cameron 2019-02-06 12:17 ` Jonathan Cameron 2019-01-24 23:07 ` [PATCHv5 10/10] doc/mm: New documentation for memory performance Keith Busch 2019-02-06 10:45 ` Jonathan Cameron 2019-02-06 10:45 ` Jonathan Cameron 2019-02-06 16:25 ` Keith Busch 2019-01-28 14:00 ` [PATCHv5 00/10] Heterogeneuos memory node attributes Michal Hocko 2019-02-06 12:31 ` Jonathan Cameron 2019-02-06 12:31 ` Jonathan Cameron 2019-02-06 17:19 ` Keith Busch 2019-02-06 17:30 ` Jonathan Cameron 2019-02-06 17:30 ` Jonathan Cameron 2019-02-07 9:53 ` Jonathan Cameron 2019-02-07 9:53 ` Jonathan Cameron 2019-02-07 15:08 ` Keith Busch
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190206122458.0000793c@huawei.com \ --to=jonathan.cameron@huawei.com \ --cc=dan.j.williams@intel.com \ --cc=dave.hansen@intel.com \ --cc=gregkh@linuxfoundation.org \ --cc=keith.busch@intel.com \ --cc=linux-acpi@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=rafael@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.