All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anup Patel <Anup.Patel@wdc.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v6 06/16] riscv: generic: Ensure that U-Boot runs within 4GB for 64bit systems
Date: Sat, 9 Feb 2019 06:32:03 +0000	[thread overview]
Message-ID: <20190209063052.29092-7-anup.patel@wdc.com> (raw)
In-Reply-To: <20190209063052.29092-1-anup.patel@wdc.com>

On 64bit systems, the DRAM top can be easily beyond 4GB and U-Boot
DMA mapping APIs will generate DMA addresses beyond 4GB. This
breaks DMA programming in 32bit DMA capable devices (such as
Cadence MACB ethernet). For example, If DRAM is more then 2GB
on QEMU sifive_u machine then Cadence MACB ethernet stops working
for U-Boot because it is a 32bit DMA capable device.

To handle 32bit DMA capable devices on 64bit systems, we provide
custom implementation of board_get_usable_ram_top() which ensures
that usable ram top is not more then 4GB. This in-turn ensures
that U-Boot always runs within 4GB hence DMA addresses generated
by DMA mapping APIs will be within 4GB too.

Signed-off-by: Atish Patra <atish.patra@wdc.com>
Signed-off-by: Anup Patel <anup.patel@wdc.com>
Reviewed-by: Alexander Graf <agraf@suse.de>
Reviewed-by: Lukas Auer <lukas.auer@aisec.fraunhofer.de>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
---
 arch/riscv/cpu/generic/dram.c | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/arch/riscv/cpu/generic/dram.c b/arch/riscv/cpu/generic/dram.c
index 84d87d2a7f..b7b1207235 100644
--- a/arch/riscv/cpu/generic/dram.c
+++ b/arch/riscv/cpu/generic/dram.c
@@ -5,6 +5,9 @@
 
 #include <common.h>
 #include <fdtdec.h>
+#include <linux/sizes.h>
+
+DECLARE_GLOBAL_DATA_PTR;
 
 int dram_init(void)
 {
@@ -15,3 +18,20 @@ int dram_init_banksize(void)
 {
 	return fdtdec_setup_memory_banksize();
 }
+
+ulong board_get_usable_ram_top(ulong total_size)
+{
+#ifdef CONFIG_64BIT
+	/*
+	 * Ensure that we run from first 4GB so that all
+	 * addresses used by U-Boot are 32bit addresses.
+	 *
+	 * This in-turn ensures that 32bit DMA capable
+	 * devices work fine because DMA mapping APIs will
+	 * provide 32bit DMA addresses only.
+	 */
+	if (gd->ram_top > SZ_4G)
+		return SZ_4G;
+#endif
+	return gd->ram_top;
+}
-- 
2.17.1

  parent reply	other threads:[~2019-02-09  6:32 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-09  6:31 [U-Boot] [PATCH v6 00/16] SiFive FU540 Support Anup Patel
2019-02-09  6:31 ` [U-Boot] [PATCH v6 01/16] .gitignore: Don't ignore arch/riscv/include/asm/arch Anup Patel
2019-02-10 18:18   ` Auer, Lukas
2019-02-09  6:31 ` [U-Boot] [PATCH v6 02/16] Makefile: Fix mrproper make target Anup Patel
2019-02-10 18:31   ` Auer, Lukas
2019-02-11  1:12     ` Tom Rini
2019-02-11  4:27       ` Anup Patel
2019-02-09  6:31 ` [U-Boot] [PATCH v6 03/16] riscv: Rename cpu/qemu to cpu/generic Anup Patel
2019-02-09  6:31 ` [U-Boot] [PATCH v6 04/16] riscv: Add asm/dma-mapping.h for DMA mappings Anup Patel
2019-02-09  6:31 ` [U-Boot] [PATCH v6 05/16] riscv: Add place-holder asm/arch/clk.h for driver compilation Anup Patel
2019-02-10 18:32   ` Auer, Lukas
2019-02-11  3:21   ` Bin Meng
2019-02-11  4:28     ` Anup Patel
2019-02-09  6:32 ` Anup Patel [this message]
2019-02-09  6:32 ` [U-Boot] [PATCH v6 07/16] net: macb: Fix clk API usage for RISC-V systems Anup Patel
2019-02-09  6:32 ` [U-Boot] [PATCH v6 08/16] net: macb: Fix GEM hardware detection Anup Patel
2019-02-09  6:32 ` [U-Boot] [PATCH v6 09/16] clk: Add SiFive FU540 PRCI clock driver Anup Patel
2019-02-10 18:40   ` Auer, Lukas
2019-02-11  4:32     ` Anup Patel
2019-02-11  9:37       ` Auer, Lukas
2019-02-09  6:32 ` [U-Boot] [PATCH v6 10/16] clk: Add fixed-factor " Anup Patel
2019-02-09  6:32 ` [U-Boot] [PATCH v6 11/16] drivers: serial_sifive: Fix baud rate calculation Anup Patel
2019-02-09  6:33 ` [U-Boot] [PATCH v6 12/16] drivers: serial_sifive: Skip baudrate config if no input clock Anup Patel
2019-02-09  6:33 ` [U-Boot] [PATCH v6 13/16] cpu: Bind timer driver for boot hart Anup Patel
2019-02-09  6:33 ` [U-Boot] [PATCH v6 14/16] riscv: Add SiFive FU540 board support Anup Patel
2019-02-09  6:33 ` [U-Boot] [PATCH v6 15/16] doc: Add a readme guide for SiFive FU540 Anup Patel
2019-02-10 18:47   ` Auer, Lukas
2019-02-11  3:00     ` Atish Patra
2019-02-09  6:33 ` [U-Boot] [PATCH v6 16/16] riscv: Enable CONFIG_SYS_BOOT_RAMDISK_HIGH for using initrd Anup Patel
2019-02-10 18:48   ` Auer, Lukas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190209063052.29092-7-anup.patel@wdc.com \
    --to=anup.patel@wdc.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.