[PATCH 1/2] crypto: chtls: remove cdev_list_lock

[PATCH 1/2] crypto: chtls: remove cdev_list_lock

[Sebastian Andrzej Siewior]

Last user of cdev_list_lock was removed in commit

  6422ccc5fbefb ("crypto/chelsio/chtls: listen fails with multiadapt")

Cc: Atul Gupta <atul.gupta@chelsio.com>
Cc: Harsh Jain <harsh@chelsio.com>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
 drivers/crypto/chelsio/chtls/chtls_main.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/crypto/chelsio/chtls/chtls_main.c b/drivers/crypto/chelsio/chtls/chtls_main.c
index 563f8fe7686ad..dd2daf2a54e06 100644
--- a/drivers/crypto/chelsio/chtls/chtls_main.c
+++ b/drivers/crypto/chelsio/chtls/chtls_main.c
@@ -30,7 +30,6 @@
  */
 static LIST_HEAD(cdev_list);
 static DEFINE_MUTEX(cdev_mutex);
-static DEFINE_MUTEX(cdev_list_lock);
 
 static DEFINE_MUTEX(notify_mutex);
 static RAW_NOTIFIER_HEAD(listen_notify_list);
-- 
2.20.1

[PATCH 2/2] crypto: user: remove crypto_cfg_mutex

[Sebastian Andrzej Siewior]

crypto_cfg_mutex was never used since it got introduced in commit

  cac5818c25d04 ("crypto: user - Implement a generic crypto statistics")

Cc: Corentin Labbe <clabbe@baylibre.com>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
 crypto/crypto_user_stat.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/crypto/crypto_user_stat.c b/crypto/crypto_user_stat.c
index 3e9a53233d804..028be6a1ea781 100644
--- a/crypto/crypto_user_stat.c
+++ b/crypto/crypto_user_stat.c
@@ -20,8 +20,6 @@
 
 #define null_terminated(x)	(strnlen(x, sizeof(x)) < sizeof(x))
 
-static DEFINE_MUTEX(crypto_cfg_mutex);
-
 extern struct sock *crypto_nlsk;
 
 struct crypto_dump_info {
-- 
2.20.1

Re: [PATCH 2/2] crypto: user: remove crypto_cfg_mutex

[Eric Biggers]

On Mon, Feb 11, 2019 at 12:02:51PM +0100, Sebastian Andrzej Siewior wrote:
> crypto_cfg_mutex was never used since it got introduced in commit
> 
>   cac5818c25d04 ("crypto: user - Implement a generic crypto statistics")
> 
> Cc: Corentin Labbe <clabbe@baylibre.com>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> ---
>  crypto/crypto_user_stat.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/crypto/crypto_user_stat.c b/crypto/crypto_user_stat.c
> index 3e9a53233d804..028be6a1ea781 100644
> --- a/crypto/crypto_user_stat.c
> +++ b/crypto/crypto_user_stat.c
> @@ -20,8 +20,6 @@
>  
>  #define null_terminated(x)	(strnlen(x, sizeof(x)) < sizeof(x))
>  
> -static DEFINE_MUTEX(crypto_cfg_mutex);
> -
>  extern struct sock *crypto_nlsk;
>  
>  struct crypto_dump_info {
> -- 
> 2.20.1
> 

Hi Sebastian, this is already removed by a patch queued in cryptodev:
https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git/commit/?id=554557ce0001fc0371fb88db53d7dfe2a398c6de

- Eric

Re: [PATCH 1/2] crypto: chtls: remove cdev_list_lock

[Herbert Xu]

On Mon, Feb 11, 2019 at 12:02:50PM +0100, Sebastian Andrzej Siewior wrote:
> Last user of cdev_list_lock was removed in commit
> 
>   6422ccc5fbefb ("crypto/chelsio/chtls: listen fails with multiadapt")
> 
> Cc: Atul Gupta <atul.gupta@chelsio.com>
> Cc: Harsh Jain <harsh@chelsio.com>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> ---
>  drivers/crypto/chelsio/chtls/chtls_main.c | 1 -
>  1 file changed, 1 deletion(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt