* [PATCH] slub: remove an unused addr argument
@ 2019-02-11 12:32 Qian Cai
2019-02-11 22:05 ` David Rientjes
0 siblings, 1 reply; 3+ messages in thread
From: Qian Cai @ 2019-02-11 12:32 UTC (permalink / raw)
To: akpm, cl, penberg, rientjes, iamjoonsoo.kim
Cc: labbott, linux-mm, linux-kernel, Qian Cai
"addr" function argument is not used in alloc_consistency_checks() at
all, so remove it.
Fixes: becfda68abca ("slub: convert SLAB_DEBUG_FREE to SLAB_CONSISTENCY_CHECKS")
Signed-off-by: Qian Cai <cai@lca.pw>
---
mm/slub.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/mm/slub.c b/mm/slub.c
index 075ebc529788..4a61959e1887 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -1077,8 +1077,7 @@ static void setup_object_debug(struct kmem_cache *s, struct page *page,
}
static inline int alloc_consistency_checks(struct kmem_cache *s,
- struct page *page,
- void *object, unsigned long addr)
+ struct page *page, void *object)
{
if (!check_slab(s, page))
return 0;
@@ -1099,7 +1098,7 @@ static noinline int alloc_debug_processing(struct kmem_cache *s,
void *object, unsigned long addr)
{
if (s->flags & SLAB_CONSISTENCY_CHECKS) {
- if (!alloc_consistency_checks(s, page, object, addr))
+ if (!alloc_consistency_checks(s, page, object))
goto bad;
}
--
2.17.2 (Apple Git-113)
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] slub: remove an unused addr argument
2019-02-11 12:32 [PATCH] slub: remove an unused addr argument Qian Cai
@ 2019-02-11 22:05 ` David Rientjes
0 siblings, 0 replies; 3+ messages in thread
From: David Rientjes @ 2019-02-11 22:05 UTC (permalink / raw)
To: Qian Cai
Cc: akpm, cl, penberg, iamjoonsoo.kim, labbott, linux-mm, linux-kernel
On Mon, 11 Feb 2019, Qian Cai wrote:
> "addr" function argument is not used in alloc_consistency_checks() at
> all, so remove it.
>
> Fixes: becfda68abca ("slub: convert SLAB_DEBUG_FREE to SLAB_CONSISTENCY_CHECKS")
> Signed-off-by: Qian Cai <cai@lca.pw>
Acked-by: David Rientjes <rientjes@google.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] slub: remove an unused addr argument
@ 2019-02-11 22:05 ` David Rientjes
0 siblings, 0 replies; 3+ messages in thread
From: David Rientjes @ 2019-02-11 22:05 UTC (permalink / raw)
To: Qian Cai
Cc: akpm, cl, penberg, iamjoonsoo.kim, labbott, linux-mm, linux-kernel
On Mon, 11 Feb 2019, Qian Cai wrote:
> "addr" function argument is not used in alloc_consistency_checks() at
> all, so remove it.
>
> Fixes: becfda68abca ("slub: convert SLAB_DEBUG_FREE to SLAB_CONSISTENCY_CHECKS")
> Signed-off-by: Qian Cai <cai@lca.pw>
Acked-by: David Rientjes <rientjes@google.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-11 22:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-11 12:32 [PATCH] slub: remove an unused addr argument Qian Cai
2019-02-11 22:05 ` David Rientjes
2019-02-11 22:05 ` David Rientjes
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.