* [U-Boot] [PATCH 1/1] test: call hexdump tests via `ut lib`
@ 2019-02-11 17:29 Heinrich Schuchardt
2019-02-11 19:42 ` Simon Goldschmidt
2019-04-24 13:21 ` [U-Boot] [U-Boot,1/1] " Tom Rini
0 siblings, 2 replies; 4+ messages in thread
From: Heinrich Schuchardt @ 2019-02-11 17:29 UTC (permalink / raw)
To: u-boot
The unit tests in test/lib/hexdump.c are not related to the device tree.
So they should be executed via `ut lib` and not via `ut dm`.
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
test/lib/hexdump.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/test/lib/hexdump.c b/test/lib/hexdump.c
index 567b57686a..5dccf43886 100644
--- a/test/lib/hexdump.c
+++ b/test/lib/hexdump.c
@@ -6,7 +6,8 @@
#include <common.h>
#include <hexdump.h>
-#include <dm/test.h>
+#include <test/lib.h>
+#include <test/test.h>
#include <test/ut.h>
static int lib_test_hex_to_bin(struct unit_test_state *uts)
@@ -32,7 +33,7 @@ static int lib_test_hex_to_bin(struct unit_test_state *uts)
return 0;
}
-DM_TEST(lib_test_hex_to_bin, DM_TESTF_SCAN_PDATA | DM_TESTF_SCAN_FDT);
+LIB_TEST(lib_test_hex_to_bin, 0);
static int lib_test_hex2bin(struct unit_test_state *uts)
{
@@ -62,7 +63,7 @@ static int lib_test_hex2bin(struct unit_test_state *uts)
return 0;
}
-DM_TEST(lib_test_hex2bin, DM_TESTF_SCAN_PDATA | DM_TESTF_SCAN_FDT);
+LIB_TEST(lib_test_hex2bin, 0);
static int lib_test_bin2hex(struct unit_test_state *uts)
{
@@ -92,4 +93,4 @@ static int lib_test_bin2hex(struct unit_test_state *uts)
return 0;
}
-DM_TEST(lib_test_bin2hex, DM_TESTF_SCAN_PDATA | DM_TESTF_SCAN_FDT);
+LIB_TEST(lib_test_bin2hex, 0);
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH 1/1] test: call hexdump tests via `ut lib`
2019-02-11 17:29 [U-Boot] [PATCH 1/1] test: call hexdump tests via `ut lib` Heinrich Schuchardt
@ 2019-02-11 19:42 ` Simon Goldschmidt
2019-04-10 0:08 ` Heinrich Schuchardt
2019-04-24 13:21 ` [U-Boot] [U-Boot,1/1] " Tom Rini
1 sibling, 1 reply; 4+ messages in thread
From: Simon Goldschmidt @ 2019-02-11 19:42 UTC (permalink / raw)
To: u-boot
Am 11.02.2019 um 18:29 schrieb Heinrich Schuchardt:
> The unit tests in test/lib/hexdump.c are not related to the device tree.
> So they should be executed via `ut lib` and not via `ut dm`.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Reviewed-by: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
Excellent idea, I'll send the same for test/lib/lmb.c.
Thanks,
Simon
> ---
> test/lib/hexdump.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/test/lib/hexdump.c b/test/lib/hexdump.c
> index 567b57686a..5dccf43886 100644
> --- a/test/lib/hexdump.c
> +++ b/test/lib/hexdump.c
> @@ -6,7 +6,8 @@
>
> #include <common.h>
> #include <hexdump.h>
> -#include <dm/test.h>
> +#include <test/lib.h>
> +#include <test/test.h>
> #include <test/ut.h>
>
> static int lib_test_hex_to_bin(struct unit_test_state *uts)
> @@ -32,7 +33,7 @@ static int lib_test_hex_to_bin(struct unit_test_state *uts)
> return 0;
> }
>
> -DM_TEST(lib_test_hex_to_bin, DM_TESTF_SCAN_PDATA | DM_TESTF_SCAN_FDT);
> +LIB_TEST(lib_test_hex_to_bin, 0);
>
> static int lib_test_hex2bin(struct unit_test_state *uts)
> {
> @@ -62,7 +63,7 @@ static int lib_test_hex2bin(struct unit_test_state *uts)
> return 0;
> }
>
> -DM_TEST(lib_test_hex2bin, DM_TESTF_SCAN_PDATA | DM_TESTF_SCAN_FDT);
> +LIB_TEST(lib_test_hex2bin, 0);
>
> static int lib_test_bin2hex(struct unit_test_state *uts)
> {
> @@ -92,4 +93,4 @@ static int lib_test_bin2hex(struct unit_test_state *uts)
> return 0;
> }
>
> -DM_TEST(lib_test_bin2hex, DM_TESTF_SCAN_PDATA | DM_TESTF_SCAN_FDT);
> +LIB_TEST(lib_test_bin2hex, 0);
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH 1/1] test: call hexdump tests via `ut lib`
2019-02-11 19:42 ` Simon Goldschmidt
@ 2019-04-10 0:08 ` Heinrich Schuchardt
0 siblings, 0 replies; 4+ messages in thread
From: Heinrich Schuchardt @ 2019-04-10 0:08 UTC (permalink / raw)
To: u-boot
On 2/11/19 8:42 PM, Simon Goldschmidt wrote:
> Am 11.02.2019 um 18:29 schrieb Heinrich Schuchardt:
>> The unit tests in test/lib/hexdump.c are not related to the device tree.
>> So they should be executed via `ut lib` and not via `ut dm`.
>>
>> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
>
> Reviewed-by: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
Hello Tom,
please, consider the patch for v2019-07.
Best regards
Heinrich
>
> Excellent idea, I'll send the same for test/lib/lmb.c.
>
> Thanks,
> Simon
>
>> ---
>> test/lib/hexdump.c | 9 +++++----
>> 1 file changed, 5 insertions(+), 4 deletions(-)
>>
>> diff --git a/test/lib/hexdump.c b/test/lib/hexdump.c
>> index 567b57686a..5dccf43886 100644
>> --- a/test/lib/hexdump.c
>> +++ b/test/lib/hexdump.c
>> @@ -6,7 +6,8 @@
>> #include <common.h>
>> #include <hexdump.h>
>> -#include <dm/test.h>
>> +#include <test/lib.h>
>> +#include <test/test.h>
>> #include <test/ut.h>
>> static int lib_test_hex_to_bin(struct unit_test_state *uts)
>> @@ -32,7 +33,7 @@ static int lib_test_hex_to_bin(struct
>> unit_test_state *uts)
>> return 0;
>> }
>> -DM_TEST(lib_test_hex_to_bin, DM_TESTF_SCAN_PDATA | DM_TESTF_SCAN_FDT);
>> +LIB_TEST(lib_test_hex_to_bin, 0);
>> static int lib_test_hex2bin(struct unit_test_state *uts)
>> {
>> @@ -62,7 +63,7 @@ static int lib_test_hex2bin(struct unit_test_state
>> *uts)
>> return 0;
>> }
>> -DM_TEST(lib_test_hex2bin, DM_TESTF_SCAN_PDATA | DM_TESTF_SCAN_FDT);
>> +LIB_TEST(lib_test_hex2bin, 0);
>> static int lib_test_bin2hex(struct unit_test_state *uts)
>> {
>> @@ -92,4 +93,4 @@ static int lib_test_bin2hex(struct unit_test_state
>> *uts)
>> return 0;
>> }
>> -DM_TEST(lib_test_bin2hex, DM_TESTF_SCAN_PDATA | DM_TESTF_SCAN_FDT);
>> +LIB_TEST(lib_test_bin2hex, 0);
>>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [U-Boot,1/1] test: call hexdump tests via `ut lib`
2019-02-11 17:29 [U-Boot] [PATCH 1/1] test: call hexdump tests via `ut lib` Heinrich Schuchardt
2019-02-11 19:42 ` Simon Goldschmidt
@ 2019-04-24 13:21 ` Tom Rini
1 sibling, 0 replies; 4+ messages in thread
From: Tom Rini @ 2019-04-24 13:21 UTC (permalink / raw)
To: u-boot
On Mon, Feb 11, 2019 at 06:29:24PM +0100, Heinrich Schuchardt wrote:
> The unit tests in test/lib/hexdump.c are not related to the device tree.
> So they should be executed via `ut lib` and not via `ut dm`.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Reviewed-by: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190424/a917d4ba/attachment.sig>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-04-24 13:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-11 17:29 [U-Boot] [PATCH 1/1] test: call hexdump tests via `ut lib` Heinrich Schuchardt
2019-02-11 19:42 ` Simon Goldschmidt
2019-04-10 0:08 ` Heinrich Schuchardt
2019-04-24 13:21 ` [U-Boot] [U-Boot,1/1] " Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.