All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: Mark Zhang <markz@nvidia.com>
Cc: blaws05@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-tegra@vger.kernel.org
Subject: Re: [PATCH v2 0/4] Add max77620 charging & low battery support
Date: Tue, 12 Feb 2019 08:04:57 +0000	[thread overview]
Message-ID: <20190212080457.GL20638@dell> (raw)
In-Reply-To: <a43eb007-c984-a209-2b4e-6672807029aa@nvidia.com>

On Tue, 12 Feb 2019, Mark Zhang wrote:

> On 2/7/2019 4:48 PM, Lee Jones wrote:
> > On Tue, 29 Jan 2019, Mark Zhang wrote:
> > 
> >> This patch set adds support for max77620 backup battery charging and
> >> low battery monitoring.
> >>
> >> Changes in v2:
> >> - Add devicetree binding documentation
> >>
> >> Mark Zhang (4):
> >>   mfd: max77620: Add backup battery charger support
> >>   mfd: max77620: add documentation for backup battery charging
> >>   mfd: max77620: Add low battery monitor support
> >>   mfd: max77620: add documentation for low battery monitoring
> >>
> >>  .../devicetree/bindings/mfd/max77620.txt      |  34 +++++
> >>  drivers/mfd/max77620.c                        | 137 +++++++++++++++++-
> > 
> > All of this needs moving out to the correct subsystem.
> > 
> > drivers/power/supply/max77620-battery.c looks right.
> 
> Actually max77620 is not a power supply device. This patch set adds 2
> features:
> - Backup battery charger. The RTC in max77620 is supplied from a backup
> battery and consumes 2.0uA when no other power sources are available. So
> basically this is not a system battery charger, it's just for RTC.
> - Low battery monitoring. This is for monitoring the system main battery
> voltage, so max77620 can shutdown or reset the SoC accordingly. But I
> think this doesn't conform the idea of "power supply" driver as well.

Most other battery handling seems to happen in
drivers/power/supply/*.battery*.  If that's not the right location,
then you need to find a place for it to go.  MFDs do not provide
useful functionality per say - that is the role of the child devices.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

  reply	other threads:[~2019-02-12  8:04 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-29  8:55 [PATCH v2 0/4] Add max77620 charging & low battery support Mark Zhang
2019-01-29  8:55 ` Mark Zhang
2019-01-29  8:55 ` [PATCH v2 1/4] mfd: max77620: Add backup battery charger support Mark Zhang
2019-01-29  8:55   ` Mark Zhang
2019-01-29  8:55 ` [PATCH v2 2/4] mfd: max77620: add documentation for backup battery charging Mark Zhang
2019-01-29  8:55   ` Mark Zhang
2019-01-30 19:51   ` Rob Herring
2019-01-31  2:26     ` Mark Zhang
2019-01-31  2:26       ` Mark Zhang
2019-01-29  8:55 ` [PATCH v2 3/4] mfd: max77620: Add low battery monitor support Mark Zhang
2019-01-29  8:55   ` Mark Zhang
2019-01-29  8:55 ` [PATCH v2 4/4] mfd: max77620: add documentation for low battery monitoring Mark Zhang
2019-01-29  8:55   ` Mark Zhang
2019-01-30 19:53   ` Rob Herring
2019-01-31  2:29     ` Mark Zhang
2019-01-31  2:29       ` Mark Zhang
2019-01-31 21:05       ` Rob Herring
2019-01-31 21:37         ` Billy laws
2019-02-07  8:48 ` [PATCH v2 0/4] Add max77620 charging & low battery support Lee Jones
2019-02-12  4:38   ` Mark Zhang
2019-02-12  4:38     ` Mark Zhang
2019-02-12  8:04     ` Lee Jones [this message]
2019-02-12  8:29       ` Mark Zhang
2019-02-12  8:29         ` Mark Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190212080457.GL20638@dell \
    --to=lee.jones@linaro.org \
    --cc=blaws05@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=markz@nvidia.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.