All of lore.kernel.org
 help / color / mirror / Atom feed
From: Billy laws <blaws05@gmail.com>
To: Rob Herring <robh@kernel.org>, Mark Zhang <markz@nvidia.com>
Cc: Lee Jones <lee.jones@linaro.org>,
	Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	linux-tegra@vger.kernel.org
Subject: Re: [PATCH v2 4/4] mfd: max77620: add documentation for low battery monitoring
Date: Thu, 31 Jan 2019 21:37:46 +0000	[thread overview]
Message-ID: <D4E89A2D-2372-4328-92BD-5B1CF923951D@gmail.com> (raw)
In-Reply-To: <CAL_JsqK6z2NbJeRB48S-kmDrHj5B8H6hciR04+_Tzq4_V2jH_Q@mail.gmail.com>



On 31 January 2019 21:05:46 GMT, Rob Herring <robh@kernel.org> wrote:
>On Wed, Jan 30, 2019 at 8:29 PM Mark Zhang <markz@nvidia.com> wrote:
>>
>> On 1/31/2019 3:53 AM, Rob Herring wrote:
>> > On Tue, Jan 29, 2019 at 04:55:31PM +0800, Mark Zhang wrote:
>> >> Adding documentation for low battery monitor properties:
>> >> - maxim,low-battery-dac-enable
>> >> - maxim,low-battery-dac-disable
>> >> - maxim,low-battery-shutdown-enable
>> >> - maxim,low-battery-shutdown-disable
>> >> - maxim,low-battery-reset-enable
>> >> - maxim,low-battery-reset-disable
>> >>
>> >> Signed-off-by: Mark Zhang <markz@nvidia.com>
>> >> ---
>> >>  Documentation/devicetree/bindings/mfd/max77620.txt | 14
>++++++++++++++
>> >>  1 file changed, 14 insertions(+)
>> >>
>> >> diff --git a/Documentation/devicetree/bindings/mfd/max77620.txt
>b/Documentation/devicetree/bindings/mfd/max77620.txt
>> >> index 484b17e4fba5..5fed0a463b80 100644
>> >> --- a/Documentation/devicetree/bindings/mfd/max77620.txt
>> >> +++ b/Documentation/devicetree/bindings/mfd/max77620.txt
>> >> @@ -142,6 +142,20 @@ Optional properties:
>> >>                      Device supports 100/1000/3000/6000 Ohms.
>> >>                      Default will be set to 1000 Ohm.
>> >>
>> >> +Low-Battery Monitor:
>> >> +==================
>> >> +This sub-node configure low battery monitor configuration
>registers. Device has
>> >> +support for low-battery monitor configuration through child DT
>node
>> >> +"low-battery-monitor".
>
>Missed this the first time, but there's not really any reason for
>these to be in a child node.
>
>> >> +
>> >> +Optional properties:
>> >> +    - maxim,low-battery-dac-enable: Enable low battery DAC.
>> >> +    - maxim,low-battery-dac-disable: Disable low battery DAC.
>> >> +    - maxim,low-battery-shutdown-enable: Enable low battery
>shutdown.
>> >> +    - maxim,low-battery-shutdown-disable: Disable low battery
>shutdown.
>> >> +    - maxim,low-battery-reset-enable: Enable low battery reset.
>> >> +    - maxim,low-battery-reset-disable: Disable low battery reset.
>> >
>> > Do you really need 3 states with the 3rd being prop not present.
>>
>> Yeah, so I think we can just keep 3 of them and shorten the names a
>little bit
>> (lbm stands for "low battery monitoring"):
>> - maxim,lbm-dac-enable
>> - maxim,lbm-shutdown-enable
>> - maxim,lbm-reset-enable
>>
>> Does this look good to you?
>
>Yes. However, are these 3 mutually exclusive? If so, then perhaps
>'maxim,low-battery-mode = "<dac|shutdown|reset>"'?
I agree, would also allow the addition of the voltage cut off point configuration by just adding more defines.(current forces 3.something v cutoff)
>
>Rob

  reply	other threads:[~2019-01-31 21:37 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-29  8:55 [PATCH v2 0/4] Add max77620 charging & low battery support Mark Zhang
2019-01-29  8:55 ` Mark Zhang
2019-01-29  8:55 ` [PATCH v2 1/4] mfd: max77620: Add backup battery charger support Mark Zhang
2019-01-29  8:55   ` Mark Zhang
2019-01-29  8:55 ` [PATCH v2 2/4] mfd: max77620: add documentation for backup battery charging Mark Zhang
2019-01-29  8:55   ` Mark Zhang
2019-01-30 19:51   ` Rob Herring
2019-01-31  2:26     ` Mark Zhang
2019-01-31  2:26       ` Mark Zhang
2019-01-29  8:55 ` [PATCH v2 3/4] mfd: max77620: Add low battery monitor support Mark Zhang
2019-01-29  8:55   ` Mark Zhang
2019-01-29  8:55 ` [PATCH v2 4/4] mfd: max77620: add documentation for low battery monitoring Mark Zhang
2019-01-29  8:55   ` Mark Zhang
2019-01-30 19:53   ` Rob Herring
2019-01-31  2:29     ` Mark Zhang
2019-01-31  2:29       ` Mark Zhang
2019-01-31 21:05       ` Rob Herring
2019-01-31 21:37         ` Billy laws [this message]
2019-02-07  8:48 ` [PATCH v2 0/4] Add max77620 charging & low battery support Lee Jones
2019-02-12  4:38   ` Mark Zhang
2019-02-12  4:38     ` Mark Zhang
2019-02-12  8:04     ` Lee Jones
2019-02-12  8:29       ` Mark Zhang
2019-02-12  8:29         ` Mark Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D4E89A2D-2372-4328-92BD-5B1CF923951D@gmail.com \
    --to=blaws05@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=markz@nvidia.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.