* [PATCH i-g-t] i915/gem_exec_big: Add a single shot test
@ 2019-02-12 19:55 ` Chris Wilson
0 siblings, 0 replies; 27+ messages in thread
From: Chris Wilson @ 2019-02-12 19:55 UTC (permalink / raw)
To: intel-gfx; +Cc: igt-dev
CI complains that the exhaustive test of trying every size up to the
limit is too slow, so add a simple test that tries to submit one
extreme batch buffer and check all the relocations land.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105555
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
tests/i915/gem_exec_big.c | 70 ++++++++++++++++++++++++++++++------
tests/intel-ci/blacklist.txt | 1 +
2 files changed, 60 insertions(+), 11 deletions(-)
diff --git a/tests/i915/gem_exec_big.c b/tests/i915/gem_exec_big.c
index a15672f66..a0e8bf67d 100644
--- a/tests/i915/gem_exec_big.c
+++ b/tests/i915/gem_exec_big.c
@@ -71,7 +71,7 @@ static void exec1(int fd, uint32_t handle, uint64_t reloc_ofs, unsigned flags, c
gem_exec[0].relocs_ptr = to_user_pointer(gem_reloc);
gem_exec[0].alignment = 0;
gem_exec[0].offset = 0;
- gem_exec[0].flags = 0;
+ gem_exec[0].flags = EXEC_OBJECT_SUPPORTS_48B_ADDRESS;
gem_exec[0].rsvd1 = 0;
gem_exec[0].rsvd2 = 0;
@@ -154,12 +154,11 @@ static void execN(int fd, uint32_t handle, uint64_t batch_size, unsigned flags,
gem_exec[0].handle = handle;
gem_exec[0].relocation_count = nreloc;
gem_exec[0].relocs_ptr = to_user_pointer(gem_reloc);
+ gem_exec[0].flags = EXEC_OBJECT_SUPPORTS_48B_ADDRESS;
memset(&execbuf, 0, sizeof(execbuf));
execbuf.buffers_ptr = to_user_pointer(gem_exec);
execbuf.buffer_count = 1;
- execbuf.batch_start_offset = 0;
- execbuf.batch_len = 8;
execbuf.flags = flags;
/* Avoid hitting slowpaths in the reloc processing which might yield a
@@ -197,16 +196,10 @@ static void execN(int fd, uint32_t handle, uint64_t batch_size, unsigned flags,
#undef reloc_ofs
}
-igt_simple_main
+static void exhaustive(int fd)
{
uint32_t batch[2] = {MI_BATCH_BUFFER_END};
uint64_t batch_size, max, ggtt_max, reloc_ofs;
- int fd;
-
- fd = drm_open_driver(DRIVER_INTEL);
- igt_require_gem(fd);
-
- use_64bit_relocs = intel_gen(intel_get_drm_devid(fd)) >= 8;
max = 3 * gem_aperture_size(fd) / 4;
ggtt_max = 3 * gem_global_aperture_size(fd) / 4;
@@ -258,6 +251,61 @@ igt_simple_main
else
batch_size *= 2;
}
+}
+
+static void single(int i915)
+{
+ const uint32_t bbe = MI_BATCH_BUFFER_END;
+ uint64_t batch_size, limit;
+ uint32_t handle;
+ void *ptr;
+
+ batch_size = intel_get_avail_ram_mb() << 20;
+ limit = gem_aperture_size(i915) - (256 << 10); /* low pages reserved */
+ if (!gem_uses_full_ppgtt(i915))
+ limit = 3 * limit / 4;
+
+ batch_size = min(batch_size, limit);
+ batch_size = ALIGN(batch_size, 4096);
+ igt_info("Submitting a %'"PRId64"MiB batch, %saperture size %'"PRId64"MiB\n",
+ batch_size >> 20,
+ gem_uses_full_ppgtt(i915) ? "" : "shared ",
+ gem_aperture_size(i915) >> 20);
+ intel_require_memory(1, batch_size, CHECK_RAM);
+
+ handle = gem_create(i915, batch_size);
+ gem_write(i915, handle, 0, &bbe, sizeof(bbe));
+
+ if (!FORCE_PREAD_PWRITE && gem_has_llc(i915))
+ ptr = __gem_mmap__cpu(i915, handle, 0, batch_size, PROT_READ);
+ else if (!FORCE_PREAD_PWRITE && gem_mmap__has_wc(i915))
+ ptr = __gem_mmap__wc(i915, handle, 0, batch_size, PROT_READ);
+ else
+ ptr = NULL;
+
+ execN(i915, handle, batch_size, 0, ptr);
+
+ if (ptr)
+ munmap(ptr, batch_size);
+}
+
+igt_main
+{
+ int i915 = -1;
+
+ igt_fixture {
+ i915 = drm_open_driver(DRIVER_INTEL);
+ igt_require_gem(i915);
+
+ use_64bit_relocs = intel_gen(intel_get_drm_devid(i915)) >= 8;
+ }
+
+ igt_subtest("single")
+ single(i915);
+
+ igt_subtest("exhaustive")
+ exhaustive(i915);
- close(fd);
+ igt_fixture
+ close(i915);
}
diff --git a/tests/intel-ci/blacklist.txt b/tests/intel-ci/blacklist.txt
index cef0da84a..0e6beeae4 100644
--- a/tests/intel-ci/blacklist.txt
+++ b/tests/intel-ci/blacklist.txt
@@ -28,6 +28,7 @@ igt@gem_ctx_thrash(@.*)?
igt@gem_evict_alignment(@.*)?
igt@gem_evict_everything(@.*)?
igt@gem_exec_alignment@(?!.*single).*
+igt@gem_exec_big@(?!.*single).*
igt@gem_exec_capture@many-(?!4K-).*
igt@gem_exec_fence@(?!.*basic).*
igt@gem_exec_flush@(?!.*basic).*
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 27+ messages in thread
* [igt-dev] [PATCH i-g-t] i915/gem_exec_big: Add a single shot test
@ 2019-02-12 19:55 ` Chris Wilson
0 siblings, 0 replies; 27+ messages in thread
From: Chris Wilson @ 2019-02-12 19:55 UTC (permalink / raw)
To: intel-gfx; +Cc: igt-dev
CI complains that the exhaustive test of trying every size up to the
limit is too slow, so add a simple test that tries to submit one
extreme batch buffer and check all the relocations land.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105555
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
tests/i915/gem_exec_big.c | 70 ++++++++++++++++++++++++++++++------
tests/intel-ci/blacklist.txt | 1 +
2 files changed, 60 insertions(+), 11 deletions(-)
diff --git a/tests/i915/gem_exec_big.c b/tests/i915/gem_exec_big.c
index a15672f66..a0e8bf67d 100644
--- a/tests/i915/gem_exec_big.c
+++ b/tests/i915/gem_exec_big.c
@@ -71,7 +71,7 @@ static void exec1(int fd, uint32_t handle, uint64_t reloc_ofs, unsigned flags, c
gem_exec[0].relocs_ptr = to_user_pointer(gem_reloc);
gem_exec[0].alignment = 0;
gem_exec[0].offset = 0;
- gem_exec[0].flags = 0;
+ gem_exec[0].flags = EXEC_OBJECT_SUPPORTS_48B_ADDRESS;
gem_exec[0].rsvd1 = 0;
gem_exec[0].rsvd2 = 0;
@@ -154,12 +154,11 @@ static void execN(int fd, uint32_t handle, uint64_t batch_size, unsigned flags,
gem_exec[0].handle = handle;
gem_exec[0].relocation_count = nreloc;
gem_exec[0].relocs_ptr = to_user_pointer(gem_reloc);
+ gem_exec[0].flags = EXEC_OBJECT_SUPPORTS_48B_ADDRESS;
memset(&execbuf, 0, sizeof(execbuf));
execbuf.buffers_ptr = to_user_pointer(gem_exec);
execbuf.buffer_count = 1;
- execbuf.batch_start_offset = 0;
- execbuf.batch_len = 8;
execbuf.flags = flags;
/* Avoid hitting slowpaths in the reloc processing which might yield a
@@ -197,16 +196,10 @@ static void execN(int fd, uint32_t handle, uint64_t batch_size, unsigned flags,
#undef reloc_ofs
}
-igt_simple_main
+static void exhaustive(int fd)
{
uint32_t batch[2] = {MI_BATCH_BUFFER_END};
uint64_t batch_size, max, ggtt_max, reloc_ofs;
- int fd;
-
- fd = drm_open_driver(DRIVER_INTEL);
- igt_require_gem(fd);
-
- use_64bit_relocs = intel_gen(intel_get_drm_devid(fd)) >= 8;
max = 3 * gem_aperture_size(fd) / 4;
ggtt_max = 3 * gem_global_aperture_size(fd) / 4;
@@ -258,6 +251,61 @@ igt_simple_main
else
batch_size *= 2;
}
+}
+
+static void single(int i915)
+{
+ const uint32_t bbe = MI_BATCH_BUFFER_END;
+ uint64_t batch_size, limit;
+ uint32_t handle;
+ void *ptr;
+
+ batch_size = intel_get_avail_ram_mb() << 20;
+ limit = gem_aperture_size(i915) - (256 << 10); /* low pages reserved */
+ if (!gem_uses_full_ppgtt(i915))
+ limit = 3 * limit / 4;
+
+ batch_size = min(batch_size, limit);
+ batch_size = ALIGN(batch_size, 4096);
+ igt_info("Submitting a %'"PRId64"MiB batch, %saperture size %'"PRId64"MiB\n",
+ batch_size >> 20,
+ gem_uses_full_ppgtt(i915) ? "" : "shared ",
+ gem_aperture_size(i915) >> 20);
+ intel_require_memory(1, batch_size, CHECK_RAM);
+
+ handle = gem_create(i915, batch_size);
+ gem_write(i915, handle, 0, &bbe, sizeof(bbe));
+
+ if (!FORCE_PREAD_PWRITE && gem_has_llc(i915))
+ ptr = __gem_mmap__cpu(i915, handle, 0, batch_size, PROT_READ);
+ else if (!FORCE_PREAD_PWRITE && gem_mmap__has_wc(i915))
+ ptr = __gem_mmap__wc(i915, handle, 0, batch_size, PROT_READ);
+ else
+ ptr = NULL;
+
+ execN(i915, handle, batch_size, 0, ptr);
+
+ if (ptr)
+ munmap(ptr, batch_size);
+}
+
+igt_main
+{
+ int i915 = -1;
+
+ igt_fixture {
+ i915 = drm_open_driver(DRIVER_INTEL);
+ igt_require_gem(i915);
+
+ use_64bit_relocs = intel_gen(intel_get_drm_devid(i915)) >= 8;
+ }
+
+ igt_subtest("single")
+ single(i915);
+
+ igt_subtest("exhaustive")
+ exhaustive(i915);
- close(fd);
+ igt_fixture
+ close(i915);
}
diff --git a/tests/intel-ci/blacklist.txt b/tests/intel-ci/blacklist.txt
index cef0da84a..0e6beeae4 100644
--- a/tests/intel-ci/blacklist.txt
+++ b/tests/intel-ci/blacklist.txt
@@ -28,6 +28,7 @@ igt@gem_ctx_thrash(@.*)?
igt@gem_evict_alignment(@.*)?
igt@gem_evict_everything(@.*)?
igt@gem_exec_alignment@(?!.*single).*
+igt@gem_exec_big@(?!.*single).*
igt@gem_exec_capture@many-(?!4K-).*
igt@gem_exec_fence@(?!.*basic).*
igt@gem_exec_flush@(?!.*basic).*
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 27+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for i915/gem_exec_big: Add a single shot test
2019-02-12 19:55 ` [igt-dev] " Chris Wilson
(?)
@ 2019-02-12 20:41 ` Patchwork
-1 siblings, 0 replies; 27+ messages in thread
From: Patchwork @ 2019-02-12 20:41 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: i915/gem_exec_big: Add a single shot test
URL : https://patchwork.freedesktop.org/series/56573/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5594 -> IGTPW_2386
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/56573/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2386 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_module_load@reload:
- fi-blb-e6850: PASS -> INCOMPLETE [fdo#107718]
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
- fi-byt-clapper: PASS -> FAIL [fdo#103191] / [fdo#107362]
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b:
- fi-byt-clapper: PASS -> FAIL [fdo#107362]
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s4-devices:
- fi-kbl-7500u: DMESG-WARN [fdo#105128] / [fdo#107139] -> PASS
* igt@i915_selftest@live_workarounds:
- {fi-icl-u3}: INCOMPLETE -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#105128]: https://bugs.freedesktop.org/show_bug.cgi?id=105128
[fdo#107139]: https://bugs.freedesktop.org/show_bug.cgi?id=107139
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#109226]: https://bugs.freedesktop.org/show_bug.cgi?id=109226
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109316]: https://bugs.freedesktop.org/show_bug.cgi?id=109316
[fdo#109567]: https://bugs.freedesktop.org/show_bug.cgi?id=109567
Participating hosts (43 -> 39)
------------------------------
Additional (2): fi-skl-guc fi-icl-u2
Missing (6): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-bdw-samus
Build changes
-------------
* IGT: IGT_4819 -> IGTPW_2386
CI_DRM_5594: 3e893592ec07457b313e045adfb9ae83f2f7198b @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2386: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2386/
IGT_4819: 845c9fb45b734aef95e2fb2317d0c02567e06a68 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Testlist changes ==
+igt@gem_exec_big@exhaustive
+igt@gem_exec_big@single
-igt@gem_exec_big
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2386/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 27+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for i915/gem_exec_big: Add a single shot test
2019-02-12 19:55 ` [igt-dev] " Chris Wilson
(?)
(?)
@ 2019-02-12 22:39 ` Patchwork
-1 siblings, 0 replies; 27+ messages in thread
From: Patchwork @ 2019-02-12 22:39 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: i915/gem_exec_big: Add a single shot test
URL : https://patchwork.freedesktop.org/series/56573/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5594_full -> IGTPW_2386_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/56573/revisions/1/mbox/
New tests
---------
New tests have been introduced between CI_DRM_5594_full and IGTPW_2386_full:
Known issues
------------
Here are the changes found in IGTPW_2386_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-a:
- shard-snb: NOTRUN -> DMESG-WARN [fdo#107956] +1
* igt@kms_ccs@pipe-b-crc-sprite-planes-basic:
- shard-kbl: PASS -> FAIL [fdo#107725] / [fdo#108145]
* igt@kms_content_protection@atomic:
- shard-kbl: NOTRUN -> FAIL [fdo#108597]
* igt@kms_cursor_crc@cursor-128x128-random:
- shard-apl: PASS -> FAIL [fdo#103232] +4
- shard-kbl: PASS -> FAIL [fdo#103232]
* igt@kms_cursor_crc@cursor-128x128-suspend:
- shard-apl: PASS -> FAIL [fdo#103191] / [fdo#103232]
- shard-kbl: PASS -> FAIL [fdo#103191] / [fdo#103232]
* igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic:
- shard-glk: NOTRUN -> FAIL [fdo#105454] / [fdo#106509]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-move:
- shard-kbl: PASS -> FAIL [fdo#103167] +2
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt:
- shard-snb: PASS -> INCOMPLETE [fdo#105411] / [fdo#107469]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
- shard-apl: PASS -> FAIL [fdo#103167] +3
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-cpu:
- shard-glk: PASS -> FAIL [fdo#103167] +5
* igt@kms_plane@pixel-format-pipe-b-planes-source-clamping:
- shard-glk: PASS -> FAIL [fdo#108948]
* igt@kms_plane_alpha_blend@pipe-c-alpha-transparant-fb:
- shard-kbl: NOTRUN -> FAIL [fdo#108145]
* igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
- shard-apl: PASS -> FAIL [fdo#103166] +3
* igt@kms_plane_multiple@atomic-pipe-b-tiling-y:
- shard-glk: PASS -> FAIL [fdo#103166] +1
- shard-kbl: PASS -> FAIL [fdo#103166]
#### Possible fixes ####
* igt@gem_ctx_isolation@rcs0-s3:
- shard-kbl: INCOMPLETE [fdo#103665] -> PASS
- shard-snb: FAIL [fdo#103375] -> PASS
* igt@gem_eio@reset-stress:
- shard-snb: FAIL [fdo#107799] -> PASS
* igt@gem_softpin@noreloc-s3:
- shard-snb: INCOMPLETE [fdo#105411] -> PASS
* igt@gem_tiled_wc:
- shard-apl: INCOMPLETE [fdo#103927] -> PASS
* igt@kms_cursor_crc@cursor-256x256-suspend:
- shard-apl: FAIL [fdo#103191] / [fdo#103232] -> PASS
* igt@kms_cursor_crc@cursor-64x64-sliding:
- shard-apl: FAIL [fdo#103232] -> PASS +2
- shard-kbl: FAIL [fdo#103232] -> PASS +1
* igt@kms_cursor_crc@cursor-size-change:
- shard-glk: FAIL [fdo#103232] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render:
- shard-apl: FAIL [fdo#103167] -> PASS +1
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff:
- shard-glk: FAIL [fdo#103167] -> PASS
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-glk: INCOMPLETE [fdo#103359] / [k.org#198133] -> PASS
* igt@kms_plane_multiple@atomic-pipe-b-tiling-none:
- shard-glk: FAIL [fdo#103166] -> PASS +4
* igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
- shard-apl: FAIL [fdo#103166] -> PASS
* igt@kms_setmode@basic:
- shard-apl: FAIL [fdo#99912] -> PASS
* igt@perf_pmu@rc6-runtime-pm-long:
- shard-glk: FAIL [fdo#105010] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#105010]: https://bugs.freedesktop.org/show_bug.cgi?id=105010
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#105454]: https://bugs.freedesktop.org/show_bug.cgi?id=105454
[fdo#106509]: https://bugs.freedesktop.org/show_bug.cgi?id=106509
[fdo#107469]: https://bugs.freedesktop.org/show_bug.cgi?id=107469
[fdo#107725]: https://bugs.freedesktop.org/show_bug.cgi?id=107725
[fdo#107799]: https://bugs.freedesktop.org/show_bug.cgi?id=107799
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108597]: https://bugs.freedesktop.org/show_bug.cgi?id=108597
[fdo#108948]: https://bugs.freedesktop.org/show_bug.cgi?id=108948
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (7 -> 5)
------------------------------
Missing (2): shard-skl shard-iclb
Build changes
-------------
* IGT: IGT_4819 -> IGTPW_2386
* Piglit: piglit_4509 -> None
CI_DRM_5594: 3e893592ec07457b313e045adfb9ae83f2f7198b @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2386: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2386/
IGT_4819: 845c9fb45b734aef95e2fb2317d0c02567e06a68 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2386/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH i-g-t] i915/gem_exec_big: Add a single shot test
2019-02-12 19:55 ` [igt-dev] " Chris Wilson
@ 2019-02-12 22:43 ` Chris Wilson
-1 siblings, 0 replies; 27+ messages in thread
From: Chris Wilson @ 2019-02-12 22:43 UTC (permalink / raw)
To: intel-gfx; +Cc: igt-dev
CI complains that the exhaustive test of trying every size up to the
limit is too slow, so add a simple test that tries to submit one
extreme batch buffer and check all the relocations land.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105555
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
tests/i915/gem_exec_big.c | 70 ++++++++++++++++++++++++++++++------
tests/intel-ci/blacklist.txt | 1 +
2 files changed, 60 insertions(+), 11 deletions(-)
diff --git a/tests/i915/gem_exec_big.c b/tests/i915/gem_exec_big.c
index a15672f66..6d7041cf4 100644
--- a/tests/i915/gem_exec_big.c
+++ b/tests/i915/gem_exec_big.c
@@ -71,7 +71,7 @@ static void exec1(int fd, uint32_t handle, uint64_t reloc_ofs, unsigned flags, c
gem_exec[0].relocs_ptr = to_user_pointer(gem_reloc);
gem_exec[0].alignment = 0;
gem_exec[0].offset = 0;
- gem_exec[0].flags = 0;
+ gem_exec[0].flags = EXEC_OBJECT_SUPPORTS_48B_ADDRESS;
gem_exec[0].rsvd1 = 0;
gem_exec[0].rsvd2 = 0;
@@ -154,12 +154,11 @@ static void execN(int fd, uint32_t handle, uint64_t batch_size, unsigned flags,
gem_exec[0].handle = handle;
gem_exec[0].relocation_count = nreloc;
gem_exec[0].relocs_ptr = to_user_pointer(gem_reloc);
+ gem_exec[0].flags = EXEC_OBJECT_SUPPORTS_48B_ADDRESS;
memset(&execbuf, 0, sizeof(execbuf));
execbuf.buffers_ptr = to_user_pointer(gem_exec);
execbuf.buffer_count = 1;
- execbuf.batch_start_offset = 0;
- execbuf.batch_len = 8;
execbuf.flags = flags;
/* Avoid hitting slowpaths in the reloc processing which might yield a
@@ -197,16 +196,10 @@ static void execN(int fd, uint32_t handle, uint64_t batch_size, unsigned flags,
#undef reloc_ofs
}
-igt_simple_main
+static void exhaustive(int fd)
{
uint32_t batch[2] = {MI_BATCH_BUFFER_END};
uint64_t batch_size, max, ggtt_max, reloc_ofs;
- int fd;
-
- fd = drm_open_driver(DRIVER_INTEL);
- igt_require_gem(fd);
-
- use_64bit_relocs = intel_gen(intel_get_drm_devid(fd)) >= 8;
max = 3 * gem_aperture_size(fd) / 4;
ggtt_max = 3 * gem_global_aperture_size(fd) / 4;
@@ -258,6 +251,61 @@ igt_simple_main
else
batch_size *= 2;
}
+}
+
+static void single(int i915)
+{
+ const uint32_t bbe = MI_BATCH_BUFFER_END;
+ uint64_t batch_size, limit;
+ uint32_t handle;
+ void *ptr;
+
+ batch_size = (intel_get_avail_ram_mb() - 4) << 20; /* internal slack */
+ limit = gem_aperture_size(i915) - (256 << 10); /* low pages reserved */
+ if (!gem_uses_full_ppgtt(i915))
+ limit = 3 * limit / 4;
+
+ batch_size = min(batch_size, limit);
+ batch_size = ALIGN(batch_size, 4096);
+ igt_info("Submitting a %'"PRId64"MiB batch, %saperture size %'"PRId64"MiB\n",
+ batch_size >> 20,
+ gem_uses_full_ppgtt(i915) ? "" : "shared ",
+ gem_aperture_size(i915) >> 20);
+ intel_require_memory(1, batch_size, CHECK_RAM);
+
+ handle = gem_create(i915, batch_size);
+ gem_write(i915, handle, 0, &bbe, sizeof(bbe));
+
+ if (!FORCE_PREAD_PWRITE && gem_has_llc(i915))
+ ptr = __gem_mmap__cpu(i915, handle, 0, batch_size, PROT_READ);
+ else if (!FORCE_PREAD_PWRITE && gem_mmap__has_wc(i915))
+ ptr = __gem_mmap__wc(i915, handle, 0, batch_size, PROT_READ);
+ else
+ ptr = NULL;
+
+ execN(i915, handle, batch_size, 0, ptr);
+
+ if (ptr)
+ munmap(ptr, batch_size);
+}
+
+igt_main
+{
+ int i915 = -1;
+
+ igt_fixture {
+ i915 = drm_open_driver(DRIVER_INTEL);
+ igt_require_gem(i915);
+
+ use_64bit_relocs = intel_gen(intel_get_drm_devid(i915)) >= 8;
+ }
+
+ igt_subtest("single")
+ single(i915);
+
+ igt_subtest("exhaustive")
+ exhaustive(i915);
- close(fd);
+ igt_fixture
+ close(i915);
}
diff --git a/tests/intel-ci/blacklist.txt b/tests/intel-ci/blacklist.txt
index cef0da84a..0e6beeae4 100644
--- a/tests/intel-ci/blacklist.txt
+++ b/tests/intel-ci/blacklist.txt
@@ -28,6 +28,7 @@ igt@gem_ctx_thrash(@.*)?
igt@gem_evict_alignment(@.*)?
igt@gem_evict_everything(@.*)?
igt@gem_exec_alignment@(?!.*single).*
+igt@gem_exec_big@(?!.*single).*
igt@gem_exec_capture@many-(?!4K-).*
igt@gem_exec_fence@(?!.*basic).*
igt@gem_exec_flush@(?!.*basic).*
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 27+ messages in thread
* [igt-dev] [PATCH i-g-t] i915/gem_exec_big: Add a single shot test
@ 2019-02-12 22:43 ` Chris Wilson
0 siblings, 0 replies; 27+ messages in thread
From: Chris Wilson @ 2019-02-12 22:43 UTC (permalink / raw)
To: intel-gfx; +Cc: igt-dev
CI complains that the exhaustive test of trying every size up to the
limit is too slow, so add a simple test that tries to submit one
extreme batch buffer and check all the relocations land.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105555
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
tests/i915/gem_exec_big.c | 70 ++++++++++++++++++++++++++++++------
tests/intel-ci/blacklist.txt | 1 +
2 files changed, 60 insertions(+), 11 deletions(-)
diff --git a/tests/i915/gem_exec_big.c b/tests/i915/gem_exec_big.c
index a15672f66..6d7041cf4 100644
--- a/tests/i915/gem_exec_big.c
+++ b/tests/i915/gem_exec_big.c
@@ -71,7 +71,7 @@ static void exec1(int fd, uint32_t handle, uint64_t reloc_ofs, unsigned flags, c
gem_exec[0].relocs_ptr = to_user_pointer(gem_reloc);
gem_exec[0].alignment = 0;
gem_exec[0].offset = 0;
- gem_exec[0].flags = 0;
+ gem_exec[0].flags = EXEC_OBJECT_SUPPORTS_48B_ADDRESS;
gem_exec[0].rsvd1 = 0;
gem_exec[0].rsvd2 = 0;
@@ -154,12 +154,11 @@ static void execN(int fd, uint32_t handle, uint64_t batch_size, unsigned flags,
gem_exec[0].handle = handle;
gem_exec[0].relocation_count = nreloc;
gem_exec[0].relocs_ptr = to_user_pointer(gem_reloc);
+ gem_exec[0].flags = EXEC_OBJECT_SUPPORTS_48B_ADDRESS;
memset(&execbuf, 0, sizeof(execbuf));
execbuf.buffers_ptr = to_user_pointer(gem_exec);
execbuf.buffer_count = 1;
- execbuf.batch_start_offset = 0;
- execbuf.batch_len = 8;
execbuf.flags = flags;
/* Avoid hitting slowpaths in the reloc processing which might yield a
@@ -197,16 +196,10 @@ static void execN(int fd, uint32_t handle, uint64_t batch_size, unsigned flags,
#undef reloc_ofs
}
-igt_simple_main
+static void exhaustive(int fd)
{
uint32_t batch[2] = {MI_BATCH_BUFFER_END};
uint64_t batch_size, max, ggtt_max, reloc_ofs;
- int fd;
-
- fd = drm_open_driver(DRIVER_INTEL);
- igt_require_gem(fd);
-
- use_64bit_relocs = intel_gen(intel_get_drm_devid(fd)) >= 8;
max = 3 * gem_aperture_size(fd) / 4;
ggtt_max = 3 * gem_global_aperture_size(fd) / 4;
@@ -258,6 +251,61 @@ igt_simple_main
else
batch_size *= 2;
}
+}
+
+static void single(int i915)
+{
+ const uint32_t bbe = MI_BATCH_BUFFER_END;
+ uint64_t batch_size, limit;
+ uint32_t handle;
+ void *ptr;
+
+ batch_size = (intel_get_avail_ram_mb() - 4) << 20; /* internal slack */
+ limit = gem_aperture_size(i915) - (256 << 10); /* low pages reserved */
+ if (!gem_uses_full_ppgtt(i915))
+ limit = 3 * limit / 4;
+
+ batch_size = min(batch_size, limit);
+ batch_size = ALIGN(batch_size, 4096);
+ igt_info("Submitting a %'"PRId64"MiB batch, %saperture size %'"PRId64"MiB\n",
+ batch_size >> 20,
+ gem_uses_full_ppgtt(i915) ? "" : "shared ",
+ gem_aperture_size(i915) >> 20);
+ intel_require_memory(1, batch_size, CHECK_RAM);
+
+ handle = gem_create(i915, batch_size);
+ gem_write(i915, handle, 0, &bbe, sizeof(bbe));
+
+ if (!FORCE_PREAD_PWRITE && gem_has_llc(i915))
+ ptr = __gem_mmap__cpu(i915, handle, 0, batch_size, PROT_READ);
+ else if (!FORCE_PREAD_PWRITE && gem_mmap__has_wc(i915))
+ ptr = __gem_mmap__wc(i915, handle, 0, batch_size, PROT_READ);
+ else
+ ptr = NULL;
+
+ execN(i915, handle, batch_size, 0, ptr);
+
+ if (ptr)
+ munmap(ptr, batch_size);
+}
+
+igt_main
+{
+ int i915 = -1;
+
+ igt_fixture {
+ i915 = drm_open_driver(DRIVER_INTEL);
+ igt_require_gem(i915);
+
+ use_64bit_relocs = intel_gen(intel_get_drm_devid(i915)) >= 8;
+ }
+
+ igt_subtest("single")
+ single(i915);
+
+ igt_subtest("exhaustive")
+ exhaustive(i915);
- close(fd);
+ igt_fixture
+ close(i915);
}
diff --git a/tests/intel-ci/blacklist.txt b/tests/intel-ci/blacklist.txt
index cef0da84a..0e6beeae4 100644
--- a/tests/intel-ci/blacklist.txt
+++ b/tests/intel-ci/blacklist.txt
@@ -28,6 +28,7 @@ igt@gem_ctx_thrash(@.*)?
igt@gem_evict_alignment(@.*)?
igt@gem_evict_everything(@.*)?
igt@gem_exec_alignment@(?!.*single).*
+igt@gem_exec_big@(?!.*single).*
igt@gem_exec_capture@many-(?!4K-).*
igt@gem_exec_fence@(?!.*basic).*
igt@gem_exec_flush@(?!.*basic).*
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 27+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for i915/gem_exec_big: Add a single shot test (rev2)
2019-02-12 19:55 ` [igt-dev] " Chris Wilson
` (3 preceding siblings ...)
(?)
@ 2019-02-12 23:33 ` Patchwork
-1 siblings, 0 replies; 27+ messages in thread
From: Patchwork @ 2019-02-12 23:33 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: i915/gem_exec_big: Add a single shot test (rev2)
URL : https://patchwork.freedesktop.org/series/56573/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5595 -> IGTPW_2388
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/56573/revisions/2/mbox/
Known issues
------------
Here are the changes found in IGTPW_2388 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live_coherency:
- fi-gdg-551: PASS -> DMESG-FAIL [fdo#107164]
* igt@kms_pipe_crc_basic@read-crc-pipe-a:
- fi-byt-clapper: PASS -> FAIL [fdo#107362]
#### Possible fixes ####
* igt@i915_selftest@live_hangcheck:
- {fi-icl-y}: INCOMPLETE [fdo#108569] -> PASS
* igt@i915_selftest@live_workarounds:
- {fi-icl-u3}: INCOMPLETE -> PASS
* igt@kms_pipe_crc_basic@hang-read-crc-pipe-b:
- fi-byt-clapper: FAIL [fdo#103191] / [fdo#107362] -> PASS
* igt@prime_vgem@basic-fence-flip:
- fi-gdg-551: DMESG-FAIL [fdo#103182] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#107164]: https://bugs.freedesktop.org/show_bug.cgi?id=107164
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
Participating hosts (44 -> 39)
------------------------------
Missing (5): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-bdw-samus
Build changes
-------------
* IGT: IGT_4819 -> IGTPW_2388
CI_DRM_5595: 159160c4276fdbf738e5c19549f07e0c7f0f27a8 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2388: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2388/
IGT_4819: 845c9fb45b734aef95e2fb2317d0c02567e06a68 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Testlist changes ==
+igt@gem_exec_big@exhaustive
+igt@gem_exec_big@single
-igt@gem_exec_big
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2388/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 27+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for i915/gem_exec_big: Add a single shot test (rev2)
2019-02-12 19:55 ` [igt-dev] " Chris Wilson
` (4 preceding siblings ...)
(?)
@ 2019-02-13 0:45 ` Patchwork
-1 siblings, 0 replies; 27+ messages in thread
From: Patchwork @ 2019-02-13 0:45 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: i915/gem_exec_big: Add a single shot test (rev2)
URL : https://patchwork.freedesktop.org/series/56573/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5595_full -> IGTPW_2388_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/56573/revisions/2/mbox/
New tests
---------
New tests have been introduced between CI_DRM_5595_full and IGTPW_2388_full:
Known issues
------------
Here are the changes found in IGTPW_2388_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_eio@reset-stress:
- shard-snb: PASS -> FAIL [fdo#107799]
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-a:
- shard-glk: NOTRUN -> DMESG-WARN [fdo#107956]
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
- shard-apl: PASS -> FAIL [fdo#106510] / [fdo#108145]
* igt@kms_color@pipe-b-ctm-max:
- shard-apl: PASS -> FAIL [fdo#108147]
* igt@kms_color@pipe-b-legacy-gamma:
- shard-apl: PASS -> FAIL [fdo#104782]
* igt@kms_cursor_crc@cursor-64x21-random:
- shard-apl: PASS -> FAIL [fdo#103232] +4
* igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic:
- shard-glk: NOTRUN -> FAIL [fdo#105454] / [fdo#106509]
* igt@kms_cursor_legacy@pipe-b-torture-move:
- shard-snb: PASS -> DMESG-WARN [fdo#107122]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt:
- shard-apl: PASS -> FAIL [fdo#103167] +3
- shard-glk: PASS -> FAIL [fdo#103167] +5
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
- shard-glk: NOTRUN -> FAIL [fdo#103167]
* igt@kms_frontbuffer_tracking@fbc-1p-rte:
- shard-apl: PASS -> FAIL [fdo#103167] / [fdo#105682]
* igt@kms_plane@pixel-format-pipe-b-planes-source-clamping:
- shard-apl: PASS -> FAIL [fdo#108948]
- shard-glk: PASS -> FAIL [fdo#108948]
* igt@kms_plane@plane-position-covered-pipe-c-planes:
- shard-apl: PASS -> FAIL [fdo#103166] +4
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
- shard-glk: PASS -> FAIL [fdo#108145] +2
* igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend:
- shard-snb: PASS -> INCOMPLETE [fdo#105411]
#### Possible fixes ####
* igt@gem_eio@unwedge-stress:
- shard-snb: FAIL [fdo#107799] -> PASS
* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-a:
- shard-apl: DMESG-WARN [fdo#107956] -> PASS
* igt@kms_ccs@pipe-b-crc-sprite-planes-basic:
- shard-glk: FAIL [fdo#108145] -> PASS
* igt@kms_cursor_crc@cursor-64x64-sliding:
- shard-apl: FAIL [fdo#103232] -> PASS +3
* igt@kms_flip@flip-vs-expired-vblank:
- shard-glk: FAIL [fdo#105363] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-onoff:
- shard-apl: FAIL [fdo#103167] -> PASS
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff:
- shard-glk: FAIL [fdo#103167] -> PASS +1
* igt@kms_plane@pixel-format-pipe-a-planes-source-clamping:
- shard-glk: FAIL [fdo#108948] -> PASS
- shard-apl: FAIL [fdo#108948] -> PASS
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-glk: INCOMPLETE [fdo#103359] / [k.org#198133] -> PASS
* igt@kms_plane@plane-position-covered-pipe-b-planes:
- shard-glk: FAIL [fdo#103166] -> PASS +1
* igt@kms_plane_multiple@atomic-pipe-c-tiling-none:
- shard-apl: FAIL [fdo#103166] -> PASS
* igt@perf_pmu@rc6-runtime-pm-long:
- shard-apl: FAIL [fdo#105010] -> PASS
- shard-glk: FAIL [fdo#105010] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
[fdo#105010]: https://bugs.freedesktop.org/show_bug.cgi?id=105010
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#105454]: https://bugs.freedesktop.org/show_bug.cgi?id=105454
[fdo#105682]: https://bugs.freedesktop.org/show_bug.cgi?id=105682
[fdo#106509]: https://bugs.freedesktop.org/show_bug.cgi?id=106509
[fdo#106510]: https://bugs.freedesktop.org/show_bug.cgi?id=106510
[fdo#107122]: https://bugs.freedesktop.org/show_bug.cgi?id=107122
[fdo#107799]: https://bugs.freedesktop.org/show_bug.cgi?id=107799
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147
[fdo#108948]: https://bugs.freedesktop.org/show_bug.cgi?id=108948
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (6 -> 4)
------------------------------
Missing (2): shard-skl shard-iclb
Build changes
-------------
* IGT: IGT_4819 -> IGTPW_2388
* Piglit: piglit_4509 -> None
CI_DRM_5595: 159160c4276fdbf738e5c19549f07e0c7f0f27a8 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2388: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2388/
IGT_4819: 845c9fb45b734aef95e2fb2317d0c02567e06a68 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2388/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH i-g-t] i915/gem_exec_big: Add a single shot test
2019-02-12 19:55 ` [igt-dev] " Chris Wilson
` (5 preceding siblings ...)
(?)
@ 2019-02-13 8:58 ` Chris Wilson
-1 siblings, 0 replies; 27+ messages in thread
From: Chris Wilson @ 2019-02-13 8:58 UTC (permalink / raw)
To: intel-gfx; +Cc: dri-devel
CI complains that the exhaustive test of trying every size up to the
limit is too slow, so add a simple test that tries to submit one
extreme batch buffer and check all the relocations land.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105555
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
tests/i915/gem_exec_big.c | 70 ++++++++++++++++++++++++++++++------
tests/intel-ci/blacklist.txt | 1 +
2 files changed, 60 insertions(+), 11 deletions(-)
diff --git a/tests/i915/gem_exec_big.c b/tests/i915/gem_exec_big.c
index a15672f66..492a19cb9 100644
--- a/tests/i915/gem_exec_big.c
+++ b/tests/i915/gem_exec_big.c
@@ -71,7 +71,7 @@ static void exec1(int fd, uint32_t handle, uint64_t reloc_ofs, unsigned flags, c
gem_exec[0].relocs_ptr = to_user_pointer(gem_reloc);
gem_exec[0].alignment = 0;
gem_exec[0].offset = 0;
- gem_exec[0].flags = 0;
+ gem_exec[0].flags = EXEC_OBJECT_SUPPORTS_48B_ADDRESS;
gem_exec[0].rsvd1 = 0;
gem_exec[0].rsvd2 = 0;
@@ -154,12 +154,11 @@ static void execN(int fd, uint32_t handle, uint64_t batch_size, unsigned flags,
gem_exec[0].handle = handle;
gem_exec[0].relocation_count = nreloc;
gem_exec[0].relocs_ptr = to_user_pointer(gem_reloc);
+ gem_exec[0].flags = EXEC_OBJECT_SUPPORTS_48B_ADDRESS;
memset(&execbuf, 0, sizeof(execbuf));
execbuf.buffers_ptr = to_user_pointer(gem_exec);
execbuf.buffer_count = 1;
- execbuf.batch_start_offset = 0;
- execbuf.batch_len = 8;
execbuf.flags = flags;
/* Avoid hitting slowpaths in the reloc processing which might yield a
@@ -197,16 +196,10 @@ static void execN(int fd, uint32_t handle, uint64_t batch_size, unsigned flags,
#undef reloc_ofs
}
-igt_simple_main
+static void exhaustive(int fd)
{
uint32_t batch[2] = {MI_BATCH_BUFFER_END};
uint64_t batch_size, max, ggtt_max, reloc_ofs;
- int fd;
-
- fd = drm_open_driver(DRIVER_INTEL);
- igt_require_gem(fd);
-
- use_64bit_relocs = intel_gen(intel_get_drm_devid(fd)) >= 8;
max = 3 * gem_aperture_size(fd) / 4;
ggtt_max = 3 * gem_global_aperture_size(fd) / 4;
@@ -258,6 +251,61 @@ igt_simple_main
else
batch_size *= 2;
}
+}
+
+static void single(int i915)
+{
+ const uint32_t bbe = MI_BATCH_BUFFER_END;
+ uint64_t batch_size, limit;
+ uint32_t handle;
+ void *ptr;
+
+ batch_size = (intel_get_avail_ram_mb() - 64) << 20; /* internal slack */
+ limit = gem_aperture_size(i915) - (256 << 10); /* low pages reserved */
+ if (!gem_uses_full_ppgtt(i915))
+ limit = 3 * limit / 4;
+
+ batch_size = min(batch_size, limit);
+ batch_size = ALIGN(batch_size, 4096);
+ igt_info("Submitting a %'"PRId64"MiB batch, %saperture size %'"PRId64"MiB\n",
+ batch_size >> 20,
+ gem_uses_full_ppgtt(i915) ? "" : "shared ",
+ gem_aperture_size(i915) >> 20);
+ intel_require_memory(1, batch_size, CHECK_RAM);
+
+ handle = gem_create(i915, batch_size);
+ gem_write(i915, handle, 0, &bbe, sizeof(bbe));
+
+ if (!FORCE_PREAD_PWRITE && gem_has_llc(i915))
+ ptr = __gem_mmap__cpu(i915, handle, 0, batch_size, PROT_READ);
+ else if (!FORCE_PREAD_PWRITE && gem_mmap__has_wc(i915))
+ ptr = __gem_mmap__wc(i915, handle, 0, batch_size, PROT_READ);
+ else
+ ptr = NULL;
+
+ execN(i915, handle, batch_size, 0, ptr);
+
+ if (ptr)
+ munmap(ptr, batch_size);
+}
+
+igt_main
+{
+ int i915 = -1;
+
+ igt_fixture {
+ i915 = drm_open_driver(DRIVER_INTEL);
+ igt_require_gem(i915);
+
+ use_64bit_relocs = intel_gen(intel_get_drm_devid(i915)) >= 8;
+ }
+
+ igt_subtest("single")
+ single(i915);
+
+ igt_subtest("exhaustive")
+ exhaustive(i915);
- close(fd);
+ igt_fixture
+ close(i915);
}
diff --git a/tests/intel-ci/blacklist.txt b/tests/intel-ci/blacklist.txt
index cef0da84a..0e6beeae4 100644
--- a/tests/intel-ci/blacklist.txt
+++ b/tests/intel-ci/blacklist.txt
@@ -28,6 +28,7 @@ igt@gem_ctx_thrash(@.*)?
igt@gem_evict_alignment(@.*)?
igt@gem_evict_everything(@.*)?
igt@gem_exec_alignment@(?!.*single).*
+igt@gem_exec_big@(?!.*single).*
igt@gem_exec_capture@many-(?!4K-).*
igt@gem_exec_fence@(?!.*basic).*
igt@gem_exec_flush@(?!.*basic).*
--
2.20.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 27+ messages in thread
* ✓ Fi.CI.BAT: success for i915/gem_exec_big: Add a single shot test
2019-02-12 19:55 ` [igt-dev] " Chris Wilson
` (6 preceding siblings ...)
(?)
@ 2019-02-13 9:28 ` Patchwork
-1 siblings, 0 replies; 27+ messages in thread
From: Patchwork @ 2019-02-13 9:28 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: i915/gem_exec_big: Add a single shot test
URL : https://patchwork.freedesktop.org/series/56595/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5596 -> IGTPW_2390
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/56595/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2390 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_busy@basic-flip-a:
- fi-gdg-551: NOTRUN -> FAIL [fdo#103182] +1
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: PASS -> FAIL [fdo#109485]
#### Possible fixes ####
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
- fi-byt-clapper: FAIL [fdo#103191] / [fdo#107362] -> PASS
* igt@prime_vgem@basic-fence-flip:
- fi-skl-6700k2: FAIL [fdo#104008] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#104008]: https://bugs.freedesktop.org/show_bug.cgi?id=104008
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109485]: https://bugs.freedesktop.org/show_bug.cgi?id=109485
Participating hosts (40 -> 39)
------------------------------
Additional (3): fi-gdg-551 fi-apl-guc fi-pnv-d510
Missing (4): fi-kbl-soraka fi-ilk-m540 fi-byt-squawks fi-bsw-cyan
Build changes
-------------
* IGT: IGT_4820 -> IGTPW_2390
CI_DRM_5596: aaaccba122fe89ef87706ae2642dc3e3b0d256e6 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2390: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2390/
IGT_4820: 368237db1149033d8274248489ffec671ea1f7d8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Testlist changes ==
+igt@gem_exec_big@exhaustive
+igt@gem_exec_big@single
-igt@gem_exec_big
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2390/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] i915/gem_exec_big: Add a single shot test
2019-02-12 22:43 ` [igt-dev] " Chris Wilson
@ 2019-02-13 10:11 ` Daniel Vetter
-1 siblings, 0 replies; 27+ messages in thread
From: Daniel Vetter @ 2019-02-13 10:11 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev, intel-gfx
On Tue, Feb 12, 2019 at 10:43:41PM +0000, Chris Wilson wrote:
> CI complains that the exhaustive test of trying every size up to the
> limit is too slow, so add a simple test that tries to submit one
> extreme batch buffer and check all the relocations land.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105555
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> tests/i915/gem_exec_big.c | 70 ++++++++++++++++++++++++++++++------
> tests/intel-ci/blacklist.txt | 1 +
> 2 files changed, 60 insertions(+), 11 deletions(-)
>
> diff --git a/tests/i915/gem_exec_big.c b/tests/i915/gem_exec_big.c
> index a15672f66..6d7041cf4 100644
> --- a/tests/i915/gem_exec_big.c
> +++ b/tests/i915/gem_exec_big.c
> @@ -71,7 +71,7 @@ static void exec1(int fd, uint32_t handle, uint64_t reloc_ofs, unsigned flags, c
> gem_exec[0].relocs_ptr = to_user_pointer(gem_reloc);
> gem_exec[0].alignment = 0;
> gem_exec[0].offset = 0;
> - gem_exec[0].flags = 0;
> + gem_exec[0].flags = EXEC_OBJECT_SUPPORTS_48B_ADDRESS;
> gem_exec[0].rsvd1 = 0;
> gem_exec[0].rsvd2 = 0;
>
> @@ -154,12 +154,11 @@ static void execN(int fd, uint32_t handle, uint64_t batch_size, unsigned flags,
> gem_exec[0].handle = handle;
> gem_exec[0].relocation_count = nreloc;
> gem_exec[0].relocs_ptr = to_user_pointer(gem_reloc);
> + gem_exec[0].flags = EXEC_OBJECT_SUPPORTS_48B_ADDRESS;
>
> memset(&execbuf, 0, sizeof(execbuf));
> execbuf.buffers_ptr = to_user_pointer(gem_exec);
> execbuf.buffer_count = 1;
> - execbuf.batch_start_offset = 0;
> - execbuf.batch_len = 8;
> execbuf.flags = flags;
>
> /* Avoid hitting slowpaths in the reloc processing which might yield a
> @@ -197,16 +196,10 @@ static void execN(int fd, uint32_t handle, uint64_t batch_size, unsigned flags,
> #undef reloc_ofs
> }
>
> -igt_simple_main
> +static void exhaustive(int fd)
> {
> uint32_t batch[2] = {MI_BATCH_BUFFER_END};
> uint64_t batch_size, max, ggtt_max, reloc_ofs;
> - int fd;
> -
> - fd = drm_open_driver(DRIVER_INTEL);
> - igt_require_gem(fd);
> -
> - use_64bit_relocs = intel_gen(intel_get_drm_devid(fd)) >= 8;
>
> max = 3 * gem_aperture_size(fd) / 4;
> ggtt_max = 3 * gem_global_aperture_size(fd) / 4;
> @@ -258,6 +251,61 @@ igt_simple_main
> else
> batch_size *= 2;
> }
> +}
> +
> +static void single(int i915)
> +{
> + const uint32_t bbe = MI_BATCH_BUFFER_END;
> + uint64_t batch_size, limit;
> + uint32_t handle;
> + void *ptr;
> +
> + batch_size = (intel_get_avail_ram_mb() - 4) << 20; /* internal slack */
> + limit = gem_aperture_size(i915) - (256 << 10); /* low pages reserved */
> + if (!gem_uses_full_ppgtt(i915))
> + limit = 3 * limit / 4;
> +
> + batch_size = min(batch_size, limit);
> + batch_size = ALIGN(batch_size, 4096);
> + igt_info("Submitting a %'"PRId64"MiB batch, %saperture size %'"PRId64"MiB\n",
> + batch_size >> 20,
> + gem_uses_full_ppgtt(i915) ? "" : "shared ",
> + gem_aperture_size(i915) >> 20);
> + intel_require_memory(1, batch_size, CHECK_RAM);
> +
> + handle = gem_create(i915, batch_size);
> + gem_write(i915, handle, 0, &bbe, sizeof(bbe));
> +
> + if (!FORCE_PREAD_PWRITE && gem_has_llc(i915))
> + ptr = __gem_mmap__cpu(i915, handle, 0, batch_size, PROT_READ);
> + else if (!FORCE_PREAD_PWRITE && gem_mmap__has_wc(i915))
> + ptr = __gem_mmap__wc(i915, handle, 0, batch_size, PROT_READ);
> + else
> + ptr = NULL;
> +
> + execN(i915, handle, batch_size, 0, ptr);
> +
> + if (ptr)
> + munmap(ptr, batch_size);
> +}
> +
> +igt_main
> +{
> + int i915 = -1;
> +
> + igt_fixture {
> + i915 = drm_open_driver(DRIVER_INTEL);
> + igt_require_gem(i915);
> +
> + use_64bit_relocs = intel_gen(intel_get_drm_devid(i915)) >= 8;
> + }
> +
> + igt_subtest("single")
> + single(i915);
> +
> + igt_subtest("exhaustive")
> + exhaustive(i915);
Do we still need this one? CI time isn't an endless resource (as much as
we'd want to), neither is our ability to maintain everything. And if all
we get is timeouts in CI I think there's better uses for that machine
time. And we do use all the CI machine time, so anytime you take away 10
minutes, it's 10 minutes of not running some other testcase.
-Daniel
>
> - close(fd);
> + igt_fixture
> + close(i915);
> }
> diff --git a/tests/intel-ci/blacklist.txt b/tests/intel-ci/blacklist.txt
> index cef0da84a..0e6beeae4 100644
> --- a/tests/intel-ci/blacklist.txt
> +++ b/tests/intel-ci/blacklist.txt
> @@ -28,6 +28,7 @@ igt@gem_ctx_thrash(@.*)?
> igt@gem_evict_alignment(@.*)?
> igt@gem_evict_everything(@.*)?
> igt@gem_exec_alignment@(?!.*single).*
> +igt@gem_exec_big@(?!.*single).*
> igt@gem_exec_capture@many-(?!4K-).*
> igt@gem_exec_fence@(?!.*basic).*
> igt@gem_exec_flush@(?!.*basic).*
> --
> 2.20.1
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] i915/gem_exec_big: Add a single shot test
@ 2019-02-13 10:11 ` Daniel Vetter
0 siblings, 0 replies; 27+ messages in thread
From: Daniel Vetter @ 2019-02-13 10:11 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev, intel-gfx
On Tue, Feb 12, 2019 at 10:43:41PM +0000, Chris Wilson wrote:
> CI complains that the exhaustive test of trying every size up to the
> limit is too slow, so add a simple test that tries to submit one
> extreme batch buffer and check all the relocations land.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105555
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> tests/i915/gem_exec_big.c | 70 ++++++++++++++++++++++++++++++------
> tests/intel-ci/blacklist.txt | 1 +
> 2 files changed, 60 insertions(+), 11 deletions(-)
>
> diff --git a/tests/i915/gem_exec_big.c b/tests/i915/gem_exec_big.c
> index a15672f66..6d7041cf4 100644
> --- a/tests/i915/gem_exec_big.c
> +++ b/tests/i915/gem_exec_big.c
> @@ -71,7 +71,7 @@ static void exec1(int fd, uint32_t handle, uint64_t reloc_ofs, unsigned flags, c
> gem_exec[0].relocs_ptr = to_user_pointer(gem_reloc);
> gem_exec[0].alignment = 0;
> gem_exec[0].offset = 0;
> - gem_exec[0].flags = 0;
> + gem_exec[0].flags = EXEC_OBJECT_SUPPORTS_48B_ADDRESS;
> gem_exec[0].rsvd1 = 0;
> gem_exec[0].rsvd2 = 0;
>
> @@ -154,12 +154,11 @@ static void execN(int fd, uint32_t handle, uint64_t batch_size, unsigned flags,
> gem_exec[0].handle = handle;
> gem_exec[0].relocation_count = nreloc;
> gem_exec[0].relocs_ptr = to_user_pointer(gem_reloc);
> + gem_exec[0].flags = EXEC_OBJECT_SUPPORTS_48B_ADDRESS;
>
> memset(&execbuf, 0, sizeof(execbuf));
> execbuf.buffers_ptr = to_user_pointer(gem_exec);
> execbuf.buffer_count = 1;
> - execbuf.batch_start_offset = 0;
> - execbuf.batch_len = 8;
> execbuf.flags = flags;
>
> /* Avoid hitting slowpaths in the reloc processing which might yield a
> @@ -197,16 +196,10 @@ static void execN(int fd, uint32_t handle, uint64_t batch_size, unsigned flags,
> #undef reloc_ofs
> }
>
> -igt_simple_main
> +static void exhaustive(int fd)
> {
> uint32_t batch[2] = {MI_BATCH_BUFFER_END};
> uint64_t batch_size, max, ggtt_max, reloc_ofs;
> - int fd;
> -
> - fd = drm_open_driver(DRIVER_INTEL);
> - igt_require_gem(fd);
> -
> - use_64bit_relocs = intel_gen(intel_get_drm_devid(fd)) >= 8;
>
> max = 3 * gem_aperture_size(fd) / 4;
> ggtt_max = 3 * gem_global_aperture_size(fd) / 4;
> @@ -258,6 +251,61 @@ igt_simple_main
> else
> batch_size *= 2;
> }
> +}
> +
> +static void single(int i915)
> +{
> + const uint32_t bbe = MI_BATCH_BUFFER_END;
> + uint64_t batch_size, limit;
> + uint32_t handle;
> + void *ptr;
> +
> + batch_size = (intel_get_avail_ram_mb() - 4) << 20; /* internal slack */
> + limit = gem_aperture_size(i915) - (256 << 10); /* low pages reserved */
> + if (!gem_uses_full_ppgtt(i915))
> + limit = 3 * limit / 4;
> +
> + batch_size = min(batch_size, limit);
> + batch_size = ALIGN(batch_size, 4096);
> + igt_info("Submitting a %'"PRId64"MiB batch, %saperture size %'"PRId64"MiB\n",
> + batch_size >> 20,
> + gem_uses_full_ppgtt(i915) ? "" : "shared ",
> + gem_aperture_size(i915) >> 20);
> + intel_require_memory(1, batch_size, CHECK_RAM);
> +
> + handle = gem_create(i915, batch_size);
> + gem_write(i915, handle, 0, &bbe, sizeof(bbe));
> +
> + if (!FORCE_PREAD_PWRITE && gem_has_llc(i915))
> + ptr = __gem_mmap__cpu(i915, handle, 0, batch_size, PROT_READ);
> + else if (!FORCE_PREAD_PWRITE && gem_mmap__has_wc(i915))
> + ptr = __gem_mmap__wc(i915, handle, 0, batch_size, PROT_READ);
> + else
> + ptr = NULL;
> +
> + execN(i915, handle, batch_size, 0, ptr);
> +
> + if (ptr)
> + munmap(ptr, batch_size);
> +}
> +
> +igt_main
> +{
> + int i915 = -1;
> +
> + igt_fixture {
> + i915 = drm_open_driver(DRIVER_INTEL);
> + igt_require_gem(i915);
> +
> + use_64bit_relocs = intel_gen(intel_get_drm_devid(i915)) >= 8;
> + }
> +
> + igt_subtest("single")
> + single(i915);
> +
> + igt_subtest("exhaustive")
> + exhaustive(i915);
Do we still need this one? CI time isn't an endless resource (as much as
we'd want to), neither is our ability to maintain everything. And if all
we get is timeouts in CI I think there's better uses for that machine
time. And we do use all the CI machine time, so anytime you take away 10
minutes, it's 10 minutes of not running some other testcase.
-Daniel
>
> - close(fd);
> + igt_fixture
> + close(i915);
> }
> diff --git a/tests/intel-ci/blacklist.txt b/tests/intel-ci/blacklist.txt
> index cef0da84a..0e6beeae4 100644
> --- a/tests/intel-ci/blacklist.txt
> +++ b/tests/intel-ci/blacklist.txt
> @@ -28,6 +28,7 @@ igt@gem_ctx_thrash(@.*)?
> igt@gem_evict_alignment(@.*)?
> igt@gem_evict_everything(@.*)?
> igt@gem_exec_alignment@(?!.*single).*
> +igt@gem_exec_big@(?!.*single).*
> igt@gem_exec_capture@many-(?!4K-).*
> igt@gem_exec_fence@(?!.*basic).*
> igt@gem_exec_flush@(?!.*basic).*
> --
> 2.20.1
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] i915/gem_exec_big: Add a single shot test
2019-02-13 10:11 ` Daniel Vetter
@ 2019-02-13 10:14 ` Chris Wilson
-1 siblings, 0 replies; 27+ messages in thread
From: Chris Wilson @ 2019-02-13 10:14 UTC (permalink / raw)
To: Daniel Vetter; +Cc: igt-dev, intel-gfx
Quoting Daniel Vetter (2019-02-13 10:11:27)
> On Tue, Feb 12, 2019 at 10:43:41PM +0000, Chris Wilson wrote:
> > CI complains that the exhaustive test of trying every size up to the
> > limit is too slow, so add a simple test that tries to submit one
> > extreme batch buffer and check all the relocations land.
> >
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105555
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > ---
> > tests/i915/gem_exec_big.c | 70 ++++++++++++++++++++++++++++++------
> > tests/intel-ci/blacklist.txt | 1 +
> > 2 files changed, 60 insertions(+), 11 deletions(-)
> >
> > diff --git a/tests/i915/gem_exec_big.c b/tests/i915/gem_exec_big.c
> > index a15672f66..6d7041cf4 100644
> > --- a/tests/i915/gem_exec_big.c
> > +++ b/tests/i915/gem_exec_big.c
> > @@ -71,7 +71,7 @@ static void exec1(int fd, uint32_t handle, uint64_t reloc_ofs, unsigned flags, c
> > gem_exec[0].relocs_ptr = to_user_pointer(gem_reloc);
> > gem_exec[0].alignment = 0;
> > gem_exec[0].offset = 0;
> > - gem_exec[0].flags = 0;
> > + gem_exec[0].flags = EXEC_OBJECT_SUPPORTS_48B_ADDRESS;
> > gem_exec[0].rsvd1 = 0;
> > gem_exec[0].rsvd2 = 0;
> >
> > @@ -154,12 +154,11 @@ static void execN(int fd, uint32_t handle, uint64_t batch_size, unsigned flags,
> > gem_exec[0].handle = handle;
> > gem_exec[0].relocation_count = nreloc;
> > gem_exec[0].relocs_ptr = to_user_pointer(gem_reloc);
> > + gem_exec[0].flags = EXEC_OBJECT_SUPPORTS_48B_ADDRESS;
> >
> > memset(&execbuf, 0, sizeof(execbuf));
> > execbuf.buffers_ptr = to_user_pointer(gem_exec);
> > execbuf.buffer_count = 1;
> > - execbuf.batch_start_offset = 0;
> > - execbuf.batch_len = 8;
> > execbuf.flags = flags;
> >
> > /* Avoid hitting slowpaths in the reloc processing which might yield a
> > @@ -197,16 +196,10 @@ static void execN(int fd, uint32_t handle, uint64_t batch_size, unsigned flags,
> > #undef reloc_ofs
> > }
> >
> > -igt_simple_main
> > +static void exhaustive(int fd)
> > {
> > uint32_t batch[2] = {MI_BATCH_BUFFER_END};
> > uint64_t batch_size, max, ggtt_max, reloc_ofs;
> > - int fd;
> > -
> > - fd = drm_open_driver(DRIVER_INTEL);
> > - igt_require_gem(fd);
> > -
> > - use_64bit_relocs = intel_gen(intel_get_drm_devid(fd)) >= 8;
> >
> > max = 3 * gem_aperture_size(fd) / 4;
> > ggtt_max = 3 * gem_global_aperture_size(fd) / 4;
> > @@ -258,6 +251,61 @@ igt_simple_main
> > else
> > batch_size *= 2;
> > }
> > +}
> > +
> > +static void single(int i915)
> > +{
> > + const uint32_t bbe = MI_BATCH_BUFFER_END;
> > + uint64_t batch_size, limit;
> > + uint32_t handle;
> > + void *ptr;
> > +
> > + batch_size = (intel_get_avail_ram_mb() - 4) << 20; /* internal slack */
> > + limit = gem_aperture_size(i915) - (256 << 10); /* low pages reserved */
> > + if (!gem_uses_full_ppgtt(i915))
> > + limit = 3 * limit / 4;
> > +
> > + batch_size = min(batch_size, limit);
> > + batch_size = ALIGN(batch_size, 4096);
> > + igt_info("Submitting a %'"PRId64"MiB batch, %saperture size %'"PRId64"MiB\n",
> > + batch_size >> 20,
> > + gem_uses_full_ppgtt(i915) ? "" : "shared ",
> > + gem_aperture_size(i915) >> 20);
> > + intel_require_memory(1, batch_size, CHECK_RAM);
> > +
> > + handle = gem_create(i915, batch_size);
> > + gem_write(i915, handle, 0, &bbe, sizeof(bbe));
> > +
> > + if (!FORCE_PREAD_PWRITE && gem_has_llc(i915))
> > + ptr = __gem_mmap__cpu(i915, handle, 0, batch_size, PROT_READ);
> > + else if (!FORCE_PREAD_PWRITE && gem_mmap__has_wc(i915))
> > + ptr = __gem_mmap__wc(i915, handle, 0, batch_size, PROT_READ);
> > + else
> > + ptr = NULL;
> > +
> > + execN(i915, handle, batch_size, 0, ptr);
> > +
> > + if (ptr)
> > + munmap(ptr, batch_size);
> > +}
> > +
> > +igt_main
> > +{
> > + int i915 = -1;
> > +
> > + igt_fixture {
> > + i915 = drm_open_driver(DRIVER_INTEL);
> > + igt_require_gem(i915);
> > +
> > + use_64bit_relocs = intel_gen(intel_get_drm_devid(i915)) >= 8;
> > + }
> > +
> > + igt_subtest("single")
> > + single(i915);
> > +
> > + igt_subtest("exhaustive")
> > + exhaustive(i915);
>
> Do we still need this one? CI time isn't an endless resource (as much as
> we'd want to), neither is our ability to maintain everything. And if all
> we get is timeouts in CI I think there's better uses for that machine
> time. And we do use all the CI machine time, so anytime you take away 10
> minutes, it's 10 minutes of not running some other testcase.
It's not for CI and not run in CI. CI is not the be all and end all of
testing. We still have to manually find test cases for CI to run...
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] i915/gem_exec_big: Add a single shot test
@ 2019-02-13 10:14 ` Chris Wilson
0 siblings, 0 replies; 27+ messages in thread
From: Chris Wilson @ 2019-02-13 10:14 UTC (permalink / raw)
To: Daniel Vetter; +Cc: igt-dev, intel-gfx
Quoting Daniel Vetter (2019-02-13 10:11:27)
> On Tue, Feb 12, 2019 at 10:43:41PM +0000, Chris Wilson wrote:
> > CI complains that the exhaustive test of trying every size up to the
> > limit is too slow, so add a simple test that tries to submit one
> > extreme batch buffer and check all the relocations land.
> >
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105555
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > ---
> > tests/i915/gem_exec_big.c | 70 ++++++++++++++++++++++++++++++------
> > tests/intel-ci/blacklist.txt | 1 +
> > 2 files changed, 60 insertions(+), 11 deletions(-)
> >
> > diff --git a/tests/i915/gem_exec_big.c b/tests/i915/gem_exec_big.c
> > index a15672f66..6d7041cf4 100644
> > --- a/tests/i915/gem_exec_big.c
> > +++ b/tests/i915/gem_exec_big.c
> > @@ -71,7 +71,7 @@ static void exec1(int fd, uint32_t handle, uint64_t reloc_ofs, unsigned flags, c
> > gem_exec[0].relocs_ptr = to_user_pointer(gem_reloc);
> > gem_exec[0].alignment = 0;
> > gem_exec[0].offset = 0;
> > - gem_exec[0].flags = 0;
> > + gem_exec[0].flags = EXEC_OBJECT_SUPPORTS_48B_ADDRESS;
> > gem_exec[0].rsvd1 = 0;
> > gem_exec[0].rsvd2 = 0;
> >
> > @@ -154,12 +154,11 @@ static void execN(int fd, uint32_t handle, uint64_t batch_size, unsigned flags,
> > gem_exec[0].handle = handle;
> > gem_exec[0].relocation_count = nreloc;
> > gem_exec[0].relocs_ptr = to_user_pointer(gem_reloc);
> > + gem_exec[0].flags = EXEC_OBJECT_SUPPORTS_48B_ADDRESS;
> >
> > memset(&execbuf, 0, sizeof(execbuf));
> > execbuf.buffers_ptr = to_user_pointer(gem_exec);
> > execbuf.buffer_count = 1;
> > - execbuf.batch_start_offset = 0;
> > - execbuf.batch_len = 8;
> > execbuf.flags = flags;
> >
> > /* Avoid hitting slowpaths in the reloc processing which might yield a
> > @@ -197,16 +196,10 @@ static void execN(int fd, uint32_t handle, uint64_t batch_size, unsigned flags,
> > #undef reloc_ofs
> > }
> >
> > -igt_simple_main
> > +static void exhaustive(int fd)
> > {
> > uint32_t batch[2] = {MI_BATCH_BUFFER_END};
> > uint64_t batch_size, max, ggtt_max, reloc_ofs;
> > - int fd;
> > -
> > - fd = drm_open_driver(DRIVER_INTEL);
> > - igt_require_gem(fd);
> > -
> > - use_64bit_relocs = intel_gen(intel_get_drm_devid(fd)) >= 8;
> >
> > max = 3 * gem_aperture_size(fd) / 4;
> > ggtt_max = 3 * gem_global_aperture_size(fd) / 4;
> > @@ -258,6 +251,61 @@ igt_simple_main
> > else
> > batch_size *= 2;
> > }
> > +}
> > +
> > +static void single(int i915)
> > +{
> > + const uint32_t bbe = MI_BATCH_BUFFER_END;
> > + uint64_t batch_size, limit;
> > + uint32_t handle;
> > + void *ptr;
> > +
> > + batch_size = (intel_get_avail_ram_mb() - 4) << 20; /* internal slack */
> > + limit = gem_aperture_size(i915) - (256 << 10); /* low pages reserved */
> > + if (!gem_uses_full_ppgtt(i915))
> > + limit = 3 * limit / 4;
> > +
> > + batch_size = min(batch_size, limit);
> > + batch_size = ALIGN(batch_size, 4096);
> > + igt_info("Submitting a %'"PRId64"MiB batch, %saperture size %'"PRId64"MiB\n",
> > + batch_size >> 20,
> > + gem_uses_full_ppgtt(i915) ? "" : "shared ",
> > + gem_aperture_size(i915) >> 20);
> > + intel_require_memory(1, batch_size, CHECK_RAM);
> > +
> > + handle = gem_create(i915, batch_size);
> > + gem_write(i915, handle, 0, &bbe, sizeof(bbe));
> > +
> > + if (!FORCE_PREAD_PWRITE && gem_has_llc(i915))
> > + ptr = __gem_mmap__cpu(i915, handle, 0, batch_size, PROT_READ);
> > + else if (!FORCE_PREAD_PWRITE && gem_mmap__has_wc(i915))
> > + ptr = __gem_mmap__wc(i915, handle, 0, batch_size, PROT_READ);
> > + else
> > + ptr = NULL;
> > +
> > + execN(i915, handle, batch_size, 0, ptr);
> > +
> > + if (ptr)
> > + munmap(ptr, batch_size);
> > +}
> > +
> > +igt_main
> > +{
> > + int i915 = -1;
> > +
> > + igt_fixture {
> > + i915 = drm_open_driver(DRIVER_INTEL);
> > + igt_require_gem(i915);
> > +
> > + use_64bit_relocs = intel_gen(intel_get_drm_devid(i915)) >= 8;
> > + }
> > +
> > + igt_subtest("single")
> > + single(i915);
> > +
> > + igt_subtest("exhaustive")
> > + exhaustive(i915);
>
> Do we still need this one? CI time isn't an endless resource (as much as
> we'd want to), neither is our ability to maintain everything. And if all
> we get is timeouts in CI I think there's better uses for that machine
> time. And we do use all the CI machine time, so anytime you take away 10
> minutes, it's 10 minutes of not running some other testcase.
It's not for CI and not run in CI. CI is not the be all and end all of
testing. We still have to manually find test cases for CI to run...
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 27+ messages in thread
* ✓ Fi.CI.IGT: success for i915/gem_exec_big: Add a single shot test
2019-02-12 19:55 ` [igt-dev] " Chris Wilson
` (7 preceding siblings ...)
(?)
@ 2019-02-13 12:55 ` Patchwork
-1 siblings, 0 replies; 27+ messages in thread
From: Patchwork @ 2019-02-13 12:55 UTC (permalink / raw)
To: intel-gfx
== Series Details ==
Series: i915/gem_exec_big: Add a single shot test
URL : https://patchwork.freedesktop.org/series/56595/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5596_full -> IGTPW_2390_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/56595/revisions/1/mbox/
New tests
---------
New tests have been introduced between CI_DRM_5596_full and IGTPW_2390_full:
Known issues
------------
Here are the changes found in IGTPW_2390_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_isolation@rcs0-s3:
- shard-snb: PASS -> INCOMPLETE [fdo#105411]
* igt@i915_suspend@shrink:
- shard-kbl: NOTRUN -> DMESG-WARN [fdo#109244]
* igt@kms_available_modes_crc@available_mode_test_crc:
- shard-kbl: NOTRUN -> FAIL [fdo#106641]
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-a:
- shard-apl: NOTRUN -> DMESG-WARN [fdo#107956]
* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-a:
- shard-kbl: NOTRUN -> DMESG-WARN [fdo#107956] +2
* igt@kms_content_protection@legacy:
- shard-kbl: NOTRUN -> FAIL [fdo#108597]
* igt@kms_cursor_crc@cursor-128x42-sliding:
- shard-glk: NOTRUN -> FAIL [fdo#103232]
* igt@kms_cursor_crc@cursor-256x85-sliding:
- shard-apl: PASS -> FAIL [fdo#103232] +6
* igt@kms_cursor_crc@cursor-64x64-sliding:
- shard-kbl: NOTRUN -> FAIL [fdo#103232]
* igt@kms_cursor_crc@cursor-alpha-opaque:
- shard-glk: PASS -> FAIL [fdo#109350]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render:
- shard-apl: PASS -> FAIL [fdo#103167]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
- shard-apl: NOTRUN -> FAIL [fdo#103167]
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-blt:
- shard-glk: PASS -> FAIL [fdo#103167] +2
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-pwrite:
- shard-glk: NOTRUN -> FAIL [fdo#103167]
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
- shard-glk: PASS -> FAIL [fdo#108145]
* igt@kms_plane_alpha_blend@pipe-c-alpha-7efc:
- shard-kbl: NOTRUN -> FAIL [fdo#108145] / [fdo#108590] +3
* igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb:
- shard-kbl: NOTRUN -> FAIL [fdo#108145] +4
* igt@kms_plane_multiple@atomic-pipe-c-tiling-y:
- shard-apl: PASS -> FAIL [fdo#103166]
* igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
- shard-glk: PASS -> FAIL [fdo#103166]
* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-hsw: PASS -> FAIL [fdo#104894]
* igt@pm_rps@reset:
- shard-glk: PASS -> INCOMPLETE [fdo#103359] / [k.org#198133]
#### Possible fixes ####
* igt@gem_exec_create@forked:
- shard-hsw: INCOMPLETE [fdo#103540] -> PASS
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
- shard-glk: FAIL [fdo#108145] -> PASS
* igt@kms_cursor_crc@cursor-256x256-random:
- shard-apl: FAIL [fdo#103232] -> PASS +4
* igt@kms_cursor_crc@cursor-64x64-suspend:
- shard-apl: FAIL [fdo#103191] / [fdo#103232] -> PASS
* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic:
- shard-hsw: FAIL [fdo#105767] -> PASS
* igt@kms_flip@basic-flip-vs-modeset:
- shard-hsw: DMESG-WARN [fdo#102614] -> PASS
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-glk: FAIL [fdo#102887] / [fdo#105363] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
- shard-apl: FAIL [fdo#103167] -> PASS +2
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen:
- shard-glk: FAIL [fdo#103167] -> PASS +1
* igt@kms_plane@pixel-format-pipe-a-planes-source-clamping:
- shard-apl: FAIL [fdo#108948] -> PASS
* igt@kms_plane@pixel-format-pipe-c-planes-source-clamping:
- shard-glk: FAIL [fdo#108948] -> PASS
- shard-apl: INCOMPLETE [fdo#103927] -> PASS
* igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
- shard-glk: FAIL [fdo#103166] -> PASS +4
- shard-apl: FAIL [fdo#103166] -> PASS +3
* igt@kms_setmode@clone-exclusive-crtc:
- shard-glk: INCOMPLETE [fdo#103359] / [k.org#198133] -> PASS +1
#### Warnings ####
* igt@gem_busy@extended-parallel-bsd:
- shard-snb: {SKIP} [fdo#109271] -> INCOMPLETE [fdo#105411]
* igt@i915_suspend@shrink:
- shard-glk: INCOMPLETE [fdo#103359] / [fdo#106886] / [k.org#198133] -> DMESG-WARN [fdo#109244]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
[fdo#102887]: https://bugs.freedesktop.org/show_bug.cgi?id=102887
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104894]: https://bugs.freedesktop.org/show_bug.cgi?id=104894
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767
[fdo#106641]: https://bugs.freedesktop.org/show_bug.cgi?id=106641
[fdo#106886]: https://bugs.freedesktop.org/show_bug.cgi?id=106886
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108590]: https://bugs.freedesktop.org/show_bug.cgi?id=108590
[fdo#108597]: https://bugs.freedesktop.org/show_bug.cgi?id=108597
[fdo#108948]: https://bugs.freedesktop.org/show_bug.cgi?id=108948
[fdo#109244]: https://bugs.freedesktop.org/show_bug.cgi?id=109244
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109350]: https://bugs.freedesktop.org/show_bug.cgi?id=109350
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (6 -> 5)
------------------------------
Additional (1): shard-kbl
Missing (2): shard-skl shard-iclb
Build changes
-------------
* IGT: IGT_4820 -> IGTPW_2390
* Piglit: piglit_4509 -> None
CI_DRM_5596: aaaccba122fe89ef87706ae2642dc3e3b0d256e6 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2390: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2390/
IGT_4820: 368237db1149033d8274248489ffec671ea1f7d8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2390/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH i-g-t] i915/gem_exec_big: Add a single shot test
2019-02-12 19:55 ` [igt-dev] " Chris Wilson
` (8 preceding siblings ...)
(?)
@ 2019-02-13 13:00 ` Chris Wilson
-1 siblings, 0 replies; 27+ messages in thread
From: Chris Wilson @ 2019-02-13 13:00 UTC (permalink / raw)
To: intel-gfx; +Cc: dri-devel
CI complains that the exhaustive test of trying every size up to the
limit is too slow, so add a simple test that tries to submit one
extreme batch buffer and check all the relocations land.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105555
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
Continue the tweaking to see how much memory CI requires for java during
the middle of test execution. java, java, java!
---
tests/i915/gem_exec_big.c | 70 ++++++++++++++++++++++++++++++------
tests/intel-ci/blacklist.txt | 1 +
2 files changed, 60 insertions(+), 11 deletions(-)
diff --git a/tests/i915/gem_exec_big.c b/tests/i915/gem_exec_big.c
index a15672f66..015f59e29 100644
--- a/tests/i915/gem_exec_big.c
+++ b/tests/i915/gem_exec_big.c
@@ -71,7 +71,7 @@ static void exec1(int fd, uint32_t handle, uint64_t reloc_ofs, unsigned flags, c
gem_exec[0].relocs_ptr = to_user_pointer(gem_reloc);
gem_exec[0].alignment = 0;
gem_exec[0].offset = 0;
- gem_exec[0].flags = 0;
+ gem_exec[0].flags = EXEC_OBJECT_SUPPORTS_48B_ADDRESS;
gem_exec[0].rsvd1 = 0;
gem_exec[0].rsvd2 = 0;
@@ -154,12 +154,11 @@ static void execN(int fd, uint32_t handle, uint64_t batch_size, unsigned flags,
gem_exec[0].handle = handle;
gem_exec[0].relocation_count = nreloc;
gem_exec[0].relocs_ptr = to_user_pointer(gem_reloc);
+ gem_exec[0].flags = EXEC_OBJECT_SUPPORTS_48B_ADDRESS;
memset(&execbuf, 0, sizeof(execbuf));
execbuf.buffers_ptr = to_user_pointer(gem_exec);
execbuf.buffer_count = 1;
- execbuf.batch_start_offset = 0;
- execbuf.batch_len = 8;
execbuf.flags = flags;
/* Avoid hitting slowpaths in the reloc processing which might yield a
@@ -197,16 +196,10 @@ static void execN(int fd, uint32_t handle, uint64_t batch_size, unsigned flags,
#undef reloc_ofs
}
-igt_simple_main
+static void exhaustive(int fd)
{
uint32_t batch[2] = {MI_BATCH_BUFFER_END};
uint64_t batch_size, max, ggtt_max, reloc_ofs;
- int fd;
-
- fd = drm_open_driver(DRIVER_INTEL);
- igt_require_gem(fd);
-
- use_64bit_relocs = intel_gen(intel_get_drm_devid(fd)) >= 8;
max = 3 * gem_aperture_size(fd) / 4;
ggtt_max = 3 * gem_global_aperture_size(fd) / 4;
@@ -258,6 +251,61 @@ igt_simple_main
else
batch_size *= 2;
}
+}
+
+static void single(int i915)
+{
+ const uint32_t bbe = MI_BATCH_BUFFER_END;
+ uint64_t batch_size, limit;
+ uint32_t handle;
+ void *ptr;
+
+ batch_size = (intel_get_avail_ram_mb() - 128) << 20; /* CI slack */
+ limit = gem_aperture_size(i915) - (256 << 10); /* low pages reserved */
+ if (!gem_uses_full_ppgtt(i915))
+ limit = 3 * limit / 4;
+
+ batch_size = min(batch_size, limit);
+ batch_size = ALIGN(batch_size, 4096);
+ igt_info("Submitting a %'"PRId64"MiB batch, %saperture size %'"PRId64"MiB\n",
+ batch_size >> 20,
+ gem_uses_full_ppgtt(i915) ? "" : "shared ",
+ gem_aperture_size(i915) >> 20);
+ intel_require_memory(1, batch_size, CHECK_RAM);
+
+ handle = gem_create(i915, batch_size);
+ gem_write(i915, handle, 0, &bbe, sizeof(bbe));
+
+ if (!FORCE_PREAD_PWRITE && gem_has_llc(i915))
+ ptr = __gem_mmap__cpu(i915, handle, 0, batch_size, PROT_READ);
+ else if (!FORCE_PREAD_PWRITE && gem_mmap__has_wc(i915))
+ ptr = __gem_mmap__wc(i915, handle, 0, batch_size, PROT_READ);
+ else
+ ptr = NULL;
+
+ execN(i915, handle, batch_size, 0, ptr);
+
+ if (ptr)
+ munmap(ptr, batch_size);
+}
+
+igt_main
+{
+ int i915 = -1;
+
+ igt_fixture {
+ i915 = drm_open_driver(DRIVER_INTEL);
+ igt_require_gem(i915);
+
+ use_64bit_relocs = intel_gen(intel_get_drm_devid(i915)) >= 8;
+ }
+
+ igt_subtest("single")
+ single(i915);
+
+ igt_subtest("exhaustive")
+ exhaustive(i915);
- close(fd);
+ igt_fixture
+ close(i915);
}
diff --git a/tests/intel-ci/blacklist.txt b/tests/intel-ci/blacklist.txt
index cef0da84a..0e6beeae4 100644
--- a/tests/intel-ci/blacklist.txt
+++ b/tests/intel-ci/blacklist.txt
@@ -28,6 +28,7 @@ igt@gem_ctx_thrash(@.*)?
igt@gem_evict_alignment(@.*)?
igt@gem_evict_everything(@.*)?
igt@gem_exec_alignment@(?!.*single).*
+igt@gem_exec_big@(?!.*single).*
igt@gem_exec_capture@many-(?!4K-).*
igt@gem_exec_fence@(?!.*basic).*
igt@gem_exec_flush@(?!.*basic).*
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 27+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] i915/gem_exec_big: Add a single shot test
2019-02-13 10:14 ` [Intel-gfx] " Chris Wilson
@ 2019-02-13 13:02 ` Daniel Vetter
-1 siblings, 0 replies; 27+ messages in thread
From: Daniel Vetter @ 2019-02-13 13:02 UTC (permalink / raw)
To: Chris Wilson; +Cc: IGT development, intel-gfx
On Wed, Feb 13, 2019 at 11:15 AM Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Quoting Daniel Vetter (2019-02-13 10:11:27)
> > On Tue, Feb 12, 2019 at 10:43:41PM +0000, Chris Wilson wrote:
> > > CI complains that the exhaustive test of trying every size up to the
> > > limit is too slow, so add a simple test that tries to submit one
> > > extreme batch buffer and check all the relocations land.
> > >
> > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105555
> > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > > ---
> > > tests/i915/gem_exec_big.c | 70 ++++++++++++++++++++++++++++++------
> > > tests/intel-ci/blacklist.txt | 1 +
> > > 2 files changed, 60 insertions(+), 11 deletions(-)
> > >
> > > diff --git a/tests/i915/gem_exec_big.c b/tests/i915/gem_exec_big.c
> > > index a15672f66..6d7041cf4 100644
> > > --- a/tests/i915/gem_exec_big.c
> > > +++ b/tests/i915/gem_exec_big.c
> > > @@ -71,7 +71,7 @@ static void exec1(int fd, uint32_t handle, uint64_t reloc_ofs, unsigned flags, c
> > > gem_exec[0].relocs_ptr = to_user_pointer(gem_reloc);
> > > gem_exec[0].alignment = 0;
> > > gem_exec[0].offset = 0;
> > > - gem_exec[0].flags = 0;
> > > + gem_exec[0].flags = EXEC_OBJECT_SUPPORTS_48B_ADDRESS;
> > > gem_exec[0].rsvd1 = 0;
> > > gem_exec[0].rsvd2 = 0;
> > >
> > > @@ -154,12 +154,11 @@ static void execN(int fd, uint32_t handle, uint64_t batch_size, unsigned flags,
> > > gem_exec[0].handle = handle;
> > > gem_exec[0].relocation_count = nreloc;
> > > gem_exec[0].relocs_ptr = to_user_pointer(gem_reloc);
> > > + gem_exec[0].flags = EXEC_OBJECT_SUPPORTS_48B_ADDRESS;
> > >
> > > memset(&execbuf, 0, sizeof(execbuf));
> > > execbuf.buffers_ptr = to_user_pointer(gem_exec);
> > > execbuf.buffer_count = 1;
> > > - execbuf.batch_start_offset = 0;
> > > - execbuf.batch_len = 8;
> > > execbuf.flags = flags;
> > >
> > > /* Avoid hitting slowpaths in the reloc processing which might yield a
> > > @@ -197,16 +196,10 @@ static void execN(int fd, uint32_t handle, uint64_t batch_size, unsigned flags,
> > > #undef reloc_ofs
> > > }
> > >
> > > -igt_simple_main
> > > +static void exhaustive(int fd)
> > > {
> > > uint32_t batch[2] = {MI_BATCH_BUFFER_END};
> > > uint64_t batch_size, max, ggtt_max, reloc_ofs;
> > > - int fd;
> > > -
> > > - fd = drm_open_driver(DRIVER_INTEL);
> > > - igt_require_gem(fd);
> > > -
> > > - use_64bit_relocs = intel_gen(intel_get_drm_devid(fd)) >= 8;
> > >
> > > max = 3 * gem_aperture_size(fd) / 4;
> > > ggtt_max = 3 * gem_global_aperture_size(fd) / 4;
> > > @@ -258,6 +251,61 @@ igt_simple_main
> > > else
> > > batch_size *= 2;
> > > }
> > > +}
> > > +
> > > +static void single(int i915)
> > > +{
> > > + const uint32_t bbe = MI_BATCH_BUFFER_END;
> > > + uint64_t batch_size, limit;
> > > + uint32_t handle;
> > > + void *ptr;
> > > +
> > > + batch_size = (intel_get_avail_ram_mb() - 4) << 20; /* internal slack */
> > > + limit = gem_aperture_size(i915) - (256 << 10); /* low pages reserved */
> > > + if (!gem_uses_full_ppgtt(i915))
> > > + limit = 3 * limit / 4;
> > > +
> > > + batch_size = min(batch_size, limit);
> > > + batch_size = ALIGN(batch_size, 4096);
> > > + igt_info("Submitting a %'"PRId64"MiB batch, %saperture size %'"PRId64"MiB\n",
> > > + batch_size >> 20,
> > > + gem_uses_full_ppgtt(i915) ? "" : "shared ",
> > > + gem_aperture_size(i915) >> 20);
> > > + intel_require_memory(1, batch_size, CHECK_RAM);
> > > +
> > > + handle = gem_create(i915, batch_size);
> > > + gem_write(i915, handle, 0, &bbe, sizeof(bbe));
> > > +
> > > + if (!FORCE_PREAD_PWRITE && gem_has_llc(i915))
> > > + ptr = __gem_mmap__cpu(i915, handle, 0, batch_size, PROT_READ);
> > > + else if (!FORCE_PREAD_PWRITE && gem_mmap__has_wc(i915))
> > > + ptr = __gem_mmap__wc(i915, handle, 0, batch_size, PROT_READ);
> > > + else
> > > + ptr = NULL;
> > > +
> > > + execN(i915, handle, batch_size, 0, ptr);
> > > +
> > > + if (ptr)
> > > + munmap(ptr, batch_size);
> > > +}
> > > +
> > > +igt_main
> > > +{
> > > + int i915 = -1;
> > > +
> > > + igt_fixture {
> > > + i915 = drm_open_driver(DRIVER_INTEL);
> > > + igt_require_gem(i915);
> > > +
> > > + use_64bit_relocs = intel_gen(intel_get_drm_devid(i915)) >= 8;
> > > + }
> > > +
> > > + igt_subtest("single")
> > > + single(i915);
> > > +
> > > + igt_subtest("exhaustive")
> > > + exhaustive(i915);
> >
> > Do we still need this one? CI time isn't an endless resource (as much as
> > we'd want to), neither is our ability to maintain everything. And if all
> > we get is timeouts in CI I think there's better uses for that machine
> > time. And we do use all the CI machine time, so anytime you take away 10
> > minutes, it's 10 minutes of not running some other testcase.
>
> It's not for CI and not run in CI. CI is not the be all and end all of
> testing. We still have to manually find test cases for CI to run...
It's run in drmtip runs afaict. That's time shared with a ton of other
runs we do, so yeah, more time spent here means less time spent
somewhere else. "Adding even more tests" when CI folks seem to say
"already takes too long" just seems like the wrong direction.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] i915/gem_exec_big: Add a single shot test
@ 2019-02-13 13:02 ` Daniel Vetter
0 siblings, 0 replies; 27+ messages in thread
From: Daniel Vetter @ 2019-02-13 13:02 UTC (permalink / raw)
To: Chris Wilson; +Cc: IGT development, intel-gfx
On Wed, Feb 13, 2019 at 11:15 AM Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Quoting Daniel Vetter (2019-02-13 10:11:27)
> > On Tue, Feb 12, 2019 at 10:43:41PM +0000, Chris Wilson wrote:
> > > CI complains that the exhaustive test of trying every size up to the
> > > limit is too slow, so add a simple test that tries to submit one
> > > extreme batch buffer and check all the relocations land.
> > >
> > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105555
> > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > > ---
> > > tests/i915/gem_exec_big.c | 70 ++++++++++++++++++++++++++++++------
> > > tests/intel-ci/blacklist.txt | 1 +
> > > 2 files changed, 60 insertions(+), 11 deletions(-)
> > >
> > > diff --git a/tests/i915/gem_exec_big.c b/tests/i915/gem_exec_big.c
> > > index a15672f66..6d7041cf4 100644
> > > --- a/tests/i915/gem_exec_big.c
> > > +++ b/tests/i915/gem_exec_big.c
> > > @@ -71,7 +71,7 @@ static void exec1(int fd, uint32_t handle, uint64_t reloc_ofs, unsigned flags, c
> > > gem_exec[0].relocs_ptr = to_user_pointer(gem_reloc);
> > > gem_exec[0].alignment = 0;
> > > gem_exec[0].offset = 0;
> > > - gem_exec[0].flags = 0;
> > > + gem_exec[0].flags = EXEC_OBJECT_SUPPORTS_48B_ADDRESS;
> > > gem_exec[0].rsvd1 = 0;
> > > gem_exec[0].rsvd2 = 0;
> > >
> > > @@ -154,12 +154,11 @@ static void execN(int fd, uint32_t handle, uint64_t batch_size, unsigned flags,
> > > gem_exec[0].handle = handle;
> > > gem_exec[0].relocation_count = nreloc;
> > > gem_exec[0].relocs_ptr = to_user_pointer(gem_reloc);
> > > + gem_exec[0].flags = EXEC_OBJECT_SUPPORTS_48B_ADDRESS;
> > >
> > > memset(&execbuf, 0, sizeof(execbuf));
> > > execbuf.buffers_ptr = to_user_pointer(gem_exec);
> > > execbuf.buffer_count = 1;
> > > - execbuf.batch_start_offset = 0;
> > > - execbuf.batch_len = 8;
> > > execbuf.flags = flags;
> > >
> > > /* Avoid hitting slowpaths in the reloc processing which might yield a
> > > @@ -197,16 +196,10 @@ static void execN(int fd, uint32_t handle, uint64_t batch_size, unsigned flags,
> > > #undef reloc_ofs
> > > }
> > >
> > > -igt_simple_main
> > > +static void exhaustive(int fd)
> > > {
> > > uint32_t batch[2] = {MI_BATCH_BUFFER_END};
> > > uint64_t batch_size, max, ggtt_max, reloc_ofs;
> > > - int fd;
> > > -
> > > - fd = drm_open_driver(DRIVER_INTEL);
> > > - igt_require_gem(fd);
> > > -
> > > - use_64bit_relocs = intel_gen(intel_get_drm_devid(fd)) >= 8;
> > >
> > > max = 3 * gem_aperture_size(fd) / 4;
> > > ggtt_max = 3 * gem_global_aperture_size(fd) / 4;
> > > @@ -258,6 +251,61 @@ igt_simple_main
> > > else
> > > batch_size *= 2;
> > > }
> > > +}
> > > +
> > > +static void single(int i915)
> > > +{
> > > + const uint32_t bbe = MI_BATCH_BUFFER_END;
> > > + uint64_t batch_size, limit;
> > > + uint32_t handle;
> > > + void *ptr;
> > > +
> > > + batch_size = (intel_get_avail_ram_mb() - 4) << 20; /* internal slack */
> > > + limit = gem_aperture_size(i915) - (256 << 10); /* low pages reserved */
> > > + if (!gem_uses_full_ppgtt(i915))
> > > + limit = 3 * limit / 4;
> > > +
> > > + batch_size = min(batch_size, limit);
> > > + batch_size = ALIGN(batch_size, 4096);
> > > + igt_info("Submitting a %'"PRId64"MiB batch, %saperture size %'"PRId64"MiB\n",
> > > + batch_size >> 20,
> > > + gem_uses_full_ppgtt(i915) ? "" : "shared ",
> > > + gem_aperture_size(i915) >> 20);
> > > + intel_require_memory(1, batch_size, CHECK_RAM);
> > > +
> > > + handle = gem_create(i915, batch_size);
> > > + gem_write(i915, handle, 0, &bbe, sizeof(bbe));
> > > +
> > > + if (!FORCE_PREAD_PWRITE && gem_has_llc(i915))
> > > + ptr = __gem_mmap__cpu(i915, handle, 0, batch_size, PROT_READ);
> > > + else if (!FORCE_PREAD_PWRITE && gem_mmap__has_wc(i915))
> > > + ptr = __gem_mmap__wc(i915, handle, 0, batch_size, PROT_READ);
> > > + else
> > > + ptr = NULL;
> > > +
> > > + execN(i915, handle, batch_size, 0, ptr);
> > > +
> > > + if (ptr)
> > > + munmap(ptr, batch_size);
> > > +}
> > > +
> > > +igt_main
> > > +{
> > > + int i915 = -1;
> > > +
> > > + igt_fixture {
> > > + i915 = drm_open_driver(DRIVER_INTEL);
> > > + igt_require_gem(i915);
> > > +
> > > + use_64bit_relocs = intel_gen(intel_get_drm_devid(i915)) >= 8;
> > > + }
> > > +
> > > + igt_subtest("single")
> > > + single(i915);
> > > +
> > > + igt_subtest("exhaustive")
> > > + exhaustive(i915);
> >
> > Do we still need this one? CI time isn't an endless resource (as much as
> > we'd want to), neither is our ability to maintain everything. And if all
> > we get is timeouts in CI I think there's better uses for that machine
> > time. And we do use all the CI machine time, so anytime you take away 10
> > minutes, it's 10 minutes of not running some other testcase.
>
> It's not for CI and not run in CI. CI is not the be all and end all of
> testing. We still have to manually find test cases for CI to run...
It's run in drmtip runs afaict. That's time shared with a ton of other
runs we do, so yeah, more time spent here means less time spent
somewhere else. "Adding even more tests" when CI folks seem to say
"already takes too long" just seems like the wrong direction.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] i915/gem_exec_big: Add a single shot test
2019-02-13 13:02 ` Daniel Vetter
@ 2019-02-13 13:05 ` Chris Wilson
-1 siblings, 0 replies; 27+ messages in thread
From: Chris Wilson @ 2019-02-13 13:05 UTC (permalink / raw)
To: Daniel Vetter; +Cc: IGT development, intel-gfx
Quoting Daniel Vetter (2019-02-13 13:02:29)
> On Wed, Feb 13, 2019 at 11:15 AM Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > Quoting Daniel Vetter (2019-02-13 10:11:27)
> > > On Tue, Feb 12, 2019 at 10:43:41PM +0000, Chris Wilson wrote:
> > > > CI complains that the exhaustive test of trying every size up to the
> > > > limit is too slow, so add a simple test that tries to submit one
> > > > extreme batch buffer and check all the relocations land.
> > > >
> > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105555
> > > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > > > ---
> > > > tests/i915/gem_exec_big.c | 70 ++++++++++++++++++++++++++++++------
> > > > tests/intel-ci/blacklist.txt | 1 +
> > > > 2 files changed, 60 insertions(+), 11 deletions(-)
> > > >
> > > > diff --git a/tests/i915/gem_exec_big.c b/tests/i915/gem_exec_big.c
> > > > index a15672f66..6d7041cf4 100644
> > > > --- a/tests/i915/gem_exec_big.c
> > > > +++ b/tests/i915/gem_exec_big.c
> > > > @@ -71,7 +71,7 @@ static void exec1(int fd, uint32_t handle, uint64_t reloc_ofs, unsigned flags, c
> > > > gem_exec[0].relocs_ptr = to_user_pointer(gem_reloc);
> > > > gem_exec[0].alignment = 0;
> > > > gem_exec[0].offset = 0;
> > > > - gem_exec[0].flags = 0;
> > > > + gem_exec[0].flags = EXEC_OBJECT_SUPPORTS_48B_ADDRESS;
> > > > gem_exec[0].rsvd1 = 0;
> > > > gem_exec[0].rsvd2 = 0;
> > > >
> > > > @@ -154,12 +154,11 @@ static void execN(int fd, uint32_t handle, uint64_t batch_size, unsigned flags,
> > > > gem_exec[0].handle = handle;
> > > > gem_exec[0].relocation_count = nreloc;
> > > > gem_exec[0].relocs_ptr = to_user_pointer(gem_reloc);
> > > > + gem_exec[0].flags = EXEC_OBJECT_SUPPORTS_48B_ADDRESS;
> > > >
> > > > memset(&execbuf, 0, sizeof(execbuf));
> > > > execbuf.buffers_ptr = to_user_pointer(gem_exec);
> > > > execbuf.buffer_count = 1;
> > > > - execbuf.batch_start_offset = 0;
> > > > - execbuf.batch_len = 8;
> > > > execbuf.flags = flags;
> > > >
> > > > /* Avoid hitting slowpaths in the reloc processing which might yield a
> > > > @@ -197,16 +196,10 @@ static void execN(int fd, uint32_t handle, uint64_t batch_size, unsigned flags,
> > > > #undef reloc_ofs
> > > > }
> > > >
> > > > -igt_simple_main
> > > > +static void exhaustive(int fd)
> > > > {
> > > > uint32_t batch[2] = {MI_BATCH_BUFFER_END};
> > > > uint64_t batch_size, max, ggtt_max, reloc_ofs;
> > > > - int fd;
> > > > -
> > > > - fd = drm_open_driver(DRIVER_INTEL);
> > > > - igt_require_gem(fd);
> > > > -
> > > > - use_64bit_relocs = intel_gen(intel_get_drm_devid(fd)) >= 8;
> > > >
> > > > max = 3 * gem_aperture_size(fd) / 4;
> > > > ggtt_max = 3 * gem_global_aperture_size(fd) / 4;
> > > > @@ -258,6 +251,61 @@ igt_simple_main
> > > > else
> > > > batch_size *= 2;
> > > > }
> > > > +}
> > > > +
> > > > +static void single(int i915)
> > > > +{
> > > > + const uint32_t bbe = MI_BATCH_BUFFER_END;
> > > > + uint64_t batch_size, limit;
> > > > + uint32_t handle;
> > > > + void *ptr;
> > > > +
> > > > + batch_size = (intel_get_avail_ram_mb() - 4) << 20; /* internal slack */
> > > > + limit = gem_aperture_size(i915) - (256 << 10); /* low pages reserved */
> > > > + if (!gem_uses_full_ppgtt(i915))
> > > > + limit = 3 * limit / 4;
> > > > +
> > > > + batch_size = min(batch_size, limit);
> > > > + batch_size = ALIGN(batch_size, 4096);
> > > > + igt_info("Submitting a %'"PRId64"MiB batch, %saperture size %'"PRId64"MiB\n",
> > > > + batch_size >> 20,
> > > > + gem_uses_full_ppgtt(i915) ? "" : "shared ",
> > > > + gem_aperture_size(i915) >> 20);
> > > > + intel_require_memory(1, batch_size, CHECK_RAM);
> > > > +
> > > > + handle = gem_create(i915, batch_size);
> > > > + gem_write(i915, handle, 0, &bbe, sizeof(bbe));
> > > > +
> > > > + if (!FORCE_PREAD_PWRITE && gem_has_llc(i915))
> > > > + ptr = __gem_mmap__cpu(i915, handle, 0, batch_size, PROT_READ);
> > > > + else if (!FORCE_PREAD_PWRITE && gem_mmap__has_wc(i915))
> > > > + ptr = __gem_mmap__wc(i915, handle, 0, batch_size, PROT_READ);
> > > > + else
> > > > + ptr = NULL;
> > > > +
> > > > + execN(i915, handle, batch_size, 0, ptr);
> > > > +
> > > > + if (ptr)
> > > > + munmap(ptr, batch_size);
> > > > +}
> > > > +
> > > > +igt_main
> > > > +{
> > > > + int i915 = -1;
> > > > +
> > > > + igt_fixture {
> > > > + i915 = drm_open_driver(DRIVER_INTEL);
> > > > + igt_require_gem(i915);
> > > > +
> > > > + use_64bit_relocs = intel_gen(intel_get_drm_devid(i915)) >= 8;
> > > > + }
> > > > +
> > > > + igt_subtest("single")
> > > > + single(i915);
> > > > +
> > > > + igt_subtest("exhaustive")
> > > > + exhaustive(i915);
> > >
> > > Do we still need this one? CI time isn't an endless resource (as much as
> > > we'd want to), neither is our ability to maintain everything. And if all
> > > we get is timeouts in CI I think there's better uses for that machine
> > > time. And we do use all the CI machine time, so anytime you take away 10
> > > minutes, it's 10 minutes of not running some other testcase.
> >
> > It's not for CI and not run in CI. CI is not the be all and end all of
> > testing. We still have to manually find test cases for CI to run...
>
> It's run in drmtip runs afaict. That's time shared with a ton of other
> runs we do, so yeah, more time spent here means less time spent
> somewhere else. "Adding even more tests" when CI folks seem to say
> "already takes too long" just seems like the wrong direction.
Which is why I'm replacing it with a slimmer variant.
> > > > CI complains that the exhaustive test of trying every size up to the
> > > > limit is too slow, so add a simple test that tries to submit one
> > > > extreme batch buffer and check all the relocations land.
But doesn't mean the old test is worthless; far from it.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] i915/gem_exec_big: Add a single shot test
@ 2019-02-13 13:05 ` Chris Wilson
0 siblings, 0 replies; 27+ messages in thread
From: Chris Wilson @ 2019-02-13 13:05 UTC (permalink / raw)
To: Daniel Vetter; +Cc: IGT development, intel-gfx
Quoting Daniel Vetter (2019-02-13 13:02:29)
> On Wed, Feb 13, 2019 at 11:15 AM Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > Quoting Daniel Vetter (2019-02-13 10:11:27)
> > > On Tue, Feb 12, 2019 at 10:43:41PM +0000, Chris Wilson wrote:
> > > > CI complains that the exhaustive test of trying every size up to the
> > > > limit is too slow, so add a simple test that tries to submit one
> > > > extreme batch buffer and check all the relocations land.
> > > >
> > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105555
> > > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > > > ---
> > > > tests/i915/gem_exec_big.c | 70 ++++++++++++++++++++++++++++++------
> > > > tests/intel-ci/blacklist.txt | 1 +
> > > > 2 files changed, 60 insertions(+), 11 deletions(-)
> > > >
> > > > diff --git a/tests/i915/gem_exec_big.c b/tests/i915/gem_exec_big.c
> > > > index a15672f66..6d7041cf4 100644
> > > > --- a/tests/i915/gem_exec_big.c
> > > > +++ b/tests/i915/gem_exec_big.c
> > > > @@ -71,7 +71,7 @@ static void exec1(int fd, uint32_t handle, uint64_t reloc_ofs, unsigned flags, c
> > > > gem_exec[0].relocs_ptr = to_user_pointer(gem_reloc);
> > > > gem_exec[0].alignment = 0;
> > > > gem_exec[0].offset = 0;
> > > > - gem_exec[0].flags = 0;
> > > > + gem_exec[0].flags = EXEC_OBJECT_SUPPORTS_48B_ADDRESS;
> > > > gem_exec[0].rsvd1 = 0;
> > > > gem_exec[0].rsvd2 = 0;
> > > >
> > > > @@ -154,12 +154,11 @@ static void execN(int fd, uint32_t handle, uint64_t batch_size, unsigned flags,
> > > > gem_exec[0].handle = handle;
> > > > gem_exec[0].relocation_count = nreloc;
> > > > gem_exec[0].relocs_ptr = to_user_pointer(gem_reloc);
> > > > + gem_exec[0].flags = EXEC_OBJECT_SUPPORTS_48B_ADDRESS;
> > > >
> > > > memset(&execbuf, 0, sizeof(execbuf));
> > > > execbuf.buffers_ptr = to_user_pointer(gem_exec);
> > > > execbuf.buffer_count = 1;
> > > > - execbuf.batch_start_offset = 0;
> > > > - execbuf.batch_len = 8;
> > > > execbuf.flags = flags;
> > > >
> > > > /* Avoid hitting slowpaths in the reloc processing which might yield a
> > > > @@ -197,16 +196,10 @@ static void execN(int fd, uint32_t handle, uint64_t batch_size, unsigned flags,
> > > > #undef reloc_ofs
> > > > }
> > > >
> > > > -igt_simple_main
> > > > +static void exhaustive(int fd)
> > > > {
> > > > uint32_t batch[2] = {MI_BATCH_BUFFER_END};
> > > > uint64_t batch_size, max, ggtt_max, reloc_ofs;
> > > > - int fd;
> > > > -
> > > > - fd = drm_open_driver(DRIVER_INTEL);
> > > > - igt_require_gem(fd);
> > > > -
> > > > - use_64bit_relocs = intel_gen(intel_get_drm_devid(fd)) >= 8;
> > > >
> > > > max = 3 * gem_aperture_size(fd) / 4;
> > > > ggtt_max = 3 * gem_global_aperture_size(fd) / 4;
> > > > @@ -258,6 +251,61 @@ igt_simple_main
> > > > else
> > > > batch_size *= 2;
> > > > }
> > > > +}
> > > > +
> > > > +static void single(int i915)
> > > > +{
> > > > + const uint32_t bbe = MI_BATCH_BUFFER_END;
> > > > + uint64_t batch_size, limit;
> > > > + uint32_t handle;
> > > > + void *ptr;
> > > > +
> > > > + batch_size = (intel_get_avail_ram_mb() - 4) << 20; /* internal slack */
> > > > + limit = gem_aperture_size(i915) - (256 << 10); /* low pages reserved */
> > > > + if (!gem_uses_full_ppgtt(i915))
> > > > + limit = 3 * limit / 4;
> > > > +
> > > > + batch_size = min(batch_size, limit);
> > > > + batch_size = ALIGN(batch_size, 4096);
> > > > + igt_info("Submitting a %'"PRId64"MiB batch, %saperture size %'"PRId64"MiB\n",
> > > > + batch_size >> 20,
> > > > + gem_uses_full_ppgtt(i915) ? "" : "shared ",
> > > > + gem_aperture_size(i915) >> 20);
> > > > + intel_require_memory(1, batch_size, CHECK_RAM);
> > > > +
> > > > + handle = gem_create(i915, batch_size);
> > > > + gem_write(i915, handle, 0, &bbe, sizeof(bbe));
> > > > +
> > > > + if (!FORCE_PREAD_PWRITE && gem_has_llc(i915))
> > > > + ptr = __gem_mmap__cpu(i915, handle, 0, batch_size, PROT_READ);
> > > > + else if (!FORCE_PREAD_PWRITE && gem_mmap__has_wc(i915))
> > > > + ptr = __gem_mmap__wc(i915, handle, 0, batch_size, PROT_READ);
> > > > + else
> > > > + ptr = NULL;
> > > > +
> > > > + execN(i915, handle, batch_size, 0, ptr);
> > > > +
> > > > + if (ptr)
> > > > + munmap(ptr, batch_size);
> > > > +}
> > > > +
> > > > +igt_main
> > > > +{
> > > > + int i915 = -1;
> > > > +
> > > > + igt_fixture {
> > > > + i915 = drm_open_driver(DRIVER_INTEL);
> > > > + igt_require_gem(i915);
> > > > +
> > > > + use_64bit_relocs = intel_gen(intel_get_drm_devid(i915)) >= 8;
> > > > + }
> > > > +
> > > > + igt_subtest("single")
> > > > + single(i915);
> > > > +
> > > > + igt_subtest("exhaustive")
> > > > + exhaustive(i915);
> > >
> > > Do we still need this one? CI time isn't an endless resource (as much as
> > > we'd want to), neither is our ability to maintain everything. And if all
> > > we get is timeouts in CI I think there's better uses for that machine
> > > time. And we do use all the CI machine time, so anytime you take away 10
> > > minutes, it's 10 minutes of not running some other testcase.
> >
> > It's not for CI and not run in CI. CI is not the be all and end all of
> > testing. We still have to manually find test cases for CI to run...
>
> It's run in drmtip runs afaict. That's time shared with a ton of other
> runs we do, so yeah, more time spent here means less time spent
> somewhere else. "Adding even more tests" when CI folks seem to say
> "already takes too long" just seems like the wrong direction.
Which is why I'm replacing it with a slimmer variant.
> > > > CI complains that the exhaustive test of trying every size up to the
> > > > limit is too slow, so add a simple test that tries to submit one
> > > > extreme batch buffer and check all the relocations land.
But doesn't mean the old test is worthless; far from it.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] i915/gem_exec_big: Add a single shot test
2019-02-13 13:05 ` Chris Wilson
@ 2019-02-13 13:08 ` Daniel Vetter
-1 siblings, 0 replies; 27+ messages in thread
From: Daniel Vetter @ 2019-02-13 13:08 UTC (permalink / raw)
To: Chris Wilson; +Cc: IGT development, intel-gfx
On Wed, Feb 13, 2019 at 2:05 PM Chris Wilson <chris@chris-wilson.co.uk> wrote:
>
> Quoting Daniel Vetter (2019-02-13 13:02:29)
> > On Wed, Feb 13, 2019 at 11:15 AM Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > > Quoting Daniel Vetter (2019-02-13 10:11:27)
> > > > On Tue, Feb 12, 2019 at 10:43:41PM +0000, Chris Wilson wrote:
> > > > > CI complains that the exhaustive test of trying every size up to the
> > > > > limit is too slow, so add a simple test that tries to submit one
> > > > > extreme batch buffer and check all the relocations land.
> > > > >
> > > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105555
> > > > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > > > > ---
> > > > > tests/i915/gem_exec_big.c | 70 ++++++++++++++++++++++++++++++------
> > > > > tests/intel-ci/blacklist.txt | 1 +
> > > > > 2 files changed, 60 insertions(+), 11 deletions(-)
> > > > >
> > > > > diff --git a/tests/i915/gem_exec_big.c b/tests/i915/gem_exec_big.c
> > > > > index a15672f66..6d7041cf4 100644
> > > > > --- a/tests/i915/gem_exec_big.c
> > > > > +++ b/tests/i915/gem_exec_big.c
> > > > > @@ -71,7 +71,7 @@ static void exec1(int fd, uint32_t handle, uint64_t reloc_ofs, unsigned flags, c
> > > > > gem_exec[0].relocs_ptr = to_user_pointer(gem_reloc);
> > > > > gem_exec[0].alignment = 0;
> > > > > gem_exec[0].offset = 0;
> > > > > - gem_exec[0].flags = 0;
> > > > > + gem_exec[0].flags = EXEC_OBJECT_SUPPORTS_48B_ADDRESS;
> > > > > gem_exec[0].rsvd1 = 0;
> > > > > gem_exec[0].rsvd2 = 0;
> > > > >
> > > > > @@ -154,12 +154,11 @@ static void execN(int fd, uint32_t handle, uint64_t batch_size, unsigned flags,
> > > > > gem_exec[0].handle = handle;
> > > > > gem_exec[0].relocation_count = nreloc;
> > > > > gem_exec[0].relocs_ptr = to_user_pointer(gem_reloc);
> > > > > + gem_exec[0].flags = EXEC_OBJECT_SUPPORTS_48B_ADDRESS;
> > > > >
> > > > > memset(&execbuf, 0, sizeof(execbuf));
> > > > > execbuf.buffers_ptr = to_user_pointer(gem_exec);
> > > > > execbuf.buffer_count = 1;
> > > > > - execbuf.batch_start_offset = 0;
> > > > > - execbuf.batch_len = 8;
> > > > > execbuf.flags = flags;
> > > > >
> > > > > /* Avoid hitting slowpaths in the reloc processing which might yield a
> > > > > @@ -197,16 +196,10 @@ static void execN(int fd, uint32_t handle, uint64_t batch_size, unsigned flags,
> > > > > #undef reloc_ofs
> > > > > }
> > > > >
> > > > > -igt_simple_main
> > > > > +static void exhaustive(int fd)
> > > > > {
> > > > > uint32_t batch[2] = {MI_BATCH_BUFFER_END};
> > > > > uint64_t batch_size, max, ggtt_max, reloc_ofs;
> > > > > - int fd;
> > > > > -
> > > > > - fd = drm_open_driver(DRIVER_INTEL);
> > > > > - igt_require_gem(fd);
> > > > > -
> > > > > - use_64bit_relocs = intel_gen(intel_get_drm_devid(fd)) >= 8;
> > > > >
> > > > > max = 3 * gem_aperture_size(fd) / 4;
> > > > > ggtt_max = 3 * gem_global_aperture_size(fd) / 4;
> > > > > @@ -258,6 +251,61 @@ igt_simple_main
> > > > > else
> > > > > batch_size *= 2;
> > > > > }
> > > > > +}
> > > > > +
> > > > > +static void single(int i915)
> > > > > +{
> > > > > + const uint32_t bbe = MI_BATCH_BUFFER_END;
> > > > > + uint64_t batch_size, limit;
> > > > > + uint32_t handle;
> > > > > + void *ptr;
> > > > > +
> > > > > + batch_size = (intel_get_avail_ram_mb() - 4) << 20; /* internal slack */
> > > > > + limit = gem_aperture_size(i915) - (256 << 10); /* low pages reserved */
> > > > > + if (!gem_uses_full_ppgtt(i915))
> > > > > + limit = 3 * limit / 4;
> > > > > +
> > > > > + batch_size = min(batch_size, limit);
> > > > > + batch_size = ALIGN(batch_size, 4096);
> > > > > + igt_info("Submitting a %'"PRId64"MiB batch, %saperture size %'"PRId64"MiB\n",
> > > > > + batch_size >> 20,
> > > > > + gem_uses_full_ppgtt(i915) ? "" : "shared ",
> > > > > + gem_aperture_size(i915) >> 20);
> > > > > + intel_require_memory(1, batch_size, CHECK_RAM);
> > > > > +
> > > > > + handle = gem_create(i915, batch_size);
> > > > > + gem_write(i915, handle, 0, &bbe, sizeof(bbe));
> > > > > +
> > > > > + if (!FORCE_PREAD_PWRITE && gem_has_llc(i915))
> > > > > + ptr = __gem_mmap__cpu(i915, handle, 0, batch_size, PROT_READ);
> > > > > + else if (!FORCE_PREAD_PWRITE && gem_mmap__has_wc(i915))
> > > > > + ptr = __gem_mmap__wc(i915, handle, 0, batch_size, PROT_READ);
> > > > > + else
> > > > > + ptr = NULL;
> > > > > +
> > > > > + execN(i915, handle, batch_size, 0, ptr);
> > > > > +
> > > > > + if (ptr)
> > > > > + munmap(ptr, batch_size);
> > > > > +}
> > > > > +
> > > > > +igt_main
> > > > > +{
> > > > > + int i915 = -1;
> > > > > +
> > > > > + igt_fixture {
> > > > > + i915 = drm_open_driver(DRIVER_INTEL);
> > > > > + igt_require_gem(i915);
> > > > > +
> > > > > + use_64bit_relocs = intel_gen(intel_get_drm_devid(i915)) >= 8;
> > > > > + }
> > > > > +
> > > > > + igt_subtest("single")
> > > > > + single(i915);
> > > > > +
> > > > > + igt_subtest("exhaustive")
> > > > > + exhaustive(i915);
> > > >
> > > > Do we still need this one? CI time isn't an endless resource (as much as
> > > > we'd want to), neither is our ability to maintain everything. And if all
> > > > we get is timeouts in CI I think there's better uses for that machine
> > > > time. And we do use all the CI machine time, so anytime you take away 10
> > > > minutes, it's 10 minutes of not running some other testcase.
> > >
> > > It's not for CI and not run in CI. CI is not the be all and end all of
> > > testing. We still have to manually find test cases for CI to run...
> >
> > It's run in drmtip runs afaict. That's time shared with a ton of other
> > runs we do, so yeah, more time spent here means less time spent
> > somewhere else. "Adding even more tests" when CI folks seem to say
> > "already takes too long" just seems like the wrong direction.
>
> Which is why I'm replacing it with a slimmer variant.
It's added, not replaced.
> > > > > CI complains that the exhaustive test of trying every size up to the
> > > > > limit is too slow, so add a simple test that tries to submit one
> > > > > extreme batch buffer and check all the relocations land.
>
> But doesn't mean the old test is worthless; far from it.
It's not about 0 value vs !0 value, it's about value/machine time. And
yes it's kinda impossible to be sure that changing the test won't
change coverage in just the worst possible way, but simply keeping all
the tests isn't a solution either.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] i915/gem_exec_big: Add a single shot test
@ 2019-02-13 13:08 ` Daniel Vetter
0 siblings, 0 replies; 27+ messages in thread
From: Daniel Vetter @ 2019-02-13 13:08 UTC (permalink / raw)
To: Chris Wilson; +Cc: IGT development, intel-gfx
On Wed, Feb 13, 2019 at 2:05 PM Chris Wilson <chris@chris-wilson.co.uk> wrote:
>
> Quoting Daniel Vetter (2019-02-13 13:02:29)
> > On Wed, Feb 13, 2019 at 11:15 AM Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > > Quoting Daniel Vetter (2019-02-13 10:11:27)
> > > > On Tue, Feb 12, 2019 at 10:43:41PM +0000, Chris Wilson wrote:
> > > > > CI complains that the exhaustive test of trying every size up to the
> > > > > limit is too slow, so add a simple test that tries to submit one
> > > > > extreme batch buffer and check all the relocations land.
> > > > >
> > > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105555
> > > > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > > > > ---
> > > > > tests/i915/gem_exec_big.c | 70 ++++++++++++++++++++++++++++++------
> > > > > tests/intel-ci/blacklist.txt | 1 +
> > > > > 2 files changed, 60 insertions(+), 11 deletions(-)
> > > > >
> > > > > diff --git a/tests/i915/gem_exec_big.c b/tests/i915/gem_exec_big.c
> > > > > index a15672f66..6d7041cf4 100644
> > > > > --- a/tests/i915/gem_exec_big.c
> > > > > +++ b/tests/i915/gem_exec_big.c
> > > > > @@ -71,7 +71,7 @@ static void exec1(int fd, uint32_t handle, uint64_t reloc_ofs, unsigned flags, c
> > > > > gem_exec[0].relocs_ptr = to_user_pointer(gem_reloc);
> > > > > gem_exec[0].alignment = 0;
> > > > > gem_exec[0].offset = 0;
> > > > > - gem_exec[0].flags = 0;
> > > > > + gem_exec[0].flags = EXEC_OBJECT_SUPPORTS_48B_ADDRESS;
> > > > > gem_exec[0].rsvd1 = 0;
> > > > > gem_exec[0].rsvd2 = 0;
> > > > >
> > > > > @@ -154,12 +154,11 @@ static void execN(int fd, uint32_t handle, uint64_t batch_size, unsigned flags,
> > > > > gem_exec[0].handle = handle;
> > > > > gem_exec[0].relocation_count = nreloc;
> > > > > gem_exec[0].relocs_ptr = to_user_pointer(gem_reloc);
> > > > > + gem_exec[0].flags = EXEC_OBJECT_SUPPORTS_48B_ADDRESS;
> > > > >
> > > > > memset(&execbuf, 0, sizeof(execbuf));
> > > > > execbuf.buffers_ptr = to_user_pointer(gem_exec);
> > > > > execbuf.buffer_count = 1;
> > > > > - execbuf.batch_start_offset = 0;
> > > > > - execbuf.batch_len = 8;
> > > > > execbuf.flags = flags;
> > > > >
> > > > > /* Avoid hitting slowpaths in the reloc processing which might yield a
> > > > > @@ -197,16 +196,10 @@ static void execN(int fd, uint32_t handle, uint64_t batch_size, unsigned flags,
> > > > > #undef reloc_ofs
> > > > > }
> > > > >
> > > > > -igt_simple_main
> > > > > +static void exhaustive(int fd)
> > > > > {
> > > > > uint32_t batch[2] = {MI_BATCH_BUFFER_END};
> > > > > uint64_t batch_size, max, ggtt_max, reloc_ofs;
> > > > > - int fd;
> > > > > -
> > > > > - fd = drm_open_driver(DRIVER_INTEL);
> > > > > - igt_require_gem(fd);
> > > > > -
> > > > > - use_64bit_relocs = intel_gen(intel_get_drm_devid(fd)) >= 8;
> > > > >
> > > > > max = 3 * gem_aperture_size(fd) / 4;
> > > > > ggtt_max = 3 * gem_global_aperture_size(fd) / 4;
> > > > > @@ -258,6 +251,61 @@ igt_simple_main
> > > > > else
> > > > > batch_size *= 2;
> > > > > }
> > > > > +}
> > > > > +
> > > > > +static void single(int i915)
> > > > > +{
> > > > > + const uint32_t bbe = MI_BATCH_BUFFER_END;
> > > > > + uint64_t batch_size, limit;
> > > > > + uint32_t handle;
> > > > > + void *ptr;
> > > > > +
> > > > > + batch_size = (intel_get_avail_ram_mb() - 4) << 20; /* internal slack */
> > > > > + limit = gem_aperture_size(i915) - (256 << 10); /* low pages reserved */
> > > > > + if (!gem_uses_full_ppgtt(i915))
> > > > > + limit = 3 * limit / 4;
> > > > > +
> > > > > + batch_size = min(batch_size, limit);
> > > > > + batch_size = ALIGN(batch_size, 4096);
> > > > > + igt_info("Submitting a %'"PRId64"MiB batch, %saperture size %'"PRId64"MiB\n",
> > > > > + batch_size >> 20,
> > > > > + gem_uses_full_ppgtt(i915) ? "" : "shared ",
> > > > > + gem_aperture_size(i915) >> 20);
> > > > > + intel_require_memory(1, batch_size, CHECK_RAM);
> > > > > +
> > > > > + handle = gem_create(i915, batch_size);
> > > > > + gem_write(i915, handle, 0, &bbe, sizeof(bbe));
> > > > > +
> > > > > + if (!FORCE_PREAD_PWRITE && gem_has_llc(i915))
> > > > > + ptr = __gem_mmap__cpu(i915, handle, 0, batch_size, PROT_READ);
> > > > > + else if (!FORCE_PREAD_PWRITE && gem_mmap__has_wc(i915))
> > > > > + ptr = __gem_mmap__wc(i915, handle, 0, batch_size, PROT_READ);
> > > > > + else
> > > > > + ptr = NULL;
> > > > > +
> > > > > + execN(i915, handle, batch_size, 0, ptr);
> > > > > +
> > > > > + if (ptr)
> > > > > + munmap(ptr, batch_size);
> > > > > +}
> > > > > +
> > > > > +igt_main
> > > > > +{
> > > > > + int i915 = -1;
> > > > > +
> > > > > + igt_fixture {
> > > > > + i915 = drm_open_driver(DRIVER_INTEL);
> > > > > + igt_require_gem(i915);
> > > > > +
> > > > > + use_64bit_relocs = intel_gen(intel_get_drm_devid(i915)) >= 8;
> > > > > + }
> > > > > +
> > > > > + igt_subtest("single")
> > > > > + single(i915);
> > > > > +
> > > > > + igt_subtest("exhaustive")
> > > > > + exhaustive(i915);
> > > >
> > > > Do we still need this one? CI time isn't an endless resource (as much as
> > > > we'd want to), neither is our ability to maintain everything. And if all
> > > > we get is timeouts in CI I think there's better uses for that machine
> > > > time. And we do use all the CI machine time, so anytime you take away 10
> > > > minutes, it's 10 minutes of not running some other testcase.
> > >
> > > It's not for CI and not run in CI. CI is not the be all and end all of
> > > testing. We still have to manually find test cases for CI to run...
> >
> > It's run in drmtip runs afaict. That's time shared with a ton of other
> > runs we do, so yeah, more time spent here means less time spent
> > somewhere else. "Adding even more tests" when CI folks seem to say
> > "already takes too long" just seems like the wrong direction.
>
> Which is why I'm replacing it with a slimmer variant.
It's added, not replaced.
> > > > > CI complains that the exhaustive test of trying every size up to the
> > > > > limit is too slow, so add a simple test that tries to submit one
> > > > > extreme batch buffer and check all the relocations land.
>
> But doesn't mean the old test is worthless; far from it.
It's not about 0 value vs !0 value, it's about value/machine time. And
yes it's kinda impossible to be sure that changing the test won't
change coverage in just the worst possible way, but simply keeping all
the tests isn't a solution either.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] i915/gem_exec_big: Add a single shot test
2019-02-13 13:08 ` Daniel Vetter
@ 2019-02-13 13:11 ` Chris Wilson
-1 siblings, 0 replies; 27+ messages in thread
From: Chris Wilson @ 2019-02-13 13:11 UTC (permalink / raw)
To: Daniel Vetter; +Cc: IGT development, intel-gfx
Quoting Daniel Vetter (2019-02-13 13:08:32)
> On Wed, Feb 13, 2019 at 2:05 PM Chris Wilson <chris@chris-wilson.co.uk> wrote:
> >
> > Quoting Daniel Vetter (2019-02-13 13:02:29)
> > > On Wed, Feb 13, 2019 at 11:15 AM Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > > > Quoting Daniel Vetter (2019-02-13 10:11:27)
> > > > > On Tue, Feb 12, 2019 at 10:43:41PM +0000, Chris Wilson wrote:
> > > > > > CI complains that the exhaustive test of trying every size up to the
> > > > > > limit is too slow, so add a simple test that tries to submit one
> > > > > > extreme batch buffer and check all the relocations land.
> > > > > >
> > > > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105555
> > > > > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > > > > > ---
> > > > > > tests/i915/gem_exec_big.c | 70 ++++++++++++++++++++++++++++++------
> > > > > > tests/intel-ci/blacklist.txt | 1 +
> > > > > > 2 files changed, 60 insertions(+), 11 deletions(-)
> > > > > >
> > > > > > diff --git a/tests/i915/gem_exec_big.c b/tests/i915/gem_exec_big.c
> > > > > > index a15672f66..6d7041cf4 100644
> > > > > > --- a/tests/i915/gem_exec_big.c
> > > > > > +++ b/tests/i915/gem_exec_big.c
> > > > > > @@ -71,7 +71,7 @@ static void exec1(int fd, uint32_t handle, uint64_t reloc_ofs, unsigned flags, c
> > > > > > gem_exec[0].relocs_ptr = to_user_pointer(gem_reloc);
> > > > > > gem_exec[0].alignment = 0;
> > > > > > gem_exec[0].offset = 0;
> > > > > > - gem_exec[0].flags = 0;
> > > > > > + gem_exec[0].flags = EXEC_OBJECT_SUPPORTS_48B_ADDRESS;
> > > > > > gem_exec[0].rsvd1 = 0;
> > > > > > gem_exec[0].rsvd2 = 0;
> > > > > >
> > > > > > @@ -154,12 +154,11 @@ static void execN(int fd, uint32_t handle, uint64_t batch_size, unsigned flags,
> > > > > > gem_exec[0].handle = handle;
> > > > > > gem_exec[0].relocation_count = nreloc;
> > > > > > gem_exec[0].relocs_ptr = to_user_pointer(gem_reloc);
> > > > > > + gem_exec[0].flags = EXEC_OBJECT_SUPPORTS_48B_ADDRESS;
> > > > > >
> > > > > > memset(&execbuf, 0, sizeof(execbuf));
> > > > > > execbuf.buffers_ptr = to_user_pointer(gem_exec);
> > > > > > execbuf.buffer_count = 1;
> > > > > > - execbuf.batch_start_offset = 0;
> > > > > > - execbuf.batch_len = 8;
> > > > > > execbuf.flags = flags;
> > > > > >
> > > > > > /* Avoid hitting slowpaths in the reloc processing which might yield a
> > > > > > @@ -197,16 +196,10 @@ static void execN(int fd, uint32_t handle, uint64_t batch_size, unsigned flags,
> > > > > > #undef reloc_ofs
> > > > > > }
> > > > > >
> > > > > > -igt_simple_main
> > > > > > +static void exhaustive(int fd)
> > > > > > {
> > > > > > uint32_t batch[2] = {MI_BATCH_BUFFER_END};
> > > > > > uint64_t batch_size, max, ggtt_max, reloc_ofs;
> > > > > > - int fd;
> > > > > > -
> > > > > > - fd = drm_open_driver(DRIVER_INTEL);
> > > > > > - igt_require_gem(fd);
> > > > > > -
> > > > > > - use_64bit_relocs = intel_gen(intel_get_drm_devid(fd)) >= 8;
> > > > > >
> > > > > > max = 3 * gem_aperture_size(fd) / 4;
> > > > > > ggtt_max = 3 * gem_global_aperture_size(fd) / 4;
> > > > > > @@ -258,6 +251,61 @@ igt_simple_main
> > > > > > else
> > > > > > batch_size *= 2;
> > > > > > }
> > > > > > +}
> > > > > > +
> > > > > > +static void single(int i915)
> > > > > > +{
> > > > > > + const uint32_t bbe = MI_BATCH_BUFFER_END;
> > > > > > + uint64_t batch_size, limit;
> > > > > > + uint32_t handle;
> > > > > > + void *ptr;
> > > > > > +
> > > > > > + batch_size = (intel_get_avail_ram_mb() - 4) << 20; /* internal slack */
> > > > > > + limit = gem_aperture_size(i915) - (256 << 10); /* low pages reserved */
> > > > > > + if (!gem_uses_full_ppgtt(i915))
> > > > > > + limit = 3 * limit / 4;
> > > > > > +
> > > > > > + batch_size = min(batch_size, limit);
> > > > > > + batch_size = ALIGN(batch_size, 4096);
> > > > > > + igt_info("Submitting a %'"PRId64"MiB batch, %saperture size %'"PRId64"MiB\n",
> > > > > > + batch_size >> 20,
> > > > > > + gem_uses_full_ppgtt(i915) ? "" : "shared ",
> > > > > > + gem_aperture_size(i915) >> 20);
> > > > > > + intel_require_memory(1, batch_size, CHECK_RAM);
> > > > > > +
> > > > > > + handle = gem_create(i915, batch_size);
> > > > > > + gem_write(i915, handle, 0, &bbe, sizeof(bbe));
> > > > > > +
> > > > > > + if (!FORCE_PREAD_PWRITE && gem_has_llc(i915))
> > > > > > + ptr = __gem_mmap__cpu(i915, handle, 0, batch_size, PROT_READ);
> > > > > > + else if (!FORCE_PREAD_PWRITE && gem_mmap__has_wc(i915))
> > > > > > + ptr = __gem_mmap__wc(i915, handle, 0, batch_size, PROT_READ);
> > > > > > + else
> > > > > > + ptr = NULL;
> > > > > > +
> > > > > > + execN(i915, handle, batch_size, 0, ptr);
> > > > > > +
> > > > > > + if (ptr)
> > > > > > + munmap(ptr, batch_size);
> > > > > > +}
> > > > > > +
> > > > > > +igt_main
> > > > > > +{
> > > > > > + int i915 = -1;
> > > > > > +
> > > > > > + igt_fixture {
> > > > > > + i915 = drm_open_driver(DRIVER_INTEL);
> > > > > > + igt_require_gem(i915);
> > > > > > +
> > > > > > + use_64bit_relocs = intel_gen(intel_get_drm_devid(i915)) >= 8;
> > > > > > + }
> > > > > > +
> > > > > > + igt_subtest("single")
> > > > > > + single(i915);
> > > > > > +
> > > > > > + igt_subtest("exhaustive")
> > > > > > + exhaustive(i915);
> > > > >
> > > > > Do we still need this one? CI time isn't an endless resource (as much as
> > > > > we'd want to), neither is our ability to maintain everything. And if all
> > > > > we get is timeouts in CI I think there's better uses for that machine
> > > > > time. And we do use all the CI machine time, so anytime you take away 10
> > > > > minutes, it's 10 minutes of not running some other testcase.
> > > >
> > > > It's not for CI and not run in CI. CI is not the be all and end all of
> > > > testing. We still have to manually find test cases for CI to run...
> > >
> > > It's run in drmtip runs afaict. That's time shared with a ton of other
> > > runs we do, so yeah, more time spent here means less time spent
> > > somewhere else. "Adding even more tests" when CI folks seem to say
> > > "already takes too long" just seems like the wrong direction.
> >
> > Which is why I'm replacing it with a slimmer variant.
>
> It's added, not replaced.
It's replaced, just go look at the results if you are in doubt.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] i915/gem_exec_big: Add a single shot test
@ 2019-02-13 13:11 ` Chris Wilson
0 siblings, 0 replies; 27+ messages in thread
From: Chris Wilson @ 2019-02-13 13:11 UTC (permalink / raw)
To: Daniel Vetter; +Cc: IGT development, intel-gfx
Quoting Daniel Vetter (2019-02-13 13:08:32)
> On Wed, Feb 13, 2019 at 2:05 PM Chris Wilson <chris@chris-wilson.co.uk> wrote:
> >
> > Quoting Daniel Vetter (2019-02-13 13:02:29)
> > > On Wed, Feb 13, 2019 at 11:15 AM Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > > > Quoting Daniel Vetter (2019-02-13 10:11:27)
> > > > > On Tue, Feb 12, 2019 at 10:43:41PM +0000, Chris Wilson wrote:
> > > > > > CI complains that the exhaustive test of trying every size up to the
> > > > > > limit is too slow, so add a simple test that tries to submit one
> > > > > > extreme batch buffer and check all the relocations land.
> > > > > >
> > > > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105555
> > > > > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > > > > > ---
> > > > > > tests/i915/gem_exec_big.c | 70 ++++++++++++++++++++++++++++++------
> > > > > > tests/intel-ci/blacklist.txt | 1 +
> > > > > > 2 files changed, 60 insertions(+), 11 deletions(-)
> > > > > >
> > > > > > diff --git a/tests/i915/gem_exec_big.c b/tests/i915/gem_exec_big.c
> > > > > > index a15672f66..6d7041cf4 100644
> > > > > > --- a/tests/i915/gem_exec_big.c
> > > > > > +++ b/tests/i915/gem_exec_big.c
> > > > > > @@ -71,7 +71,7 @@ static void exec1(int fd, uint32_t handle, uint64_t reloc_ofs, unsigned flags, c
> > > > > > gem_exec[0].relocs_ptr = to_user_pointer(gem_reloc);
> > > > > > gem_exec[0].alignment = 0;
> > > > > > gem_exec[0].offset = 0;
> > > > > > - gem_exec[0].flags = 0;
> > > > > > + gem_exec[0].flags = EXEC_OBJECT_SUPPORTS_48B_ADDRESS;
> > > > > > gem_exec[0].rsvd1 = 0;
> > > > > > gem_exec[0].rsvd2 = 0;
> > > > > >
> > > > > > @@ -154,12 +154,11 @@ static void execN(int fd, uint32_t handle, uint64_t batch_size, unsigned flags,
> > > > > > gem_exec[0].handle = handle;
> > > > > > gem_exec[0].relocation_count = nreloc;
> > > > > > gem_exec[0].relocs_ptr = to_user_pointer(gem_reloc);
> > > > > > + gem_exec[0].flags = EXEC_OBJECT_SUPPORTS_48B_ADDRESS;
> > > > > >
> > > > > > memset(&execbuf, 0, sizeof(execbuf));
> > > > > > execbuf.buffers_ptr = to_user_pointer(gem_exec);
> > > > > > execbuf.buffer_count = 1;
> > > > > > - execbuf.batch_start_offset = 0;
> > > > > > - execbuf.batch_len = 8;
> > > > > > execbuf.flags = flags;
> > > > > >
> > > > > > /* Avoid hitting slowpaths in the reloc processing which might yield a
> > > > > > @@ -197,16 +196,10 @@ static void execN(int fd, uint32_t handle, uint64_t batch_size, unsigned flags,
> > > > > > #undef reloc_ofs
> > > > > > }
> > > > > >
> > > > > > -igt_simple_main
> > > > > > +static void exhaustive(int fd)
> > > > > > {
> > > > > > uint32_t batch[2] = {MI_BATCH_BUFFER_END};
> > > > > > uint64_t batch_size, max, ggtt_max, reloc_ofs;
> > > > > > - int fd;
> > > > > > -
> > > > > > - fd = drm_open_driver(DRIVER_INTEL);
> > > > > > - igt_require_gem(fd);
> > > > > > -
> > > > > > - use_64bit_relocs = intel_gen(intel_get_drm_devid(fd)) >= 8;
> > > > > >
> > > > > > max = 3 * gem_aperture_size(fd) / 4;
> > > > > > ggtt_max = 3 * gem_global_aperture_size(fd) / 4;
> > > > > > @@ -258,6 +251,61 @@ igt_simple_main
> > > > > > else
> > > > > > batch_size *= 2;
> > > > > > }
> > > > > > +}
> > > > > > +
> > > > > > +static void single(int i915)
> > > > > > +{
> > > > > > + const uint32_t bbe = MI_BATCH_BUFFER_END;
> > > > > > + uint64_t batch_size, limit;
> > > > > > + uint32_t handle;
> > > > > > + void *ptr;
> > > > > > +
> > > > > > + batch_size = (intel_get_avail_ram_mb() - 4) << 20; /* internal slack */
> > > > > > + limit = gem_aperture_size(i915) - (256 << 10); /* low pages reserved */
> > > > > > + if (!gem_uses_full_ppgtt(i915))
> > > > > > + limit = 3 * limit / 4;
> > > > > > +
> > > > > > + batch_size = min(batch_size, limit);
> > > > > > + batch_size = ALIGN(batch_size, 4096);
> > > > > > + igt_info("Submitting a %'"PRId64"MiB batch, %saperture size %'"PRId64"MiB\n",
> > > > > > + batch_size >> 20,
> > > > > > + gem_uses_full_ppgtt(i915) ? "" : "shared ",
> > > > > > + gem_aperture_size(i915) >> 20);
> > > > > > + intel_require_memory(1, batch_size, CHECK_RAM);
> > > > > > +
> > > > > > + handle = gem_create(i915, batch_size);
> > > > > > + gem_write(i915, handle, 0, &bbe, sizeof(bbe));
> > > > > > +
> > > > > > + if (!FORCE_PREAD_PWRITE && gem_has_llc(i915))
> > > > > > + ptr = __gem_mmap__cpu(i915, handle, 0, batch_size, PROT_READ);
> > > > > > + else if (!FORCE_PREAD_PWRITE && gem_mmap__has_wc(i915))
> > > > > > + ptr = __gem_mmap__wc(i915, handle, 0, batch_size, PROT_READ);
> > > > > > + else
> > > > > > + ptr = NULL;
> > > > > > +
> > > > > > + execN(i915, handle, batch_size, 0, ptr);
> > > > > > +
> > > > > > + if (ptr)
> > > > > > + munmap(ptr, batch_size);
> > > > > > +}
> > > > > > +
> > > > > > +igt_main
> > > > > > +{
> > > > > > + int i915 = -1;
> > > > > > +
> > > > > > + igt_fixture {
> > > > > > + i915 = drm_open_driver(DRIVER_INTEL);
> > > > > > + igt_require_gem(i915);
> > > > > > +
> > > > > > + use_64bit_relocs = intel_gen(intel_get_drm_devid(i915)) >= 8;
> > > > > > + }
> > > > > > +
> > > > > > + igt_subtest("single")
> > > > > > + single(i915);
> > > > > > +
> > > > > > + igt_subtest("exhaustive")
> > > > > > + exhaustive(i915);
> > > > >
> > > > > Do we still need this one? CI time isn't an endless resource (as much as
> > > > > we'd want to), neither is our ability to maintain everything. And if all
> > > > > we get is timeouts in CI I think there's better uses for that machine
> > > > > time. And we do use all the CI machine time, so anytime you take away 10
> > > > > minutes, it's 10 minutes of not running some other testcase.
> > > >
> > > > It's not for CI and not run in CI. CI is not the be all and end all of
> > > > testing. We still have to manually find test cases for CI to run...
> > >
> > > It's run in drmtip runs afaict. That's time shared with a ton of other
> > > runs we do, so yeah, more time spent here means less time spent
> > > somewhere else. "Adding even more tests" when CI folks seem to say
> > > "already takes too long" just seems like the wrong direction.
> >
> > Which is why I'm replacing it with a slimmer variant.
>
> It's added, not replaced.
It's replaced, just go look at the results if you are in doubt.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 27+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for i915/gem_exec_big: Add a single shot test (rev3)
2019-02-12 19:55 ` [igt-dev] " Chris Wilson
` (9 preceding siblings ...)
(?)
@ 2019-02-15 15:29 ` Patchwork
-1 siblings, 0 replies; 27+ messages in thread
From: Patchwork @ 2019-02-15 15:29 UTC (permalink / raw)
To: igt-dev
== Series Details ==
Series: i915/gem_exec_big: Add a single shot test (rev3)
URL : https://patchwork.freedesktop.org/series/56573/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5608 -> IGTPW_2415
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/56573/revisions/3/mbox/
Known issues
------------
Here are the changes found in IGTPW_2415 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a:
- fi-byt-clapper: PASS -> FAIL [fdo#107362]
* igt@prime_vgem@basic-fence-flip:
- fi-ilk-650: PASS -> FAIL [fdo#104008]
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s3:
- {fi-icl-u2}: FAIL [fdo#103375] -> PASS
* igt@i915_selftest@live_evict:
- fi-bsw-kefka: DMESG-WARN [fdo#107709] -> PASS
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: FAIL [fdo#109485] -> PASS
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
- fi-byt-clapper: FAIL [fdo#103191] / [fdo#107362] -> PASS
* igt@pm_rpm@basic-pci-d3-state:
- fi-byt-j1900: {SKIP} [fdo#109271] -> PASS
* igt@pm_rpm@basic-rte:
- fi-byt-j1900: FAIL [fdo#108800] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#104008]: https://bugs.freedesktop.org/show_bug.cgi?id=104008
[fdo#105998]: https://bugs.freedesktop.org/show_bug.cgi?id=105998
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107709]: https://bugs.freedesktop.org/show_bug.cgi?id=107709
[fdo#108622]: https://bugs.freedesktop.org/show_bug.cgi?id=108622
[fdo#108800]: https://bugs.freedesktop.org/show_bug.cgi?id=108800
[fdo#108840]: https://bugs.freedesktop.org/show_bug.cgi?id=108840
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109294]: https://bugs.freedesktop.org/show_bug.cgi?id=109294
[fdo#109485]: https://bugs.freedesktop.org/show_bug.cgi?id=109485
[fdo#109527]: https://bugs.freedesktop.org/show_bug.cgi?id=109527
[fdo#109528]: https://bugs.freedesktop.org/show_bug.cgi?id=109528
[fdo#109530]: https://bugs.freedesktop.org/show_bug.cgi?id=109530
Participating hosts (48 -> 43)
------------------------------
Additional (2): fi-icl-y fi-pnv-d510
Missing (7): fi-kbl-soraka fi-ilk-m540 fi-bxt-dsi fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus
Build changes
-------------
* IGT: IGT_4830 -> IGTPW_2415
CI_DRM_5608: a6301f3b868a688c97ae63d9ad4cb69ff62596bb @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2415: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2415/
IGT_4830: 2fa3de65d6a29bfe0f86da391c7da90791a2a767 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Testlist changes ==
+igt@gem_exec_big@exhaustive
+igt@gem_exec_big@single
-igt@gem_exec_big
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2415/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 27+ messages in thread
* [igt-dev] ✗ Fi.CI.IGT: failure for i915/gem_exec_big: Add a single shot test (rev3)
2019-02-12 19:55 ` [igt-dev] " Chris Wilson
` (10 preceding siblings ...)
(?)
@ 2019-02-15 18:08 ` Patchwork
2019-02-15 18:13 ` Chris Wilson
-1 siblings, 1 reply; 27+ messages in thread
From: Patchwork @ 2019-02-15 18:08 UTC (permalink / raw)
To: igt-dev
== Series Details ==
Series: i915/gem_exec_big: Add a single shot test (rev3)
URL : https://patchwork.freedesktop.org/series/56573/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_5608_full -> IGTPW_2415_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_2415_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_2415_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/56573/revisions/3/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_2415_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_atomic_transition@1x-modeset-transitions-nonblocking:
- shard-apl: NOTRUN -> FAIL
* igt@kms_atomic_transition@1x-modeset-transitions-nonblocking-fencing:
- shard-apl: PASS -> FAIL
New tests
---------
New tests have been introduced between CI_DRM_5608_full and IGTPW_2415_full:
### New IGT tests (1) ###
* igt@gem_exec_big@single:
- Statuses : 3 incomplete(s) 1 pass(s)
- Exec time: [0.0, 2.41] s
Known issues
------------
Here are the changes found in IGTPW_2415_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* {igt@gem_exec_big@single} (NEW):
- shard-kbl: NOTRUN -> INCOMPLETE [fdo#103665]
- shard-glk: NOTRUN -> INCOMPLETE [fdo#103359] / [k.org#198133]
- shard-apl: NOTRUN -> INCOMPLETE [fdo#103927]
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b:
- shard-snb: NOTRUN -> DMESG-WARN [fdo#107956] +1
* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-c:
- shard-kbl: PASS -> DMESG-WARN [fdo#107956]
* igt@kms_ccs@pipe-b-crc-sprite-planes-basic:
- shard-glk: PASS -> FAIL [fdo#108145]
- shard-kbl: PASS -> FAIL [fdo#107725] / [fdo#108145]
* igt@kms_color@pipe-a-ctm-max:
- shard-apl: PASS -> FAIL [fdo#108147]
* igt@kms_color@pipe-c-legacy-gamma:
- shard-apl: PASS -> FAIL [fdo#104782]
* igt@kms_cursor_crc@cursor-256x85-random:
- shard-apl: PASS -> FAIL [fdo#103232] +6
* igt@kms_cursor_crc@cursor-64x21-onscreen:
- shard-kbl: PASS -> FAIL [fdo#103232] +1
* igt@kms_cursor_crc@cursor-64x64-suspend:
- shard-apl: PASS -> FAIL [fdo#103191] / [fdo#103232]
* igt@kms_cursor_crc@cursor-alpha-opaque:
- shard-kbl: PASS -> FAIL [fdo#109350]
- shard-apl: PASS -> FAIL [fdo#109350]
* igt@kms_cursor_crc@cursor-size-change:
- shard-glk: PASS -> FAIL [fdo#103232]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-wc:
- shard-kbl: PASS -> FAIL [fdo#103167]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt:
- shard-apl: PASS -> FAIL [fdo#103167] +1
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff:
- shard-glk: PASS -> FAIL [fdo#103167] +7
* igt@kms_frontbuffer_tracking@fbc-2p-rte:
- shard-glk: PASS -> FAIL [fdo#103167] / [fdo#105682]
* igt@kms_plane@pixel-format-pipe-c-planes:
- shard-glk: PASS -> INCOMPLETE [fdo#103359] / [k.org#198133]
* igt@kms_plane@plane-position-covered-pipe-c-planes:
- shard-apl: PASS -> FAIL [fdo#103166] +4
* igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
- shard-glk: PASS -> FAIL [fdo#103166] +7
* igt@kms_vblank@pipe-b-ts-continuation-dpms-rpm:
- shard-apl: PASS -> FAIL [fdo#104894] +3
- shard-kbl: PASS -> FAIL [fdo#104894] +2
#### Possible fixes ####
* igt@kms_cursor_crc@cursor-256x256-random:
- shard-apl: FAIL [fdo#103232] -> PASS +4
* igt@kms_cursor_crc@cursor-256x256-suspend:
- shard-apl: FAIL [fdo#103191] / [fdo#103232] -> PASS
* igt@kms_cursor_crc@cursor-64x64-dpms:
- shard-kbl: FAIL [fdo#103232] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-onoff:
- shard-kbl: FAIL [fdo#103167] -> PASS +1
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen:
- shard-glk: FAIL [fdo#103167] -> PASS +4
- shard-apl: FAIL [fdo#103167] -> PASS +3
* igt@kms_plane_multiple@atomic-pipe-b-tiling-y:
- shard-apl: FAIL [fdo#103166] -> PASS +6
* igt@kms_plane_multiple@atomic-pipe-c-tiling-x:
- shard-glk: FAIL [fdo#103166] -> PASS +2
* igt@kms_setmode@basic:
- shard-kbl: FAIL [fdo#99912] -> PASS
* igt@kms_universal_plane@universal-plane-pipe-b-functional:
- shard-kbl: FAIL [fdo#103166] -> PASS +1
* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-apl: FAIL [fdo#104894] -> PASS
#### Warnings ####
* igt@i915_hangman@error-state-capture-vebox:
- shard-snb: {SKIP} [fdo#109271] -> INCOMPLETE [fdo#105411] / [fdo#107469]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
[fdo#104894]: https://bugs.freedesktop.org/show_bug.cgi?id=104894
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#105682]: https://bugs.freedesktop.org/show_bug.cgi?id=105682
[fdo#107469]: https://bugs.freedesktop.org/show_bug.cgi?id=107469
[fdo#107725]: https://bugs.freedesktop.org/show_bug.cgi?id=107725
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109350]: https://bugs.freedesktop.org/show_bug.cgi?id=109350
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (7 -> 5)
------------------------------
Missing (2): shard-skl shard-iclb
Build changes
-------------
* IGT: IGT_4830 -> IGTPW_2415
* Piglit: piglit_4509 -> None
CI_DRM_5608: a6301f3b868a688c97ae63d9ad4cb69ff62596bb @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2415: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2415/
IGT_4830: 2fa3de65d6a29bfe0f86da391c7da90791a2a767 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2415/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [igt-dev] ✗ Fi.CI.IGT: failure for i915/gem_exec_big: Add a single shot test (rev3)
2019-02-15 18:08 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
@ 2019-02-15 18:13 ` Chris Wilson
0 siblings, 0 replies; 27+ messages in thread
From: Chris Wilson @ 2019-02-15 18:13 UTC (permalink / raw)
To: Patchwork, igt-dev
Quoting Patchwork (2019-02-15 18:08:25)
> New tests
> ---------
>
> New tests have been introduced between CI_DRM_5608_full and IGTPW_2415_full:
>
> ### New IGT tests (1) ###
>
> * igt@gem_exec_big@single:
> - Statuses : 3 incomplete(s) 1 pass(s)
> - Exec time: [0.0, 2.41] s
Thanks to Martin's new summary, hopefully this convinces that we are
only adding the one subtest and removing the old test.
Now I just have to work out just how much memory java consumes during
the course of the test. WHAT IS IT DOING RUNNING DURING THE TEST?
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 27+ messages in thread
end of thread, other threads:[~2019-02-15 18:13 UTC | newest]
Thread overview: 27+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-12 19:55 [PATCH i-g-t] i915/gem_exec_big: Add a single shot test Chris Wilson
2019-02-12 19:55 ` [igt-dev] " Chris Wilson
2019-02-12 20:41 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-02-12 22:39 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-02-12 22:43 ` [PATCH i-g-t] " Chris Wilson
2019-02-12 22:43 ` [igt-dev] " Chris Wilson
2019-02-13 10:11 ` Daniel Vetter
2019-02-13 10:11 ` Daniel Vetter
2019-02-13 10:14 ` Chris Wilson
2019-02-13 10:14 ` [Intel-gfx] " Chris Wilson
2019-02-13 13:02 ` Daniel Vetter
2019-02-13 13:02 ` Daniel Vetter
2019-02-13 13:05 ` Chris Wilson
2019-02-13 13:05 ` Chris Wilson
2019-02-13 13:08 ` Daniel Vetter
2019-02-13 13:08 ` Daniel Vetter
2019-02-13 13:11 ` Chris Wilson
2019-02-13 13:11 ` Chris Wilson
2019-02-12 23:33 ` [igt-dev] ✓ Fi.CI.BAT: success for i915/gem_exec_big: Add a single shot test (rev2) Patchwork
2019-02-13 0:45 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-02-13 8:58 ` [PATCH i-g-t] i915/gem_exec_big: Add a single shot test Chris Wilson
2019-02-13 9:28 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-02-13 12:55 ` ✓ Fi.CI.IGT: " Patchwork
2019-02-13 13:00 ` [PATCH i-g-t] " Chris Wilson
2019-02-15 15:29 ` [igt-dev] ✓ Fi.CI.BAT: success for i915/gem_exec_big: Add a single shot test (rev3) Patchwork
2019-02-15 18:08 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2019-02-15 18:13 ` Chris Wilson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.