* [U-Boot] [PATCH] MTD: mxs_nand: Fix BCH read timeout error on boards requiring ECC
@ 2019-01-03 2:36 Adam Ford
2019-01-03 15:55 ` Stefan Agner
` (2 more replies)
0 siblings, 3 replies; 11+ messages in thread
From: Adam Ford @ 2019-01-03 2:36 UTC (permalink / raw)
To: u-boot
The LogicPD board uses a Micron Flash with ECC. To boot this from
SPL, the ECC needs to be correctly configured or the BCH engine
times out.
Signed-off-by: Adam Ford <aford173@gmail.com>
diff --git a/drivers/mtd/nand/raw/mxs_nand.c b/drivers/mtd/nand/raw/mxs_nand.c
index e3341812a2..2d84bfffe2 100644
--- a/drivers/mtd/nand/raw/mxs_nand.c
+++ b/drivers/mtd/nand/raw/mxs_nand.c
@@ -1163,6 +1163,12 @@ int mxs_nand_init_spl(struct nand_chip *nand)
nand_info->gpmi_regs = (struct mxs_gpmi_regs *)MXS_GPMI_BASE;
nand_info->bch_regs = (struct mxs_bch_regs *)MXS_BCH_BASE;
+
+ if (is_mx6sx() || is_mx7())
+ nand_info->max_ecc_strength_supported = 62;
+ else
+ nand_info->max_ecc_strength_supported = 40;
+
err = mxs_nand_alloc_buffers(nand_info);
if (err)
return err;
diff --git a/drivers/mtd/nand/raw/mxs_nand_spl.c b/drivers/mtd/nand/raw/mxs_nand_spl.c
index c628f3adec..ba85baac60 100644
--- a/drivers/mtd/nand/raw/mxs_nand_spl.c
+++ b/drivers/mtd/nand/raw/mxs_nand_spl.c
@@ -201,6 +201,7 @@ static int mxs_nand_init(void)
/* setup flash layout (does not scan as we override that) */
mtd->size = nand_chip.chipsize;
nand_chip.scan_bbt(mtd);
+ mxs_nand_setup_ecc(mtd);
return 0;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [U-Boot] [PATCH] MTD: mxs_nand: Fix BCH read timeout error on boards requiring ECC
2019-01-03 2:36 [U-Boot] [PATCH] MTD: mxs_nand: Fix BCH read timeout error on boards requiring ECC Adam Ford
@ 2019-01-03 15:55 ` Stefan Agner
2019-02-02 13:21 ` Jörg Krause
2019-02-04 18:17 ` Tim Harvey
2019-02-16 10:26 ` [U-Boot] " sbabic at denx.de
2 siblings, 1 reply; 11+ messages in thread
From: Stefan Agner @ 2019-01-03 15:55 UTC (permalink / raw)
To: u-boot
[this time using reply to all]
On 03.01.19 03:36, Adam Ford wrote:
> The LogicPD board uses a Micron Flash with ECC. To boot this from
> SPL, the ECC needs to be correctly configured or the BCH engine
> times out.
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
Looks good to me,
Acked-by: Stefan Agner <stefan.agner@toradex.com>
>
> diff --git a/drivers/mtd/nand/raw/mxs_nand.c b/drivers/mtd/nand/raw/mxs_nand.c
> index e3341812a2..2d84bfffe2 100644
> --- a/drivers/mtd/nand/raw/mxs_nand.c
> +++ b/drivers/mtd/nand/raw/mxs_nand.c
> @@ -1163,6 +1163,12 @@ int mxs_nand_init_spl(struct nand_chip *nand)
>
> nand_info->gpmi_regs = (struct mxs_gpmi_regs *)MXS_GPMI_BASE;
> nand_info->bch_regs = (struct mxs_bch_regs *)MXS_BCH_BASE;
> +
> + if (is_mx6sx() || is_mx7())
> + nand_info->max_ecc_strength_supported = 62;
> + else
> + nand_info->max_ecc_strength_supported = 40;
> +
> err = mxs_nand_alloc_buffers(nand_info);
> if (err)
> return err;
> diff --git a/drivers/mtd/nand/raw/mxs_nand_spl.c b/drivers/mtd/nand/raw/mxs_nand_spl.c
> index c628f3adec..ba85baac60 100644
> --- a/drivers/mtd/nand/raw/mxs_nand_spl.c
> +++ b/drivers/mtd/nand/raw/mxs_nand_spl.c
> @@ -201,6 +201,7 @@ static int mxs_nand_init(void)
> /* setup flash layout (does not scan as we override that) */
> mtd->size = nand_chip.chipsize;
> nand_chip.scan_bbt(mtd);
> + mxs_nand_setup_ecc(mtd);
>
> return 0;
> }
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [U-Boot] [PATCH] MTD: mxs_nand: Fix BCH read timeout error on boards requiring ECC
2019-01-03 15:55 ` Stefan Agner
@ 2019-02-02 13:21 ` Jörg Krause
0 siblings, 0 replies; 11+ messages in thread
From: Jörg Krause @ 2019-02-02 13:21 UTC (permalink / raw)
To: u-boot
Hi,
On Thu, 2019-01-03 at 15:55 +0000, Stefan Agner wrote:
> [this time using reply to all]
>
> On 03.01.19 03:36, Adam Ford wrote:
> > The LogicPD board uses a Micron Flash with ECC. To boot this from
> > SPL, the ECC needs to be correctly configured or the BCH engine
> > times out.
> >
> > Signed-off-by: Adam Ford <aford173@gmail.com>
>
> Looks good to me,
>
> Acked-by: Stefan Agner <stefan.agner@toradex.com>
Tested on a custom i.MX6ULL board with Micron NAND flash.
Fixes:
"""
Trying to boot from NAND
MXS NAND: BCH read timeout
...
MXS NAND: BCH read timeout
"""
Tested-by: Jörg Krause <joerg.krause@embedded.rocks>
> > diff --git a/drivers/mtd/nand/raw/mxs_nand.c b/drivers/mtd/nand/raw/mxs_nand.c
> > index e3341812a2..2d84bfffe2 100644
> > --- a/drivers/mtd/nand/raw/mxs_nand.c
> > +++ b/drivers/mtd/nand/raw/mxs_nand.c
> > @@ -1163,6 +1163,12 @@ int mxs_nand_init_spl(struct nand_chip *nand)
> >
> > nand_info->gpmi_regs = (struct mxs_gpmi_regs *)MXS_GPMI_BASE;
> > nand_info->bch_regs = (struct mxs_bch_regs *)MXS_BCH_BASE;
> > +
> > + if (is_mx6sx() || is_mx7())
> > + nand_info->max_ecc_strength_supported = 62;
> > + else
> > + nand_info->max_ecc_strength_supported = 40;
> > +
> > err = mxs_nand_alloc_buffers(nand_info);
> > if (err)
> > return err;
> > diff --git a/drivers/mtd/nand/raw/mxs_nand_spl.c b/drivers/mtd/nand/raw/mxs_nand_spl.c
> > index c628f3adec..ba85baac60 100644
> > --- a/drivers/mtd/nand/raw/mxs_nand_spl.c
> > +++ b/drivers/mtd/nand/raw/mxs_nand_spl.c
> > @@ -201,6 +201,7 @@ static int mxs_nand_init(void)
> > /* setup flash layout (does not scan as we override that) */
> > mtd->size = nand_chip.chipsize;
> > nand_chip.scan_bbt(mtd);
> > + mxs_nand_setup_ecc(mtd);
> >
> > return 0;
> > }
> >
^ permalink raw reply [flat|nested] 11+ messages in thread
* [U-Boot] [PATCH] MTD: mxs_nand: Fix BCH read timeout error on boards requiring ECC
2019-01-03 2:36 [U-Boot] [PATCH] MTD: mxs_nand: Fix BCH read timeout error on boards requiring ECC Adam Ford
2019-01-03 15:55 ` Stefan Agner
@ 2019-02-04 18:17 ` Tim Harvey
2019-02-10 13:30 ` Adam Ford
2019-02-16 10:26 ` [U-Boot] " sbabic at denx.de
2 siblings, 1 reply; 11+ messages in thread
From: Tim Harvey @ 2019-02-04 18:17 UTC (permalink / raw)
To: u-boot
On Wed, Jan 2, 2019 at 6:37 PM Adam Ford <aford173@gmail.com> wrote:
>
> The LogicPD board uses a Micron Flash with ECC. To boot this from
> SPL, the ECC needs to be correctly configured or the BCH engine
> times out.
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
>
> diff --git a/drivers/mtd/nand/raw/mxs_nand.c b/drivers/mtd/nand/raw/mxs_nand.c
> index e3341812a2..2d84bfffe2 100644
> --- a/drivers/mtd/nand/raw/mxs_nand.c
> +++ b/drivers/mtd/nand/raw/mxs_nand.c
> @@ -1163,6 +1163,12 @@ int mxs_nand_init_spl(struct nand_chip *nand)
>
> nand_info->gpmi_regs = (struct mxs_gpmi_regs *)MXS_GPMI_BASE;
> nand_info->bch_regs = (struct mxs_bch_regs *)MXS_BCH_BASE;
> +
> + if (is_mx6sx() || is_mx7())
> + nand_info->max_ecc_strength_supported = 62;
> + else
> + nand_info->max_ecc_strength_supported = 40;
> +
> err = mxs_nand_alloc_buffers(nand_info);
> if (err)
> return err;
> diff --git a/drivers/mtd/nand/raw/mxs_nand_spl.c b/drivers/mtd/nand/raw/mxs_nand_spl.c
> index c628f3adec..ba85baac60 100644
> --- a/drivers/mtd/nand/raw/mxs_nand_spl.c
> +++ b/drivers/mtd/nand/raw/mxs_nand_spl.c
> @@ -201,6 +201,7 @@ static int mxs_nand_init(void)
> /* setup flash layout (does not scan as we override that) */
> mtd->size = nand_chip.chipsize;
> nand_chip.scan_bbt(mtd);
> + mxs_nand_setup_ecc(mtd);
>
> return 0;
> }
> --
> 2.17.1
>
Thanks Adam,
This resolves failed booting on Gateworks Ventana IMX6 with NAND SPL
for MT29F2G08AB 2Gbit (oob=64)
Acked-by: Tim Harvey <tharvey@gateworks.com>
Tested-by: Tim Harvey <tharvey@gateworks.com>
for GW5100 with MT29F2G08AB 2Gbit (oob=64)
^ permalink raw reply [flat|nested] 11+ messages in thread
* [U-Boot] [PATCH] MTD: mxs_nand: Fix BCH read timeout error on boards requiring ECC
2019-02-04 18:17 ` Tim Harvey
@ 2019-02-10 13:30 ` Adam Ford
2019-02-10 13:48 ` Adam Ford
0 siblings, 1 reply; 11+ messages in thread
From: Adam Ford @ 2019-02-10 13:30 UTC (permalink / raw)
To: u-boot
On Mon, Feb 4, 2019 at 12:17 PM Tim Harvey <tharvey@gateworks.com> wrote:
>
> On Wed, Jan 2, 2019 at 6:37 PM Adam Ford <aford173@gmail.com> wrote:
> >
> > The LogicPD board uses a Micron Flash with ECC. To boot this from
> > SPL, the ECC needs to be correctly configured or the BCH engine
> > times out.
> >
> > Signed-off-by: Adam Ford <aford173@gmail.com>
> >
> > diff --git a/drivers/mtd/nand/raw/mxs_nand.c b/drivers/mtd/nand/raw/mxs_nand.c
> > index e3341812a2..2d84bfffe2 100644
> > --- a/drivers/mtd/nand/raw/mxs_nand.c
> > +++ b/drivers/mtd/nand/raw/mxs_nand.c
> > @@ -1163,6 +1163,12 @@ int mxs_nand_init_spl(struct nand_chip *nand)
> >
> > nand_info->gpmi_regs = (struct mxs_gpmi_regs *)MXS_GPMI_BASE;
> > nand_info->bch_regs = (struct mxs_bch_regs *)MXS_BCH_BASE;
> > +
> > + if (is_mx6sx() || is_mx7())
> > + nand_info->max_ecc_strength_supported = 62;
> > + else
> > + nand_info->max_ecc_strength_supported = 40;
> > +
> > err = mxs_nand_alloc_buffers(nand_info);
> > if (err)
> > return err;
> > diff --git a/drivers/mtd/nand/raw/mxs_nand_spl.c b/drivers/mtd/nand/raw/mxs_nand_spl.c
> > index c628f3adec..ba85baac60 100644
> > --- a/drivers/mtd/nand/raw/mxs_nand_spl.c
> > +++ b/drivers/mtd/nand/raw/mxs_nand_spl.c
> > @@ -201,6 +201,7 @@ static int mxs_nand_init(void)
> > /* setup flash layout (does not scan as we override that) */
> > mtd->size = nand_chip.chipsize;
> > nand_chip.scan_bbt(mtd);
> > + mxs_nand_setup_ecc(mtd);
> >
> > return 0;
> > }
> > --
> > 2.17.1
> >
>
> Thanks Adam,
Scott / Stefano,
Any chance this can get reviewed and/or applied for the next release?
We've got a few people who have their respective tested-by comments.
adam
>
> This resolves failed booting on Gateworks Ventana IMX6 with NAND SPL
> for MT29F2G08AB 2Gbit (oob=64)
>
> Acked-by: Tim Harvey <tharvey@gateworks.com>
>
> Tested-by: Tim Harvey <tharvey@gateworks.com>
> for GW5100 with MT29F2G08AB 2Gbit (oob=64)
^ permalink raw reply [flat|nested] 11+ messages in thread
* [U-Boot] [PATCH] MTD: mxs_nand: Fix BCH read timeout error on boards requiring ECC
2019-02-10 13:30 ` Adam Ford
@ 2019-02-10 13:48 ` Adam Ford
2019-02-12 21:38 ` Scott Wood
0 siblings, 1 reply; 11+ messages in thread
From: Adam Ford @ 2019-02-10 13:48 UTC (permalink / raw)
To: u-boot
On Sun, Feb 10, 2019 at 7:30 AM Adam Ford <aford173@gmail.com> wrote:
>
> On Mon, Feb 4, 2019 at 12:17 PM Tim Harvey <tharvey@gateworks.com> wrote:
> >
> > On Wed, Jan 2, 2019 at 6:37 PM Adam Ford <aford173@gmail.com> wrote:
> > >
> > > The LogicPD board uses a Micron Flash with ECC. To boot this from
> > > SPL, the ECC needs to be correctly configured or the BCH engine
> > > times out.
> > >
> > > Signed-off-by: Adam Ford <aford173@gmail.com>
> > >
> > > diff --git a/drivers/mtd/nand/raw/mxs_nand.c b/drivers/mtd/nand/raw/mxs_nand.c
> > > index e3341812a2..2d84bfffe2 100644
> > > --- a/drivers/mtd/nand/raw/mxs_nand.c
> > > +++ b/drivers/mtd/nand/raw/mxs_nand.c
> > > @@ -1163,6 +1163,12 @@ int mxs_nand_init_spl(struct nand_chip *nand)
> > >
> > > nand_info->gpmi_regs = (struct mxs_gpmi_regs *)MXS_GPMI_BASE;
> > > nand_info->bch_regs = (struct mxs_bch_regs *)MXS_BCH_BASE;
> > > +
> > > + if (is_mx6sx() || is_mx7())
> > > + nand_info->max_ecc_strength_supported = 62;
> > > + else
> > > + nand_info->max_ecc_strength_supported = 40;
> > > +
> > > err = mxs_nand_alloc_buffers(nand_info);
> > > if (err)
> > > return err;
> > > diff --git a/drivers/mtd/nand/raw/mxs_nand_spl.c b/drivers/mtd/nand/raw/mxs_nand_spl.c
> > > index c628f3adec..ba85baac60 100644
> > > --- a/drivers/mtd/nand/raw/mxs_nand_spl.c
> > > +++ b/drivers/mtd/nand/raw/mxs_nand_spl.c
> > > @@ -201,6 +201,7 @@ static int mxs_nand_init(void)
> > > /* setup flash layout (does not scan as we override that) */
> > > mtd->size = nand_chip.chipsize;
> > > nand_chip.scan_bbt(mtd);
> > > + mxs_nand_setup_ecc(mtd);
> > >
> > > return 0;
> > > }
> > > --
> > > 2.17.1
> > >
> >
> > Thanks Adam,
>
Scott / Stefano,
I had to use Scott's other -email.
Any chance this can get reviewed and/or applied for the next release?
We've got a few people who have their respective tested-by comments.
adam
> >
> > This resolves failed booting on Gateworks Ventana IMX6 with NAND SPL
> > for MT29F2G08AB 2Gbit (oob=64)
> >
> > Acked-by: Tim Harvey <tharvey@gateworks.com>
> >
> > Tested-by: Tim Harvey <tharvey@gateworks.com>
> > for GW5100 with MT29F2G08AB 2Gbit (oob=64)
^ permalink raw reply [flat|nested] 11+ messages in thread
* [U-Boot] [PATCH] MTD: mxs_nand: Fix BCH read timeout error on boards requiring ECC
2019-02-10 13:48 ` Adam Ford
@ 2019-02-12 21:38 ` Scott Wood
2019-02-12 21:44 ` Adam Ford
0 siblings, 1 reply; 11+ messages in thread
From: Scott Wood @ 2019-02-12 21:38 UTC (permalink / raw)
To: u-boot
On Sun, 2019-02-10 at 07:48 -0600, Adam Ford wrote:
> On Sun, Feb 10, 2019 at 7:30 AM Adam Ford <aford173@gmail.com> wrote:
> >
> > On Mon, Feb 4, 2019 at 12:17 PM Tim Harvey <tharvey@gateworks.com> wrote:
> > >
> > > On Wed, Jan 2, 2019 at 6:37 PM Adam Ford <aford173@gmail.com> wrote:
> > > >
> > > > The LogicPD board uses a Micron Flash with ECC. To boot this from
> > > > SPL, the ECC needs to be correctly configured or the BCH engine
> > > > times out.
> > > >
> > > > Signed-off-by: Adam Ford <aford173@gmail.com>
> > > >
> > > > diff --git a/drivers/mtd/nand/raw/mxs_nand.c
> > > > b/drivers/mtd/nand/raw/mxs_nand.c
> > > > index e3341812a2..2d84bfffe2 100644
> > > > --- a/drivers/mtd/nand/raw/mxs_nand.c
> > > > +++ b/drivers/mtd/nand/raw/mxs_nand.c
> > > > @@ -1163,6 +1163,12 @@ int mxs_nand_init_spl(struct nand_chip *nand)
> > > >
> > > > nand_info->gpmi_regs = (struct mxs_gpmi_regs *)MXS_GPMI_BASE;
> > > > nand_info->bch_regs = (struct mxs_bch_regs *)MXS_BCH_BASE;
> > > > +
> > > > + if (is_mx6sx() || is_mx7())
> > > > + nand_info->max_ecc_strength_supported = 62;
> > > > + else
> > > > + nand_info->max_ecc_strength_supported = 40;
> > > > +
> > > > err = mxs_nand_alloc_buffers(nand_info);
> > > > if (err)
> > > > return err;
> > > > diff --git a/drivers/mtd/nand/raw/mxs_nand_spl.c
> > > > b/drivers/mtd/nand/raw/mxs_nand_spl.c
> > > > index c628f3adec..ba85baac60 100644
> > > > --- a/drivers/mtd/nand/raw/mxs_nand_spl.c
> > > > +++ b/drivers/mtd/nand/raw/mxs_nand_spl.c
> > > > @@ -201,6 +201,7 @@ static int mxs_nand_init(void)
> > > > /* setup flash layout (does not scan as we override that) */
> > > > mtd->size = nand_chip.chipsize;
> > > > nand_chip.scan_bbt(mtd);
> > > > + mxs_nand_setup_ecc(mtd);
> > > >
> > > > return 0;
> > > > }
> > > > --
> > > > 2.17.1
> > > >
> > >
> > > Thanks Adam,
>
> Scott / Stefano,
>
> I had to use Scott's other -email.
>
>
> Any chance this can get reviewed and/or applied for the next release?
> We've got a few people who have their respective tested-by comments.
I haven't been involved in U-Boot for a while now.
-Scott
^ permalink raw reply [flat|nested] 11+ messages in thread
* [U-Boot] [PATCH] MTD: mxs_nand: Fix BCH read timeout error on boards requiring ECC
2019-02-12 21:38 ` Scott Wood
@ 2019-02-12 21:44 ` Adam Ford
2019-02-12 23:05 ` Tom Rini
0 siblings, 1 reply; 11+ messages in thread
From: Adam Ford @ 2019-02-12 21:44 UTC (permalink / raw)
To: u-boot
On Tue, Feb 12, 2019 at 3:41 PM Scott Wood <oss@buserror.net> wrote:
>
> On Sun, 2019-02-10 at 07:48 -0600, Adam Ford wrote:
> > On Sun, Feb 10, 2019 at 7:30 AM Adam Ford <aford173@gmail.com> wrote:
> > >
> > > On Mon, Feb 4, 2019 at 12:17 PM Tim Harvey <tharvey@gateworks.com> wrote:
> > > >
> > > > On Wed, Jan 2, 2019 at 6:37 PM Adam Ford <aford173@gmail.com> wrote:
> > > > >
> > > > > The LogicPD board uses a Micron Flash with ECC. To boot this from
> > > > > SPL, the ECC needs to be correctly configured or the BCH engine
> > > > > times out.
> > > > >
> > > > > Signed-off-by: Adam Ford <aford173@gmail.com>
> > > > >
> > > > > diff --git a/drivers/mtd/nand/raw/mxs_nand.c
> > > > > b/drivers/mtd/nand/raw/mxs_nand.c
> > > > > index e3341812a2..2d84bfffe2 100644
> > > > > --- a/drivers/mtd/nand/raw/mxs_nand.c
> > > > > +++ b/drivers/mtd/nand/raw/mxs_nand.c
> > > > > @@ -1163,6 +1163,12 @@ int mxs_nand_init_spl(struct nand_chip *nand)
> > > > >
> > > > > nand_info->gpmi_regs = (struct mxs_gpmi_regs *)MXS_GPMI_BASE;
> > > > > nand_info->bch_regs = (struct mxs_bch_regs *)MXS_BCH_BASE;
> > > > > +
> > > > > + if (is_mx6sx() || is_mx7())
> > > > > + nand_info->max_ecc_strength_supported = 62;
> > > > > + else
> > > > > + nand_info->max_ecc_strength_supported = 40;
> > > > > +
> > > > > err = mxs_nand_alloc_buffers(nand_info);
> > > > > if (err)
> > > > > return err;
> > > > > diff --git a/drivers/mtd/nand/raw/mxs_nand_spl.c
> > > > > b/drivers/mtd/nand/raw/mxs_nand_spl.c
> > > > > index c628f3adec..ba85baac60 100644
> > > > > --- a/drivers/mtd/nand/raw/mxs_nand_spl.c
> > > > > +++ b/drivers/mtd/nand/raw/mxs_nand_spl.c
> > > > > @@ -201,6 +201,7 @@ static int mxs_nand_init(void)
> > > > > /* setup flash layout (does not scan as we override that) */
> > > > > mtd->size = nand_chip.chipsize;
> > > > > nand_chip.scan_bbt(mtd);
> > > > > + mxs_nand_setup_ecc(mtd);
> > > > >
> > > > > return 0;
> > > > > }
> > > > > --
> > > > > 2.17.1
> > > > >
> > > >
> > > > Thanks Adam,
> >
> > Scott / Stefano,
> >
> > I had to use Scott's other -email.
> >
> >
> > Any chance this can get reviewed and/or applied for the next release?
> > We've got a few people who have their respective tested-by comments.
>
> I haven't been involved in U-Boot for a while now.
Tom / Stefano,
Patchwork is showing this is being delegated to Scott, but he's saying
he isn't the right person. Is there someone else who can review
and/or apply a few of these patches designated to Scott? Both of the
patches I care about deligated to him are imx6 related
thanks,
adam
>
> -Scott
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [U-Boot] [PATCH] MTD: mxs_nand: Fix BCH read timeout error on boards requiring ECC
2019-02-12 21:44 ` Adam Ford
@ 2019-02-12 23:05 ` Tom Rini
2019-02-13 7:42 ` Stefano Babic
0 siblings, 1 reply; 11+ messages in thread
From: Tom Rini @ 2019-02-12 23:05 UTC (permalink / raw)
To: u-boot
On Tue, Feb 12, 2019 at 03:44:05PM -0600, Adam Ford wrote:
> On Tue, Feb 12, 2019 at 3:41 PM Scott Wood <oss@buserror.net> wrote:
> >
> > On Sun, 2019-02-10 at 07:48 -0600, Adam Ford wrote:
> > > On Sun, Feb 10, 2019 at 7:30 AM Adam Ford <aford173@gmail.com> wrote:
> > > >
> > > > On Mon, Feb 4, 2019 at 12:17 PM Tim Harvey <tharvey@gateworks.com> wrote:
> > > > >
> > > > > On Wed, Jan 2, 2019 at 6:37 PM Adam Ford <aford173@gmail.com> wrote:
> > > > > >
> > > > > > The LogicPD board uses a Micron Flash with ECC. To boot this from
> > > > > > SPL, the ECC needs to be correctly configured or the BCH engine
> > > > > > times out.
> > > > > >
> > > > > > Signed-off-by: Adam Ford <aford173@gmail.com>
> > > > > >
> > > > > > diff --git a/drivers/mtd/nand/raw/mxs_nand.c
> > > > > > b/drivers/mtd/nand/raw/mxs_nand.c
> > > > > > index e3341812a2..2d84bfffe2 100644
> > > > > > --- a/drivers/mtd/nand/raw/mxs_nand.c
> > > > > > +++ b/drivers/mtd/nand/raw/mxs_nand.c
> > > > > > @@ -1163,6 +1163,12 @@ int mxs_nand_init_spl(struct nand_chip *nand)
> > > > > >
> > > > > > nand_info->gpmi_regs = (struct mxs_gpmi_regs *)MXS_GPMI_BASE;
> > > > > > nand_info->bch_regs = (struct mxs_bch_regs *)MXS_BCH_BASE;
> > > > > > +
> > > > > > + if (is_mx6sx() || is_mx7())
> > > > > > + nand_info->max_ecc_strength_supported = 62;
> > > > > > + else
> > > > > > + nand_info->max_ecc_strength_supported = 40;
> > > > > > +
> > > > > > err = mxs_nand_alloc_buffers(nand_info);
> > > > > > if (err)
> > > > > > return err;
> > > > > > diff --git a/drivers/mtd/nand/raw/mxs_nand_spl.c
> > > > > > b/drivers/mtd/nand/raw/mxs_nand_spl.c
> > > > > > index c628f3adec..ba85baac60 100644
> > > > > > --- a/drivers/mtd/nand/raw/mxs_nand_spl.c
> > > > > > +++ b/drivers/mtd/nand/raw/mxs_nand_spl.c
> > > > > > @@ -201,6 +201,7 @@ static int mxs_nand_init(void)
> > > > > > /* setup flash layout (does not scan as we override that) */
> > > > > > mtd->size = nand_chip.chipsize;
> > > > > > nand_chip.scan_bbt(mtd);
> > > > > > + mxs_nand_setup_ecc(mtd);
> > > > > >
> > > > > > return 0;
> > > > > > }
> > > > > > --
> > > > > > 2.17.1
> > > > > >
> > > > >
> > > > > Thanks Adam,
> > >
> > > Scott / Stefano,
> > >
> > > I had to use Scott's other -email.
> > >
> > >
> > > Any chance this can get reviewed and/or applied for the next release?
> > > We've got a few people who have their respective tested-by comments.
> >
> > I haven't been involved in U-Boot for a while now.
>
> Tom / Stefano,
>
> Patchwork is showing this is being delegated to Scott, but he's saying
> he isn't the right person. Is there someone else who can review
> and/or apply a few of these patches designated to Scott? Both of the
> patches I care about deligated to him are imx6 related
I've assigned the mxs related patches to Stefano, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190212/902fe63b/attachment.sig>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [U-Boot] [PATCH] MTD: mxs_nand: Fix BCH read timeout error on boards requiring ECC
2019-02-12 23:05 ` Tom Rini
@ 2019-02-13 7:42 ` Stefano Babic
0 siblings, 0 replies; 11+ messages in thread
From: Stefano Babic @ 2019-02-13 7:42 UTC (permalink / raw)
To: u-boot
On 13/02/19 00:05, Tom Rini wrote:
> On Tue, Feb 12, 2019 at 03:44:05PM -0600, Adam Ford wrote:
>> On Tue, Feb 12, 2019 at 3:41 PM Scott Wood <oss@buserror.net> wrote:
>>>
>>> On Sun, 2019-02-10 at 07:48 -0600, Adam Ford wrote:
>>>> On Sun, Feb 10, 2019 at 7:30 AM Adam Ford <aford173@gmail.com> wrote:
>>>>>
>>>>> On Mon, Feb 4, 2019 at 12:17 PM Tim Harvey <tharvey@gateworks.com> wrote:
>>>>>>
>>>>>> On Wed, Jan 2, 2019 at 6:37 PM Adam Ford <aford173@gmail.com> wrote:
>>>>>>>
>>>>>>> The LogicPD board uses a Micron Flash with ECC. To boot this from
>>>>>>> SPL, the ECC needs to be correctly configured or the BCH engine
>>>>>>> times out.
>>>>>>>
>>>>>>> Signed-off-by: Adam Ford <aford173@gmail.com>
>>>>>>>
>>>>>>> diff --git a/drivers/mtd/nand/raw/mxs_nand.c
>>>>>>> b/drivers/mtd/nand/raw/mxs_nand.c
>>>>>>> index e3341812a2..2d84bfffe2 100644
>>>>>>> --- a/drivers/mtd/nand/raw/mxs_nand.c
>>>>>>> +++ b/drivers/mtd/nand/raw/mxs_nand.c
>>>>>>> @@ -1163,6 +1163,12 @@ int mxs_nand_init_spl(struct nand_chip *nand)
>>>>>>>
>>>>>>> nand_info->gpmi_regs = (struct mxs_gpmi_regs *)MXS_GPMI_BASE;
>>>>>>> nand_info->bch_regs = (struct mxs_bch_regs *)MXS_BCH_BASE;
>>>>>>> +
>>>>>>> + if (is_mx6sx() || is_mx7())
>>>>>>> + nand_info->max_ecc_strength_supported = 62;
>>>>>>> + else
>>>>>>> + nand_info->max_ecc_strength_supported = 40;
>>>>>>> +
>>>>>>> err = mxs_nand_alloc_buffers(nand_info);
>>>>>>> if (err)
>>>>>>> return err;
>>>>>>> diff --git a/drivers/mtd/nand/raw/mxs_nand_spl.c
>>>>>>> b/drivers/mtd/nand/raw/mxs_nand_spl.c
>>>>>>> index c628f3adec..ba85baac60 100644
>>>>>>> --- a/drivers/mtd/nand/raw/mxs_nand_spl.c
>>>>>>> +++ b/drivers/mtd/nand/raw/mxs_nand_spl.c
>>>>>>> @@ -201,6 +201,7 @@ static int mxs_nand_init(void)
>>>>>>> /* setup flash layout (does not scan as we override that) */
>>>>>>> mtd->size = nand_chip.chipsize;
>>>>>>> nand_chip.scan_bbt(mtd);
>>>>>>> + mxs_nand_setup_ecc(mtd);
>>>>>>>
>>>>>>> return 0;
>>>>>>> }
>>>>>>> --
>>>>>>> 2.17.1
>>>>>>>
>>>>>>
>>>>>> Thanks Adam,
>>>>
>>>> Scott / Stefano,
>>>>
>>>> I had to use Scott's other -email.
>>>>
>>>>
>>>> Any chance this can get reviewed and/or applied for the next release?
>>>> We've got a few people who have their respective tested-by comments.
>>>
>>> I haven't been involved in U-Boot for a while now.
>>
>> Tom / Stefano,
>>
>> Patchwork is showing this is being delegated to Scott, but he's saying
>> he isn't the right person. Is there someone else who can review
>> and/or apply a few of these patches designated to Scott? Both of the
>> patches I care about deligated to him are imx6 related
>
> I've assigned the mxs related patches to Stefano, thanks!
>
Ok, thanks - I take care of this.
Regards,
Stefano
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 11+ messages in thread
* [U-Boot] MTD: mxs_nand: Fix BCH read timeout error on boards requiring ECC
2019-01-03 2:36 [U-Boot] [PATCH] MTD: mxs_nand: Fix BCH read timeout error on boards requiring ECC Adam Ford
2019-01-03 15:55 ` Stefan Agner
2019-02-04 18:17 ` Tim Harvey
@ 2019-02-16 10:26 ` sbabic at denx.de
2 siblings, 0 replies; 11+ messages in thread
From: sbabic at denx.de @ 2019-02-16 10:26 UTC (permalink / raw)
To: u-boot
> The LogicPD board uses a Micron Flash with ECC. To boot this from
> SPL, the ECC needs to be correctly configured or the BCH engine
> times out.
> Signed-off-by: Adam Ford <aford173@gmail.com>
> Acked-by: Stefan Agner <stefan.agner@toradex.com>
> Tested-by: Jörg Krause <joerg.krause@embedded.rocks>
> Acked-by: Tim Harvey <tharvey@gateworks.com>
> Tested-by: Tim Harvey <tharvey@gateworks.com>
> diff --git a/drivers/mtd/nand/raw/mxs_nand.c b/drivers/mtd/nand/raw/mxs_nand.c
> index e3341812a2..2d84bfffe2 100644
> --- a/drivers/mtd/nand/raw/mxs_nand.c
> +++ b/drivers/mtd/nand/raw/mxs_nand.c
> @@ -1163,6 +1163,12 @@ int mxs_nand_init_spl(struct nand_chip *nand)
>
> nand_info->gpmi_regs = (struct mxs_gpmi_regs *)MXS_GPMI_BASE;
> nand_info->bch_regs = (struct mxs_bch_regs *)MXS_BCH_BASE;
> +
> + if (is_mx6sx() || is_mx7())
> + nand_info->max_ecc_strength_supported = 62;
> + else
> + nand_info->max_ecc_strength_supported = 40;
> +
> err = mxs_nand_alloc_buffers(nand_info);
> if (err)
> return err;
> diff --git a/drivers/mtd/nand/raw/mxs_nand_spl.c b/drivers/mtd/nand/raw/mxs_nand_spl.c
> index c628f3adec..ba85baac60 100644
> --- a/drivers/mtd/nand/raw/mxs_nand_spl.c
> +++ b/drivers/mtd/nand/raw/mxs_nand_spl.c
> @@ -201,6 +201,7 @@ static int mxs_nand_init(void)
> /* setup flash layout (does not scan as we override that) */
> mtd->size = nand_chip.chipsize;
> nand_chip.scan_bbt(mtd);
> + mxs_nand_setup_ecc(mtd);
>
> return 0;
> }
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2019-02-16 10:26 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-03 2:36 [U-Boot] [PATCH] MTD: mxs_nand: Fix BCH read timeout error on boards requiring ECC Adam Ford
2019-01-03 15:55 ` Stefan Agner
2019-02-02 13:21 ` Jörg Krause
2019-02-04 18:17 ` Tim Harvey
2019-02-10 13:30 ` Adam Ford
2019-02-10 13:48 ` Adam Ford
2019-02-12 21:38 ` Scott Wood
2019-02-12 21:44 ` Adam Ford
2019-02-12 23:05 ` Tom Rini
2019-02-13 7:42 ` Stefano Babic
2019-02-16 10:26 ` [U-Boot] " sbabic at denx.de
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.