* [PATCH -next] RDMA/iwpm: Remove set but not used variable 'msg_seq'
@ 2019-02-14 1:57 YueHaibing
2019-02-14 21:48 ` Jason Gunthorpe
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2019-02-14 1:57 UTC (permalink / raw)
To: kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/infiniband/core/iwpm_util.c: In function 'iwpm_send_hello':
drivers/infiniband/core/iwpm_util.c:811:6: warning:
variable 'msg_seq' set but not used [-Wunused-but-set-variable]
It never used since introduction in commit b0bad9ad514f ("RDMA/IWPM: Support
no port mapping requirements")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/infiniband/core/iwpm_util.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/infiniband/core/iwpm_util.c b/drivers/infiniband/core/iwpm_util.c
index 7b97f6e2075f..a5d2a20ee697 100644
--- a/drivers/infiniband/core/iwpm_util.c
+++ b/drivers/infiniband/core/iwpm_util.c
@@ -808,7 +808,6 @@ int iwpm_send_hello(u8 nl_client, int iwpm_pid, u16 abi_version)
{
struct sk_buff *skb = NULL;
struct nlmsghdr *nlh;
- u32 msg_seq;
const char *err_str = "";
int ret = -EINVAL;
@@ -818,7 +817,6 @@ int iwpm_send_hello(u8 nl_client, int iwpm_pid, u16 abi_version)
goto hello_num_error;
}
nlh->nlmsg_seq = iwpm_get_nlmsg_seq();
- msg_seq = 0;
err_str = "Unable to put attribute of abi_version into nlmsg";
ret = ibnl_put_attr(skb, nlh, sizeof(u16), &abi_version,
IWPM_NLA_HELLO_ABI_VERSION);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] RDMA/iwpm: Remove set but not used variable 'msg_seq'
2019-02-14 1:57 [PATCH -next] RDMA/iwpm: Remove set but not used variable 'msg_seq' YueHaibing
@ 2019-02-14 21:48 ` Jason Gunthorpe
0 siblings, 0 replies; 2+ messages in thread
From: Jason Gunthorpe @ 2019-02-14 21:48 UTC (permalink / raw)
To: kernel-janitors
On Thu, Feb 14, 2019 at 01:57:10AM +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/infiniband/core/iwpm_util.c: In function 'iwpm_send_hello':
> drivers/infiniband/core/iwpm_util.c:811:6: warning:
> variable 'msg_seq' set but not used [-Wunused-but-set-variable]
>
> It never used since introduction in commit b0bad9ad514f ("RDMA/IWPM: Support
> no port mapping requirements")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/infiniband/core/iwpm_util.c | 2 --
> 1 file changed, 2 deletions(-)
applied to for-next, thanks
Jason
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-02-14 21:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-14 1:57 [PATCH -next] RDMA/iwpm: Remove set but not used variable 'msg_seq' YueHaibing
2019-02-14 21:48 ` Jason Gunthorpe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.