All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] package/docker-containerd: fix typo in uclibc dependency
@ 2019-02-14  8:53 Thomas Petazzoni
  2019-02-14 10:06 ` Peter Korsgaard
  2019-02-21 12:53 ` Peter Korsgaard
  0 siblings, 2 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2019-02-14  8:53 UTC (permalink / raw)
  To: buildroot

Commit 6e3f7fbc072c88ab344f2ffa39e402464b566f19 ("package/runc: add
upstream security fix for CVE-2019-5736") added a dependency of
docker-containerd to uclibc (inherited from runc), but the depends on
has a typo that makes it ineffective. Due to this, docker-containerd
can still be selected in uClibc configurations, causing runc to be
build, and failing to build due fexecve() being missing in uClibc.

Fixes:

  http://autobuild.buildroot.net/results/64ecdb1e007106fdb05979b10b42b90591255504/

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
 package/docker-containerd/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/docker-containerd/Config.in b/package/docker-containerd/Config.in
index bdb5dd7b80..5e0cc1e877 100644
--- a/package/docker-containerd/Config.in
+++ b/package/docker-containerd/Config.in
@@ -3,7 +3,7 @@ config BR2_PACKAGE_DOCKER_CONTAINERD
 	depends on BR2_PACKAGE_HOST_GO_ARCH_SUPPORTS
 	depends on BR2_PACKAGE_HOST_GO_CGO_LINKING_SUPPORTS
 	depends on BR2_TOOLCHAIN_HAS_THREADS
-	depends on !BR2_PACKAGE_TOOLCHAIN_USES_UCLIBC # runc
+	depends on !BR2_TOOLCHAIN_USES_UCLIBC # runc
 	depends on BR2_USE_MMU # util-linux
 	select BR2_PACKAGE_RUNC # runtime dependency
 	select BR2_PACKAGE_UTIL_LINUX # runtime dependency
-- 
2.20.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] package/docker-containerd: fix typo in uclibc dependency
  2019-02-14  8:53 [Buildroot] [PATCH] package/docker-containerd: fix typo in uclibc dependency Thomas Petazzoni
@ 2019-02-14 10:06 ` Peter Korsgaard
  2019-02-21 12:53 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2019-02-14 10:06 UTC (permalink / raw)
  To: buildroot

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:

 > Commit 6e3f7fbc072c88ab344f2ffa39e402464b566f19 ("package/runc: add
 > upstream security fix for CVE-2019-5736") added a dependency of
 > docker-containerd to uclibc (inherited from runc), but the depends on
 > has a typo that makes it ineffective. Due to this, docker-containerd
 > can still be selected in uClibc configurations, causing runc to be
 > build, and failing to build due fexecve() being missing in uClibc.

 > Fixes:

 >   http://autobuild.buildroot.net/results/64ecdb1e007106fdb05979b10b42b90591255504/

 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Ups - Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] package/docker-containerd: fix typo in uclibc dependency
  2019-02-14  8:53 [Buildroot] [PATCH] package/docker-containerd: fix typo in uclibc dependency Thomas Petazzoni
  2019-02-14 10:06 ` Peter Korsgaard
@ 2019-02-21 12:53 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2019-02-21 12:53 UTC (permalink / raw)
  To: buildroot

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:

 > Commit 6e3f7fbc072c88ab344f2ffa39e402464b566f19 ("package/runc: add
 > upstream security fix for CVE-2019-5736") added a dependency of
 > docker-containerd to uclibc (inherited from runc), but the depends on
 > has a typo that makes it ineffective. Due to this, docker-containerd
 > can still be selected in uClibc configurations, causing runc to be
 > build, and failing to build due fexecve() being missing in uClibc.

 > Fixes:

 >   http://autobuild.buildroot.net/results/64ecdb1e007106fdb05979b10b42b90591255504/

 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Committed to 2018.11.x, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-02-21 12:53 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-14  8:53 [Buildroot] [PATCH] package/docker-containerd: fix typo in uclibc dependency Thomas Petazzoni
2019-02-14 10:06 ` Peter Korsgaard
2019-02-21 12:53 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.