* [PATCH] watchdog: pc87413: Mark expected switch fall-through
@ 2019-02-14 20:26 Gustavo A. R. Silva
2019-02-18 16:09 ` Guenter Roeck
0 siblings, 1 reply; 6+ messages in thread
From: Gustavo A. R. Silva @ 2019-02-14 20:26 UTC (permalink / raw)
To: Wim Van Sebroeck, Guenter Roeck
Cc: linux-watchdog, linux-kernel, Gustavo A. R. Silva, Kees Cook
In preparation to enabling -Wimplicit-fallthrough, mark switch
cases where we are expecting to fall through.
This patch fixes the following warning:
drivers/watchdog/pc87413_wdt.c: In function ‘pc87413_ioctl’:
drivers/watchdog/pc87413_wdt.c:439:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
pc87413_refresh();
^~~~~~~~~~~~~~~~~
drivers/watchdog/pc87413_wdt.c:441:2: note: here
case WDIOC_GETTIMEOUT:
^~~~
Warning level 3 was used: -Wimplicit-fallthrough=3
Notice that, in this particular case, the code comment is modified
in accordance with what GCC is expecting to find.
This patch is part of the ongoing efforts to enable
-Wimplicit-fallthrough.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/watchdog/pc87413_wdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/watchdog/pc87413_wdt.c b/drivers/watchdog/pc87413_wdt.c
index 06a892e36a8d..2ffa39b46970 100644
--- a/drivers/watchdog/pc87413_wdt.c
+++ b/drivers/watchdog/pc87413_wdt.c
@@ -437,7 +437,7 @@ static long pc87413_ioctl(struct file *file, unsigned int cmd,
return -EINVAL;
timeout = new_timeout;
pc87413_refresh();
- /* fall through and return the new timeout... */
+ /* fall through - and return the new timeout... */
case WDIOC_GETTIMEOUT:
new_timeout = timeout * 60;
return put_user(new_timeout, uarg.i);
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] watchdog: pc87413: Mark expected switch fall-through
2019-02-14 20:26 [PATCH] watchdog: pc87413: Mark expected switch fall-through Gustavo A. R. Silva
@ 2019-02-18 16:09 ` Guenter Roeck
2019-02-18 17:50 ` Gustavo A. R. Silva
0 siblings, 1 reply; 6+ messages in thread
From: Guenter Roeck @ 2019-02-18 16:09 UTC (permalink / raw)
To: Gustavo A. R. Silva, Wim Van Sebroeck
Cc: linux-watchdog, linux-kernel, Kees Cook
On 2/14/19 12:26 PM, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
>
> This patch fixes the following warning:
>
> drivers/watchdog/pc87413_wdt.c: In function ‘pc87413_ioctl’:
> drivers/watchdog/pc87413_wdt.c:439:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
> pc87413_refresh();
> ^~~~~~~~~~~~~~~~~
> drivers/watchdog/pc87413_wdt.c:441:2: note: here
> case WDIOC_GETTIMEOUT:
> ^~~~
>
> Warning level 3 was used: -Wimplicit-fallthrough=3
>
> Notice that, in this particular case, the code comment is modified
> in accordance with what GCC is expecting to find.
>
> This patch is part of the ongoing efforts to enable
> -Wimplicit-fallthrough.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/pc87413_wdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/pc87413_wdt.c b/drivers/watchdog/pc87413_wdt.c
> index 06a892e36a8d..2ffa39b46970 100644
> --- a/drivers/watchdog/pc87413_wdt.c
> +++ b/drivers/watchdog/pc87413_wdt.c
> @@ -437,7 +437,7 @@ static long pc87413_ioctl(struct file *file, unsigned int cmd,
> return -EINVAL;
> timeout = new_timeout;
> pc87413_refresh();
> - /* fall through and return the new timeout... */
> + /* fall through - and return the new timeout... */
> case WDIOC_GETTIMEOUT:
> new_timeout = timeout * 60;
> return put_user(new_timeout, uarg.i);
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] watchdog: pc87413: Mark expected switch fall-through
2019-02-18 16:09 ` Guenter Roeck
@ 2019-02-18 17:50 ` Gustavo A. R. Silva
2019-02-26 17:46 ` Gustavo A. R. Silva
0 siblings, 1 reply; 6+ messages in thread
From: Gustavo A. R. Silva @ 2019-02-18 17:50 UTC (permalink / raw)
To: Guenter Roeck, Wim Van Sebroeck; +Cc: linux-watchdog, linux-kernel, Kees Cook
On 2/18/19 10:09 AM, Guenter Roeck wrote:
> On 2/14/19 12:26 PM, Gustavo A. R. Silva wrote:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>> cases where we are expecting to fall through.
>>
>> This patch fixes the following warning:
>>
>> drivers/watchdog/pc87413_wdt.c: In function ‘pc87413_ioctl’:
>> drivers/watchdog/pc87413_wdt.c:439:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
>> pc87413_refresh();
>> ^~~~~~~~~~~~~~~~~
>> drivers/watchdog/pc87413_wdt.c:441:2: note: here
>> case WDIOC_GETTIMEOUT:
>> ^~~~
>>
>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>
>> Notice that, in this particular case, the code comment is modified
>> in accordance with what GCC is expecting to find.
>>
>> This patch is part of the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>
Thanks, Guenter.
--
Gustavo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] watchdog: pc87413: Mark expected switch fall-through
2019-02-18 17:50 ` Gustavo A. R. Silva
@ 2019-02-26 17:46 ` Gustavo A. R. Silva
2019-02-26 17:55 ` Guenter Roeck
0 siblings, 1 reply; 6+ messages in thread
From: Gustavo A. R. Silva @ 2019-02-26 17:46 UTC (permalink / raw)
To: Guenter Roeck, Wim Van Sebroeck; +Cc: linux-watchdog, linux-kernel, Kees Cook
Hi all,
Friendly ping:
Who can take this?
Thanks
--
Gustavo
On 2/18/19 11:50 AM, Gustavo A. R. Silva wrote:
>
>
> On 2/18/19 10:09 AM, Guenter Roeck wrote:
>> On 2/14/19 12:26 PM, Gustavo A. R. Silva wrote:
>>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>>> cases where we are expecting to fall through.
>>>
>>> This patch fixes the following warning:
>>>
>>> drivers/watchdog/pc87413_wdt.c: In function ‘pc87413_ioctl’:
>>> drivers/watchdog/pc87413_wdt.c:439:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
>>> pc87413_refresh();
>>> ^~~~~~~~~~~~~~~~~
>>> drivers/watchdog/pc87413_wdt.c:441:2: note: here
>>> case WDIOC_GETTIMEOUT:
>>> ^~~~
>>>
>>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>>
>>> Notice that, in this particular case, the code comment is modified
>>> in accordance with what GCC is expecting to find.
>>>
>>> This patch is part of the ongoing efforts to enable
>>> -Wimplicit-fallthrough.
>>>
>>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>>
>> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>>
>
> Thanks, Guenter.
>
> --
> Gustavo
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] watchdog: pc87413: Mark expected switch fall-through
2019-02-26 17:46 ` Gustavo A. R. Silva
@ 2019-02-26 17:55 ` Guenter Roeck
2019-02-26 18:10 ` Gustavo A. R. Silva
0 siblings, 1 reply; 6+ messages in thread
From: Guenter Roeck @ 2019-02-26 17:55 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Wim Van Sebroeck, linux-watchdog, linux-kernel, Kees Cook
On Tue, Feb 26, 2019 at 11:46:09AM -0600, Gustavo A. R. Silva wrote:
> Hi all,
>
> Friendly ping:
>
> Who can take this?
>
Wim, presumably.
Guenter
> Thanks
> --
> Gustavo
>
>
> On 2/18/19 11:50 AM, Gustavo A. R. Silva wrote:
> >
> >
> > On 2/18/19 10:09 AM, Guenter Roeck wrote:
> >> On 2/14/19 12:26 PM, Gustavo A. R. Silva wrote:
> >>> In preparation to enabling -Wimplicit-fallthrough, mark switch
> >>> cases where we are expecting to fall through.
> >>>
> >>> This patch fixes the following warning:
> >>>
> >>> drivers/watchdog/pc87413_wdt.c: In function ‘pc87413_ioctl’:
> >>> drivers/watchdog/pc87413_wdt.c:439:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
> >>> pc87413_refresh();
> >>> ^~~~~~~~~~~~~~~~~
> >>> drivers/watchdog/pc87413_wdt.c:441:2: note: here
> >>> case WDIOC_GETTIMEOUT:
> >>> ^~~~
> >>>
> >>> Warning level 3 was used: -Wimplicit-fallthrough=3
> >>>
> >>> Notice that, in this particular case, the code comment is modified
> >>> in accordance with what GCC is expecting to find.
> >>>
> >>> This patch is part of the ongoing efforts to enable
> >>> -Wimplicit-fallthrough.
> >>>
> >>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> >>
> >> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> >>
> >
> > Thanks, Guenter.
> >
> > --
> > Gustavo
> >
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] watchdog: pc87413: Mark expected switch fall-through
2019-02-26 17:55 ` Guenter Roeck
@ 2019-02-26 18:10 ` Gustavo A. R. Silva
0 siblings, 0 replies; 6+ messages in thread
From: Gustavo A. R. Silva @ 2019-02-26 18:10 UTC (permalink / raw)
To: Guenter Roeck; +Cc: Wim Van Sebroeck, linux-watchdog, linux-kernel, Kees Cook
On 2/26/19 11:55 AM, Guenter Roeck wrote:
> On Tue, Feb 26, 2019 at 11:46:09AM -0600, Gustavo A. R. Silva wrote:
>> Hi all,
>>
>> Friendly ping:
>>
>> Who can take this?
>>
> Wim, presumably.
>
Oh OK. Hopefully, he'll notice this thread soon.
Thanks
--
Gustavo
> Guenter
>
>> Thanks
>> --
>> Gustavo
>>
>>
>> On 2/18/19 11:50 AM, Gustavo A. R. Silva wrote:
>>>
>>>
>>> On 2/18/19 10:09 AM, Guenter Roeck wrote:
>>>> On 2/14/19 12:26 PM, Gustavo A. R. Silva wrote:
>>>>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>>>>> cases where we are expecting to fall through.
>>>>>
>>>>> This patch fixes the following warning:
>>>>>
>>>>> drivers/watchdog/pc87413_wdt.c: In function ‘pc87413_ioctl’:
>>>>> drivers/watchdog/pc87413_wdt.c:439:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
>>>>> pc87413_refresh();
>>>>> ^~~~~~~~~~~~~~~~~
>>>>> drivers/watchdog/pc87413_wdt.c:441:2: note: here
>>>>> case WDIOC_GETTIMEOUT:
>>>>> ^~~~
>>>>>
>>>>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>>>>
>>>>> Notice that, in this particular case, the code comment is modified
>>>>> in accordance with what GCC is expecting to find.
>>>>>
>>>>> This patch is part of the ongoing efforts to enable
>>>>> -Wimplicit-fallthrough.
>>>>>
>>>>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>>>>
>>>> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>>>>
>>>
>>> Thanks, Guenter.
>>>
>>> --
>>> Gustavo
>>>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-02-26 18:10 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-14 20:26 [PATCH] watchdog: pc87413: Mark expected switch fall-through Gustavo A. R. Silva
2019-02-18 16:09 ` Guenter Roeck
2019-02-18 17:50 ` Gustavo A. R. Silva
2019-02-26 17:46 ` Gustavo A. R. Silva
2019-02-26 17:55 ` Guenter Roeck
2019-02-26 18:10 ` Gustavo A. R. Silva
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.