[PATCH 0/3] Correct CAN clocks definition

[PATCH 0/3] Correct CAN clocks definition

[Fabrizio Castro]

Dear All,

since we now know that the r8a774a1 is similar to the r8a7796
from a CAN and CANFD perspective, changes to the clocks are in
order.

Thanks,
Fab

Fabrizio Castro (3):
  clk: renesas: r8a774a1: Add missing CANFD clock
  arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes
  dt-bindings: can: rcar_canfd: Document r8a774a1 support

 Documentation/devicetree/bindings/net/can/rcar_canfd.txt | 15 ++++++++-------
 arch/arm64/boot/dts/renesas/r8a774a1.dtsi                | 12 ++++++++----
 drivers/clk/renesas/r8a774a1-cpg-mssr.c                  |  2 ++
 include/dt-bindings/clock/r8a774a1-cpg-mssr.h            |  1 +
 4 files changed, 19 insertions(+), 11 deletions(-)

-- 
2.7.4

[PATCH 1/3] clk: renesas: r8a774a1: Add missing CANFD clock

[Fabrizio Castro]

This patch adds the missing CANFD clock to the r8a774a1 specific
clock driver.

Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
---
 drivers/clk/renesas/r8a774a1-cpg-mssr.c       | 2 ++
 include/dt-bindings/clock/r8a774a1-cpg-mssr.h | 1 +
 2 files changed, 3 insertions(+)

diff --git a/drivers/clk/renesas/r8a774a1-cpg-mssr.c b/drivers/clk/renesas/r8a774a1-cpg-mssr.c
index 10e8525..e103741 100644
--- a/drivers/clk/renesas/r8a774a1-cpg-mssr.c
+++ b/drivers/clk/renesas/r8a774a1-cpg-mssr.c
@@ -102,6 +102,7 @@ static const struct cpg_core_clk r8a774a1_core_clks[] __initconst = {
 	DEF_FIXED("cp",         R8A774A1_CLK_CP,    CLK_EXTAL,      2, 1),
 	DEF_FIXED("cpex",       R8A774A1_CLK_CPEX,  CLK_EXTAL,      2, 1),
 
+	DEF_DIV6P1("canfd",     R8A774A1_CLK_CANFD, CLK_PLL1_DIV4, 0x244),
 	DEF_DIV6P1("csi0",      R8A774A1_CLK_CSI0,  CLK_PLL1_DIV4, 0x00c),
 	DEF_DIV6P1("mso",       R8A774A1_CLK_MSO,   CLK_PLL1_DIV4, 0x014),
 	DEF_DIV6P1("hdmi",      R8A774A1_CLK_HDMI,  CLK_PLL1_DIV4, 0x250),
@@ -191,6 +192,7 @@ static const struct mssr_mod_clk r8a774a1_mod_clks[] __initconst = {
 	DEF_MOD("gpio2",		 910,	R8A774A1_CLK_S3D4),
 	DEF_MOD("gpio1",		 911,	R8A774A1_CLK_S3D4),
 	DEF_MOD("gpio0",		 912,	R8A774A1_CLK_S3D4),
+	DEF_MOD("can-fd",		 914,	R8A774A1_CLK_S3D2),
 	DEF_MOD("can-if1",		 915,	R8A774A1_CLK_S3D4),
 	DEF_MOD("can-if0",		 916,	R8A774A1_CLK_S3D4),
 	DEF_MOD("i2c6",			 918,	R8A774A1_CLK_S0D6),
diff --git a/include/dt-bindings/clock/r8a774a1-cpg-mssr.h b/include/dt-bindings/clock/r8a774a1-cpg-mssr.h
index 9bc5d45..e355363 100644
--- a/include/dt-bindings/clock/r8a774a1-cpg-mssr.h
+++ b/include/dt-bindings/clock/r8a774a1-cpg-mssr.h
@@ -54,5 +54,6 @@
 #define R8A774A1_CLK_CPEX		43
 #define R8A774A1_CLK_R			44
 #define R8A774A1_CLK_OSC		45
+#define R8A774A1_CLK_CANFD		46
 
 #endif /* __DT_BINDINGS_CLOCK_R8A774A1_CPG_MSSR_H__ */
-- 
2.7.4

[PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes

[Fabrizio Castro]

According to the latest information, clkp2 is available on RZ/G2.
Modify CAN0 and CAN1 nodes accordingly.

Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
---
 arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
index 46a8fd2..71066d4 100644
--- a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
@@ -879,8 +879,10 @@
 				     "renesas,rcar-gen3-can";
 			reg = <0 0xe6c30000 0 0x1000>;
 			interrupts = <GIC_SPI 186 IRQ_TYPE_LEVEL_HIGH>;
-			clocks = <&cpg CPG_MOD 916>, <&can_clk>;
-			clock-names = "clkp1", "can_clk";
+			clocks = <&cpg CPG_MOD 916>,
+				 <&cpg CPG_CORE R8A774A1_CLK_CANFD>,
+				 <&can_clk>;
+			clock-names = "clkp1", "clkp2", "can_clk";
 			power-domains = <&sysc R8A774A1_PD_ALWAYS_ON>;
 			resets = <&cpg 916>;
 			status = "disabled";
@@ -891,8 +893,10 @@
 				     "renesas,rcar-gen3-can";
 			reg = <0 0xe6c38000 0 0x1000>;
 			interrupts = <GIC_SPI 187 IRQ_TYPE_LEVEL_HIGH>;
-			clocks = <&cpg CPG_MOD 915>, <&can_clk>;
-			clock-names = "clkp1", "can_clk";
+			clocks = <&cpg CPG_MOD 915>,
+				 <&cpg CPG_CORE R8A774A1_CLK_CANFD>,
+				 <&can_clk>;
+			clock-names = "clkp1", "clkp2", "can_clk";
 			power-domains = <&sysc R8A774A1_PD_ALWAYS_ON>;
 			resets = <&cpg 915>;
 			status = "disabled";
-- 
2.7.4

[PATCH 3/3] dt-bindings: can: rcar_canfd: Document r8a774a1 support

[Fabrizio Castro]

Document support for rcar_canfd on R8A774A1 SoC devices.

Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
---
This patch depends on:
https://patchwork.kernel.org/patch/10766781/

 Documentation/devicetree/bindings/net/can/rcar_canfd.txt | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/can/rcar_canfd.txt b/Documentation/devicetree/bindings/net/can/rcar_canfd.txt
index 32f051f..fd353a9 100644
--- a/Documentation/devicetree/bindings/net/can/rcar_canfd.txt
+++ b/Documentation/devicetree/bindings/net/can/rcar_canfd.txt
@@ -4,6 +4,7 @@ Renesas R-Car CAN FD controller Device Tree Bindings
 Required properties:
 - compatible: Must contain one or more of the following:
   - "renesas,rcar-gen3-canfd" for R-Car Gen3 and RZ/G2 compatible controllers.
+  - "renesas,r8a774a1-canfd" for R8A774A1 (RZ/G2M) compatible controller.
   - "renesas,r8a774c0-canfd" for R8A774C0 (RZ/G2E) compatible controller.
   - "renesas,r8a7795-canfd" for R8A7795 (R-Car H3) compatible controller.
   - "renesas,r8a7796-canfd" for R8A7796 (R-Car M3-W) compatible controller.
@@ -29,13 +30,13 @@ The name of the child nodes are "channel0" and "channel1" respectively. Each
 child node supports the "status" property only, which is used to
 enable/disable the respective channel.
 
-Required properties for "renesas,r8a774c0-canfd", "renesas,r8a7795-canfd",
-"renesas,r8a7796-canfd", "renesas,r8a77965-canfd", and "renesas,r8a77990-canfd"
-compatible:
-In R8A774C0, R8A7795, R8A7796, R8A77965, and R8A77990 SoCs, canfd clock is a
-div6 clock and can be used by both CAN and CAN FD controller at the same time.
-It needs to be scaled to maximum frequency if any of these controllers use it.
-This is done using the below properties:
+Required properties for "renesas,r8a774a1-canfd", "renesas,r8a774c0-canfd",
+"renesas,r8a7795-canfd", "renesas,r8a7796-canfd", "renesas,r8a77965-canfd", and
+"renesas,r8a77990-canfd" compatible:
+In R8A774A1, R8A774C0, R8A7795, R8A7796, R8A77965, and R8A77990 SoCs, canfd
+clock is a div6 clock and can be used by both CAN and CAN FD controller at the
+same time. It needs to be scaled to maximum frequency if any of these
+controllers use it. This is done using the below properties:
 
 - assigned-clocks: phandle of canfd clock.
 - assigned-clock-rates: maximum frequency of this clock.
-- 
2.7.4

Re: [PATCH 3/3] dt-bindings: can: rcar_canfd: Document r8a774a1 support

[Simon Horman]

On Thu, Jan 17, 2019 at 02:54:16PM +0000, Fabrizio Castro wrote:
> Document support for rcar_canfd on R8A774A1 SoC devices.
> 
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>

Reviewed-by: Simon Horman <horms+renesas@verge.net.au>

Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes

[Simon Horman]

On Thu, Jan 17, 2019 at 02:54:15PM +0000, Fabrizio Castro wrote:
> According to the latest information, clkp2 is available on RZ/G2.
> Modify CAN0 and CAN1 nodes accordingly.
> 
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>

Thanks,

This looks fine to me but I will wait to see if there are other reviews
before applying.

Reviewed-by: Simon Horman <horms+renesas@verge.net.au>

Re: [PATCH 1/3] clk: renesas: r8a774a1: Add missing CANFD clock

[Simon Horman]

On Thu, Jan 17, 2019 at 02:54:14PM +0000, Fabrizio Castro wrote:
> This patch adds the missing CANFD clock to the r8a774a1 specific
> clock driver.
> 
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>

Reviewed-by: Simon Horman <horms+renesas@verge.net.au>

Re: [PATCH 1/3] clk: renesas: r8a774a1: Add missing CANFD clock

[Geert Uytterhoeven]

On Thu, Jan 17, 2019 at 3:54 PM Fabrizio Castro
<fabrizio.castro@bp.renesas.com> wrote:
> This patch adds the missing CANFD clock to the r8a774a1 specific
> clock driver.
>
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in clk-renesas-for-v5.1.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 1/3] clk: renesas: r8a774a1: Add missing CANFD clock

[Geert Uytterhoeven]

On Thu, Jan 17, 2019 at 3:54 PM Fabrizio Castro
<fabrizio.castro@bp.renesas.com> wrote:
> This patch adds the missing CANFD clock to the r8a774a1 specific
> clock driver.
>
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in clk-renesas-for-v5.1.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes

[Simon Horman]

On Fri, Jan 18, 2019 at 01:13:53PM +0100, Simon Horman wrote:
> On Thu, Jan 17, 2019 at 02:54:15PM +0000, Fabrizio Castro wrote:
> > According to the latest information, clkp2 is available on RZ/G2.
> > Modify CAN0 and CAN1 nodes accordingly.
> > 
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
> 
> Thanks,
> 
> This looks fine to me but I will wait to see if there are other reviews
> before applying.
> 
> Reviewed-by: Simon Horman <horms+renesas@verge.net.au>

Thanks again, applied for v5.1.

Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes

[Simon Horman]

On Wed, Jan 23, 2019 at 10:51:23AM +0100, Simon Horman wrote:
> On Fri, Jan 18, 2019 at 01:13:53PM +0100, Simon Horman wrote:
> > On Thu, Jan 17, 2019 at 02:54:15PM +0000, Fabrizio Castro wrote:
> > > According to the latest information, clkp2 is available on RZ/G2.
> > > Modify CAN0 and CAN1 nodes accordingly.
> > > 
> > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > > Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
> > 
> > Thanks,
> > 
> > This looks fine to me but I will wait to see if there are other reviews
> > before applying.
> > 
> > Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
> 
> Thanks again, applied for v5.1.

Sorry, I was a little hasty there.

This patch depends on the presence of R8A774A1_CLK_CANFD which
(rightly) is added in a different patch in this series which is to
go upstream via a different tree.

I have dropped this patch for now. I think there are two solution to this
problem.

1. Provide a version of this patch which uses a numeric index instead of
   R8A774A1_CLK_CANFD. And then, once R8A774A1_CLK_CANFD is present in an
   RC release provide a patch to switch to using R8A774A1_CLK_CANFD.

2. Defer this patch until R8A774A1_CLK_CANFD is present in an RC release.

RE: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes

[Fabrizio Castro]

Hello Simon,

Thank you for your feedback!

> From: Simon Horman <horms@verge.net.au>
> Sent: 23 January 2019 11:38
> Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes
>
> On Wed, Jan 23, 2019 at 10:51:23AM +0100, Simon Horman wrote:
> > On Fri, Jan 18, 2019 at 01:13:53PM +0100, Simon Horman wrote:
> > > On Thu, Jan 17, 2019 at 02:54:15PM +0000, Fabrizio Castro wrote:
> > > > According to the latest information, clkp2 is available on RZ/G2.
> > > > Modify CAN0 and CAN1 nodes accordingly.
> > > >
> > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > > > Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
> > >
> > > Thanks,
> > >
> > > This looks fine to me but I will wait to see if there are other reviews
> > > before applying.
> > >
> > > Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
> >
> > Thanks again, applied for v5.1.
>
> Sorry, I was a little hasty there.
>
> This patch depends on the presence of R8A774A1_CLK_CANFD which
> (rightly) is added in a different patch in this series which is to
> go upstream via a different tree.
>
> I have dropped this patch for now. I think there are two solution to this
> problem.
>
> 1. Provide a version of this patch which uses a numeric index instead of
>    R8A774A1_CLK_CANFD. And then, once R8A774A1_CLK_CANFD is present in an
>    RC release provide a patch to switch to using R8A774A1_CLK_CANFD.
>
> 2. Defer this patch until R8A774A1_CLK_CANFD is present in an RC release.
>

Yeah, my personal preference is solution 2.

Thanks,
Fab



Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.

RE: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes

[Fabrizio Castro]

Hello Simon,

Thank you for your feedback!

> From: Simon Horman <horms@verge.net.au>
> Sent: 23 January 2019 11:38
> Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes
>
> On Wed, Jan 23, 2019 at 10:51:23AM +0100, Simon Horman wrote:
> > On Fri, Jan 18, 2019 at 01:13:53PM +0100, Simon Horman wrote:
> > > On Thu, Jan 17, 2019 at 02:54:15PM +0000, Fabrizio Castro wrote:
> > > > According to the latest information, clkp2 is available on RZ/G2.
> > > > Modify CAN0 and CAN1 nodes accordingly.
> > > >
> > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > > > Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
> > >
> > > Thanks,
> > >
> > > This looks fine to me but I will wait to see if there are other reviews
> > > before applying.
> > >
> > > Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
> >
> > Thanks again, applied for v5.1.
>
> Sorry, I was a little hasty there.
>
> This patch depends on the presence of R8A774A1_CLK_CANFD which
> (rightly) is added in a different patch in this series which is to
> go upstream via a different tree.
>
> I have dropped this patch for now. I think there are two solution to this
> problem.
>
> 1. Provide a version of this patch which uses a numeric index instead of
>    R8A774A1_CLK_CANFD. And then, once R8A774A1_CLK_CANFD is present in an
>    RC release provide a patch to switch to using R8A774A1_CLK_CANFD.
>
> 2. Defer this patch until R8A774A1_CLK_CANFD is present in an RC release.
>

Yeah, my personal preference is solution 2.

Thanks,
Fab



Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.

Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes

[Geert Uytterhoeven]

Hi Fabrizio,

On Wed, Jan 23, 2019 at 1:01 PM Fabrizio Castro
<fabrizio.castro@bp.renesas.com> wrote:
> > From: Simon Horman <horms@verge.net.au>
> > Sent: 23 January 2019 11:38
> > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes
> >
> > On Wed, Jan 23, 2019 at 10:51:23AM +0100, Simon Horman wrote:
> > > On Fri, Jan 18, 2019 at 01:13:53PM +0100, Simon Horman wrote:
> > > > On Thu, Jan 17, 2019 at 02:54:15PM +0000, Fabrizio Castro wrote:
> > > > > According to the latest information, clkp2 is available on RZ/G2.
> > > > > Modify CAN0 and CAN1 nodes accordingly.
> > > > >
> > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > > > > Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>

> > > Thanks again, applied for v5.1.
> >
> > Sorry, I was a little hasty there.
> >
> > This patch depends on the presence of R8A774A1_CLK_CANFD which
> > (rightly) is added in a different patch in this series which is to
> > go upstream via a different tree.
> >
> > I have dropped this patch for now. I think there are two solution to this
> > problem.
> >
> > 1. Provide a version of this patch which uses a numeric index instead of
> >    R8A774A1_CLK_CANFD. And then, once R8A774A1_CLK_CANFD is present in an
> >    RC release provide a patch to switch to using R8A774A1_CLK_CANFD.
> >
> > 2. Defer this patch until R8A774A1_CLK_CANFD is present in an RC release.
>
> Yeah, my personal preference is solution 2.

Note that solution 2 will probably defer the DT patch to v5.2.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes

[Geert Uytterhoeven]

Hi Fabrizio,

On Wed, Jan 23, 2019 at 1:01 PM Fabrizio Castro
<fabrizio.castro@bp.renesas.com> wrote:
> > From: Simon Horman <horms@verge.net.au>
> > Sent: 23 January 2019 11:38
> > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes
> >
> > On Wed, Jan 23, 2019 at 10:51:23AM +0100, Simon Horman wrote:
> > > On Fri, Jan 18, 2019 at 01:13:53PM +0100, Simon Horman wrote:
> > > > On Thu, Jan 17, 2019 at 02:54:15PM +0000, Fabrizio Castro wrote:
> > > > > According to the latest information, clkp2 is available on RZ/G2.
> > > > > Modify CAN0 and CAN1 nodes accordingly.
> > > > >
> > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > > > > Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>

> > > Thanks again, applied for v5.1.
> >
> > Sorry, I was a little hasty there.
> >
> > This patch depends on the presence of R8A774A1_CLK_CANFD which
> > (rightly) is added in a different patch in this series which is to
> > go upstream via a different tree.
> >
> > I have dropped this patch for now. I think there are two solution to this
> > problem.
> >
> > 1. Provide a version of this patch which uses a numeric index instead of
> >    R8A774A1_CLK_CANFD. And then, once R8A774A1_CLK_CANFD is present in an
> >    RC release provide a patch to switch to using R8A774A1_CLK_CANFD.
> >
> > 2. Defer this patch until R8A774A1_CLK_CANFD is present in an RC release.
>
> Yeah, my personal preference is solution 2.

Note that solution 2 will probably defer the DT patch to v5.2.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

RE: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes

[Fabrizio Castro]

Hello Geert,

Thank you for your feedback!

> From: Geert Uytterhoeven <geert@linux-m68k.org>
> Sent: 23 January 2019 12:08
> Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes
>
> Hi Fabrizio,
>
> On Wed, Jan 23, 2019 at 1:01 PM Fabrizio Castro
> <fabrizio.castro@bp.renesas.com> wrote:
> > > From: Simon Horman <horms@verge.net.au>
> > > Sent: 23 January 2019 11:38
> > > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes
> > >
> > > On Wed, Jan 23, 2019 at 10:51:23AM +0100, Simon Horman wrote:
> > > > On Fri, Jan 18, 2019 at 01:13:53PM +0100, Simon Horman wrote:
> > > > > On Thu, Jan 17, 2019 at 02:54:15PM +0000, Fabrizio Castro wrote:
> > > > > > According to the latest information, clkp2 is available on RZ/G2.
> > > > > > Modify CAN0 and CAN1 nodes accordingly.
> > > > > >
> > > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > > > > > Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
>
> > > > Thanks again, applied for v5.1.
> > >
> > > Sorry, I was a little hasty there.
> > >
> > > This patch depends on the presence of R8A774A1_CLK_CANFD which
> > > (rightly) is added in a different patch in this series which is to
> > > go upstream via a different tree.
> > >
> > > I have dropped this patch for now. I think there are two solution to this
> > > problem.
> > >
> > > 1. Provide a version of this patch which uses a numeric index instead of
> > >    R8A774A1_CLK_CANFD. And then, once R8A774A1_CLK_CANFD is present in an
> > >    RC release provide a patch to switch to using R8A774A1_CLK_CANFD.
> > >
> > > 2. Defer this patch until R8A774A1_CLK_CANFD is present in an RC release.
> >
> > Yeah, my personal preference is solution 2.
>
> Note that solution 2 will probably defer the DT patch to v5.2.

Yeah, my understanding is that even if we chose solution 1 we would still need to be
waiting for v5.2 for the patch to switch to using R8A774A1_CLK_CANFD to appear in
a rc, therefore I think solution 2 is fine.

Thanks,
Fab

>
> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds



Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.

RE: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes

[Fabrizio Castro]

Hello Geert,

Thank you for your feedback!

> From: Geert Uytterhoeven <geert@linux-m68k.org>
> Sent: 23 January 2019 12:08
> Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes
>
> Hi Fabrizio,
>
> On Wed, Jan 23, 2019 at 1:01 PM Fabrizio Castro
> <fabrizio.castro@bp.renesas.com> wrote:
> > > From: Simon Horman <horms@verge.net.au>
> > > Sent: 23 January 2019 11:38
> > > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes
> > >
> > > On Wed, Jan 23, 2019 at 10:51:23AM +0100, Simon Horman wrote:
> > > > On Fri, Jan 18, 2019 at 01:13:53PM +0100, Simon Horman wrote:
> > > > > On Thu, Jan 17, 2019 at 02:54:15PM +0000, Fabrizio Castro wrote:
> > > > > > According to the latest information, clkp2 is available on RZ/G2.
> > > > > > Modify CAN0 and CAN1 nodes accordingly.
> > > > > >
> > > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > > > > > Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
>
> > > > Thanks again, applied for v5.1.
> > >
> > > Sorry, I was a little hasty there.
> > >
> > > This patch depends on the presence of R8A774A1_CLK_CANFD which
> > > (rightly) is added in a different patch in this series which is to
> > > go upstream via a different tree.
> > >
> > > I have dropped this patch for now. I think there are two solution to this
> > > problem.
> > >
> > > 1. Provide a version of this patch which uses a numeric index instead of
> > >    R8A774A1_CLK_CANFD. And then, once R8A774A1_CLK_CANFD is present in an
> > >    RC release provide a patch to switch to using R8A774A1_CLK_CANFD.
> > >
> > > 2. Defer this patch until R8A774A1_CLK_CANFD is present in an RC release.
> >
> > Yeah, my personal preference is solution 2.
>
> Note that solution 2 will probably defer the DT patch to v5.2.

Yeah, my understanding is that even if we chose solution 1 we would still need to be
waiting for v5.2 for the patch to switch to using R8A774A1_CLK_CANFD to appear in
a rc, therefore I think solution 2 is fine.

Thanks,
Fab

>
> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds



Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.

Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes

[Simon Horman]

On Wed, Jan 23, 2019 at 12:18:45PM +0000, Fabrizio Castro wrote:
> Hello Geert,
> 
> Thank you for your feedback!
> 
> > From: Geert Uytterhoeven <geert@linux-m68k.org>
> > Sent: 23 January 2019 12:08
> > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes
> >
> > Hi Fabrizio,
> >
> > On Wed, Jan 23, 2019 at 1:01 PM Fabrizio Castro
> > <fabrizio.castro@bp.renesas.com> wrote:
> > > > From: Simon Horman <horms@verge.net.au>
> > > > Sent: 23 January 2019 11:38
> > > > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes
> > > >
> > > > On Wed, Jan 23, 2019 at 10:51:23AM +0100, Simon Horman wrote:
> > > > > On Fri, Jan 18, 2019 at 01:13:53PM +0100, Simon Horman wrote:
> > > > > > On Thu, Jan 17, 2019 at 02:54:15PM +0000, Fabrizio Castro wrote:
> > > > > > > According to the latest information, clkp2 is available on RZ/G2.
> > > > > > > Modify CAN0 and CAN1 nodes accordingly.
> > > > > > >
> > > > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > > > > > > Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
> >
> > > > > Thanks again, applied for v5.1.
> > > >
> > > > Sorry, I was a little hasty there.
> > > >
> > > > This patch depends on the presence of R8A774A1_CLK_CANFD which
> > > > (rightly) is added in a different patch in this series which is to
> > > > go upstream via a different tree.
> > > >
> > > > I have dropped this patch for now. I think there are two solution to this
> > > > problem.
> > > >
> > > > 1. Provide a version of this patch which uses a numeric index instead of
> > > >    R8A774A1_CLK_CANFD. And then, once R8A774A1_CLK_CANFD is present in an
> > > >    RC release provide a patch to switch to using R8A774A1_CLK_CANFD.
> > > >
> > > > 2. Defer this patch until R8A774A1_CLK_CANFD is present in an RC release.
> > >
> > > Yeah, my personal preference is solution 2.
> >
> > Note that solution 2 will probably defer the DT patch to v5.2.
> 
> Yeah, my understanding is that even if we chose solution 1 we would still
> need to be waiting for v5.2 for the patch to switch to using
> R8A774A1_CLK_CANFD to appear in a rc, therefore I think solution 2 is
> fine.

Your understanding is the same as mine.

I do seem some slight value in option 1 in terms of getting the change,
less the minor issue of using an index rather than a symbol, upstream
earlier. But I do not feel strongly about this.

I am marking this patch as deferred. Please repost or otherwise ping me
when you would like to revisit this topic.

Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes

[Simon Horman]

On Wed, Jan 23, 2019 at 12:18:45PM +0000, Fabrizio Castro wrote:
> Hello Geert,
> 
> Thank you for your feedback!
> 
> > From: Geert Uytterhoeven <geert@linux-m68k.org>
> > Sent: 23 January 2019 12:08
> > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes
> >
> > Hi Fabrizio,
> >
> > On Wed, Jan 23, 2019 at 1:01 PM Fabrizio Castro
> > <fabrizio.castro@bp.renesas.com> wrote:
> > > > From: Simon Horman <horms@verge.net.au>
> > > > Sent: 23 January 2019 11:38
> > > > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes
> > > >
> > > > On Wed, Jan 23, 2019 at 10:51:23AM +0100, Simon Horman wrote:
> > > > > On Fri, Jan 18, 2019 at 01:13:53PM +0100, Simon Horman wrote:
> > > > > > On Thu, Jan 17, 2019 at 02:54:15PM +0000, Fabrizio Castro wrote:
> > > > > > > According to the latest information, clkp2 is available on RZ/G2.
> > > > > > > Modify CAN0 and CAN1 nodes accordingly.
> > > > > > >
> > > > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > > > > > > Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
> >
> > > > > Thanks again, applied for v5.1.
> > > >
> > > > Sorry, I was a little hasty there.
> > > >
> > > > This patch depends on the presence of R8A774A1_CLK_CANFD which
> > > > (rightly) is added in a different patch in this series which is to
> > > > go upstream via a different tree.
> > > >
> > > > I have dropped this patch for now. I think there are two solution to this
> > > > problem.
> > > >
> > > > 1. Provide a version of this patch which uses a numeric index instead of
> > > >    R8A774A1_CLK_CANFD. And then, once R8A774A1_CLK_CANFD is present in an
> > > >    RC release provide a patch to switch to using R8A774A1_CLK_CANFD.
> > > >
> > > > 2. Defer this patch until R8A774A1_CLK_CANFD is present in an RC release.
> > >
> > > Yeah, my personal preference is solution 2.
> >
> > Note that solution 2 will probably defer the DT patch to v5.2.
> 
> Yeah, my understanding is that even if we chose solution 1 we would still
> need to be waiting for v5.2 for the patch to switch to using
> R8A774A1_CLK_CANFD to appear in a rc, therefore I think solution 2 is
> fine.

Your understanding is the same as mine.

I do seem some slight value in option 1 in terms of getting the change,
less the minor issue of using an index rather than a symbol, upstream
earlier. But I do not feel strongly about this.

I am marking this patch as deferred. Please repost or otherwise ping me
when you would like to revisit this topic.

RE: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes

[Fabrizio Castro]

Hello Simon,

Thank you for your feedback!

> From: Simon Horman <horms@verge.net.au>
> Sent: 24 January 2019 10:01
> Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes
>
> On Wed, Jan 23, 2019 at 12:18:45PM +0000, Fabrizio Castro wrote:
> > Hello Geert,
> >
> > Thank you for your feedback!
> >
> > > From: Geert Uytterhoeven <geert@linux-m68k.org>
> > > Sent: 23 January 2019 12:08
> > > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes
> > >
> > > Hi Fabrizio,
> > >
> > > On Wed, Jan 23, 2019 at 1:01 PM Fabrizio Castro
> > > <fabrizio.castro@bp.renesas.com> wrote:
> > > > > From: Simon Horman <horms@verge.net.au>
> > > > > Sent: 23 January 2019 11:38
> > > > > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes
> > > > >
> > > > > On Wed, Jan 23, 2019 at 10:51:23AM +0100, Simon Horman wrote:
> > > > > > On Fri, Jan 18, 2019 at 01:13:53PM +0100, Simon Horman wrote:
> > > > > > > On Thu, Jan 17, 2019 at 02:54:15PM +0000, Fabrizio Castro wrote:
> > > > > > > > According to the latest information, clkp2 is available on RZ/G2.
> > > > > > > > Modify CAN0 and CAN1 nodes accordingly.
> > > > > > > >
> > > > > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > > > > > > > Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
> > >
> > > > > > Thanks again, applied for v5.1.
> > > > >
> > > > > Sorry, I was a little hasty there.
> > > > >
> > > > > This patch depends on the presence of R8A774A1_CLK_CANFD which
> > > > > (rightly) is added in a different patch in this series which is to
> > > > > go upstream via a different tree.
> > > > >
> > > > > I have dropped this patch for now. I think there are two solution to this
> > > > > problem.
> > > > >
> > > > > 1. Provide a version of this patch which uses a numeric index instead of
> > > > >    R8A774A1_CLK_CANFD. And then, once R8A774A1_CLK_CANFD is present in an
> > > > >    RC release provide a patch to switch to using R8A774A1_CLK_CANFD.
> > > > >
> > > > > 2. Defer this patch until R8A774A1_CLK_CANFD is present in an RC release.
> > > >
> > > > Yeah, my personal preference is solution 2.
> > >
> > > Note that solution 2 will probably defer the DT patch to v5.2.
> >
> > Yeah, my understanding is that even if we chose solution 1 we would still
> > need to be waiting for v5.2 for the patch to switch to using
> > R8A774A1_CLK_CANFD to appear in a rc, therefore I think solution 2 is
> > fine.
>
> Your understanding is the same as mine.
>
> I do seem some slight value in option 1 in terms of getting the change,
> less the minor issue of using an index rather than a symbol, upstream
> earlier. But I do not feel strongly about this.
>
> I am marking this patch as deferred. Please repost or otherwise ping me
> when you would like to revisit this topic.

Thank you. Will do.

Fab




Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.

RE: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes

[Fabrizio Castro]

Hello Simon,

Thank you for your feedback!

> From: Simon Horman <horms@verge.net.au>
> Sent: 24 January 2019 10:01
> Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes
>
> On Wed, Jan 23, 2019 at 12:18:45PM +0000, Fabrizio Castro wrote:
> > Hello Geert,
> >
> > Thank you for your feedback!
> >
> > > From: Geert Uytterhoeven <geert@linux-m68k.org>
> > > Sent: 23 January 2019 12:08
> > > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes
> > >
> > > Hi Fabrizio,
> > >
> > > On Wed, Jan 23, 2019 at 1:01 PM Fabrizio Castro
> > > <fabrizio.castro@bp.renesas.com> wrote:
> > > > > From: Simon Horman <horms@verge.net.au>
> > > > > Sent: 23 January 2019 11:38
> > > > > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes
> > > > >
> > > > > On Wed, Jan 23, 2019 at 10:51:23AM +0100, Simon Horman wrote:
> > > > > > On Fri, Jan 18, 2019 at 01:13:53PM +0100, Simon Horman wrote:
> > > > > > > On Thu, Jan 17, 2019 at 02:54:15PM +0000, Fabrizio Castro wrote:
> > > > > > > > According to the latest information, clkp2 is available on RZ/G2.
> > > > > > > > Modify CAN0 and CAN1 nodes accordingly.
> > > > > > > >
> > > > > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > > > > > > > Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
> > >
> > > > > > Thanks again, applied for v5.1.
> > > > >
> > > > > Sorry, I was a little hasty there.
> > > > >
> > > > > This patch depends on the presence of R8A774A1_CLK_CANFD which
> > > > > (rightly) is added in a different patch in this series which is to
> > > > > go upstream via a different tree.
> > > > >
> > > > > I have dropped this patch for now. I think there are two solution to this
> > > > > problem.
> > > > >
> > > > > 1. Provide a version of this patch which uses a numeric index instead of
> > > > >    R8A774A1_CLK_CANFD. And then, once R8A774A1_CLK_CANFD is present in an
> > > > >    RC release provide a patch to switch to using R8A774A1_CLK_CANFD.
> > > > >
> > > > > 2. Defer this patch until R8A774A1_CLK_CANFD is present in an RC release.
> > > >
> > > > Yeah, my personal preference is solution 2.
> > >
> > > Note that solution 2 will probably defer the DT patch to v5.2.
> >
> > Yeah, my understanding is that even if we chose solution 1 we would still
> > need to be waiting for v5.2 for the patch to switch to using
> > R8A774A1_CLK_CANFD to appear in a rc, therefore I think solution 2 is
> > fine.
>
> Your understanding is the same as mine.
>
> I do seem some slight value in option 1 in terms of getting the change,
> less the minor issue of using an index rather than a symbol, upstream
> earlier. But I do not feel strongly about this.
>
> I am marking this patch as deferred. Please repost or otherwise ping me
> when you would like to revisit this topic.

Thank you. Will do.

Fab




Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.

Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes

[Simon Horman]

On Fri, Jan 25, 2019 at 11:33:41AM +0000, Fabrizio Castro wrote:
> Hello Simon,
> 
> Thank you for your feedback!
> 
> > From: Simon Horman <horms@verge.net.au>
> > Sent: 24 January 2019 10:01
> > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes
> >
> > On Wed, Jan 23, 2019 at 12:18:45PM +0000, Fabrizio Castro wrote:
> > > Hello Geert,
> > >
> > > Thank you for your feedback!
> > >
> > > > From: Geert Uytterhoeven <geert@linux-m68k.org>
> > > > Sent: 23 January 2019 12:08
> > > > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes
> > > >
> > > > Hi Fabrizio,
> > > >
> > > > On Wed, Jan 23, 2019 at 1:01 PM Fabrizio Castro
> > > > <fabrizio.castro@bp.renesas.com> wrote:
> > > > > > From: Simon Horman <horms@verge.net.au>
> > > > > > Sent: 23 January 2019 11:38
> > > > > > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes
> > > > > >
> > > > > > On Wed, Jan 23, 2019 at 10:51:23AM +0100, Simon Horman wrote:
> > > > > > > On Fri, Jan 18, 2019 at 01:13:53PM +0100, Simon Horman wrote:
> > > > > > > > On Thu, Jan 17, 2019 at 02:54:15PM +0000, Fabrizio Castro wrote:
> > > > > > > > > According to the latest information, clkp2 is available on RZ/G2.
> > > > > > > > > Modify CAN0 and CAN1 nodes accordingly.
> > > > > > > > >
> > > > > > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > > > > > > > > Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
> > > >
> > > > > > > Thanks again, applied for v5.1.
> > > > > >
> > > > > > Sorry, I was a little hasty there.
> > > > > >
> > > > > > This patch depends on the presence of R8A774A1_CLK_CANFD which
> > > > > > (rightly) is added in a different patch in this series which is to
> > > > > > go upstream via a different tree.
> > > > > >
> > > > > > I have dropped this patch for now. I think there are two solution to this
> > > > > > problem.
> > > > > >
> > > > > > 1. Provide a version of this patch which uses a numeric index instead of
> > > > > >    R8A774A1_CLK_CANFD. And then, once R8A774A1_CLK_CANFD is present in an
> > > > > >    RC release provide a patch to switch to using R8A774A1_CLK_CANFD.
> > > > > >
> > > > > > 2. Defer this patch until R8A774A1_CLK_CANFD is present in an RC release.
> > > > >
> > > > > Yeah, my personal preference is solution 2.
> > > >
> > > > Note that solution 2 will probably defer the DT patch to v5.2.
> > >
> > > Yeah, my understanding is that even if we chose solution 1 we would still
> > > need to be waiting for v5.2 for the patch to switch to using
> > > R8A774A1_CLK_CANFD to appear in a rc, therefore I think solution 2 is
> > > fine.
> >
> > Your understanding is the same as mine.
> >
> > I do seem some slight value in option 1 in terms of getting the change,
> > less the minor issue of using an index rather than a symbol, upstream
> > earlier. But I do not feel strongly about this.
> >
> > I am marking this patch as deferred. Please repost or otherwise ping me
> > when you would like to revisit this topic.
> 
> Thank you. Will do.

Thanks.

I believe "[10/11] arm64: dts: renesas: r8a774c0: Add clkp2 clock to CAN nodes"
falls into the same category. I have marked it as deferred accordingly.

Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes

[Simon Horman]

On Fri, Jan 25, 2019 at 11:33:41AM +0000, Fabrizio Castro wrote:
> Hello Simon,
> 
> Thank you for your feedback!
> 
> > From: Simon Horman <horms@verge.net.au>
> > Sent: 24 January 2019 10:01
> > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes
> >
> > On Wed, Jan 23, 2019 at 12:18:45PM +0000, Fabrizio Castro wrote:
> > > Hello Geert,
> > >
> > > Thank you for your feedback!
> > >
> > > > From: Geert Uytterhoeven <geert@linux-m68k.org>
> > > > Sent: 23 January 2019 12:08
> > > > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes
> > > >
> > > > Hi Fabrizio,
> > > >
> > > > On Wed, Jan 23, 2019 at 1:01 PM Fabrizio Castro
> > > > <fabrizio.castro@bp.renesas.com> wrote:
> > > > > > From: Simon Horman <horms@verge.net.au>
> > > > > > Sent: 23 January 2019 11:38
> > > > > > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes
> > > > > >
> > > > > > On Wed, Jan 23, 2019 at 10:51:23AM +0100, Simon Horman wrote:
> > > > > > > On Fri, Jan 18, 2019 at 01:13:53PM +0100, Simon Horman wrote:
> > > > > > > > On Thu, Jan 17, 2019 at 02:54:15PM +0000, Fabrizio Castro wrote:
> > > > > > > > > According to the latest information, clkp2 is available on RZ/G2.
> > > > > > > > > Modify CAN0 and CAN1 nodes accordingly.
> > > > > > > > >
> > > > > > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > > > > > > > > Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
> > > >
> > > > > > > Thanks again, applied for v5.1.
> > > > > >
> > > > > > Sorry, I was a little hasty there.
> > > > > >
> > > > > > This patch depends on the presence of R8A774A1_CLK_CANFD which
> > > > > > (rightly) is added in a different patch in this series which is to
> > > > > > go upstream via a different tree.
> > > > > >
> > > > > > I have dropped this patch for now. I think there are two solution to this
> > > > > > problem.
> > > > > >
> > > > > > 1. Provide a version of this patch which uses a numeric index instead of
> > > > > >    R8A774A1_CLK_CANFD. And then, once R8A774A1_CLK_CANFD is present in an
> > > > > >    RC release provide a patch to switch to using R8A774A1_CLK_CANFD.
> > > > > >
> > > > > > 2. Defer this patch until R8A774A1_CLK_CANFD is present in an RC release.
> > > > >
> > > > > Yeah, my personal preference is solution 2.
> > > >
> > > > Note that solution 2 will probably defer the DT patch to v5.2.
> > >
> > > Yeah, my understanding is that even if we chose solution 1 we would still
> > > need to be waiting for v5.2 for the patch to switch to using
> > > R8A774A1_CLK_CANFD to appear in a rc, therefore I think solution 2 is
> > > fine.
> >
> > Your understanding is the same as mine.
> >
> > I do seem some slight value in option 1 in terms of getting the change,
> > less the minor issue of using an index rather than a symbol, upstream
> > earlier. But I do not feel strongly about this.
> >
> > I am marking this patch as deferred. Please repost or otherwise ping me
> > when you would like to revisit this topic.
> 
> Thank you. Will do.

Thanks.

I believe "[10/11] arm64: dts: renesas: r8a774c0: Add clkp2 clock to CAN nodes"
falls into the same category. I have marked it as deferred accordingly.

RE: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes

[Fabrizio Castro]

> From: Simon Horman <horms@verge.net.au>
> Sent: 28 January 2019 13:01
> Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes
>
> On Fri, Jan 25, 2019 at 11:33:41AM +0000, Fabrizio Castro wrote:
> > Hello Simon,
> >
> > Thank you for your feedback!
> >
> > > From: Simon Horman <horms@verge.net.au>
> > > Sent: 24 January 2019 10:01
> > > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes
> > >
> > > On Wed, Jan 23, 2019 at 12:18:45PM +0000, Fabrizio Castro wrote:
> > > > Hello Geert,
> > > >
> > > > Thank you for your feedback!
> > > >
> > > > > From: Geert Uytterhoeven <geert@linux-m68k.org>
> > > > > Sent: 23 January 2019 12:08
> > > > > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes
> > > > >
> > > > > Hi Fabrizio,
> > > > >
> > > > > On Wed, Jan 23, 2019 at 1:01 PM Fabrizio Castro
> > > > > <fabrizio.castro@bp.renesas.com> wrote:
> > > > > > > From: Simon Horman <horms@verge.net.au>
> > > > > > > Sent: 23 January 2019 11:38
> > > > > > > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes
> > > > > > >
> > > > > > > On Wed, Jan 23, 2019 at 10:51:23AM +0100, Simon Horman wrote:
> > > > > > > > On Fri, Jan 18, 2019 at 01:13:53PM +0100, Simon Horman wrote:
> > > > > > > > > On Thu, Jan 17, 2019 at 02:54:15PM +0000, Fabrizio Castro wrote:
> > > > > > > > > > According to the latest information, clkp2 is available on RZ/G2.
> > > > > > > > > > Modify CAN0 and CAN1 nodes accordingly.
> > > > > > > > > >
> > > > > > > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > > > > > > > > > Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
> > > > >
> > > > > > > > Thanks again, applied for v5.1.
> > > > > > >
> > > > > > > Sorry, I was a little hasty there.
> > > > > > >
> > > > > > > This patch depends on the presence of R8A774A1_CLK_CANFD which
> > > > > > > (rightly) is added in a different patch in this series which is to
> > > > > > > go upstream via a different tree.
> > > > > > >
> > > > > > > I have dropped this patch for now. I think there are two solution to this
> > > > > > > problem.
> > > > > > >
> > > > > > > 1. Provide a version of this patch which uses a numeric index instead of
> > > > > > >    R8A774A1_CLK_CANFD. And then, once R8A774A1_CLK_CANFD is present in an
> > > > > > >    RC release provide a patch to switch to using R8A774A1_CLK_CANFD.
> > > > > > >
> > > > > > > 2. Defer this patch until R8A774A1_CLK_CANFD is present in an RC release.
> > > > > >
> > > > > > Yeah, my personal preference is solution 2.
> > > > >
> > > > > Note that solution 2 will probably defer the DT patch to v5.2.
> > > >
> > > > Yeah, my understanding is that even if we chose solution 1 we would still
> > > > need to be waiting for v5.2 for the patch to switch to using
> > > > R8A774A1_CLK_CANFD to appear in a rc, therefore I think solution 2 is
> > > > fine.
> > >
> > > Your understanding is the same as mine.
> > >
> > > I do seem some slight value in option 1 in terms of getting the change,
> > > less the minor issue of using an index rather than a symbol, upstream
> > > earlier. But I do not feel strongly about this.
> > >
> > > I am marking this patch as deferred. Please repost or otherwise ping me
> > > when you would like to revisit this topic.
> >
> > Thank you. Will do.
>
> Thanks.
>
> I believe "[10/11] arm64: dts: renesas: r8a774c0: Add clkp2 clock to CAN nodes"
> falls into the same category. I have marked it as deferred accordingly.

Ok, thank you Simon

Fab




Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.

RE: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes

[Fabrizio Castro]

> From: Simon Horman <horms@verge.net.au>
> Sent: 28 January 2019 13:01
> Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes
>
> On Fri, Jan 25, 2019 at 11:33:41AM +0000, Fabrizio Castro wrote:
> > Hello Simon,
> >
> > Thank you for your feedback!
> >
> > > From: Simon Horman <horms@verge.net.au>
> > > Sent: 24 January 2019 10:01
> > > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes
> > >
> > > On Wed, Jan 23, 2019 at 12:18:45PM +0000, Fabrizio Castro wrote:
> > > > Hello Geert,
> > > >
> > > > Thank you for your feedback!
> > > >
> > > > > From: Geert Uytterhoeven <geert@linux-m68k.org>
> > > > > Sent: 23 January 2019 12:08
> > > > > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes
> > > > >
> > > > > Hi Fabrizio,
> > > > >
> > > > > On Wed, Jan 23, 2019 at 1:01 PM Fabrizio Castro
> > > > > <fabrizio.castro@bp.renesas.com> wrote:
> > > > > > > From: Simon Horman <horms@verge.net.au>
> > > > > > > Sent: 23 January 2019 11:38
> > > > > > > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes
> > > > > > >
> > > > > > > On Wed, Jan 23, 2019 at 10:51:23AM +0100, Simon Horman wrote:
> > > > > > > > On Fri, Jan 18, 2019 at 01:13:53PM +0100, Simon Horman wrote:
> > > > > > > > > On Thu, Jan 17, 2019 at 02:54:15PM +0000, Fabrizio Castro wrote:
> > > > > > > > > > According to the latest information, clkp2 is available on RZ/G2.
> > > > > > > > > > Modify CAN0 and CAN1 nodes accordingly.
> > > > > > > > > >
> > > > > > > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > > > > > > > > > Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
> > > > >
> > > > > > > > Thanks again, applied for v5.1.
> > > > > > >
> > > > > > > Sorry, I was a little hasty there.
> > > > > > >
> > > > > > > This patch depends on the presence of R8A774A1_CLK_CANFD which
> > > > > > > (rightly) is added in a different patch in this series which is to
> > > > > > > go upstream via a different tree.
> > > > > > >
> > > > > > > I have dropped this patch for now. I think there are two solution to this
> > > > > > > problem.
> > > > > > >
> > > > > > > 1. Provide a version of this patch which uses a numeric index instead of
> > > > > > >    R8A774A1_CLK_CANFD. And then, once R8A774A1_CLK_CANFD is present in an
> > > > > > >    RC release provide a patch to switch to using R8A774A1_CLK_CANFD.
> > > > > > >
> > > > > > > 2. Defer this patch until R8A774A1_CLK_CANFD is present in an RC release.
> > > > > >
> > > > > > Yeah, my personal preference is solution 2.
> > > > >
> > > > > Note that solution 2 will probably defer the DT patch to v5.2.
> > > >
> > > > Yeah, my understanding is that even if we chose solution 1 we would still
> > > > need to be waiting for v5.2 for the patch to switch to using
> > > > R8A774A1_CLK_CANFD to appear in a rc, therefore I think solution 2 is
> > > > fine.
> > >
> > > Your understanding is the same as mine.
> > >
> > > I do seem some slight value in option 1 in terms of getting the change,
> > > less the minor issue of using an index rather than a symbol, upstream
> > > earlier. But I do not feel strongly about this.
> > >
> > > I am marking this patch as deferred. Please repost or otherwise ping me
> > > when you would like to revisit this topic.
> >
> > Thank you. Will do.
>
> Thanks.
>
> I believe "[10/11] arm64: dts: renesas: r8a774c0: Add clkp2 clock to CAN nodes"
> falls into the same category. I have marked it as deferred accordingly.

Ok, thank you Simon

Fab




Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.

Re: [PATCH 3/3] dt-bindings: can: rcar_canfd: Document r8a774a1 support

[Rob Herring]

On Thu, 17 Jan 2019 14:54:16 +0000, Fabrizio Castro wrote:
> Document support for rcar_canfd on R8A774A1 SoC devices.
> 
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
> ---
> This patch depends on:
> https://patchwork.kernel.org/patch/10766781/
> 
>  Documentation/devicetree/bindings/net/can/rcar_canfd.txt | 15 ++++++++-------
>  1 file changed, 8 insertions(+), 7 deletions(-)
> 

Reviewed-by: Rob Herring <robh@kernel.org>

Re: [PATCH 3/3] dt-bindings: can: rcar_canfd: Document r8a774a1 support

[Rob Herring]

On Thu, 17 Jan 2019 14:54:16 +0000, Fabrizio Castro wrote:
> Document support for rcar_canfd on R8A774A1 SoC devices.
> 
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
> ---
> This patch depends on:
> https://patchwork.kernel.org/patch/10766781/
> 
>  Documentation/devicetree/bindings/net/can/rcar_canfd.txt | 15 ++++++++-------
>  1 file changed, 8 insertions(+), 7 deletions(-)
> 

Reviewed-by: Rob Herring <robh@kernel.org>

RE: [PATCH 3/3] dt-bindings: can: rcar_canfd: Document r8a774a1 support

[Fabrizio Castro]

Hello Marc,

I am sorry to bother you.
Do you think you can take this patch?

Thanks,
Fab

> From: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Sent: 17 January 2019 14:54
> Subject: [PATCH 3/3] dt-bindings: can: rcar_canfd: Document r8a774a1 support
> 
> Document support for rcar_canfd on R8A774A1 SoC devices.
> 
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
> ---
> This patch depends on:
> https://patchwork.kernel.org/patch/10766781/
> 
>  Documentation/devicetree/bindings/net/can/rcar_canfd.txt | 15 ++++++++-------
>  1 file changed, 8 insertions(+), 7 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/can/rcar_canfd.txt
> b/Documentation/devicetree/bindings/net/can/rcar_canfd.txt
> index 32f051f..fd353a9 100644
> --- a/Documentation/devicetree/bindings/net/can/rcar_canfd.txt
> +++ b/Documentation/devicetree/bindings/net/can/rcar_canfd.txt
> @@ -4,6 +4,7 @@ Renesas R-Car CAN FD controller Device Tree Bindings
>  Required properties:
>  - compatible: Must contain one or more of the following:
>    - "renesas,rcar-gen3-canfd" for R-Car Gen3 and RZ/G2 compatible controllers.
> +  - "renesas,r8a774a1-canfd" for R8A774A1 (RZ/G2M) compatible controller.
>    - "renesas,r8a774c0-canfd" for R8A774C0 (RZ/G2E) compatible controller.
>    - "renesas,r8a7795-canfd" for R8A7795 (R-Car H3) compatible controller.
>    - "renesas,r8a7796-canfd" for R8A7796 (R-Car M3-W) compatible controller.
> @@ -29,13 +30,13 @@ The name of the child nodes are "channel0" and "channel1" respectively. Each
>  child node supports the "status" property only, which is used to
>  enable/disable the respective channel.
> 
> -Required properties for "renesas,r8a774c0-canfd", "renesas,r8a7795-canfd",
> -"renesas,r8a7796-canfd", "renesas,r8a77965-canfd", and "renesas,r8a77990-canfd"
> -compatible:
> -In R8A774C0, R8A7795, R8A7796, R8A77965, and R8A77990 SoCs, canfd clock is a
> -div6 clock and can be used by both CAN and CAN FD controller at the same time.
> -It needs to be scaled to maximum frequency if any of these controllers use it.
> -This is done using the below properties:
> +Required properties for "renesas,r8a774a1-canfd", "renesas,r8a774c0-canfd",
> +"renesas,r8a7795-canfd", "renesas,r8a7796-canfd", "renesas,r8a77965-canfd", and
> +"renesas,r8a77990-canfd" compatible:
> +In R8A774A1, R8A774C0, R8A7795, R8A7796, R8A77965, and R8A77990 SoCs, canfd
> +clock is a div6 clock and can be used by both CAN and CAN FD controller at the
> +same time. It needs to be scaled to maximum frequency if any of these
> +controllers use it. This is done using the below properties:
> 
>  - assigned-clocks: phandle of canfd clock.
>  - assigned-clock-rates: maximum frequency of this clock.
> --
> 2.7.4

RE: [PATCH 3/3] dt-bindings: can: rcar_canfd: Document r8a774a1 support

[Fabrizio Castro]

Hello Marc,

I am sorry to bother you.
Do you think you can take this patch?

Thanks,
Fab

> From: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Sent: 17 January 2019 14:54
> Subject: [PATCH 3/3] dt-bindings: can: rcar_canfd: Document r8a774a1 support
> 
> Document support for rcar_canfd on R8A774A1 SoC devices.
> 
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
> ---
> This patch depends on:
> https://patchwork.kernel.org/patch/10766781/
> 
>  Documentation/devicetree/bindings/net/can/rcar_canfd.txt | 15 ++++++++-------
>  1 file changed, 8 insertions(+), 7 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/can/rcar_canfd.txt
> b/Documentation/devicetree/bindings/net/can/rcar_canfd.txt
> index 32f051f..fd353a9 100644
> --- a/Documentation/devicetree/bindings/net/can/rcar_canfd.txt
> +++ b/Documentation/devicetree/bindings/net/can/rcar_canfd.txt
> @@ -4,6 +4,7 @@ Renesas R-Car CAN FD controller Device Tree Bindings
>  Required properties:
>  - compatible: Must contain one or more of the following:
>    - "renesas,rcar-gen3-canfd" for R-Car Gen3 and RZ/G2 compatible controllers.
> +  - "renesas,r8a774a1-canfd" for R8A774A1 (RZ/G2M) compatible controller.
>    - "renesas,r8a774c0-canfd" for R8A774C0 (RZ/G2E) compatible controller.
>    - "renesas,r8a7795-canfd" for R8A7795 (R-Car H3) compatible controller.
>    - "renesas,r8a7796-canfd" for R8A7796 (R-Car M3-W) compatible controller.
> @@ -29,13 +30,13 @@ The name of the child nodes are "channel0" and "channel1" respectively. Each
>  child node supports the "status" property only, which is used to
>  enable/disable the respective channel.
> 
> -Required properties for "renesas,r8a774c0-canfd", "renesas,r8a7795-canfd",
> -"renesas,r8a7796-canfd", "renesas,r8a77965-canfd", and "renesas,r8a77990-canfd"
> -compatible:
> -In R8A774C0, R8A7795, R8A7796, R8A77965, and R8A77990 SoCs, canfd clock is a
> -div6 clock and can be used by both CAN and CAN FD controller at the same time.
> -It needs to be scaled to maximum frequency if any of these controllers use it.
> -This is done using the below properties:
> +Required properties for "renesas,r8a774a1-canfd", "renesas,r8a774c0-canfd",
> +"renesas,r8a7795-canfd", "renesas,r8a7796-canfd", "renesas,r8a77965-canfd", and
> +"renesas,r8a77990-canfd" compatible:
> +In R8A774A1, R8A774C0, R8A7795, R8A7796, R8A77965, and R8A77990 SoCs, canfd
> +clock is a div6 clock and can be used by both CAN and CAN FD controller at the
> +same time. It needs to be scaled to maximum frequency if any of these
> +controllers use it. This is done using the below properties:
> 
>  - assigned-clocks: phandle of canfd clock.
>  - assigned-clock-rates: maximum frequency of this clock.
> --
> 2.7.4

RE: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes

[Fabrizio Castro]

Hello Simon,

> From: devicetree-owner@vger.kernel.org <devicetree-owner@vger.kernel.org> On Behalf Of Fabrizio Castro
> Sent: 28 January 2019 14:49
> Subject: RE: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes
> 
> > From: Simon Horman <horms@verge.net.au>
> > Sent: 28 January 2019 13:01
> > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes
> >
> > On Fri, Jan 25, 2019 at 11:33:41AM +0000, Fabrizio Castro wrote:
> > > Hello Simon,
> > >
> > > Thank you for your feedback!
> > >
> > > > From: Simon Horman <horms@verge.net.au>
> > > > Sent: 24 January 2019 10:01
> > > > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes
> > > >
> > > > On Wed, Jan 23, 2019 at 12:18:45PM +0000, Fabrizio Castro wrote:
> > > > > Hello Geert,
> > > > >
> > > > > Thank you for your feedback!
> > > > >
> > > > > > From: Geert Uytterhoeven <geert@linux-m68k.org>
> > > > > > Sent: 23 January 2019 12:08
> > > > > > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes
> > > > > >
> > > > > > Hi Fabrizio,
> > > > > >
> > > > > > On Wed, Jan 23, 2019 at 1:01 PM Fabrizio Castro
> > > > > > <fabrizio.castro@bp.renesas.com> wrote:
> > > > > > > > From: Simon Horman <horms@verge.net.au>
> > > > > > > > Sent: 23 January 2019 11:38
> > > > > > > > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes
> > > > > > > >
> > > > > > > > On Wed, Jan 23, 2019 at 10:51:23AM +0100, Simon Horman wrote:
> > > > > > > > > On Fri, Jan 18, 2019 at 01:13:53PM +0100, Simon Horman wrote:
> > > > > > > > > > On Thu, Jan 17, 2019 at 02:54:15PM +0000, Fabrizio Castro wrote:
> > > > > > > > > > > According to the latest information, clkp2 is available on RZ/G2.
> > > > > > > > > > > Modify CAN0 and CAN1 nodes accordingly.
> > > > > > > > > > >
> > > > > > > > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > > > > > > > > > > Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
> > > > > >
> > > > > > > > > Thanks again, applied for v5.1.
> > > > > > > >
> > > > > > > > Sorry, I was a little hasty there.
> > > > > > > >
> > > > > > > > This patch depends on the presence of R8A774A1_CLK_CANFD which
> > > > > > > > (rightly) is added in a different patch in this series which is to
> > > > > > > > go upstream via a different tree.
> > > > > > > >
> > > > > > > > I have dropped this patch for now. I think there are two solution to this
> > > > > > > > problem.
> > > > > > > >
> > > > > > > > 1. Provide a version of this patch which uses a numeric index instead of
> > > > > > > >    R8A774A1_CLK_CANFD. And then, once R8A774A1_CLK_CANFD is present in an
> > > > > > > >    RC release provide a patch to switch to using R8A774A1_CLK_CANFD.
> > > > > > > >
> > > > > > > > 2. Defer this patch until R8A774A1_CLK_CANFD is present in an RC release.
> > > > > > >
> > > > > > > Yeah, my personal preference is solution 2.
> > > > > >
> > > > > > Note that solution 2 will probably defer the DT patch to v5.2.
> > > > >
> > > > > Yeah, my understanding is that even if we chose solution 1 we would still
> > > > > need to be waiting for v5.2 for the patch to switch to using
> > > > > R8A774A1_CLK_CANFD to appear in a rc, therefore I think solution 2 is
> > > > > fine.
> > > >
> > > > Your understanding is the same as mine.
> > > >
> > > > I do seem some slight value in option 1 in terms of getting the change,
> > > > less the minor issue of using an index rather than a symbol, upstream
> > > > earlier. But I do not feel strongly about this.
> > > >
> > > > I am marking this patch as deferred. Please repost or otherwise ping me
> > > > when you would like to revisit this topic.
> > >
> > > Thank you. Will do.
> >
> > Thanks.
> >
> > I believe "[10/11] arm64: dts: renesas: r8a774c0: Add clkp2 clock to CAN nodes"
> > falls into the same category. I have marked it as deferred accordingly.
> 
> Ok, thank you Simon

My understanding is that this patch can now be taken, and it still applies neatly.

Thanks,
Fab

> 
> Fab
> 
> 
> 
> 
> Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England &
> Wales under Registered No. 04586709.

RE: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes

[Fabrizio Castro]

Hello Simon,

> From: devicetree-owner@vger.kernel.org <devicetree-owner@vger.kernel.org> On Behalf Of Fabrizio Castro
> Sent: 28 January 2019 14:49
> Subject: RE: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes
> 
> > From: Simon Horman <horms@verge.net.au>
> > Sent: 28 January 2019 13:01
> > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes
> >
> > On Fri, Jan 25, 2019 at 11:33:41AM +0000, Fabrizio Castro wrote:
> > > Hello Simon,
> > >
> > > Thank you for your feedback!
> > >
> > > > From: Simon Horman <horms@verge.net.au>
> > > > Sent: 24 January 2019 10:01
> > > > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes
> > > >
> > > > On Wed, Jan 23, 2019 at 12:18:45PM +0000, Fabrizio Castro wrote:
> > > > > Hello Geert,
> > > > >
> > > > > Thank you for your feedback!
> > > > >
> > > > > > From: Geert Uytterhoeven <geert@linux-m68k.org>
> > > > > > Sent: 23 January 2019 12:08
> > > > > > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes
> > > > > >
> > > > > > Hi Fabrizio,
> > > > > >
> > > > > > On Wed, Jan 23, 2019 at 1:01 PM Fabrizio Castro
> > > > > > <fabrizio.castro@bp.renesas.com> wrote:
> > > > > > > > From: Simon Horman <horms@verge.net.au>
> > > > > > > > Sent: 23 January 2019 11:38
> > > > > > > > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes
> > > > > > > >
> > > > > > > > On Wed, Jan 23, 2019 at 10:51:23AM +0100, Simon Horman wrote:
> > > > > > > > > On Fri, Jan 18, 2019 at 01:13:53PM +0100, Simon Horman wrote:
> > > > > > > > > > On Thu, Jan 17, 2019 at 02:54:15PM +0000, Fabrizio Castro wrote:
> > > > > > > > > > > According to the latest information, clkp2 is available on RZ/G2.
> > > > > > > > > > > Modify CAN0 and CAN1 nodes accordingly.
> > > > > > > > > > >
> > > > > > > > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > > > > > > > > > > Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
> > > > > >
> > > > > > > > > Thanks again, applied for v5.1.
> > > > > > > >
> > > > > > > > Sorry, I was a little hasty there.
> > > > > > > >
> > > > > > > > This patch depends on the presence of R8A774A1_CLK_CANFD which
> > > > > > > > (rightly) is added in a different patch in this series which is to
> > > > > > > > go upstream via a different tree.
> > > > > > > >
> > > > > > > > I have dropped this patch for now. I think there are two solution to this
> > > > > > > > problem.
> > > > > > > >
> > > > > > > > 1. Provide a version of this patch which uses a numeric index instead of
> > > > > > > >    R8A774A1_CLK_CANFD. And then, once R8A774A1_CLK_CANFD is present in an
> > > > > > > >    RC release provide a patch to switch to using R8A774A1_CLK_CANFD.
> > > > > > > >
> > > > > > > > 2. Defer this patch until R8A774A1_CLK_CANFD is present in an RC release.
> > > > > > >
> > > > > > > Yeah, my personal preference is solution 2.
> > > > > >
> > > > > > Note that solution 2 will probably defer the DT patch to v5.2.
> > > > >
> > > > > Yeah, my understanding is that even if we chose solution 1 we would still
> > > > > need to be waiting for v5.2 for the patch to switch to using
> > > > > R8A774A1_CLK_CANFD to appear in a rc, therefore I think solution 2 is
> > > > > fine.
> > > >
> > > > Your understanding is the same as mine.
> > > >
> > > > I do seem some slight value in option 1 in terms of getting the change,
> > > > less the minor issue of using an index rather than a symbol, upstream
> > > > earlier. But I do not feel strongly about this.
> > > >
> > > > I am marking this patch as deferred. Please repost or otherwise ping me
> > > > when you would like to revisit this topic.
> > >
> > > Thank you. Will do.
> >
> > Thanks.
> >
> > I believe "[10/11] arm64: dts: renesas: r8a774c0: Add clkp2 clock to CAN nodes"
> > falls into the same category. I have marked it as deferred accordingly.
> 
> Ok, thank you Simon

My understanding is that this patch can now be taken, and it still applies neatly.

Thanks,
Fab

> 
> Fab
> 
> 
> 
> 
> Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England &
> Wales under Registered No. 04586709.

Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes

[Simon Horman]

On Tue, Mar 19, 2019 at 11:22:35AM +0000, Fabrizio Castro wrote:
> Hello Simon,
> 
> > From: devicetree-owner@vger.kernel.org <devicetree-owner@vger.kernel.org> On Behalf Of Fabrizio Castro
> > Sent: 28 January 2019 14:49
> > Subject: RE: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes
> > 
> > > From: Simon Horman <horms@verge.net.au>
> > > Sent: 28 January 2019 13:01
> > > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes
> > >
> > > On Fri, Jan 25, 2019 at 11:33:41AM +0000, Fabrizio Castro wrote:
> > > > Hello Simon,
> > > >
> > > > Thank you for your feedback!
> > > >
> > > > > From: Simon Horman <horms@verge.net.au>
> > > > > Sent: 24 January 2019 10:01
> > > > > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes
> > > > >
> > > > > On Wed, Jan 23, 2019 at 12:18:45PM +0000, Fabrizio Castro wrote:
> > > > > > Hello Geert,
> > > > > >
> > > > > > Thank you for your feedback!
> > > > > >
> > > > > > > From: Geert Uytterhoeven <geert@linux-m68k.org>
> > > > > > > Sent: 23 January 2019 12:08
> > > > > > > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes
> > > > > > >
> > > > > > > Hi Fabrizio,
> > > > > > >
> > > > > > > On Wed, Jan 23, 2019 at 1:01 PM Fabrizio Castro
> > > > > > > <fabrizio.castro@bp.renesas.com> wrote:
> > > > > > > > > From: Simon Horman <horms@verge.net.au>
> > > > > > > > > Sent: 23 January 2019 11:38
> > > > > > > > > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes
> > > > > > > > >
> > > > > > > > > On Wed, Jan 23, 2019 at 10:51:23AM +0100, Simon Horman wrote:
> > > > > > > > > > On Fri, Jan 18, 2019 at 01:13:53PM +0100, Simon Horman wrote:
> > > > > > > > > > > On Thu, Jan 17, 2019 at 02:54:15PM +0000, Fabrizio Castro wrote:
> > > > > > > > > > > > According to the latest information, clkp2 is available on RZ/G2.
> > > > > > > > > > > > Modify CAN0 and CAN1 nodes accordingly.
> > > > > > > > > > > >
> > > > > > > > > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > > > > > > > > > > > Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
> > > > > > >
> > > > > > > > > > Thanks again, applied for v5.1.
> > > > > > > > >
> > > > > > > > > Sorry, I was a little hasty there.
> > > > > > > > >
> > > > > > > > > This patch depends on the presence of R8A774A1_CLK_CANFD which
> > > > > > > > > (rightly) is added in a different patch in this series which is to
> > > > > > > > > go upstream via a different tree.
> > > > > > > > >
> > > > > > > > > I have dropped this patch for now. I think there are two solution to this
> > > > > > > > > problem.
> > > > > > > > >
> > > > > > > > > 1. Provide a version of this patch which uses a numeric index instead of
> > > > > > > > >    R8A774A1_CLK_CANFD. And then, once R8A774A1_CLK_CANFD is present in an
> > > > > > > > >    RC release provide a patch to switch to using R8A774A1_CLK_CANFD.
> > > > > > > > >
> > > > > > > > > 2. Defer this patch until R8A774A1_CLK_CANFD is present in an RC release.
> > > > > > > >
> > > > > > > > Yeah, my personal preference is solution 2.
> > > > > > >
> > > > > > > Note that solution 2 will probably defer the DT patch to v5.2.
> > > > > >
> > > > > > Yeah, my understanding is that even if we chose solution 1 we would still
> > > > > > need to be waiting for v5.2 for the patch to switch to using
> > > > > > R8A774A1_CLK_CANFD to appear in a rc, therefore I think solution 2 is
> > > > > > fine.
> > > > >
> > > > > Your understanding is the same as mine.
> > > > >
> > > > > I do seem some slight value in option 1 in terms of getting the change,
> > > > > less the minor issue of using an index rather than a symbol, upstream
> > > > > earlier. But I do not feel strongly about this.
> > > > >
> > > > > I am marking this patch as deferred. Please repost or otherwise ping me
> > > > > when you would like to revisit this topic.
> > > >
> > > > Thank you. Will do.
> > >
> > > Thanks.
> > >
> > > I believe "[10/11] arm64: dts: renesas: r8a774c0: Add clkp2 clock to CAN nodes"
> > > falls into the same category. I have marked it as deferred accordingly.
> > 
> > Ok, thank you Simon
> 
> My understanding is that this patch can now be taken, and it still applies neatly.

Thanks, I agree this should be ready now.
I've applied it for v5.2.

Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes

[Simon Horman]

On Tue, Mar 19, 2019 at 11:22:35AM +0000, Fabrizio Castro wrote:
> Hello Simon,
> 
> > From: devicetree-owner@vger.kernel.org <devicetree-owner@vger.kernel.org> On Behalf Of Fabrizio Castro
> > Sent: 28 January 2019 14:49
> > Subject: RE: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes
> > 
> > > From: Simon Horman <horms@verge.net.au>
> > > Sent: 28 January 2019 13:01
> > > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes
> > >
> > > On Fri, Jan 25, 2019 at 11:33:41AM +0000, Fabrizio Castro wrote:
> > > > Hello Simon,
> > > >
> > > > Thank you for your feedback!
> > > >
> > > > > From: Simon Horman <horms@verge.net.au>
> > > > > Sent: 24 January 2019 10:01
> > > > > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes
> > > > >
> > > > > On Wed, Jan 23, 2019 at 12:18:45PM +0000, Fabrizio Castro wrote:
> > > > > > Hello Geert,
> > > > > >
> > > > > > Thank you for your feedback!
> > > > > >
> > > > > > > From: Geert Uytterhoeven <geert@linux-m68k.org>
> > > > > > > Sent: 23 January 2019 12:08
> > > > > > > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes
> > > > > > >
> > > > > > > Hi Fabrizio,
> > > > > > >
> > > > > > > On Wed, Jan 23, 2019 at 1:01 PM Fabrizio Castro
> > > > > > > <fabrizio.castro@bp.renesas.com> wrote:
> > > > > > > > > From: Simon Horman <horms@verge.net.au>
> > > > > > > > > Sent: 23 January 2019 11:38
> > > > > > > > > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes
> > > > > > > > >
> > > > > > > > > On Wed, Jan 23, 2019 at 10:51:23AM +0100, Simon Horman wrote:
> > > > > > > > > > On Fri, Jan 18, 2019 at 01:13:53PM +0100, Simon Horman wrote:
> > > > > > > > > > > On Thu, Jan 17, 2019 at 02:54:15PM +0000, Fabrizio Castro wrote:
> > > > > > > > > > > > According to the latest information, clkp2 is available on RZ/G2.
> > > > > > > > > > > > Modify CAN0 and CAN1 nodes accordingly.
> > > > > > > > > > > >
> > > > > > > > > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > > > > > > > > > > > Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
> > > > > > >
> > > > > > > > > > Thanks again, applied for v5.1.
> > > > > > > > >
> > > > > > > > > Sorry, I was a little hasty there.
> > > > > > > > >
> > > > > > > > > This patch depends on the presence of R8A774A1_CLK_CANFD which
> > > > > > > > > (rightly) is added in a different patch in this series which is to
> > > > > > > > > go upstream via a different tree.
> > > > > > > > >
> > > > > > > > > I have dropped this patch for now. I think there are two solution to this
> > > > > > > > > problem.
> > > > > > > > >
> > > > > > > > > 1. Provide a version of this patch which uses a numeric index instead of
> > > > > > > > >    R8A774A1_CLK_CANFD. And then, once R8A774A1_CLK_CANFD is present in an
> > > > > > > > >    RC release provide a patch to switch to using R8A774A1_CLK_CANFD.
> > > > > > > > >
> > > > > > > > > 2. Defer this patch until R8A774A1_CLK_CANFD is present in an RC release.
> > > > > > > >
> > > > > > > > Yeah, my personal preference is solution 2.
> > > > > > >
> > > > > > > Note that solution 2 will probably defer the DT patch to v5.2.
> > > > > >
> > > > > > Yeah, my understanding is that even if we chose solution 1 we would still
> > > > > > need to be waiting for v5.2 for the patch to switch to using
> > > > > > R8A774A1_CLK_CANFD to appear in a rc, therefore I think solution 2 is
> > > > > > fine.
> > > > >
> > > > > Your understanding is the same as mine.
> > > > >
> > > > > I do seem some slight value in option 1 in terms of getting the change,
> > > > > less the minor issue of using an index rather than a symbol, upstream
> > > > > earlier. But I do not feel strongly about this.
> > > > >
> > > > > I am marking this patch as deferred. Please repost or otherwise ping me
> > > > > when you would like to revisit this topic.
> > > >
> > > > Thank you. Will do.
> > >
> > > Thanks.
> > >
> > > I believe "[10/11] arm64: dts: renesas: r8a774c0: Add clkp2 clock to CAN nodes"
> > > falls into the same category. I have marked it as deferred accordingly.
> > 
> > Ok, thank you Simon
> 
> My understanding is that this patch can now be taken, and it still applies neatly.

Thanks, I agree this should be ready now.
I've applied it for v5.2.