All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/5] drm/i915: Enable transition watermarks for glk
@ 2019-02-18 20:52 Ville Syrjala
  2019-02-18 20:52 ` [PATCH 2/5] drm/i915: Implement display w/a 1140 for glk/cnl Ville Syrjala
                   ` (7 more replies)
  0 siblings, 8 replies; 10+ messages in thread
From: Ville Syrjala @ 2019-02-18 20:52 UTC (permalink / raw)
  To: intel-gfx

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

We are mistakenly skipping transition watermarks on glk. Fix
up the condition for glk, and toss in the w/a name from
the database.

v2: Reorder the ipc enabled vs. platform check to be more sensible

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> #v1
---
 drivers/gpu/drm/i915/intel_pm.c | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 4c0e43caa5cd..581f90e12f93 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -4859,14 +4859,17 @@ static void skl_compute_transition_wm(const struct intel_crtc_state *cstate,
 	const u16 trans_amount = 10; /* This is configurable amount */
 	u16 wm0_sel_res_b, trans_offset_b, res_blocks;
 
-	/* Transition WM are not recommended by HW team for GEN9 */
-	if (INTEL_GEN(dev_priv) <= 9)
-		return;
-
 	/* Transition WM don't make any sense if ipc is disabled */
 	if (!dev_priv->ipc_enabled)
 		return;
 
+	/*
+	 * WaDisableTWM:skl,kbl,cfl,bxt
+	 * Transition WM are not recommended by HW team for GEN9
+	 */
+	if (IS_GEN9_BC(dev_priv) || IS_BROXTON(dev_priv))
+		return;
+
 	trans_min = 14;
 	if (INTEL_GEN(dev_priv) >= 11)
 		trans_min = 4;
-- 
2.19.2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2019-03-21  6:21 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-18 20:52 [PATCH 1/5] drm/i915: Enable transition watermarks for glk Ville Syrjala
2019-02-18 20:52 ` [PATCH 2/5] drm/i915: Implement display w/a 1140 for glk/cnl Ville Syrjala
2019-02-18 20:52 ` [PATCH 3/5] drm/i915: Document that we implement WaIncreaseLatencyIPCEnabled Ville Syrjala
2019-02-18 20:52 ` [PATCH 4/5] drm/i915: Drop WaIncreaseLatencyIPCEnabled/1140 for cnl Ville Syrjala
2019-02-18 20:52 ` [PATCH 5/5] drm/i915: Move w/a 0477/WaDisableIPC:skl into intel_init_ipc() Ville Syrjala
2019-02-19 17:50   ` Rodrigo Vivi
2019-02-18 21:49 ` ✓ Fi.CI.BAT: success for series starting with [1/5] drm/i915: Enable transition watermarks for glk Patchwork
2019-02-19  2:48 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-03-20 23:54 ` ✓ Fi.CI.BAT: success for series starting with [1/5] drm/i915: Enable transition watermarks for glk (rev2) Patchwork
2019-03-21  6:21 ` ✗ Fi.CI.IGT: failure " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.