* [igt-dev] [PATCH i-g-t 1/3] tools: Add dpcd_reg binary to gitignore
@ 2019-02-19 13:25 Arkadiusz Hiler
2019-02-19 13:25 ` [igt-dev] [PATCH i-g-t 2/3] tests/i915: Rename files so they correspond to binary names Arkadiusz Hiler
` (3 more replies)
0 siblings, 4 replies; 10+ messages in thread
From: Arkadiusz Hiler @ 2019-02-19 13:25 UTC (permalink / raw)
To: igt-dev; +Cc: Petri Latvala
Cc: Petri Latvala <petri.latvala@intel.com>
Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
---
tools/.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/.gitignore b/tools/.gitignore
index 2de665a3..210daac5 100644
--- a/tools/.gitignore
+++ b/tools/.gitignore
@@ -1,5 +1,6 @@
# Please keep sorted alphabetically
cnl_compute_wrpll
+dpcd_reg
hsw_compute_wrpll
igt_stats
intel_aubdump
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [igt-dev] [PATCH i-g-t 2/3] tests/i915: Rename files so they correspond to binary names
2019-02-19 13:25 [igt-dev] [PATCH i-g-t 1/3] tools: Add dpcd_reg binary to gitignore Arkadiusz Hiler
@ 2019-02-19 13:25 ` Arkadiusz Hiler
2019-02-19 13:25 ` [igt-dev] [PATCH i-g-t 3/3] tests: Prefix pm_ tests with i915_ and move them to i915/ Arkadiusz Hiler
` (2 subsequent siblings)
3 siblings, 0 replies; 10+ messages in thread
From: Arkadiusz Hiler @ 2019-02-19 13:25 UTC (permalink / raw)
To: igt-dev; +Cc: Petri Latvala
So we do not have to do any rename shenanigans in the build system and
the .c files are easier to find.
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Petri Latvala <petri.latvala@intel.com>
Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
---
tests/Makefile.sources | 16 +++----
tests/i915/{fb_tiling.c => i915_fb_tiling.c} | 0
...tparams_basic.c => i915_getparams_basic.c} | 0
tests/i915/{hangman.c => i915_hangman.c} | 0
.../i915/{missed_irq.c => i915_missed_irq.c} | 0
.../{module_load.c => i915_module_load.c} | 0
tests/i915/{query.c => i915_query.c} | 0
tests/i915/{selftest.c => i915_selftest.c} | 0
tests/i915/{suspend.c => i915_suspend.c} | 0
tests/meson.build | 43 ++++++-------------
10 files changed, 21 insertions(+), 38 deletions(-)
rename tests/i915/{fb_tiling.c => i915_fb_tiling.c} (100%)
rename tests/i915/{getparams_basic.c => i915_getparams_basic.c} (100%)
rename tests/i915/{hangman.c => i915_hangman.c} (100%)
rename tests/i915/{missed_irq.c => i915_missed_irq.c} (100%)
rename tests/i915/{module_load.c => i915_module_load.c} (100%)
rename tests/i915/{query.c => i915_query.c} (100%)
rename tests/i915/{selftest.c => i915_selftest.c} (100%)
rename tests/i915/{suspend.c => i915_suspend.c} (100%)
diff --git a/tests/Makefile.sources b/tests/Makefile.sources
index d2c4f9fe..1efd3ecb 100644
--- a/tests/Makefile.sources
+++ b/tests/Makefile.sources
@@ -472,28 +472,28 @@ TESTS_progs += gen3_render_tiledy_blits
gen3_render_tiledy_blits_SOURCES = i915/gen3_render_tiledy_blits.c
TESTS_progs += i915_fb_tiling
-i915_fb_tiling_SOURCES = i915/fb_tiling.c
+i915_fb_tiling_SOURCES = i915/i915_fb_tiling.c
TESTS_progs += i915_getparams_basic
-i915_getparams_basic_SOURCES = i915/getparams_basic.c
+i915_getparams_basic_SOURCES = i915/i915_getparams_basic.c
TESTS_progs += i915_hangman
-i915_hangman_SOURCES = i915/hangman.c
+i915_hangman_SOURCES = i915/i915_hangman.c
TESTS_progs += i915_missed_irq
-i915_missed_irq_SOURCES = i915/missed_irq.c
+i915_missed_irq_SOURCES = i915/i915_missed_irq.c
TESTS_progs += i915_module_load
-i915_module_load_SOURCES = i915/module_load.c
+i915_module_load_SOURCES = i915/i915_module_load.c
TESTS_progs += i915_query
-i915_query_SOURCES = i915/query.c
+i915_query_SOURCES = i915/i915_query.c
TESTS_progs += i915_selftest
-i915_selftest_SOURCES = i915/selftest.c
+i915_selftest_SOURCES = i915/i915_selftest.c
TESTS_progs += i915_suspend
-i915_suspend_SOURCES = i915/suspend.c
+i915_suspend_SOURCES = i915/i915_suspend.c
TESTS_progs_X = gem_concurrent_all
gem_concurrent_all_SOURCES = i915/gem_concurrent_all.c
diff --git a/tests/i915/fb_tiling.c b/tests/i915/i915_fb_tiling.c
similarity index 100%
rename from tests/i915/fb_tiling.c
rename to tests/i915/i915_fb_tiling.c
diff --git a/tests/i915/getparams_basic.c b/tests/i915/i915_getparams_basic.c
similarity index 100%
rename from tests/i915/getparams_basic.c
rename to tests/i915/i915_getparams_basic.c
diff --git a/tests/i915/hangman.c b/tests/i915/i915_hangman.c
similarity index 100%
rename from tests/i915/hangman.c
rename to tests/i915/i915_hangman.c
diff --git a/tests/i915/missed_irq.c b/tests/i915/i915_missed_irq.c
similarity index 100%
rename from tests/i915/missed_irq.c
rename to tests/i915/i915_missed_irq.c
diff --git a/tests/i915/module_load.c b/tests/i915/i915_module_load.c
similarity index 100%
rename from tests/i915/module_load.c
rename to tests/i915/i915_module_load.c
diff --git a/tests/i915/query.c b/tests/i915/i915_query.c
similarity index 100%
rename from tests/i915/query.c
rename to tests/i915/i915_query.c
diff --git a/tests/i915/selftest.c b/tests/i915/i915_selftest.c
similarity index 100%
rename from tests/i915/selftest.c
rename to tests/i915/i915_selftest.c
diff --git a/tests/i915/suspend.c b/tests/i915/i915_suspend.c
similarity index 100%
rename from tests/i915/suspend.c
rename to tests/i915/i915_suspend.c
diff --git a/tests/meson.build b/tests/meson.build
index ec980651..bb90711e 100644
--- a/tests/meson.build
+++ b/tests/meson.build
@@ -97,17 +97,11 @@ test_progs = [
]
i915_progs = [
- 'fb_tiling',
- 'getparams_basic',
- 'hangman',
- 'missed_irq',
- 'module_load',
- 'query',
- 'selftest',
- 'suspend',
-]
-
-gem_progs = [
+ 'gen3_mixed_blits',
+ 'gen3_render_linear_blits',
+ 'gen3_render_mixed_blits',
+ 'gen3_render_tiledx_blits',
+ 'gen3_render_tiledy_blits',
'gem_bad_reloc',
'gem_basic',
'gem_busy',
@@ -224,14 +218,14 @@ gem_progs = [
'gem_wait',
'gem_workarounds',
'gem_write_read_ring_switch',
-]
-
-gen3_progs = [
- 'gen3_mixed_blits',
- 'gen3_render_linear_blits',
- 'gen3_render_mixed_blits',
- 'gen3_render_tiledx_blits',
- 'gen3_render_tiledy_blits',
+ 'i915_fb_tiling',
+ 'i915_getparams_basic',
+ 'i915_hangman',
+ 'i915_missed_irq',
+ 'i915_module_load',
+ 'i915_query',
+ 'i915_selftest',
+ 'i915_suspend',
]
test_deps = [ igt_deps ]
@@ -272,17 +266,6 @@ foreach prog : test_progs
endforeach
foreach prog : i915_progs
- prog_name = 'i915_' + prog
- test_executables += executable(prog_name,
- join_paths('i915', prog + '.c'),
- dependencies : test_deps,
- install_dir : libexecdir,
- install_rpath : libexecdir_rpathdir,
- install : true)
- test_list += prog_name
-endforeach
-
-foreach prog : gem_progs + gen3_progs
test_executables += executable(prog,
join_paths('i915', prog + '.c'),
dependencies : test_deps,
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [igt-dev] [PATCH i-g-t 3/3] tests: Prefix pm_ tests with i915_ and move them to i915/
2019-02-19 13:25 [igt-dev] [PATCH i-g-t 1/3] tools: Add dpcd_reg binary to gitignore Arkadiusz Hiler
2019-02-19 13:25 ` [igt-dev] [PATCH i-g-t 2/3] tests/i915: Rename files so they correspond to binary names Arkadiusz Hiler
@ 2019-02-19 13:25 ` Arkadiusz Hiler
2019-02-19 14:23 ` Arkadiusz Hiler
2019-02-20 10:04 ` Jani Nikula
2019-02-19 14:03 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/3] tools: Add dpcd_reg binary to gitignore Patchwork
2019-02-19 17:53 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
3 siblings, 2 replies; 10+ messages in thread
From: Arkadiusz Hiler @ 2019-02-19 13:25 UTC (permalink / raw)
To: igt-dev; +Cc: Petri Latvala
They are i915-specific, so they belong to the directory.
The (now) infix _pm_ is quite informative and worth keeping.
v2: also prefix .c files
Cc: Petri Latvala <petri.latvala@intel.com>
Cc: Ewelina Musial <ewelina.musial@intel.com>
Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
---
Acks/rbs appreciated, but please let me push it, as I have to do
renaming in the cibuglog first :-)
tests/Makefile.sources | 24 ++++++++++++++-----
.../i915_pm_backlight.c} | 0
tests/{pm_lpsp.c => i915/i915_pm_lpsp.c} | 0
.../i915_pm_rc6_residency.c} | 0
tests/{pm_rpm.c => i915/i915_pm_rpm.c} | 0
tests/{pm_rps.c => i915/i915_pm_rps.c} | 0
tests/{pm_sseu.c => i915/i915_pm_sseu.c} | 0
tests/meson.build | 12 +++++-----
8 files changed, 24 insertions(+), 12 deletions(-)
rename tests/{pm_backlight.c => i915/i915_pm_backlight.c} (100%)
rename tests/{pm_lpsp.c => i915/i915_pm_lpsp.c} (100%)
rename tests/{pm_rc6_residency.c => i915/i915_pm_rc6_residency.c} (100%)
rename tests/{pm_rpm.c => i915/i915_pm_rpm.c} (100%)
rename tests/{pm_rps.c => i915/i915_pm_rps.c} (100%)
rename tests/{pm_sseu.c => i915/i915_pm_sseu.c} (100%)
diff --git a/tests/Makefile.sources b/tests/Makefile.sources
index 1efd3ecb..35c79592 100644
--- a/tests/Makefile.sources
+++ b/tests/Makefile.sources
@@ -77,12 +77,6 @@ TESTS_progs = \
meta_test \
perf \
perf_pmu \
- pm_backlight \
- pm_lpsp \
- pm_rc6_residency \
- pm_rpm \
- pm_rps \
- pm_sseu \
prime_busy \
prime_mmap \
prime_mmap_coherency \
@@ -486,6 +480,24 @@ i915_missed_irq_SOURCES = i915/i915_missed_irq.c
TESTS_progs += i915_module_load
i915_module_load_SOURCES = i915/i915_module_load.c
+TESTS_progs += i915_pm_backlight
+i915_pm_backlight_SOURCES = i915/i915_pm_backlight.c
+
+TESTS_progs += i915_pm_lpsp
+i915_pm_lpsp_SOURCES = i915/i915_pm_lpsp.c
+
+TESTS_progs += i915_pm_rc6_residency
+i915_pm_rc6_residency_SOURCES = i915/i915_pm_rc6_residency.c
+
+TESTS_progs += i915_pm_rpm
+i915_pm_rpm_SOURCES = i915/i915_pm_rpm.c
+
+TESTS_progs += i915_pm_rps
+i915_pm_rps_SOURCES = i915/i915_pm_rps.c
+
+TESTS_progs += i915_pm_sseu
+i915_pm_sseu_SOURCES = i915/i915_pm_sseu.c
+
TESTS_progs += i915_query
i915_query_SOURCES = i915/i915_query.c
diff --git a/tests/pm_backlight.c b/tests/i915/i915_pm_backlight.c
similarity index 100%
rename from tests/pm_backlight.c
rename to tests/i915/i915_pm_backlight.c
diff --git a/tests/pm_lpsp.c b/tests/i915/i915_pm_lpsp.c
similarity index 100%
rename from tests/pm_lpsp.c
rename to tests/i915/i915_pm_lpsp.c
diff --git a/tests/pm_rc6_residency.c b/tests/i915/i915_pm_rc6_residency.c
similarity index 100%
rename from tests/pm_rc6_residency.c
rename to tests/i915/i915_pm_rc6_residency.c
diff --git a/tests/pm_rpm.c b/tests/i915/i915_pm_rpm.c
similarity index 100%
rename from tests/pm_rpm.c
rename to tests/i915/i915_pm_rpm.c
diff --git a/tests/pm_rps.c b/tests/i915/i915_pm_rps.c
similarity index 100%
rename from tests/pm_rps.c
rename to tests/i915/i915_pm_rps.c
diff --git a/tests/pm_sseu.c b/tests/i915/i915_pm_sseu.c
similarity index 100%
rename from tests/pm_sseu.c
rename to tests/i915/i915_pm_sseu.c
diff --git a/tests/meson.build b/tests/meson.build
index bb90711e..f4bd4a10 100644
--- a/tests/meson.build
+++ b/tests/meson.build
@@ -63,12 +63,6 @@ test_progs = [
'kms_vrr',
'meta_test',
'perf',
- 'pm_backlight',
- 'pm_lpsp',
- 'pm_rc6_residency',
- 'pm_rpm',
- 'pm_rps',
- 'pm_sseu',
'prime_busy',
'prime_mmap',
'prime_mmap_coherency',
@@ -223,6 +217,12 @@ i915_progs = [
'i915_hangman',
'i915_missed_irq',
'i915_module_load',
+ 'i915_pm_backlight',
+ 'i915_pm_lpsp',
+ 'i915_pm_rc6_residency',
+ 'i915_pm_rpm',
+ 'i915_pm_rps',
+ 'i915_pm_sseu',
'i915_query',
'i915_selftest',
'i915_suspend',
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/3] tools: Add dpcd_reg binary to gitignore
2019-02-19 13:25 [igt-dev] [PATCH i-g-t 1/3] tools: Add dpcd_reg binary to gitignore Arkadiusz Hiler
2019-02-19 13:25 ` [igt-dev] [PATCH i-g-t 2/3] tests/i915: Rename files so they correspond to binary names Arkadiusz Hiler
2019-02-19 13:25 ` [igt-dev] [PATCH i-g-t 3/3] tests: Prefix pm_ tests with i915_ and move them to i915/ Arkadiusz Hiler
@ 2019-02-19 14:03 ` Patchwork
2019-02-19 17:53 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
3 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2019-02-19 14:03 UTC (permalink / raw)
To: igt-dev
== Series Details ==
Series: series starting with [i-g-t,1/3] tools: Add dpcd_reg binary to gitignore
URL : https://patchwork.freedesktop.org/series/56897/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5630 -> IGTPW_2448
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/56897/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2448 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_pipe_crc_basic@read-crc-pipe-a:
- fi-byt-clapper: PASS -> FAIL [fdo#107362]
#### Possible fixes ####
* igt@i915_module_load@reload:
- fi-blb-e6850: INCOMPLETE [fdo#107718] -> PASS
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: FAIL [fdo#109485] -> PASS
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- fi-byt-clapper: INCOMPLETE [fdo#102657] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#102657]: https://bugs.freedesktop.org/show_bug.cgi?id=102657
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#105998]: https://bugs.freedesktop.org/show_bug.cgi?id=105998
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109294]: https://bugs.freedesktop.org/show_bug.cgi?id=109294
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109485]: https://bugs.freedesktop.org/show_bug.cgi?id=109485
[fdo#109527]: https://bugs.freedesktop.org/show_bug.cgi?id=109527
[fdo#109528]: https://bugs.freedesktop.org/show_bug.cgi?id=109528
[fdo#109530]: https://bugs.freedesktop.org/show_bug.cgi?id=109530
Participating hosts (44 -> 41)
------------------------------
Additional (2): fi-icl-y fi-bdw-5557u
Missing (5): fi-kbl-soraka fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-icl-u2
Build changes
-------------
* IGT: IGT_4837 -> IGTPW_2448
CI_DRM_5630: 82d591391bfcd9cfe2eeac149c49a678b571cd62 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2448: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2448/
IGT_4837: 368e76156f752e6ed6ac32ed9f400567aef7d3fc @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Testlist changes ==
+++ 64 lines
--- 64 lines
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2448/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 3/3] tests: Prefix pm_ tests with i915_ and move them to i915/
2019-02-19 13:25 ` [igt-dev] [PATCH i-g-t 3/3] tests: Prefix pm_ tests with i915_ and move them to i915/ Arkadiusz Hiler
@ 2019-02-19 14:23 ` Arkadiusz Hiler
2019-02-20 7:34 ` Arkadiusz Hiler
2019-02-21 9:32 ` Chris Wilson
2019-02-20 10:04 ` Jani Nikula
1 sibling, 2 replies; 10+ messages in thread
From: Arkadiusz Hiler @ 2019-02-19 14:23 UTC (permalink / raw)
To: igt-dev; +Cc: Petri Latvala
On Tue, Feb 19, 2019 at 03:25:43PM +0200, Arkadiusz Hiler wrote:
> They are i915-specific, so they belong to the directory.
> The (now) infix _pm_ is quite informative and worth keeping.
>
> v2: also prefix .c files
>
> Cc: Petri Latvala <petri.latvala@intel.com>
> Cc: Ewelina Musial <ewelina.musial@intel.com>
> Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> ---
> Acks/rbs appreciated, but please let me push it, as I have to do
> renaming in the cibuglog first :-)
I forgot to stage this change:
diff --git a/tests/intel-ci/blacklist.txt b/tests/intel-ci/blacklist.txt
index f9ad47ea..f3440f31 100644
--- a/tests/intel-ci/blacklist.txt
+++ b/tests/intel-ci/blacklist.txt
@@ -13,7 +13,7 @@ igt@drm_mm(@.*)?
# failures in tests run afterwards.
###############################################
igt@i915_module_load(@.*)?
-igt@pm_rpm@module-reload
+igt@i915_pm_rpm@module-reload
###############################################
# GEM
###############################################
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,1/3] tools: Add dpcd_reg binary to gitignore
2019-02-19 13:25 [igt-dev] [PATCH i-g-t 1/3] tools: Add dpcd_reg binary to gitignore Arkadiusz Hiler
` (2 preceding siblings ...)
2019-02-19 14:03 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/3] tools: Add dpcd_reg binary to gitignore Patchwork
@ 2019-02-19 17:53 ` Patchwork
3 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2019-02-19 17:53 UTC (permalink / raw)
To: igt-dev
== Series Details ==
Series: series starting with [i-g-t,1/3] tools: Add dpcd_reg binary to gitignore
URL : https://patchwork.freedesktop.org/series/56897/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5630_full -> IGTPW_2448_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/56897/revisions/1/mbox/
New tests
---------
New tests have been introduced between CI_DRM_5630_full and IGTPW_2448_full:
### New IGT tests (62) ###
* igt@i915_pm_backlight@bad-brightness:
- Statuses : 5 skip(s)
- Exec time: [0.0] s
* igt@i915_pm_backlight@basic-brightness:
- Statuses : 5 skip(s)
- Exec time: [0.0] s
* igt@i915_pm_backlight@fade:
- Statuses : 5 skip(s)
- Exec time: [0.0] s
* igt@i915_pm_backlight@fade_with_dpms:
- Statuses : 5 skip(s)
- Exec time: [0.0] s
* igt@i915_pm_backlight@fade_with_suspend:
- Statuses : 5 skip(s)
- Exec time: [0.0] s
* igt@i915_pm_lpsp@edp-native:
- Statuses : 4 skip(s)
- Exec time: [0.0, 0.02] s
* igt@i915_pm_lpsp@edp-panel-fitter:
- Statuses : 5 skip(s)
- Exec time: [0.0, 0.04] s
* igt@i915_pm_lpsp@non-edp:
- Statuses : 1 pass(s) 4 skip(s)
- Exec time: [0.0, 0.11] s
* igt@i915_pm_lpsp@screens-disabled:
- Statuses : 1 pass(s) 4 skip(s)
- Exec time: [0.0, 0.03] s
* igt@i915_pm_rc6_residency@media-rc6-accuracy:
- Statuses : 5 skip(s)
- Exec time: [0.0] s
* igt@i915_pm_rc6_residency@rc6-accuracy:
- Statuses : 4 pass(s) 1 skip(s)
- Exec time: [0.0, 3.00] s
* igt@i915_pm_rpm@basic-pci-d3-state:
- Statuses : 4 pass(s) 1 skip(s)
- Exec time: [0.0, 0.19] s
* igt@i915_pm_rpm@basic-rte:
- Statuses : 4 pass(s) 1 skip(s)
- Exec time: [1.18, 1.52] s
* igt@i915_pm_rpm@cursor:
- Statuses : 4 pass(s) 1 skip(s)
- Exec time: [0.0, 2.45] s
* igt@i915_pm_rpm@cursor-dpms:
- Statuses : 4 pass(s)
- Exec time: [0.90, 2.16] s
* igt@i915_pm_rpm@debugfs-forcewake-user:
- Statuses : 4 pass(s) 1 skip(s)
- Exec time: [0.0, 10.21] s
* igt@i915_pm_rpm@debugfs-read:
- Statuses : 4 pass(s) 1 skip(s)
- Exec time: [0.0, 4.55] s
* igt@i915_pm_rpm@dpms-lpsp:
- Statuses : 5 skip(s)
- Exec time: [0.0] s
* igt@i915_pm_rpm@dpms-mode-unset-lpsp:
- Statuses : 5 skip(s)
- Exec time: [0.0, 0.00] s
* igt@i915_pm_rpm@dpms-mode-unset-non-lpsp:
- Statuses : 2 pass(s) 1 skip(s)
- Exec time: [0.0, 0.66] s
* igt@i915_pm_rpm@dpms-non-lpsp:
- Statuses : 4 pass(s) 1 skip(s)
- Exec time: [0.0, 0.15] s
* igt@i915_pm_rpm@drm-resources-equal:
- Statuses : 4 pass(s)
- Exec time: [0.93, 3.12] s
* igt@i915_pm_rpm@fences:
- Statuses : 4 pass(s) 1 skip(s)
- Exec time: [0.0, 4.63] s
* igt@i915_pm_rpm@fences-dpms:
- Statuses : 4 pass(s) 1 skip(s)
- Exec time: [0.0, 3.66] s
* igt@i915_pm_rpm@gem-evict-pwrite:
- Statuses : 4 pass(s) 1 skip(s)
- Exec time: [0.0, 1.74] s
* igt@i915_pm_rpm@gem-execbuf:
- Statuses : 4 pass(s) 1 skip(s)
- Exec time: [0.0, 8.68] s
* igt@i915_pm_rpm@gem-execbuf-stress:
- Statuses : 4 pass(s) 1 skip(s)
- Exec time: [0.0, 39.75] s
* igt@i915_pm_rpm@gem-execbuf-stress-extra-wait:
- Statuses : 4 pass(s) 1 skip(s)
- Exec time: [0.0, 88.47] s
* igt@i915_pm_rpm@gem-execbuf-stress-pc8:
- Statuses : 5 skip(s)
- Exec time: [0.0, 0.00] s
* igt@i915_pm_rpm@gem-idle:
- Statuses : 3 pass(s) 1 skip(s)
- Exec time: [0.0, 5.03] s
* igt@i915_pm_rpm@gem-mmap-cpu:
- Statuses : 4 pass(s) 1 skip(s)
- Exec time: [0.0, 1.76] s
* igt@i915_pm_rpm@gem-mmap-gtt:
- Statuses : 4 pass(s) 1 skip(s)
- Exec time: [0.0, 2.46] s
* igt@i915_pm_rpm@gem-pread:
- Statuses : 4 pass(s) 1 skip(s)
- Exec time: [0.0, 0.96] s
* igt@i915_pm_rpm@i2c:
- Statuses : 4 pass(s) 1 skip(s)
- Exec time: [0.0, 1.30] s
* igt@i915_pm_rpm@legacy-planes:
- Statuses : 4 pass(s) 1 skip(s)
- Exec time: [0.0, 3.58] s
* igt@i915_pm_rpm@legacy-planes-dpms:
- Statuses : 2 pass(s) 1 skip(s)
- Exec time: [0.0, 3.85] s
* igt@i915_pm_rpm@modeset-lpsp:
- Statuses : 5 skip(s)
- Exec time: [0.0, 0.00] s
* igt@i915_pm_rpm@modeset-lpsp-stress:
- Statuses : 4 skip(s)
- Exec time: [0.0, 0.00] s
* igt@i915_pm_rpm@modeset-lpsp-stress-no-wait:
- Statuses : 5 skip(s)
- Exec time: [0.0, 0.00] s
* igt@i915_pm_rpm@modeset-non-lpsp:
- Statuses : 4 pass(s) 1 skip(s)
- Exec time: [0.0, 0.15] s
* igt@i915_pm_rpm@modeset-non-lpsp-stress:
- Statuses : 4 pass(s) 1 skip(s)
- Exec time: [0.0, 5.68] s
* igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait:
- Statuses : 4 pass(s) 1 skip(s)
- Exec time: [0.0, 4.25] s
* igt@i915_pm_rpm@modeset-pc8-residency-stress:
- Statuses : 5 skip(s)
- Exec time: [0.0] s
* igt@i915_pm_rpm@modeset-stress-extra-wait:
- Statuses : 4 pass(s) 1 skip(s)
- Exec time: [0.0, 52.16] s
* igt@i915_pm_rpm@module-reload:
- Statuses : 4 pass(s) 1 skip(s)
- Exec time: [0.0, 26.44] s
* igt@i915_pm_rpm@pc8-residency:
- Statuses : 5 skip(s)
- Exec time: [0.0] s
* igt@i915_pm_rpm@pm-caching:
- Statuses : 4 pass(s) 1 skip(s)
- Exec time: [0.0, 0.91] s
* igt@i915_pm_rpm@pm-tiling:
- Statuses : 4 pass(s) 1 skip(s)
- Exec time: [0.0, 2.55] s
* igt@i915_pm_rpm@reg-read-ioctl:
- Statuses : 4 pass(s) 1 skip(s)
- Exec time: [0.0, 0.22] s
* igt@i915_pm_rpm@sysfs-read:
- Statuses : 4 pass(s) 1 skip(s)
- Exec time: [0.0, 0.00] s
* igt@i915_pm_rpm@system-suspend:
- Statuses : 4 pass(s)
- Exec time: [1.94, 2.44] s
* igt@i915_pm_rpm@system-suspend-devices:
- Statuses : 4 pass(s) 1 skip(s)
- Exec time: [0.0, 7.22] s
* igt@i915_pm_rpm@system-suspend-execbuf:
- Statuses : 4 pass(s)
- Exec time: [82.23, 82.71] s
* igt@i915_pm_rpm@system-suspend-modeset:
- Statuses : 4 pass(s) 1 skip(s)
- Exec time: [0.0, 3.02] s
* igt@i915_pm_rpm@universal-planes:
- Statuses : 4 pass(s) 1 skip(s)
- Exec time: [0.0, 5.71] s
* igt@i915_pm_rpm@universal-planes-dpms:
- Statuses : 3 pass(s) 1 skip(s)
- Exec time: [0.0, 7.38] s
* igt@i915_pm_rps@basic-api:
- Statuses : 5 pass(s)
- Exec time: [0.00, 0.01] s
* igt@i915_pm_rps@min-max-config-idle:
- Statuses : 5 pass(s)
- Exec time: [5.40, 11.77] s
* igt@i915_pm_rps@min-max-config-loaded:
- Statuses : 5 pass(s)
- Exec time: [0.32, 0.34] s
* igt@i915_pm_rps@reset:
- Statuses : 5 pass(s)
- Exec time: [3.52, 5.52] s
* igt@i915_pm_rps@waitboost:
- Statuses : 5 pass(s)
- Exec time: [2.52, 3.27] s
* igt@i915_pm_sseu@full-enable:
- Statuses : 3 pass(s) 2 skip(s)
- Exec time: [0.0, 0.01] s
Known issues
------------
Here are the changes found in IGTPW_2448_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* {igt@i915_pm_backlight@bad-brightness} (NEW):
- shard-glk: NOTRUN -> {SKIP} [fdo#109271] +17
* {igt@i915_pm_rpm@gem-execbuf-stress-extra-wait} (NEW):
- shard-snb: NOTRUN -> {SKIP} [fdo#109271] +52
* {igt@i915_pm_rpm@gem-execbuf-stress-pc8} (NEW):
- shard-hsw: NOTRUN -> {SKIP} [fdo#109271] +16
* {igt@i915_pm_rpm@modeset-lpsp-stress} (NEW):
- shard-apl: NOTRUN -> {SKIP} [fdo#109271] +17
* {igt@i915_pm_rpm@modeset-lpsp-stress-no-wait} (NEW):
- shard-kbl: NOTRUN -> {SKIP} [fdo#109271] +15
* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-a:
- shard-kbl: NOTRUN -> DMESG-WARN [fdo#107956]
* igt@kms_color@pipe-a-legacy-gamma:
- shard-glk: PASS -> FAIL [fdo#104782] / [fdo#108145]
* igt@kms_color@pipe-b-ctm-max:
- shard-apl: PASS -> FAIL [fdo#108147]
* igt@kms_cursor_crc@cursor-128x128-onscreen:
- shard-apl: PASS -> FAIL [fdo#103232] +2
* igt@kms_cursor_crc@cursor-128x128-suspend:
- shard-apl: PASS -> FAIL [fdo#103191] / [fdo#103232]
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic:
- shard-glk: PASS -> FAIL [fdo#104873]
* igt@kms_flip@2x-flip-vs-dpms:
- shard-hsw: PASS -> DMESG-WARN [fdo#102614]
* igt@kms_flip@2x-flip-vs-expired-vblank:
- shard-glk: PASS -> FAIL [fdo#105363]
* igt@kms_flip@2x-modeset-vs-vblank-race-interruptible:
- shard-glk: PASS -> FAIL [fdo#103060]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-move:
- shard-apl: PASS -> FAIL [fdo#103167] +1
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
- shard-kbl: PASS -> FAIL [fdo#103167]
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-cpu:
- shard-glk: PASS -> FAIL [fdo#103167] +5
* igt@kms_plane@plane-position-covered-pipe-b-planes:
- shard-glk: PASS -> FAIL [fdo#103166] +2
* igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
- shard-apl: NOTRUN -> FAIL [fdo#108145]
- shard-glk: PASS -> FAIL [fdo#108145]
- shard-kbl: NOTRUN -> FAIL [fdo#108145]
* igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
- shard-apl: PASS -> FAIL [fdo#103166] +5
* igt@kms_plane_multiple@atomic-pipe-a-tiling-yf:
- shard-kbl: PASS -> FAIL [fdo#103166] +1
* igt@kms_rotation_crc@multiplane-rotation:
- shard-kbl: NOTRUN -> DMESG-FAIL [fdo#105763]
* igt@kms_rotation_crc@multiplane-rotation-cropping-bottom:
- shard-kbl: PASS -> DMESG-FAIL [fdo#105763]
* igt@kms_vblank@pipe-c-ts-continuation-dpms-rpm:
- shard-apl: PASS -> FAIL [fdo#104894]
#### Possible fixes ####
* igt@kms_atomic_transition@plane-all-modeset-transition:
- shard-apl: INCOMPLETE [fdo#103927] -> PASS
* igt@kms_busy@extended-modeset-hang-newfb-render-a:
- shard-kbl: DMESG-WARN [fdo#107956] -> PASS
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
- shard-glk: FAIL [fdo#108145] -> PASS +1
* igt@kms_ccs@pipe-b-crc-sprite-planes-basic:
- shard-apl: FAIL [fdo#106510] / [fdo#108145] -> PASS
- shard-kbl: FAIL [fdo#107725] / [fdo#108145] -> PASS +1
* igt@kms_color@pipe-b-legacy-gamma:
- shard-apl: FAIL [fdo#104782] -> PASS
* igt@kms_cursor_crc@cursor-256x85-sliding:
- shard-apl: FAIL [fdo#103232] -> PASS +3
* igt@kms_cursor_crc@cursor-64x64-suspend:
- shard-apl: FAIL [fdo#103191] / [fdo#103232] -> PASS +1
* igt@kms_cursor_crc@cursor-alpha-opaque:
- shard-apl: FAIL [fdo#109350] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render:
- shard-apl: FAIL [fdo#103167] -> PASS +5
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-blt:
- shard-glk: FAIL [fdo#103167] -> PASS +1
* igt@kms_plane@pixel-format-pipe-c-planes-source-clamping:
- shard-glk: FAIL [fdo#108948] -> PASS
- shard-apl: FAIL [fdo#108948] -> PASS +1
* igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
- shard-apl: FAIL [fdo#103166] -> PASS +2
* igt@kms_setmode@basic:
- shard-kbl: FAIL [fdo#99912] -> PASS
* igt@kms_universal_plane@universal-plane-pipe-b-functional:
- shard-glk: FAIL [fdo#103166] -> PASS +2
#### Warnings ####
* igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-wc:
- shard-snb: {SKIP} [fdo#109271] -> INCOMPLETE [fdo#105411]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
[fdo#103060]: https://bugs.freedesktop.org/show_bug.cgi?id=103060
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
[fdo#104873]: https://bugs.freedesktop.org/show_bug.cgi?id=104873
[fdo#104894]: https://bugs.freedesktop.org/show_bug.cgi?id=104894
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
[fdo#106510]: https://bugs.freedesktop.org/show_bug.cgi?id=106510
[fdo#107725]: https://bugs.freedesktop.org/show_bug.cgi?id=107725
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147
[fdo#108739]: https://bugs.freedesktop.org/show_bug.cgi?id=108739
[fdo#108948]: https://bugs.freedesktop.org/show_bug.cgi?id=108948
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109350]: https://bugs.freedesktop.org/show_bug.cgi?id=109350
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (7 -> 5)
------------------------------
Missing (2): shard-skl shard-iclb
Build changes
-------------
* IGT: IGT_4837 -> IGTPW_2448
* Piglit: piglit_4509 -> None
CI_DRM_5630: 82d591391bfcd9cfe2eeac149c49a678b571cd62 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2448: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2448/
IGT_4837: 368e76156f752e6ed6ac32ed9f400567aef7d3fc @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2448/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 3/3] tests: Prefix pm_ tests with i915_ and move them to i915/
2019-02-19 14:23 ` Arkadiusz Hiler
@ 2019-02-20 7:34 ` Arkadiusz Hiler
2019-02-21 9:32 ` Chris Wilson
1 sibling, 0 replies; 10+ messages in thread
From: Arkadiusz Hiler @ 2019-02-20 7:34 UTC (permalink / raw)
To: igt-dev; +Cc: Petri Latvala
On Tue, Feb 19, 2019 at 04:23:32PM +0200, Arkadiusz Hiler wrote:
> On Tue, Feb 19, 2019 at 03:25:43PM +0200, Arkadiusz Hiler wrote:
> > They are i915-specific, so they belong to the directory.
> > The (now) infix _pm_ is quite informative and worth keeping.
> >
> > v2: also prefix .c files
> >
> > Cc: Petri Latvala <petri.latvala@intel.com>
> > Cc: Ewelina Musial <ewelina.musial@intel.com>
> > Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> > ---
> > Acks/rbs appreciated, but please let me push it, as I have to do
> > renaming in the cibuglog first :-)
>
> I forgot to stage this change:
>
> diff --git a/tests/intel-ci/blacklist.txt b/tests/intel-ci/blacklist.txt
> index f9ad47ea..f3440f31 100644
> --- a/tests/intel-ci/blacklist.txt
> +++ b/tests/intel-ci/blacklist.txt
> @@ -13,7 +13,7 @@ igt@drm_mm(@.*)?
> # failures in tests run afterwards.
> ###############################################
> igt@i915_module_load(@.*)?
> -igt@pm_rpm@module-reload
> +igt@i915_pm_rpm@module-reload
> ###############################################
> # GEM
> ###############################################
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
And pushed with Petri's r-bs via IRC. Thanks!
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 3/3] tests: Prefix pm_ tests with i915_ and move them to i915/
2019-02-19 13:25 ` [igt-dev] [PATCH i-g-t 3/3] tests: Prefix pm_ tests with i915_ and move them to i915/ Arkadiusz Hiler
2019-02-19 14:23 ` Arkadiusz Hiler
@ 2019-02-20 10:04 ` Jani Nikula
2019-02-20 11:20 ` Arkadiusz Hiler
1 sibling, 1 reply; 10+ messages in thread
From: Jani Nikula @ 2019-02-20 10:04 UTC (permalink / raw)
To: Arkadiusz Hiler, igt-dev; +Cc: Petri Latvala
On Tue, 19 Feb 2019, Arkadiusz Hiler <arkadiusz.hiler@intel.com> wrote:
> They are i915-specific, so they belong to the directory.
> The (now) infix _pm_ is quite informative and worth keeping.
Too late to the party and I'm sure I'm missing something. But...
It does feel like moving things in i915 directory *and* prefixing with
i915 is an unnecessary tautology. Why not just one or the other?
BR,
Jani.
>
> v2: also prefix .c files
>
> Cc: Petri Latvala <petri.latvala@intel.com>
> Cc: Ewelina Musial <ewelina.musial@intel.com>
> Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> ---
> Acks/rbs appreciated, but please let me push it, as I have to do
> renaming in the cibuglog first :-)
>
> tests/Makefile.sources | 24 ++++++++++++++-----
> .../i915_pm_backlight.c} | 0
> tests/{pm_lpsp.c => i915/i915_pm_lpsp.c} | 0
> .../i915_pm_rc6_residency.c} | 0
> tests/{pm_rpm.c => i915/i915_pm_rpm.c} | 0
> tests/{pm_rps.c => i915/i915_pm_rps.c} | 0
> tests/{pm_sseu.c => i915/i915_pm_sseu.c} | 0
> tests/meson.build | 12 +++++-----
> 8 files changed, 24 insertions(+), 12 deletions(-)
> rename tests/{pm_backlight.c => i915/i915_pm_backlight.c} (100%)
> rename tests/{pm_lpsp.c => i915/i915_pm_lpsp.c} (100%)
> rename tests/{pm_rc6_residency.c => i915/i915_pm_rc6_residency.c} (100%)
> rename tests/{pm_rpm.c => i915/i915_pm_rpm.c} (100%)
> rename tests/{pm_rps.c => i915/i915_pm_rps.c} (100%)
> rename tests/{pm_sseu.c => i915/i915_pm_sseu.c} (100%)
>
> diff --git a/tests/Makefile.sources b/tests/Makefile.sources
> index 1efd3ecb..35c79592 100644
> --- a/tests/Makefile.sources
> +++ b/tests/Makefile.sources
> @@ -77,12 +77,6 @@ TESTS_progs = \
> meta_test \
> perf \
> perf_pmu \
> - pm_backlight \
> - pm_lpsp \
> - pm_rc6_residency \
> - pm_rpm \
> - pm_rps \
> - pm_sseu \
> prime_busy \
> prime_mmap \
> prime_mmap_coherency \
> @@ -486,6 +480,24 @@ i915_missed_irq_SOURCES = i915/i915_missed_irq.c
> TESTS_progs += i915_module_load
> i915_module_load_SOURCES = i915/i915_module_load.c
>
> +TESTS_progs += i915_pm_backlight
> +i915_pm_backlight_SOURCES = i915/i915_pm_backlight.c
> +
> +TESTS_progs += i915_pm_lpsp
> +i915_pm_lpsp_SOURCES = i915/i915_pm_lpsp.c
> +
> +TESTS_progs += i915_pm_rc6_residency
> +i915_pm_rc6_residency_SOURCES = i915/i915_pm_rc6_residency.c
> +
> +TESTS_progs += i915_pm_rpm
> +i915_pm_rpm_SOURCES = i915/i915_pm_rpm.c
> +
> +TESTS_progs += i915_pm_rps
> +i915_pm_rps_SOURCES = i915/i915_pm_rps.c
> +
> +TESTS_progs += i915_pm_sseu
> +i915_pm_sseu_SOURCES = i915/i915_pm_sseu.c
> +
> TESTS_progs += i915_query
> i915_query_SOURCES = i915/i915_query.c
>
> diff --git a/tests/pm_backlight.c b/tests/i915/i915_pm_backlight.c
> similarity index 100%
> rename from tests/pm_backlight.c
> rename to tests/i915/i915_pm_backlight.c
> diff --git a/tests/pm_lpsp.c b/tests/i915/i915_pm_lpsp.c
> similarity index 100%
> rename from tests/pm_lpsp.c
> rename to tests/i915/i915_pm_lpsp.c
> diff --git a/tests/pm_rc6_residency.c b/tests/i915/i915_pm_rc6_residency.c
> similarity index 100%
> rename from tests/pm_rc6_residency.c
> rename to tests/i915/i915_pm_rc6_residency.c
> diff --git a/tests/pm_rpm.c b/tests/i915/i915_pm_rpm.c
> similarity index 100%
> rename from tests/pm_rpm.c
> rename to tests/i915/i915_pm_rpm.c
> diff --git a/tests/pm_rps.c b/tests/i915/i915_pm_rps.c
> similarity index 100%
> rename from tests/pm_rps.c
> rename to tests/i915/i915_pm_rps.c
> diff --git a/tests/pm_sseu.c b/tests/i915/i915_pm_sseu.c
> similarity index 100%
> rename from tests/pm_sseu.c
> rename to tests/i915/i915_pm_sseu.c
> diff --git a/tests/meson.build b/tests/meson.build
> index bb90711e..f4bd4a10 100644
> --- a/tests/meson.build
> +++ b/tests/meson.build
> @@ -63,12 +63,6 @@ test_progs = [
> 'kms_vrr',
> 'meta_test',
> 'perf',
> - 'pm_backlight',
> - 'pm_lpsp',
> - 'pm_rc6_residency',
> - 'pm_rpm',
> - 'pm_rps',
> - 'pm_sseu',
> 'prime_busy',
> 'prime_mmap',
> 'prime_mmap_coherency',
> @@ -223,6 +217,12 @@ i915_progs = [
> 'i915_hangman',
> 'i915_missed_irq',
> 'i915_module_load',
> + 'i915_pm_backlight',
> + 'i915_pm_lpsp',
> + 'i915_pm_rc6_residency',
> + 'i915_pm_rpm',
> + 'i915_pm_rps',
> + 'i915_pm_sseu',
> 'i915_query',
> 'i915_selftest',
> 'i915_suspend',
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 3/3] tests: Prefix pm_ tests with i915_ and move them to i915/
2019-02-20 10:04 ` Jani Nikula
@ 2019-02-20 11:20 ` Arkadiusz Hiler
0 siblings, 0 replies; 10+ messages in thread
From: Arkadiusz Hiler @ 2019-02-20 11:20 UTC (permalink / raw)
To: Jani Nikula; +Cc: igt-dev, Petri Latvala
On Wed, Feb 20, 2019 at 12:04:08PM +0200, Jani Nikula wrote:
> On Tue, 19 Feb 2019, Arkadiusz Hiler <arkadiusz.hiler@intel.com> wrote:
> > They are i915-specific, so they belong to the directory.
> > The (now) infix _pm_ is quite informative and worth keeping.
>
> Too late to the party and I'm sure I'm missing something. But...
>
> It does feel like moving things in i915 directory *and* prefixing with
> i915 is an unnecessary tautology. Why not just one or the other?
I am not a fan of this redundancy either, but it makes sense with some
context. Let me explain:
* i915/ so that `ls` ouput is more digestible. We also have gem_ and
gen3_ tests there that are not i915_ prefixed.
* i915_ so that binary name corresponds to .c file, makes test lookup
easier.
Of all the considered options this seem to make the most people happy.
--
Cheers,
Arek
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 3/3] tests: Prefix pm_ tests with i915_ and move them to i915/
2019-02-19 14:23 ` Arkadiusz Hiler
2019-02-20 7:34 ` Arkadiusz Hiler
@ 2019-02-21 9:32 ` Chris Wilson
1 sibling, 0 replies; 10+ messages in thread
From: Chris Wilson @ 2019-02-21 9:32 UTC (permalink / raw)
To: Arkadiusz Hiler, igt-dev; +Cc: Petri Latvala
Quoting Arkadiusz Hiler (2019-02-19 14:23:32)
> On Tue, Feb 19, 2019 at 03:25:43PM +0200, Arkadiusz Hiler wrote:
> > They are i915-specific, so they belong to the directory.
> > The (now) infix _pm_ is quite informative and worth keeping.
> >
> > v2: also prefix .c files
> >
> > Cc: Petri Latvala <petri.latvala@intel.com>
> > Cc: Ewelina Musial <ewelina.musial@intel.com>
> > Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> > ---
> > Acks/rbs appreciated, but please let me push it, as I have to do
> > renaming in the cibuglog first :-)
>
> I forgot to stage this change:
>
> diff --git a/tests/intel-ci/blacklist.txt b/tests/intel-ci/blacklist.txt
> index f9ad47ea..f3440f31 100644
> --- a/tests/intel-ci/blacklist.txt
> +++ b/tests/intel-ci/blacklist.txt
Did you also forget to update fast-feedback.testlist?
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2019-02-21 9:33 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-19 13:25 [igt-dev] [PATCH i-g-t 1/3] tools: Add dpcd_reg binary to gitignore Arkadiusz Hiler
2019-02-19 13:25 ` [igt-dev] [PATCH i-g-t 2/3] tests/i915: Rename files so they correspond to binary names Arkadiusz Hiler
2019-02-19 13:25 ` [igt-dev] [PATCH i-g-t 3/3] tests: Prefix pm_ tests with i915_ and move them to i915/ Arkadiusz Hiler
2019-02-19 14:23 ` Arkadiusz Hiler
2019-02-20 7:34 ` Arkadiusz Hiler
2019-02-21 9:32 ` Chris Wilson
2019-02-20 10:04 ` Jani Nikula
2019-02-20 11:20 ` Arkadiusz Hiler
2019-02-19 14:03 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/3] tools: Add dpcd_reg binary to gitignore Patchwork
2019-02-19 17:53 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.