* [PATCH] xfs/450: require working falloc command
@ 2019-02-19 18:32 Darrick J. Wong
2019-02-20 14:14 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Darrick J. Wong @ 2019-02-19 18:32 UTC (permalink / raw)
To: Eryu Guan; +Cc: fstests, xfs, Christoph Hellwig
From: Darrick J. Wong <darrick.wong@oracle.com>
This test needs to check for working falloc command before using it.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
tests/xfs/450 | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/xfs/450 b/tests/xfs/450
index 15b73877..615aded7 100755
--- a/tests/xfs/450
+++ b/tests/xfs/450
@@ -32,6 +32,7 @@ rm -f $seqres.full
# real QA test starts here
_supported_os Linux
_supported_fs xfs
+_require_xfs_io_command "falloc"
_require_test_program "punch-alternating"
_require_xfs_scratch_rmapbt
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xfs/450: require working falloc command
2019-02-19 18:32 [PATCH] xfs/450: require working falloc command Darrick J. Wong
@ 2019-02-20 14:14 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2019-02-20 14:14 UTC (permalink / raw)
To: Darrick J. Wong; +Cc: Eryu Guan, fstests, xfs, Christoph Hellwig
On Tue, Feb 19, 2019 at 10:32:38AM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> This test needs to check for working falloc command before using it.
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-02-20 14:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-19 18:32 [PATCH] xfs/450: require working falloc command Darrick J. Wong
2019-02-20 14:14 ` Christoph Hellwig
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.