From: Daniel Kiper <daniel.kiper@oracle.com>
To: Andre Przywara <andre.przywara@arm.com>
Cc: Daniel Kiper <dkiper@net-space.pl>,
Vladimir Serbinenko <phcoder@gmail.com>,
Andrei Borzenkov <arvidjaar@gmail.com>,
Mark Rutland <mark.rutland@arm.com>,
grub-devel@gnu.org
Subject: Re: [PATCH v2 1/9] net: dhcp: remove dead code
Date: Wed, 20 Feb 2019 22:09:38 +0100 [thread overview]
Message-ID: <20190220210938.j2pyqf3btectvqhp@tomti.i.net-space.pl> (raw)
In-Reply-To: <20190212174700.184741-2-andre.przywara@arm.com>
Hi Andre,
First of all, sorry for late reply. I am clearing my backlog after the
travel. I hope that I will be replying more often starting from now.
On Tue, Feb 12, 2019 at 05:46:52PM +0000, Andre Przywara wrote:
> From: Andrei Borzenkov <arvidjaar@gmail.com>
>
> The comment is right, the "giaddr" fields holds the IP address of the
> BOOTP relay, not a general purpose router address.
> Just remove the commented code, archeologists can find it in the git
> history.
>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
Daniel
next prev parent reply other threads:[~2019-02-20 21:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-12 17:46 [PATCH v2 0/9] net: bootp: add native DHCPv4 support Andre Przywara
2019-02-12 17:46 ` [PATCH v2 1/9] net: dhcp: remove dead code Andre Przywara
2019-02-20 21:09 ` Daniel Kiper [this message]
2019-02-12 17:46 ` [PATCH v2 2/9] net: dhcp: replace parse_dhcp_vendor() with find_dhcp_option() Andre Przywara
2019-02-21 18:06 ` Daniel Kiper
2019-02-12 17:46 ` [PATCH v2 3/9] net: dhcp: refactor DHCP packet transmission into separate function Andre Przywara
2019-02-21 18:12 ` Daniel Kiper
2019-02-12 17:46 ` [PATCH v2 4/9] net: dhcp: make grub_net_process_dhcp take an interface Andre Przywara
2019-02-21 18:21 ` Daniel Kiper
2019-02-12 17:46 ` [PATCH v2 5/9] net: dhcp: introduce per-interface timeout Andre Przywara
2019-02-21 18:40 ` Daniel Kiper
2019-02-12 17:46 ` [PATCH v2 6/9] net: dhcp: use DHCP options for name and bootfile Andre Przywara
2019-02-21 18:49 ` Daniel Kiper
2019-03-07 10:36 ` Andre Przywara
2019-02-12 17:46 ` [PATCH v2 7/9] net: dhcp: allow receiving DHCP OFFER and ACK packets Andre Przywara
2019-02-21 22:11 ` Daniel Kiper
2019-02-12 17:46 ` [PATCH v2 8/9] net: dhcp: actually send out DHCPv4 DISCOVER and REQUEST messages Andre Przywara
2019-02-21 22:19 ` Daniel Kiper
2019-02-12 17:47 ` [PATCH v2 9/9] net: dhcp: add explicit net_dhcp command Andre Przywara
2019-02-21 22:28 ` Daniel Kiper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190220210938.j2pyqf3btectvqhp@tomti.i.net-space.pl \
--to=daniel.kiper@oracle.com \
--cc=andre.przywara@arm.com \
--cc=arvidjaar@gmail.com \
--cc=dkiper@net-space.pl \
--cc=grub-devel@gnu.org \
--cc=mark.rutland@arm.com \
--cc=phcoder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.