[PATCH i-g-t 1/2] lib: Only require we have i915.reset module parameter for allow-hang

[PATCH i-g-t 1/2] lib: Only require we have i915.reset module parameter for allow-hang

[Chris Wilson]

To control hang detection, we manipulate the i915.reset module
parameter. However, to be nice we should SKIP if we cannot modify the
parameter as opposed to outright FAILing.

References: https://bugs.freedesktop.org/show_bug.cgi?id=108891
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 lib/igt_gt.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/igt_gt.c b/lib/igt_gt.c
index 646696727..c98a7553b 100644
--- a/lib/igt_gt.c
+++ b/lib/igt_gt.c
@@ -176,8 +176,8 @@ igt_hang_t igt_allow_hang(int fd, unsigned ctx, unsigned flags)
 	if (!igt_check_boolean_env_var("IGT_HANG_WITHOUT_RESET", false))
 		igt_require(has_gpu_reset(fd));
 
-	igt_assert(igt_sysfs_set_parameter
-		   (fd, "reset", "%d", INT_MAX /* any reset method */));
+	igt_require(igt_sysfs_set_parameter
+		    (fd, "reset", "%d", INT_MAX /* any reset method */));
 
 	if ((flags & HANG_ALLOW_CAPTURE) == 0) {
 		param.param = I915_CONTEXT_PARAM_NO_ERROR_CAPTURE;
-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[igt-dev] [PATCH i-g-t 1/2] lib: Only require we have i915.reset module parameter for allow-hang

[Chris Wilson]

To control hang detection, we manipulate the i915.reset module
parameter. However, to be nice we should SKIP if we cannot modify the
parameter as opposed to outright FAILing.

References: https://bugs.freedesktop.org/show_bug.cgi?id=108891
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 lib/igt_gt.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/igt_gt.c b/lib/igt_gt.c
index 646696727..c98a7553b 100644
--- a/lib/igt_gt.c
+++ b/lib/igt_gt.c
@@ -176,8 +176,8 @@ igt_hang_t igt_allow_hang(int fd, unsigned ctx, unsigned flags)
 	if (!igt_check_boolean_env_var("IGT_HANG_WITHOUT_RESET", false))
 		igt_require(has_gpu_reset(fd));
 
-	igt_assert(igt_sysfs_set_parameter
-		   (fd, "reset", "%d", INT_MAX /* any reset method */));
+	igt_require(igt_sysfs_set_parameter
+		    (fd, "reset", "%d", INT_MAX /* any reset method */));
 
 	if ((flags & HANG_ALLOW_CAPTURE) == 0) {
 		param.param = I915_CONTEXT_PARAM_NO_ERROR_CAPTURE;
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[PATCH i-g-t 2/2] igt/drv_hangman: Skip if resets are disallowed

[Chris Wilson]

If we tell the machine to reset but they are disallowed, we will leave
the system in a wedged state, preventing the majority of subsequent
tests.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/i915/i915_hangman.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/tests/i915/i915_hangman.c b/tests/i915/i915_hangman.c
index df1e0afed..4e515e3a0 100644
--- a/tests/i915/i915_hangman.c
+++ b/tests/i915/i915_hangman.c
@@ -257,6 +257,7 @@ static void hangcheck_unterminated(void)
 igt_main
 {
 	const struct intel_execution_engine *e;
+	igt_hang_t hang = {};
 
 	igt_skip_on_simulation();
 
@@ -266,6 +267,8 @@ igt_main
 		device = drm_open_driver(DRIVER_INTEL);
 		igt_require_gem(device);
 
+		hang = igt_allow_hang(device, 0, HANG_ALLOW_CAPTURE);
+
 		sysfs = igt_sysfs_open(device, &idx);
 		igt_assert(sysfs != -1);
 
@@ -288,4 +291,8 @@ igt_main
 
 	igt_subtest("hangcheck-unterminated")
 		hangcheck_unterminated();
+
+	igt_fixture {
+		igt_disallow_hang(device, hang);
+	}
 }
-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[igt-dev] [PATCH i-g-t 2/2] igt/drv_hangman: Skip if resets are disallowed

[Chris Wilson]

If we tell the machine to reset but they are disallowed, we will leave
the system in a wedged state, preventing the majority of subsequent
tests.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/i915/i915_hangman.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/tests/i915/i915_hangman.c b/tests/i915/i915_hangman.c
index df1e0afed..4e515e3a0 100644
--- a/tests/i915/i915_hangman.c
+++ b/tests/i915/i915_hangman.c
@@ -257,6 +257,7 @@ static void hangcheck_unterminated(void)
 igt_main
 {
 	const struct intel_execution_engine *e;
+	igt_hang_t hang = {};
 
 	igt_skip_on_simulation();
 
@@ -266,6 +267,8 @@ igt_main
 		device = drm_open_driver(DRIVER_INTEL);
 		igt_require_gem(device);
 
+		hang = igt_allow_hang(device, 0, HANG_ALLOW_CAPTURE);
+
 		sysfs = igt_sysfs_open(device, &idx);
 		igt_assert(sysfs != -1);
 
@@ -288,4 +291,8 @@ igt_main
 
 	igt_subtest("hangcheck-unterminated")
 		hangcheck_unterminated();
+
+	igt_fixture {
+		igt_disallow_hang(device, hang);
+	}
 }
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] lib: Only require we have i915.reset module parameter for allow-hang

[Patchwork]

== Series Details ==

Series: series starting with [i-g-t,1/2] lib: Only require we have i915.reset module parameter for allow-hang
URL   : https://patchwork.freedesktop.org/series/57003/
State : success

== Summary ==

CI Bug Log - changes from IGT_4847 -> IGTPW_2467
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/57003/revisions/1/mbox/

Known issues
------------

  Here are the changes found in IGTPW_2467 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@amdgpu/amd_basic@cs-compute:
    - fi-kbl-8809g:       NOTRUN -> FAIL [fdo#108094]

  * igt@i915_hangman@error-state-basic:
    - fi-kbl-guc:         PASS -> SKIP [fdo#109271]
    - fi-apl-guc:         PASS -> SKIP [fdo#109271]
    - fi-skl-guc:         PASS -> SKIP [fdo#109271]
    - fi-cfl-guc:         PASS -> SKIP [fdo#109271]

  * igt@kms_busy@basic-flip-c:
    - fi-blb-e6850:       NOTRUN -> SKIP [fdo#109271] / [fdo#109278]

  * igt@kms_chamelium@common-hpd-after-suspend:
    - fi-kbl-7567u:       PASS -> WARN [fdo#109380]

  * igt@kms_pipe_crc_basic@hang-read-crc-pipe-c:
    - fi-blb-e6850:       NOTRUN -> SKIP [fdo#109271] +43

  * igt@kms_pipe_crc_basic@nonblocking-crc-pipe-c:
    - fi-kbl-7567u:       PASS -> SKIP [fdo#109271] +31

  
#### Possible fixes ####

  * igt@amdgpu/amd_basic@userptr:
    - fi-kbl-8809g:       DMESG-WARN [fdo#108965] -> PASS

  * igt@gem_exec_suspend@basic-s4-devices:
    - fi-blb-e6850:       INCOMPLETE [fdo#107718] -> PASS

  * igt@i915_selftest@live_evict:
    - fi-bsw-kefka:       DMESG-WARN [fdo#107709] -> PASS

  * igt@kms_busy@basic-flip-a:
    - fi-apl-guc:         SKIP [fdo#109271] -> PASS +5

  * igt@kms_busy@basic-flip-b:
    - fi-cfl-guc:         SKIP [fdo#109271] -> PASS +5
    - fi-skl-guc:         SKIP [fdo#109271] -> PASS +5

  * igt@prime_vgem@basic-wait-default:
    - fi-kbl-guc:         SKIP [fdo#109271] -> PASS +12

  
  [fdo#107709]: https://bugs.freedesktop.org/show_bug.cgi?id=107709
  [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
  [fdo#108094]: https://bugs.freedesktop.org/show_bug.cgi?id=108094
  [fdo#108965]: https://bugs.freedesktop.org/show_bug.cgi?id=108965
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
  [fdo#109380]: https://bugs.freedesktop.org/show_bug.cgi?id=109380


Participating hosts (46 -> 36)
------------------------------

  Missing    (10): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-gdg-551 fi-icl-y fi-bdw-samus fi-byt-clapper fi-skl-6600u 


Build changes
-------------

    * IGT: IGT_4847 -> IGTPW_2467

  CI_DRM_5645: c67ed483692270fa9c8402d172d54b6c1335b7f7 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2467: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2467/
  IGT_4847: ebf2d10a95fff590542808ec14c7bce74ad11b37 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2467/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [PATCH i-g-t 1/2] lib: Only require we have i915.reset module parameter for allow-hang

[Antonio Argenziano]

On 21/02/19 02:19, Chris Wilson wrote:
> To control hang detection, we manipulate the i915.reset module
> parameter. However, to be nice we should SKIP if we cannot modify the
> parameter as opposed to outright FAILing.
> 
> References: https://bugs.freedesktop.org/show_bug.cgi?id=108891
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>   lib/igt_gt.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/igt_gt.c b/lib/igt_gt.c
> index 646696727..c98a7553b 100644
> --- a/lib/igt_gt.c
> +++ b/lib/igt_gt.c
> @@ -176,8 +176,8 @@ igt_hang_t igt_allow_hang(int fd, unsigned ctx, unsigned flags)
>   	if (!igt_check_boolean_env_var("IGT_HANG_WITHOUT_RESET", false))
>   		igt_require(has_gpu_reset(fd));
>   
> -	igt_assert(igt_sysfs_set_parameter
> -		   (fd, "reset", "%d", INT_MAX /* any reset method */));
> +	igt_require(igt_sysfs_set_parameter
> +		    (fd, "reset", "%d", INT_MAX /* any reset method */));

How come we were not able to write that parameter? Isn't that sysfs 
always there?

Antonio

>   
>   	if ((flags & HANG_ALLOW_CAPTURE) == 0) {
>   		param.param = I915_CONTEXT_PARAM_NO_ERROR_CAPTURE;
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [igt-dev] [Intel-gfx] [PATCH i-g-t 1/2] lib: Only require we have i915.reset module parameter for allow-hang

[Antonio Argenziano]

On 21/02/19 02:19, Chris Wilson wrote:
> To control hang detection, we manipulate the i915.reset module
> parameter. However, to be nice we should SKIP if we cannot modify the
> parameter as opposed to outright FAILing.
> 
> References: https://bugs.freedesktop.org/show_bug.cgi?id=108891
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>   lib/igt_gt.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/igt_gt.c b/lib/igt_gt.c
> index 646696727..c98a7553b 100644
> --- a/lib/igt_gt.c
> +++ b/lib/igt_gt.c
> @@ -176,8 +176,8 @@ igt_hang_t igt_allow_hang(int fd, unsigned ctx, unsigned flags)
>   	if (!igt_check_boolean_env_var("IGT_HANG_WITHOUT_RESET", false))
>   		igt_require(has_gpu_reset(fd));
>   
> -	igt_assert(igt_sysfs_set_parameter
> -		   (fd, "reset", "%d", INT_MAX /* any reset method */));
> +	igt_require(igt_sysfs_set_parameter
> +		    (fd, "reset", "%d", INT_MAX /* any reset method */));

How come we were not able to write that parameter? Isn't that sysfs 
always there?

Antonio

>   
>   	if ((flags & HANG_ALLOW_CAPTURE) == 0) {
>   		param.param = I915_CONTEXT_PARAM_NO_ERROR_CAPTURE;
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [PATCH i-g-t 1/2] lib: Only require we have i915.reset module parameter for allow-hang

[Chris Wilson]

Quoting Antonio Argenziano (2019-02-21 16:08:04)
> 
> 
> On 21/02/19 02:19, Chris Wilson wrote:
> > To control hang detection, we manipulate the i915.reset module
> > parameter. However, to be nice we should SKIP if we cannot modify the
> > parameter as opposed to outright FAILing.
> > 
> > References: https://bugs.freedesktop.org/show_bug.cgi?id=108891
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > ---
> >   lib/igt_gt.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/lib/igt_gt.c b/lib/igt_gt.c
> > index 646696727..c98a7553b 100644
> > --- a/lib/igt_gt.c
> > +++ b/lib/igt_gt.c
> > @@ -176,8 +176,8 @@ igt_hang_t igt_allow_hang(int fd, unsigned ctx, unsigned flags)
> >       if (!igt_check_boolean_env_var("IGT_HANG_WITHOUT_RESET", false))
> >               igt_require(has_gpu_reset(fd));
> >   
> > -     igt_assert(igt_sysfs_set_parameter
> > -                (fd, "reset", "%d", INT_MAX /* any reset method */));
> > +     igt_require(igt_sysfs_set_parameter
> > +                 (fd, "reset", "%d", INT_MAX /* any reset method */));
> 
> How come we were not able to write that parameter? Isn't that sysfs 
> always there?

No. It can be compiled out.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [igt-dev] [Intel-gfx] [PATCH i-g-t 1/2] lib: Only require we have i915.reset module parameter for allow-hang

[Chris Wilson]

Quoting Antonio Argenziano (2019-02-21 16:08:04)
> 
> 
> On 21/02/19 02:19, Chris Wilson wrote:
> > To control hang detection, we manipulate the i915.reset module
> > parameter. However, to be nice we should SKIP if we cannot modify the
> > parameter as opposed to outright FAILing.
> > 
> > References: https://bugs.freedesktop.org/show_bug.cgi?id=108891
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > ---
> >   lib/igt_gt.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/lib/igt_gt.c b/lib/igt_gt.c
> > index 646696727..c98a7553b 100644
> > --- a/lib/igt_gt.c
> > +++ b/lib/igt_gt.c
> > @@ -176,8 +176,8 @@ igt_hang_t igt_allow_hang(int fd, unsigned ctx, unsigned flags)
> >       if (!igt_check_boolean_env_var("IGT_HANG_WITHOUT_RESET", false))
> >               igt_require(has_gpu_reset(fd));
> >   
> > -     igt_assert(igt_sysfs_set_parameter
> > -                (fd, "reset", "%d", INT_MAX /* any reset method */));
> > +     igt_require(igt_sysfs_set_parameter
> > +                 (fd, "reset", "%d", INT_MAX /* any reset method */));
> 
> How come we were not able to write that parameter? Isn't that sysfs 
> always there?

No. It can be compiled out.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 2/2] igt/drv_hangman: Skip if resets are disallowed

[Antonio Argenziano]

On 21/02/19 02:19, Chris Wilson wrote:
> If we tell the machine to reset but they are disallowed, we will leave
> the system in a wedged state, preventing the majority of subsequent
> tests.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

LGTM.

Reviewed-by: Antonio Argenziano <antonio.argenziano@intel.com>

> ---
>   tests/i915/i915_hangman.c | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/tests/i915/i915_hangman.c b/tests/i915/i915_hangman.c
> index df1e0afed..4e515e3a0 100644
> --- a/tests/i915/i915_hangman.c
> +++ b/tests/i915/i915_hangman.c
> @@ -257,6 +257,7 @@ static void hangcheck_unterminated(void)
>   igt_main
>   {
>   	const struct intel_execution_engine *e;
> +	igt_hang_t hang = {};
>   
>   	igt_skip_on_simulation();
>   
> @@ -266,6 +267,8 @@ igt_main
>   		device = drm_open_driver(DRIVER_INTEL);
>   		igt_require_gem(device);
>   
> +		hang = igt_allow_hang(device, 0, HANG_ALLOW_CAPTURE);
> +
>   		sysfs = igt_sysfs_open(device, &idx);
>   		igt_assert(sysfs != -1);
>   
> @@ -288,4 +291,8 @@ igt_main
>   
>   	igt_subtest("hangcheck-unterminated")
>   		hangcheck_unterminated();
> +
> +	igt_fixture {
> +		igt_disallow_hang(device, hang);
> +	}
>   }
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [igt-dev] [PATCH i-g-t 2/2] igt/drv_hangman: Skip if resets are disallowed

[Antonio Argenziano]

On 21/02/19 02:19, Chris Wilson wrote:
> If we tell the machine to reset but they are disallowed, we will leave
> the system in a wedged state, preventing the majority of subsequent
> tests.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

LGTM.

Reviewed-by: Antonio Argenziano <antonio.argenziano@intel.com>

> ---
>   tests/i915/i915_hangman.c | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/tests/i915/i915_hangman.c b/tests/i915/i915_hangman.c
> index df1e0afed..4e515e3a0 100644
> --- a/tests/i915/i915_hangman.c
> +++ b/tests/i915/i915_hangman.c
> @@ -257,6 +257,7 @@ static void hangcheck_unterminated(void)
>   igt_main
>   {
>   	const struct intel_execution_engine *e;
> +	igt_hang_t hang = {};
>   
>   	igt_skip_on_simulation();
>   
> @@ -266,6 +267,8 @@ igt_main
>   		device = drm_open_driver(DRIVER_INTEL);
>   		igt_require_gem(device);
>   
> +		hang = igt_allow_hang(device, 0, HANG_ALLOW_CAPTURE);
> +
>   		sysfs = igt_sysfs_open(device, &idx);
>   		igt_assert(sysfs != -1);
>   
> @@ -288,4 +291,8 @@ igt_main
>   
>   	igt_subtest("hangcheck-unterminated")
>   		hangcheck_unterminated();
> +
> +	igt_fixture {
> +		igt_disallow_hang(device, hang);
> +	}
>   }
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [PATCH i-g-t 1/2] lib: Only require we have i915.reset module parameter for allow-hang

[Antonio Argenziano]

On 21/02/19 08:11, Chris Wilson wrote:
> Quoting Antonio Argenziano (2019-02-21 16:08:04)
>>
>>
>> On 21/02/19 02:19, Chris Wilson wrote:
>>> To control hang detection, we manipulate the i915.reset module
>>> parameter. However, to be nice we should SKIP if we cannot modify the
>>> parameter as opposed to outright FAILing.
>>>
>>> References: https://bugs.freedesktop.org/show_bug.cgi?id=108891
>>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>>> ---
>>>    lib/igt_gt.c | 4 ++--
>>>    1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/lib/igt_gt.c b/lib/igt_gt.c
>>> index 646696727..c98a7553b 100644
>>> --- a/lib/igt_gt.c
>>> +++ b/lib/igt_gt.c
>>> @@ -176,8 +176,8 @@ igt_hang_t igt_allow_hang(int fd, unsigned ctx, unsigned flags)
>>>        if (!igt_check_boolean_env_var("IGT_HANG_WITHOUT_RESET", false))
>>>                igt_require(has_gpu_reset(fd));
>>>    
>>> -     igt_assert(igt_sysfs_set_parameter
>>> -                (fd, "reset", "%d", INT_MAX /* any reset method */));
>>> +     igt_require(igt_sysfs_set_parameter
>>> +                 (fd, "reset", "%d", INT_MAX /* any reset method */));
>>
>> How come we were not able to write that parameter? Isn't that sysfs
>> always there?
> 
> No. It can be compiled out.

Right...

Reviewed-by: Antonio Argenziano <antonio.argenziano@intel.com>

> -Chris
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [igt-dev] [Intel-gfx] [PATCH i-g-t 1/2] lib: Only require we have i915.reset module parameter for allow-hang

[Antonio Argenziano]

On 21/02/19 08:11, Chris Wilson wrote:
> Quoting Antonio Argenziano (2019-02-21 16:08:04)
>>
>>
>> On 21/02/19 02:19, Chris Wilson wrote:
>>> To control hang detection, we manipulate the i915.reset module
>>> parameter. However, to be nice we should SKIP if we cannot modify the
>>> parameter as opposed to outright FAILing.
>>>
>>> References: https://bugs.freedesktop.org/show_bug.cgi?id=108891
>>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>>> ---
>>>    lib/igt_gt.c | 4 ++--
>>>    1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/lib/igt_gt.c b/lib/igt_gt.c
>>> index 646696727..c98a7553b 100644
>>> --- a/lib/igt_gt.c
>>> +++ b/lib/igt_gt.c
>>> @@ -176,8 +176,8 @@ igt_hang_t igt_allow_hang(int fd, unsigned ctx, unsigned flags)
>>>        if (!igt_check_boolean_env_var("IGT_HANG_WITHOUT_RESET", false))
>>>                igt_require(has_gpu_reset(fd));
>>>    
>>> -     igt_assert(igt_sysfs_set_parameter
>>> -                (fd, "reset", "%d", INT_MAX /* any reset method */));
>>> +     igt_require(igt_sysfs_set_parameter
>>> +                 (fd, "reset", "%d", INT_MAX /* any reset method */));
>>
>> How come we were not able to write that parameter? Isn't that sysfs
>> always there?
> 
> No. It can be compiled out.

Right...

Reviewed-by: Antonio Argenziano <antonio.argenziano@intel.com>

> -Chris
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,1/2] lib: Only require we have i915.reset module parameter for allow-hang

[Patchwork]

== Series Details ==

Series: series starting with [i-g-t,1/2] lib: Only require we have i915.reset module parameter for allow-hang
URL   : https://patchwork.freedesktop.org/series/57003/
State : success

== Summary ==

CI Bug Log - changes from IGT_4847_full -> IGTPW_2467_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/57003/revisions/1/mbox/

Known issues
------------

  Here are the changes found in IGTPW_2467_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_ctx_param@invalid-param-get:
    - shard-apl:          NOTRUN -> FAIL [fdo#109559]

  * igt@gem_exec_async@concurrent-writes-bsd1:
    - shard-hsw:          NOTRUN -> SKIP [fdo#109271] +20

  * igt@gem_mocs_settings@mocs-rc6-vebox:
    - shard-snb:          NOTRUN -> SKIP [fdo#109271] +4

  * igt@gem_wait@wait-bsd2:
    - shard-apl:          NOTRUN -> SKIP [fdo#109271] +5

  * igt@kms_atomic_transition@4x-modeset-transitions-nonblocking-fencing:
    - shard-glk:          NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +1

  * igt@kms_busy@extended-pageflip-hang-newfb-render-a:
    - shard-glk:          NOTRUN -> DMESG-WARN [fdo#107956] +1

  * igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-f:
    - shard-kbl:          NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +1

  * igt@kms_ccs@pipe-b-crc-sprite-planes-basic:
    - shard-glk:          PASS -> FAIL [fdo#108145]

  * igt@kms_chamelium@dp-hpd-storm-disable:
    - shard-glk:          NOTRUN -> SKIP [fdo#109271] +25

  * igt@kms_color@pipe-a-ctm-max:
    - shard-glk:          NOTRUN -> FAIL [fdo#108147]

  * igt@kms_cursor_crc@cursor-128x42-sliding:
    - shard-apl:          PASS -> FAIL [fdo#103232] +2

  * igt@kms_cursor_crc@cursor-256x85-onscreen:
    - shard-glk:          NOTRUN -> FAIL [fdo#103232] +3

  * igt@kms_cursor_legacy@2x-cursor-vs-flip-legacy:
    - shard-hsw:          PASS -> INCOMPLETE [fdo#103540]

  * igt@kms_draw_crc@draw-method-xrgb8888-mmap-cpu-xtiled:
    - shard-glk:          PASS -> FAIL [fdo#107791]

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-onoff:
    - shard-apl:          PASS -> FAIL [fdo#103167]

  * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-cpu:
    - shard-glk:          PASS -> FAIL [fdo#103167] +5

  * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-gtt:
    - shard-kbl:          NOTRUN -> SKIP [fdo#109271] +16

  * igt@kms_plane@pixel-format-pipe-a-planes-source-clamping:
    - shard-glk:          PASS -> FAIL [fdo#108948]
    - shard-apl:          PASS -> FAIL [fdo#108948]
    - shard-kbl:          PASS -> FAIL [fdo#108948]

  * igt@kms_plane_alpha_blend@pipe-a-alpha-basic:
    - shard-kbl:          NOTRUN -> FAIL [fdo#108145] / [fdo#108590]

  * igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
    - shard-glk:          NOTRUN -> FAIL [fdo#108145]

  * igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
    - shard-glk:          PASS -> FAIL [fdo#103166] +3
    - shard-kbl:          PASS -> FAIL [fdo#103166] +3

  * igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
    - shard-apl:          PASS -> FAIL [fdo#103166] +8
    - shard-glk:          NOTRUN -> FAIL [fdo#103166]

  * igt@kms_universal_plane@cursor-fb-leak-pipe-f:
    - shard-hsw:          NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +2

  * igt@kms_vblank@pipe-a-ts-continuation-suspend:
    - shard-apl:          PASS -> FAIL [fdo#104894] +2

  * igt@kms_vblank@pipe-c-ts-continuation-modeset:
    - shard-kbl:          PASS -> FAIL [fdo#104894]

  
#### Possible fixes ####

  * igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-c:
    - shard-apl:          DMESG-WARN [fdo#107956] -> PASS

  * igt@kms_color@pipe-b-degamma:
    - shard-kbl:          FAIL [fdo#104782] -> PASS
    - shard-apl:          FAIL [fdo#104782] -> PASS

  * igt@kms_cursor_crc@cursor-128x128-onscreen:
    - shard-kbl:          FAIL [fdo#103232] -> PASS +1

  * igt@kms_cursor_crc@cursor-128x128-suspend:
    - shard-apl:          FAIL [fdo#103191] / [fdo#103232] -> PASS

  * igt@kms_cursor_crc@cursor-64x21-sliding:
    - shard-apl:          FAIL [fdo#103232] -> PASS +3

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-pwrite:
    - shard-apl:          FAIL [fdo#103167] -> PASS +2

  * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-pwrite:
    - shard-glk:          FAIL [fdo#103167] -> PASS +3

  * igt@kms_plane_multiple@atomic-pipe-c-tiling-none:
    - shard-glk:          FAIL [fdo#103166] -> PASS +3

  * igt@kms_plane_multiple@atomic-pipe-c-tiling-y:
    - shard-kbl:          FAIL [fdo#103166] -> PASS

  * igt@kms_rotation_crc@multiplane-rotation-cropping-bottom:
    - shard-kbl:          DMESG-FAIL [fdo#105763] -> PASS

  * igt@kms_setmode@basic:
    - shard-apl:          FAIL [fdo#99912] -> PASS

  * igt@kms_universal_plane@universal-plane-pipe-b-functional:
    - shard-apl:          FAIL [fdo#103166] -> PASS +1

  * igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend:
    - shard-apl:          FAIL [fdo#104894] -> PASS +1

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
  [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
  [fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
  [fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
  [fdo#104894]: https://bugs.freedesktop.org/show_bug.cgi?id=104894
  [fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
  [fdo#107791]: https://bugs.freedesktop.org/show_bug.cgi?id=107791
  [fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
  [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
  [fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147
  [fdo#108590]: https://bugs.freedesktop.org/show_bug.cgi?id=108590
  [fdo#108948]: https://bugs.freedesktop.org/show_bug.cgi?id=108948
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
  [fdo#109559]: https://bugs.freedesktop.org/show_bug.cgi?id=109559
  [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912


Participating hosts (7 -> 5)
------------------------------

  Missing    (2): shard-skl shard-iclb 


Build changes
-------------

    * IGT: IGT_4847 -> IGTPW_2467

  CI_DRM_5645: c67ed483692270fa9c8402d172d54b6c1335b7f7 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2467: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2467/
  IGT_4847: ebf2d10a95fff590542808ec14c7bce74ad11b37 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2467/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev