* [PATCH -next] drm/qxl: remove set but not used variable 'map'
@ 2018-11-10 3:44 ` YueHaibing
0 siblings, 0 replies; 15+ messages in thread
From: YueHaibing @ 2018-11-10 3:44 UTC (permalink / raw)
To: Dave Airlie, Gerd Hoffmann, David Airlie
Cc: YueHaibing, virtualization, dri-devel, linux-kernel, kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/gpu/drm/qxl/qxl_object.c: In function 'qxl_bo_kunmap_atomic_page':
drivers/gpu/drm/qxl/qxl_object.c:189:21: warning:
variable 'map' set but not used [-Wunused-but-set-variable]
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/gpu/drm/qxl/qxl_object.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/qxl/qxl_object.c b/drivers/gpu/drm/qxl/qxl_object.c
index f67a3c5..b1706cb 100644
--- a/drivers/gpu/drm/qxl/qxl_object.c
+++ b/drivers/gpu/drm/qxl/qxl_object.c
@@ -186,13 +186,9 @@ void qxl_bo_kunmap_atomic_page(struct qxl_device *qdev,
struct qxl_bo *bo, void *pmap)
{
struct ttm_mem_type_manager *man = &bo->tbo.bdev->man[bo->tbo.mem.mem_type];
- struct io_mapping *map;
- if (bo->tbo.mem.mem_type == TTM_PL_VRAM)
- map = qdev->vram_mapping;
- else if (bo->tbo.mem.mem_type == TTM_PL_PRIV)
- map = qdev->surface_mapping;
- else
+ if ((bo->tbo.mem.mem_type != TTM_PL_VRAM) &&
+ (bo->tbo.mem.mem_type != TTM_PL_PRIV))
goto fallback;
io_mapping_unmap_atomic(pmap);
@@ -200,7 +196,7 @@ void qxl_bo_kunmap_atomic_page(struct qxl_device *qdev,
(void) ttm_mem_io_lock(man, false);
ttm_mem_io_free(bo->tbo.bdev, &bo->tbo.mem);
ttm_mem_io_unlock(man);
- return ;
+ return;
fallback:
qxl_bo_kunmap(bo);
}
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH -next] drm/qxl: remove set but not used variable 'map'
@ 2018-11-10 3:44 ` YueHaibing
0 siblings, 0 replies; 15+ messages in thread
From: YueHaibing @ 2018-11-10 3:44 UTC (permalink / raw)
To: Dave Airlie, Gerd Hoffmann, David Airlie
Cc: YueHaibing, virtualization, dri-devel, linux-kernel, kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/gpu/drm/qxl/qxl_object.c: In function 'qxl_bo_kunmap_atomic_page':
drivers/gpu/drm/qxl/qxl_object.c:189:21: warning:
variable 'map' set but not used [-Wunused-but-set-variable]
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/gpu/drm/qxl/qxl_object.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/qxl/qxl_object.c b/drivers/gpu/drm/qxl/qxl_object.c
index f67a3c5..b1706cb 100644
--- a/drivers/gpu/drm/qxl/qxl_object.c
+++ b/drivers/gpu/drm/qxl/qxl_object.c
@@ -186,13 +186,9 @@ void qxl_bo_kunmap_atomic_page(struct qxl_device *qdev,
struct qxl_bo *bo, void *pmap)
{
struct ttm_mem_type_manager *man = &bo->tbo.bdev->man[bo->tbo.mem.mem_type];
- struct io_mapping *map;
- if (bo->tbo.mem.mem_type = TTM_PL_VRAM)
- map = qdev->vram_mapping;
- else if (bo->tbo.mem.mem_type = TTM_PL_PRIV)
- map = qdev->surface_mapping;
- else
+ if ((bo->tbo.mem.mem_type != TTM_PL_VRAM) &&
+ (bo->tbo.mem.mem_type != TTM_PL_PRIV))
goto fallback;
io_mapping_unmap_atomic(pmap);
@@ -200,7 +196,7 @@ void qxl_bo_kunmap_atomic_page(struct qxl_device *qdev,
(void) ttm_mem_io_lock(man, false);
ttm_mem_io_free(bo->tbo.bdev, &bo->tbo.mem);
ttm_mem_io_unlock(man);
- return ;
+ return;
fallback:
qxl_bo_kunmap(bo);
}
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH -next] drm/qxl: remove set but not used variable 'map'
@ 2018-11-10 3:44 ` YueHaibing
0 siblings, 0 replies; 15+ messages in thread
From: YueHaibing @ 2018-11-10 3:44 UTC (permalink / raw)
To: Dave Airlie, Gerd Hoffmann, David Airlie
Cc: YueHaibing, virtualization, dri-devel, linux-kernel, kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/gpu/drm/qxl/qxl_object.c: In function 'qxl_bo_kunmap_atomic_page':
drivers/gpu/drm/qxl/qxl_object.c:189:21: warning:
variable 'map' set but not used [-Wunused-but-set-variable]
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/gpu/drm/qxl/qxl_object.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/qxl/qxl_object.c b/drivers/gpu/drm/qxl/qxl_object.c
index f67a3c5..b1706cb 100644
--- a/drivers/gpu/drm/qxl/qxl_object.c
+++ b/drivers/gpu/drm/qxl/qxl_object.c
@@ -186,13 +186,9 @@ void qxl_bo_kunmap_atomic_page(struct qxl_device *qdev,
struct qxl_bo *bo, void *pmap)
{
struct ttm_mem_type_manager *man = &bo->tbo.bdev->man[bo->tbo.mem.mem_type];
- struct io_mapping *map;
- if (bo->tbo.mem.mem_type == TTM_PL_VRAM)
- map = qdev->vram_mapping;
- else if (bo->tbo.mem.mem_type == TTM_PL_PRIV)
- map = qdev->surface_mapping;
- else
+ if ((bo->tbo.mem.mem_type != TTM_PL_VRAM) &&
+ (bo->tbo.mem.mem_type != TTM_PL_PRIV))
goto fallback;
io_mapping_unmap_atomic(pmap);
@@ -200,7 +196,7 @@ void qxl_bo_kunmap_atomic_page(struct qxl_device *qdev,
(void) ttm_mem_io_lock(man, false);
ttm_mem_io_free(bo->tbo.bdev, &bo->tbo.mem);
ttm_mem_io_unlock(man);
- return ;
+ return;
fallback:
qxl_bo_kunmap(bo);
}
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH -next] drm/qxl: remove set but not used variables 'driver, qbo'
2018-11-10 3:44 ` YueHaibing
(?)
@ 2018-11-12 13:32 ` YueHaibing
-1 siblings, 0 replies; 15+ messages in thread
From: YueHaibing @ 2018-11-12 13:32 UTC (permalink / raw)
To: Dave Airlie, Gerd Hoffmann, David Airlie
Cc: YueHaibing, virtualization, dri-devel, linux-kernel, kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/gpu/drm/qxl/qxl_release.c: In function 'qxl_release_fence_buffer_objects':
drivers/gpu/drm/qxl/qxl_release.c:431:17: warning:
variable 'qbo' set but not used [-Wunused-but-set-variable]
drivers/gpu/drm/qxl/qxl_release.c:430:24: warning:
variable 'driver' set but not used [-Wunused-but-set-variable]
'qbo' not used since commit f2c24b83ae90 ("drm/ttm: flip the switch, and convert
to dma_fence")
And 'driver' never used since introduction in
8002db6336dd ("qxl: convert qxl driver to proper use for reservations")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/gpu/drm/qxl/qxl_release.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/qxl/qxl_release.c b/drivers/gpu/drm/qxl/qxl_release.c
index 3813ec1..0a693fe 100644
--- a/drivers/gpu/drm/qxl/qxl_release.c
+++ b/drivers/gpu/drm/qxl/qxl_release.c
@@ -427,8 +427,6 @@ void qxl_release_fence_buffer_objects(struct qxl_release *release)
struct ttm_buffer_object *bo;
struct ttm_bo_global *glob;
struct ttm_bo_device *bdev;
- struct ttm_bo_driver *driver;
- struct qxl_bo *qbo;
struct ttm_validate_buffer *entry;
struct qxl_device *qdev;
@@ -449,14 +447,12 @@ void qxl_release_fence_buffer_objects(struct qxl_release *release)
release->id | 0xf0000000, release->base.seqno);
trace_dma_fence_emit(&release->base);
- driver = bdev->driver;
glob = bdev->glob;
spin_lock(&glob->lru_lock);
list_for_each_entry(entry, &release->bos, head) {
bo = entry->bo;
- qbo = to_qxl_bo(bo);
reservation_object_add_shared_fence(bo->resv, &release->base);
ttm_bo_add_to_lru(bo);
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH -next] drm/qxl: remove set but not used variables 'driver, qbo'
@ 2018-11-12 13:32 ` YueHaibing
0 siblings, 0 replies; 15+ messages in thread
From: YueHaibing @ 2018-11-12 13:32 UTC (permalink / raw)
To: Dave Airlie, Gerd Hoffmann, David Airlie
Cc: YueHaibing, virtualization, dri-devel, linux-kernel, kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/gpu/drm/qxl/qxl_release.c: In function 'qxl_release_fence_buffer_objects':
drivers/gpu/drm/qxl/qxl_release.c:431:17: warning:
variable 'qbo' set but not used [-Wunused-but-set-variable]
drivers/gpu/drm/qxl/qxl_release.c:430:24: warning:
variable 'driver' set but not used [-Wunused-but-set-variable]
'qbo' not used since commit f2c24b83ae90 ("drm/ttm: flip the switch, and convert
to dma_fence")
And 'driver' never used since introduction in
8002db6336dd ("qxl: convert qxl driver to proper use for reservations")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/gpu/drm/qxl/qxl_release.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/qxl/qxl_release.c b/drivers/gpu/drm/qxl/qxl_release.c
index 3813ec1..0a693fe 100644
--- a/drivers/gpu/drm/qxl/qxl_release.c
+++ b/drivers/gpu/drm/qxl/qxl_release.c
@@ -427,8 +427,6 @@ void qxl_release_fence_buffer_objects(struct qxl_release *release)
struct ttm_buffer_object *bo;
struct ttm_bo_global *glob;
struct ttm_bo_device *bdev;
- struct ttm_bo_driver *driver;
- struct qxl_bo *qbo;
struct ttm_validate_buffer *entry;
struct qxl_device *qdev;
@@ -449,14 +447,12 @@ void qxl_release_fence_buffer_objects(struct qxl_release *release)
release->id | 0xf0000000, release->base.seqno);
trace_dma_fence_emit(&release->base);
- driver = bdev->driver;
glob = bdev->glob;
spin_lock(&glob->lru_lock);
list_for_each_entry(entry, &release->bos, head) {
bo = entry->bo;
- qbo = to_qxl_bo(bo);
reservation_object_add_shared_fence(bo->resv, &release->base);
ttm_bo_add_to_lru(bo);
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH -next] drm/qxl: remove set but not used variables 'driver, qbo'
@ 2018-11-12 13:32 ` YueHaibing
0 siblings, 0 replies; 15+ messages in thread
From: YueHaibing @ 2018-11-12 13:32 UTC (permalink / raw)
To: Dave Airlie, Gerd Hoffmann, David Airlie
Cc: YueHaibing, virtualization, dri-devel, linux-kernel, kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/gpu/drm/qxl/qxl_release.c: In function 'qxl_release_fence_buffer_objects':
drivers/gpu/drm/qxl/qxl_release.c:431:17: warning:
variable 'qbo' set but not used [-Wunused-but-set-variable]
drivers/gpu/drm/qxl/qxl_release.c:430:24: warning:
variable 'driver' set but not used [-Wunused-but-set-variable]
'qbo' not used since commit f2c24b83ae90 ("drm/ttm: flip the switch, and convert
to dma_fence")
And 'driver' never used since introduction in
8002db6336dd ("qxl: convert qxl driver to proper use for reservations")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/gpu/drm/qxl/qxl_release.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/qxl/qxl_release.c b/drivers/gpu/drm/qxl/qxl_release.c
index 3813ec1..0a693fe 100644
--- a/drivers/gpu/drm/qxl/qxl_release.c
+++ b/drivers/gpu/drm/qxl/qxl_release.c
@@ -427,8 +427,6 @@ void qxl_release_fence_buffer_objects(struct qxl_release *release)
struct ttm_buffer_object *bo;
struct ttm_bo_global *glob;
struct ttm_bo_device *bdev;
- struct ttm_bo_driver *driver;
- struct qxl_bo *qbo;
struct ttm_validate_buffer *entry;
struct qxl_device *qdev;
@@ -449,14 +447,12 @@ void qxl_release_fence_buffer_objects(struct qxl_release *release)
release->id | 0xf0000000, release->base.seqno);
trace_dma_fence_emit(&release->base);
- driver = bdev->driver;
glob = bdev->glob;
spin_lock(&glob->lru_lock);
list_for_each_entry(entry, &release->bos, head) {
bo = entry->bo;
- qbo = to_qxl_bo(bo);
reservation_object_add_shared_fence(bo->resv, &release->base);
ttm_bo_add_to_lru(bo);
^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH -next] drm/qxl: remove set but not used variable 'map'
2018-11-10 3:44 ` YueHaibing
@ 2018-11-14 12:16 ` Gerd Hoffmann
-1 siblings, 0 replies; 15+ messages in thread
From: Gerd Hoffmann @ 2018-11-14 12:16 UTC (permalink / raw)
To: YueHaibing
Cc: Dave Airlie, David Airlie, virtualization, dri-devel,
linux-kernel, kernel-janitors
On Sat, Nov 10, 2018 at 03:44:46AM +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/qxl/qxl_object.c: In function 'qxl_bo_kunmap_atomic_page':
> drivers/gpu/drm/qxl/qxl_object.c:189:21: warning:
> variable 'map' set but not used [-Wunused-but-set-variable]
Both qxl patches added to qemu queue, should land in drm-misc-next soon.
thanks,
Gerd
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH -next] drm/qxl: remove set but not used variable 'map'
@ 2018-11-14 12:16 ` Gerd Hoffmann
0 siblings, 0 replies; 15+ messages in thread
From: Gerd Hoffmann @ 2018-11-14 12:16 UTC (permalink / raw)
To: YueHaibing
Cc: Dave Airlie, David Airlie, virtualization, dri-devel,
linux-kernel, kernel-janitors
On Sat, Nov 10, 2018 at 03:44:46AM +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/qxl/qxl_object.c: In function 'qxl_bo_kunmap_atomic_page':
> drivers/gpu/drm/qxl/qxl_object.c:189:21: warning:
> variable 'map' set but not used [-Wunused-but-set-variable]
Both qxl patches added to qemu queue, should land in drm-misc-next soon.
thanks,
Gerd
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH -next] drm/qxl: remove set but not used variable 'map'
2018-11-10 3:44 ` YueHaibing
(?)
(?)
@ 2018-11-14 12:16 ` Gerd Hoffmann
-1 siblings, 0 replies; 15+ messages in thread
From: Gerd Hoffmann @ 2018-11-14 12:16 UTC (permalink / raw)
To: YueHaibing
Cc: David Airlie, kernel-janitors, linux-kernel, dri-devel,
virtualization, Dave Airlie
On Sat, Nov 10, 2018 at 03:44:46AM +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/qxl/qxl_object.c: In function 'qxl_bo_kunmap_atomic_page':
> drivers/gpu/drm/qxl/qxl_object.c:189:21: warning:
> variable 'map' set but not used [-Wunused-but-set-variable]
Both qxl patches added to qemu queue, should land in drm-misc-next soon.
thanks,
Gerd
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH -next] drm/qxl: remove set but not used variable 'bo_old'
2018-11-10 3:44 ` YueHaibing
(?)
@ 2019-02-18 8:54 ` YueHaibing
-1 siblings, 0 replies; 15+ messages in thread
From: YueHaibing @ 2019-02-18 8:54 UTC (permalink / raw)
To: Dave Airlie, Gerd Hoffmann, David Airlie, Daniel Vetter
Cc: YueHaibing, virtualization, spice-devel, dri-devel, linux-kernel,
kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/gpu/drm/qxl/qxl_display.c: In function 'qxl_primary_atomic_update':
drivers/gpu/drm/qxl/qxl_display.c:538:17: warning:
variable 'bo_old' set but not used [-Wunused-but-set-variable]
It's not used any more after 4979904c62b9 ("drm/qxl: use shadow bo directly")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/gpu/drm/qxl/qxl_display.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/qxl/qxl_display.c b/drivers/gpu/drm/qxl/qxl_display.c
index 08c725544a2f..8b319ebbb0fb 100644
--- a/drivers/gpu/drm/qxl/qxl_display.c
+++ b/drivers/gpu/drm/qxl/qxl_display.c
@@ -535,7 +535,7 @@ static void qxl_primary_atomic_update(struct drm_plane *plane,
{
struct qxl_device *qdev = plane->dev->dev_private;
struct qxl_bo *bo = gem_to_qxl_bo(plane->state->fb->obj[0]);
- struct qxl_bo *bo_old, *primary;
+ struct qxl_bo *primary;
struct drm_clip_rect norect = {
.x1 = 0,
.y1 = 0,
@@ -544,12 +544,6 @@ static void qxl_primary_atomic_update(struct drm_plane *plane,
};
uint32_t dumb_shadow_offset = 0;
- if (old_state->fb) {
- bo_old = gem_to_qxl_bo(old_state->fb->obj[0]);
- } else {
- bo_old = NULL;
- }
-
primary = bo->shadow ? bo->shadow : bo;
if (!primary->is_primary) {
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH -next] drm/qxl: remove set but not used variable 'bo_old'
@ 2019-02-18 8:54 ` YueHaibing
0 siblings, 0 replies; 15+ messages in thread
From: YueHaibing @ 2019-02-18 8:54 UTC (permalink / raw)
To: Dave Airlie, Gerd Hoffmann, David Airlie, Daniel Vetter
Cc: YueHaibing, virtualization, spice-devel, dri-devel, linux-kernel,
kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/gpu/drm/qxl/qxl_display.c: In function 'qxl_primary_atomic_update':
drivers/gpu/drm/qxl/qxl_display.c:538:17: warning:
variable 'bo_old' set but not used [-Wunused-but-set-variable]
It's not used any more after 4979904c62b9 ("drm/qxl: use shadow bo directly")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/gpu/drm/qxl/qxl_display.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/qxl/qxl_display.c b/drivers/gpu/drm/qxl/qxl_display.c
index 08c725544a2f..8b319ebbb0fb 100644
--- a/drivers/gpu/drm/qxl/qxl_display.c
+++ b/drivers/gpu/drm/qxl/qxl_display.c
@@ -535,7 +535,7 @@ static void qxl_primary_atomic_update(struct drm_plane *plane,
{
struct qxl_device *qdev = plane->dev->dev_private;
struct qxl_bo *bo = gem_to_qxl_bo(plane->state->fb->obj[0]);
- struct qxl_bo *bo_old, *primary;
+ struct qxl_bo *primary;
struct drm_clip_rect norect = {
.x1 = 0,
.y1 = 0,
@@ -544,12 +544,6 @@ static void qxl_primary_atomic_update(struct drm_plane *plane,
};
uint32_t dumb_shadow_offset = 0;
- if (old_state->fb) {
- bo_old = gem_to_qxl_bo(old_state->fb->obj[0]);
- } else {
- bo_old = NULL;
- }
-
primary = bo->shadow ? bo->shadow : bo;
if (!primary->is_primary) {
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH -next] drm/qxl: remove set but not used variable 'bo_old'
@ 2019-02-18 8:54 ` YueHaibing
0 siblings, 0 replies; 15+ messages in thread
From: YueHaibing @ 2019-02-18 8:54 UTC (permalink / raw)
To: Dave Airlie, Gerd Hoffmann, David Airlie, Daniel Vetter
Cc: YueHaibing, virtualization, spice-devel, dri-devel, linux-kernel,
kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/gpu/drm/qxl/qxl_display.c: In function 'qxl_primary_atomic_update':
drivers/gpu/drm/qxl/qxl_display.c:538:17: warning:
variable 'bo_old' set but not used [-Wunused-but-set-variable]
It's not used any more after 4979904c62b9 ("drm/qxl: use shadow bo directly")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/gpu/drm/qxl/qxl_display.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/qxl/qxl_display.c b/drivers/gpu/drm/qxl/qxl_display.c
index 08c725544a2f..8b319ebbb0fb 100644
--- a/drivers/gpu/drm/qxl/qxl_display.c
+++ b/drivers/gpu/drm/qxl/qxl_display.c
@@ -535,7 +535,7 @@ static void qxl_primary_atomic_update(struct drm_plane *plane,
{
struct qxl_device *qdev = plane->dev->dev_private;
struct qxl_bo *bo = gem_to_qxl_bo(plane->state->fb->obj[0]);
- struct qxl_bo *bo_old, *primary;
+ struct qxl_bo *primary;
struct drm_clip_rect norect = {
.x1 = 0,
.y1 = 0,
@@ -544,12 +544,6 @@ static void qxl_primary_atomic_update(struct drm_plane *plane,
};
uint32_t dumb_shadow_offset = 0;
- if (old_state->fb) {
- bo_old = gem_to_qxl_bo(old_state->fb->obj[0]);
- } else {
- bo_old = NULL;
- }
-
primary = bo->shadow ? bo->shadow : bo;
if (!primary->is_primary) {
^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH -next] drm/qxl: remove set but not used variable 'bo_old'
2019-02-18 8:54 ` YueHaibing
@ 2019-02-21 12:05 ` Gerd Hoffmann
-1 siblings, 0 replies; 15+ messages in thread
From: Gerd Hoffmann @ 2019-02-21 12:05 UTC (permalink / raw)
To: YueHaibing
Cc: Dave Airlie, David Airlie, Daniel Vetter, virtualization,
spice-devel, dri-devel, linux-kernel, kernel-janitors
On Mon, Feb 18, 2019 at 08:54:59AM +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/qxl/qxl_display.c: In function 'qxl_primary_atomic_update':
> drivers/gpu/drm/qxl/qxl_display.c:538:17: warning:
> variable 'bo_old' set but not used [-Wunused-but-set-variable]
>
> It's not used any more after 4979904c62b9 ("drm/qxl: use shadow bo directly")
Pushed to drm-misc-next.
thanks,
Gerd
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH -next] drm/qxl: remove set but not used variable 'bo_old'
@ 2019-02-21 12:05 ` Gerd Hoffmann
0 siblings, 0 replies; 15+ messages in thread
From: Gerd Hoffmann @ 2019-02-21 12:05 UTC (permalink / raw)
To: YueHaibing
Cc: Dave Airlie, David Airlie, Daniel Vetter, virtualization,
spice-devel, dri-devel, linux-kernel, kernel-janitors
On Mon, Feb 18, 2019 at 08:54:59AM +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/qxl/qxl_display.c: In function 'qxl_primary_atomic_update':
> drivers/gpu/drm/qxl/qxl_display.c:538:17: warning:
> variable 'bo_old' set but not used [-Wunused-but-set-variable]
>
> It's not used any more after 4979904c62b9 ("drm/qxl: use shadow bo directly")
Pushed to drm-misc-next.
thanks,
Gerd
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH -next] drm/qxl: remove set but not used variable 'bo_old'
2019-02-18 8:54 ` YueHaibing
(?)
(?)
@ 2019-02-21 12:05 ` Gerd Hoffmann
-1 siblings, 0 replies; 15+ messages in thread
From: Gerd Hoffmann @ 2019-02-21 12:05 UTC (permalink / raw)
To: YueHaibing
Cc: David Airlie, kernel-janitors, linux-kernel, dri-devel,
virtualization, Daniel Vetter, spice-devel, Dave Airlie
On Mon, Feb 18, 2019 at 08:54:59AM +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/qxl/qxl_display.c: In function 'qxl_primary_atomic_update':
> drivers/gpu/drm/qxl/qxl_display.c:538:17: warning:
> variable 'bo_old' set but not used [-Wunused-but-set-variable]
>
> It's not used any more after 4979904c62b9 ("drm/qxl: use shadow bo directly")
Pushed to drm-misc-next.
thanks,
Gerd
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2019-02-21 12:05 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-18 8:54 [PATCH -next] drm/qxl: remove set but not used variable 'bo_old' YueHaibing
2019-02-18 8:54 ` YueHaibing
2019-02-18 8:54 ` YueHaibing
2019-02-21 12:05 ` Gerd Hoffmann
2019-02-21 12:05 ` Gerd Hoffmann
2019-02-21 12:05 ` Gerd Hoffmann
-- strict thread matches above, loose matches on Subject: below --
2018-11-12 13:32 [PATCH -next] drm/qxl: remove set but not used variables 'driver, qbo' YueHaibing
2018-11-12 13:32 ` YueHaibing
2018-11-12 13:32 ` YueHaibing
2018-11-10 3:44 [PATCH -next] drm/qxl: remove set but not used variable 'map' YueHaibing
2018-11-10 3:44 ` YueHaibing
2018-11-10 3:44 ` YueHaibing
2018-11-14 12:16 ` Gerd Hoffmann
2018-11-14 12:16 ` Gerd Hoffmann
2018-11-14 12:16 ` Gerd Hoffmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.