All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] drm/hibmc: Drop best_encoder
@ 2019-02-21 15:58 Daniel Vetter
  2019-02-21 15:58 ` [PATCH 2/2] drm/bochs: " Daniel Vetter
                   ` (3 more replies)
  0 siblings, 4 replies; 10+ messages in thread
From: Daniel Vetter @ 2019-02-21 15:58 UTC (permalink / raw)
  To: DRI Development
  Cc: Neil Armstrong, Daniel Vetter, Rodrigo Vivi, Daniel Vetter,
	Sam Ravnborg, Luc Van Oostenryck

This is the default for atomic drivers.

Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Neil Armstrong <narmstrong@baylibre.com>
Cc: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c
index d2cf7317930a..8c2f9b9cafb3 100644
--- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c
+++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c
@@ -33,17 +33,10 @@ static enum drm_mode_status hibmc_connector_mode_valid(struct drm_connector *con
 	return MODE_OK;
 }
 
-static struct drm_encoder *
-hibmc_connector_best_encoder(struct drm_connector *connector)
-{
-	return drm_encoder_find(connector->dev, NULL, connector->encoder_ids[0]);
-}
-
 static const struct drm_connector_helper_funcs
 	hibmc_connector_helper_funcs = {
 	.get_modes = hibmc_connector_get_modes,
 	.mode_valid = hibmc_connector_mode_valid,
-	.best_encoder = hibmc_connector_best_encoder,
 };
 
 static const struct drm_connector_funcs hibmc_connector_funcs = {
-- 
2.20.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 2/2] drm/bochs: Drop best_encoder
  2019-02-21 15:58 [PATCH 1/2] drm/hibmc: Drop best_encoder Daniel Vetter
@ 2019-02-21 15:58 ` Daniel Vetter
  2019-02-21 15:58 ` Daniel Vetter
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 10+ messages in thread
From: Daniel Vetter @ 2019-02-21 15:58 UTC (permalink / raw)
  To: DRI Development; +Cc: Daniel Vetter, virtualization, Daniel Vetter

This is the default for atomic drivers.

Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: virtualization@lists.linux-foundation.org
---
 drivers/gpu/drm/bochs/bochs_kms.c | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/drivers/gpu/drm/bochs/bochs_kms.c b/drivers/gpu/drm/bochs/bochs_kms.c
index 9cd82e3631fb..9e7cd6b34106 100644
--- a/drivers/gpu/drm/bochs/bochs_kms.c
+++ b/drivers/gpu/drm/bochs/bochs_kms.c
@@ -214,20 +214,9 @@ static enum drm_mode_status bochs_connector_mode_valid(struct drm_connector *con
 	return MODE_OK;
 }
 
-static struct drm_encoder *
-bochs_connector_best_encoder(struct drm_connector *connector)
-{
-	int enc_id = connector->encoder_ids[0];
-	/* pick the encoder ids */
-	if (enc_id)
-		return drm_encoder_find(connector->dev, NULL, enc_id);
-	return NULL;
-}
-
 static const struct drm_connector_helper_funcs bochs_connector_connector_helper_funcs = {
 	.get_modes = bochs_connector_get_modes,
 	.mode_valid = bochs_connector_mode_valid,
-	.best_encoder = bochs_connector_best_encoder,
 };
 
 static const struct drm_connector_funcs bochs_connector_connector_funcs = {
-- 
2.20.1

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 2/2] drm/bochs: Drop best_encoder
  2019-02-21 15:58 [PATCH 1/2] drm/hibmc: Drop best_encoder Daniel Vetter
  2019-02-21 15:58 ` [PATCH 2/2] drm/bochs: " Daniel Vetter
@ 2019-02-21 15:58 ` Daniel Vetter
  2019-02-28  8:55   ` Gerd Hoffmann
  2019-02-28  8:55   ` Gerd Hoffmann
  2019-02-28 13:16 ` [PATCH 1/2] drm/hibmc: " Noralf Trønnes
  2019-02-28 14:00 ` Gerd Hoffmann
  3 siblings, 2 replies; 10+ messages in thread
From: Daniel Vetter @ 2019-02-21 15:58 UTC (permalink / raw)
  To: DRI Development
  Cc: Daniel Vetter, virtualization, Gerd Hoffmann, Daniel Vetter

This is the default for atomic drivers.

Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: virtualization@lists.linux-foundation.org
---
 drivers/gpu/drm/bochs/bochs_kms.c | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/drivers/gpu/drm/bochs/bochs_kms.c b/drivers/gpu/drm/bochs/bochs_kms.c
index 9cd82e3631fb..9e7cd6b34106 100644
--- a/drivers/gpu/drm/bochs/bochs_kms.c
+++ b/drivers/gpu/drm/bochs/bochs_kms.c
@@ -214,20 +214,9 @@ static enum drm_mode_status bochs_connector_mode_valid(struct drm_connector *con
 	return MODE_OK;
 }
 
-static struct drm_encoder *
-bochs_connector_best_encoder(struct drm_connector *connector)
-{
-	int enc_id = connector->encoder_ids[0];
-	/* pick the encoder ids */
-	if (enc_id)
-		return drm_encoder_find(connector->dev, NULL, enc_id);
-	return NULL;
-}
-
 static const struct drm_connector_helper_funcs bochs_connector_connector_helper_funcs = {
 	.get_modes = bochs_connector_get_modes,
 	.mode_valid = bochs_connector_mode_valid,
-	.best_encoder = bochs_connector_best_encoder,
 };
 
 static const struct drm_connector_funcs bochs_connector_connector_funcs = {
-- 
2.20.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH 2/2] drm/bochs: Drop best_encoder
  2019-02-21 15:58 ` Daniel Vetter
  2019-02-28  8:55   ` Gerd Hoffmann
@ 2019-02-28  8:55   ` Gerd Hoffmann
  1 sibling, 0 replies; 10+ messages in thread
From: Gerd Hoffmann @ 2019-02-28  8:55 UTC (permalink / raw)
  To: Daniel Vetter; +Cc: Daniel Vetter, DRI Development, virtualization

On Thu, Feb 21, 2019 at 04:58:57PM +0100, Daniel Vetter wrote:
> This is the default for atomic drivers.
> 
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: virtualization@lists.linux-foundation.org
> ---
>  drivers/gpu/drm/bochs/bochs_kms.c | 11 -----------
>  1 file changed, 11 deletions(-)

Pushed to drm-misc-next.

thanks,
  Gerd

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 2/2] drm/bochs: Drop best_encoder
  2019-02-21 15:58 ` Daniel Vetter
@ 2019-02-28  8:55   ` Gerd Hoffmann
  2019-02-28  9:32     ` Daniel Vetter
  2019-02-28  9:32     ` Daniel Vetter
  2019-02-28  8:55   ` Gerd Hoffmann
  1 sibling, 2 replies; 10+ messages in thread
From: Gerd Hoffmann @ 2019-02-28  8:55 UTC (permalink / raw)
  To: Daniel Vetter; +Cc: Daniel Vetter, DRI Development, virtualization

On Thu, Feb 21, 2019 at 04:58:57PM +0100, Daniel Vetter wrote:
> This is the default for atomic drivers.
> 
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: virtualization@lists.linux-foundation.org
> ---
>  drivers/gpu/drm/bochs/bochs_kms.c | 11 -----------
>  1 file changed, 11 deletions(-)

Pushed to drm-misc-next.

thanks,
  Gerd

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 2/2] drm/bochs: Drop best_encoder
  2019-02-28  8:55   ` Gerd Hoffmann
  2019-02-28  9:32     ` Daniel Vetter
@ 2019-02-28  9:32     ` Daniel Vetter
  1 sibling, 0 replies; 10+ messages in thread
From: Daniel Vetter @ 2019-02-28  9:32 UTC (permalink / raw)
  To: Gerd Hoffmann
  Cc: Daniel Vetter, virtualization, DRI Development, Daniel Vetter

On Thu, Feb 28, 2019 at 09:55:22AM +0100, Gerd Hoffmann wrote:
> On Thu, Feb 21, 2019 at 04:58:57PM +0100, Daniel Vetter wrote:
> > This is the default for atomic drivers.
> > 
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > Cc: Gerd Hoffmann <kraxel@redhat.com>
> > Cc: virtualization@lists.linux-foundation.org
> > ---
> >  drivers/gpu/drm/bochs/bochs_kms.c | 11 -----------
> >  1 file changed, 11 deletions(-)
> 
> Pushed to drm-misc-next.

Thanks. r-b on the first patch too so I can pull that in?
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 2/2] drm/bochs: Drop best_encoder
  2019-02-28  8:55   ` Gerd Hoffmann
@ 2019-02-28  9:32     ` Daniel Vetter
  2019-02-28  9:32     ` Daniel Vetter
  1 sibling, 0 replies; 10+ messages in thread
From: Daniel Vetter @ 2019-02-28  9:32 UTC (permalink / raw)
  To: Gerd Hoffmann
  Cc: Daniel Vetter, virtualization, DRI Development, Daniel Vetter

On Thu, Feb 28, 2019 at 09:55:22AM +0100, Gerd Hoffmann wrote:
> On Thu, Feb 21, 2019 at 04:58:57PM +0100, Daniel Vetter wrote:
> > This is the default for atomic drivers.
> > 
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > Cc: Gerd Hoffmann <kraxel@redhat.com>
> > Cc: virtualization@lists.linux-foundation.org
> > ---
> >  drivers/gpu/drm/bochs/bochs_kms.c | 11 -----------
> >  1 file changed, 11 deletions(-)
> 
> Pushed to drm-misc-next.

Thanks. r-b on the first patch too so I can pull that in?
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 1/2] drm/hibmc: Drop best_encoder
  2019-02-21 15:58 [PATCH 1/2] drm/hibmc: Drop best_encoder Daniel Vetter
  2019-02-21 15:58 ` [PATCH 2/2] drm/bochs: " Daniel Vetter
  2019-02-21 15:58 ` Daniel Vetter
@ 2019-02-28 13:16 ` Noralf Trønnes
  2019-02-28 14:15   ` Daniel Vetter
  2019-02-28 14:00 ` Gerd Hoffmann
  3 siblings, 1 reply; 10+ messages in thread
From: Noralf Trønnes @ 2019-02-28 13:16 UTC (permalink / raw)
  To: Daniel Vetter, DRI Development
  Cc: Daniel Vetter, Rodrigo Vivi, Sam Ravnborg, Luc Van Oostenryck,
	Neil Armstrong



Den 21.02.2019 16.58, skrev Daniel Vetter:
> This is the default for atomic drivers.
> 
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Neil Armstrong <narmstrong@baylibre.com>
> Cc: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---

Acked-by: Noralf Trønnes <noralf@tronnes.org>

>  drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c
> index d2cf7317930a..8c2f9b9cafb3 100644
> --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c
> +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c
> @@ -33,17 +33,10 @@ static enum drm_mode_status hibmc_connector_mode_valid(struct drm_connector *con
>  	return MODE_OK;
>  }
>  
> -static struct drm_encoder *
> -hibmc_connector_best_encoder(struct drm_connector *connector)
> -{
> -	return drm_encoder_find(connector->dev, NULL, connector->encoder_ids[0]);
> -}
> -
>  static const struct drm_connector_helper_funcs
>  	hibmc_connector_helper_funcs = {
>  	.get_modes = hibmc_connector_get_modes,
>  	.mode_valid = hibmc_connector_mode_valid,
> -	.best_encoder = hibmc_connector_best_encoder,
>  };
>  
>  static const struct drm_connector_funcs hibmc_connector_funcs = {
> 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 1/2] drm/hibmc: Drop best_encoder
  2019-02-21 15:58 [PATCH 1/2] drm/hibmc: Drop best_encoder Daniel Vetter
                   ` (2 preceding siblings ...)
  2019-02-28 13:16 ` [PATCH 1/2] drm/hibmc: " Noralf Trønnes
@ 2019-02-28 14:00 ` Gerd Hoffmann
  3 siblings, 0 replies; 10+ messages in thread
From: Gerd Hoffmann @ 2019-02-28 14:00 UTC (permalink / raw)
  To: Daniel Vetter
  Cc: Neil Armstrong, DRI Development, Rodrigo Vivi, Daniel Vetter,
	Sam Ravnborg, Luc Van Oostenryck

On Thu, Feb 21, 2019 at 04:58:56PM +0100, Daniel Vetter wrote:
> This is the default for atomic drivers.
> 
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Neil Armstrong <narmstrong@baylibre.com>
> Cc: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>

Acked-by: Gerd Hoffmann <kraxel@redhat.com>

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 1/2] drm/hibmc: Drop best_encoder
  2019-02-28 13:16 ` [PATCH 1/2] drm/hibmc: " Noralf Trønnes
@ 2019-02-28 14:15   ` Daniel Vetter
  0 siblings, 0 replies; 10+ messages in thread
From: Daniel Vetter @ 2019-02-28 14:15 UTC (permalink / raw)
  To: Noralf Trønnes
  Cc: Neil Armstrong, Daniel Vetter, DRI Development, Rodrigo Vivi,
	Daniel Vetter, Sam Ravnborg, Luc Van Oostenryck

On Thu, Feb 28, 2019 at 02:16:03PM +0100, Noralf Trønnes wrote:
> 
> 
> Den 21.02.2019 16.58, skrev Daniel Vetter:
> > This is the default for atomic drivers.
> > 
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Cc: Sam Ravnborg <sam@ravnborg.org>
> > Cc: Neil Armstrong <narmstrong@baylibre.com>
> > Cc: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > ---
> 
> Acked-by: Noralf Trønnes <noralf@tronnes.org>
Thanks for taking a look, merged to drm-misc-next.
-Daniel
> 
> >  drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c | 7 -------
> >  1 file changed, 7 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c
> > index d2cf7317930a..8c2f9b9cafb3 100644
> > --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c
> > +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c
> > @@ -33,17 +33,10 @@ static enum drm_mode_status hibmc_connector_mode_valid(struct drm_connector *con
> >  	return MODE_OK;
> >  }
> >  
> > -static struct drm_encoder *
> > -hibmc_connector_best_encoder(struct drm_connector *connector)
> > -{
> > -	return drm_encoder_find(connector->dev, NULL, connector->encoder_ids[0]);
> > -}
> > -
> >  static const struct drm_connector_helper_funcs
> >  	hibmc_connector_helper_funcs = {
> >  	.get_modes = hibmc_connector_get_modes,
> >  	.mode_valid = hibmc_connector_mode_valid,
> > -	.best_encoder = hibmc_connector_best_encoder,
> >  };
> >  
> >  static const struct drm_connector_funcs hibmc_connector_funcs = {
> > 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2019-02-28 14:15 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-21 15:58 [PATCH 1/2] drm/hibmc: Drop best_encoder Daniel Vetter
2019-02-21 15:58 ` [PATCH 2/2] drm/bochs: " Daniel Vetter
2019-02-21 15:58 ` Daniel Vetter
2019-02-28  8:55   ` Gerd Hoffmann
2019-02-28  9:32     ` Daniel Vetter
2019-02-28  9:32     ` Daniel Vetter
2019-02-28  8:55   ` Gerd Hoffmann
2019-02-28 13:16 ` [PATCH 1/2] drm/hibmc: " Noralf Trønnes
2019-02-28 14:15   ` Daniel Vetter
2019-02-28 14:00 ` Gerd Hoffmann

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.