* [PATCH] tools: add link path flag for local build to pkg-config files
@ 2019-02-21 17:36 Juergen Gross
2019-02-21 17:42 ` Wei Liu
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Juergen Gross @ 2019-02-21 17:36 UTC (permalink / raw)
To: xen-devel; +Cc: Juergen Gross, Wei Liu, Ian Jackson
The qemu build process is requiring the link path of Xen libraries
to be specified both with -L and -Wl,-rpath-link. Add the -L flag
to the local pkg-config files.
At the same time let the pkg-config files depend on the Makefile
creating them, too.
Signed-off-by: Juergen Gross <jgross@suse.com>
---
tools/Rules.mk | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/Rules.mk b/tools/Rules.mk
index 68f2ed7ce1..f5613f73a7 100644
--- a/tools/Rules.mk
+++ b/tools/Rules.mk
@@ -262,7 +262,7 @@ PKG_CONFIG_DIR ?= $(XEN_ROOT)/tools/pkg-config
PKG_CONFIG_FILTER = $(foreach l,$(PKG_CONFIG_REMOVE),-e 's!\([ ,]\)$(l),!\1!g' -e 's![ ,]$(l)$$!!g')
-$(PKG_CONFIG_DIR)/%.pc: %.pc.in Makefile
+$(PKG_CONFIG_DIR)/%.pc: %.pc.in Makefile $(XEN_ROOT)/tools/Rules.mk
mkdir -p $(PKG_CONFIG_DIR)
@sed -e 's!@@version@@!$(PKG_CONFIG_VERSION)!g' \
-e 's!@@prefix@@!$(PKG_CONFIG_PREFIX)!g' \
@@ -271,10 +271,10 @@ $(PKG_CONFIG_DIR)/%.pc: %.pc.in Makefile
-e 's!@@firmwaredir@@!$(XENFIRMWAREDIR)!g' \
-e 's!@@libexecbin@@!$(LIBEXEC_BIN)!g' \
-e 's!@@cflagslocal@@!$(PKG_CONFIG_CFLAGS_LOCAL)!g' \
- -e 's!@@libsflag@@!-Wl,-rpath-link=!g' \
+ -e 's!@@libsflag@@\([^ ]*\)!-L\1 -Wl,-rpath-link=\1!g' \
$(PKG_CONFIG_FILTER) < $< > $@
-%.pc: %.pc.in Makefile
+%.pc: %.pc.in Makefile $(XEN_ROOT)/tools/Rules.mk
@sed -e 's!@@version@@!$(PKG_CONFIG_VERSION)!g' \
-e 's!@@prefix@@!$(PKG_CONFIG_PREFIX)!g' \
-e 's!@@incdir@@!$(PKG_CONFIG_INCDIR)!g' \
--
2.16.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] tools: add link path flag for local build to pkg-config files
2019-02-21 17:36 [PATCH] tools: add link path flag for local build to pkg-config files Juergen Gross
@ 2019-02-21 17:42 ` Wei Liu
2019-02-21 17:43 ` Wei Liu
2019-02-22 11:52 ` Wei Liu
2 siblings, 0 replies; 6+ messages in thread
From: Wei Liu @ 2019-02-21 17:42 UTC (permalink / raw)
To: Juergen Gross; +Cc: xen-devel, Ian Jackson, Wei Liu
On Thu, Feb 21, 2019 at 06:36:13PM +0100, Juergen Gross wrote:
> The qemu build process is requiring the link path of Xen libraries
> to be specified both with -L and -Wl,-rpath-link. Add the -L flag
> to the local pkg-config files.
>
> At the same time let the pkg-config files depend on the Makefile
> creating them, too.
>
> Signed-off-by: Juergen Gross <jgross@suse.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tools: add link path flag for local build to pkg-config files
2019-02-21 17:36 [PATCH] tools: add link path flag for local build to pkg-config files Juergen Gross
2019-02-21 17:42 ` Wei Liu
@ 2019-02-21 17:43 ` Wei Liu
2019-02-22 11:52 ` Wei Liu
2 siblings, 0 replies; 6+ messages in thread
From: Wei Liu @ 2019-02-21 17:43 UTC (permalink / raw)
To: Juergen Gross; +Cc: Anthony PERARD, xen-devel, Ian Jackson, Wei Liu
CC Anthony
On Thu, Feb 21, 2019 at 06:36:13PM +0100, Juergen Gross wrote:
> The qemu build process is requiring the link path of Xen libraries
> to be specified both with -L and -Wl,-rpath-link. Add the -L flag
> to the local pkg-config files.
>
> At the same time let the pkg-config files depend on the Makefile
> creating them, too.
>
> Signed-off-by: Juergen Gross <jgross@suse.com>
> ---
> tools/Rules.mk | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/Rules.mk b/tools/Rules.mk
> index 68f2ed7ce1..f5613f73a7 100644
> --- a/tools/Rules.mk
> +++ b/tools/Rules.mk
> @@ -262,7 +262,7 @@ PKG_CONFIG_DIR ?= $(XEN_ROOT)/tools/pkg-config
>
> PKG_CONFIG_FILTER = $(foreach l,$(PKG_CONFIG_REMOVE),-e 's!\([ ,]\)$(l),!\1!g' -e 's![ ,]$(l)$$!!g')
>
> -$(PKG_CONFIG_DIR)/%.pc: %.pc.in Makefile
> +$(PKG_CONFIG_DIR)/%.pc: %.pc.in Makefile $(XEN_ROOT)/tools/Rules.mk
> mkdir -p $(PKG_CONFIG_DIR)
> @sed -e 's!@@version@@!$(PKG_CONFIG_VERSION)!g' \
> -e 's!@@prefix@@!$(PKG_CONFIG_PREFIX)!g' \
> @@ -271,10 +271,10 @@ $(PKG_CONFIG_DIR)/%.pc: %.pc.in Makefile
> -e 's!@@firmwaredir@@!$(XENFIRMWAREDIR)!g' \
> -e 's!@@libexecbin@@!$(LIBEXEC_BIN)!g' \
> -e 's!@@cflagslocal@@!$(PKG_CONFIG_CFLAGS_LOCAL)!g' \
> - -e 's!@@libsflag@@!-Wl,-rpath-link=!g' \
> + -e 's!@@libsflag@@\([^ ]*\)!-L\1 -Wl,-rpath-link=\1!g' \
> $(PKG_CONFIG_FILTER) < $< > $@
>
> -%.pc: %.pc.in Makefile
> +%.pc: %.pc.in Makefile $(XEN_ROOT)/tools/Rules.mk
> @sed -e 's!@@version@@!$(PKG_CONFIG_VERSION)!g' \
> -e 's!@@prefix@@!$(PKG_CONFIG_PREFIX)!g' \
> -e 's!@@incdir@@!$(PKG_CONFIG_INCDIR)!g' \
> --
> 2.16.4
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tools: add link path flag for local build to pkg-config files
2019-02-21 17:36 [PATCH] tools: add link path flag for local build to pkg-config files Juergen Gross
2019-02-21 17:42 ` Wei Liu
2019-02-21 17:43 ` Wei Liu
@ 2019-02-22 11:52 ` Wei Liu
2019-02-22 12:02 ` Juergen Gross
2 siblings, 1 reply; 6+ messages in thread
From: Wei Liu @ 2019-02-22 11:52 UTC (permalink / raw)
To: Juergen Gross; +Cc: xen-devel, Ian Jackson, Wei Liu
On Thu, Feb 21, 2019 at 06:36:13PM +0100, Juergen Gross wrote:
> The qemu build process is requiring the link path of Xen libraries
> to be specified both with -L and -Wl,-rpath-link. Add the -L flag
> to the local pkg-config files.
>
> At the same time let the pkg-config files depend on the Makefile
> creating them, too.
>
> Signed-off-by: Juergen Gross <jgross@suse.com>
Juergen, do you want this in 4.12?
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tools: add link path flag for local build to pkg-config files
2019-02-22 11:52 ` Wei Liu
@ 2019-02-22 12:02 ` Juergen Gross
2019-02-22 12:04 ` Wei Liu
0 siblings, 1 reply; 6+ messages in thread
From: Juergen Gross @ 2019-02-22 12:02 UTC (permalink / raw)
To: Wei Liu; +Cc: xen-devel, Ian Jackson
On 22/02/2019 12:52, Wei Liu wrote:
> On Thu, Feb 21, 2019 at 06:36:13PM +0100, Juergen Gross wrote:
>> The qemu build process is requiring the link path of Xen libraries
>> to be specified both with -L and -Wl,-rpath-link. Add the -L flag
>> to the local pkg-config files.
>>
>> At the same time let the pkg-config files depend on the Makefile
>> creating them, too.
>>
>> Signed-off-by: Juergen Gross <jgross@suse.com>
>
> Juergen, do you want this in 4.12?
Hmm, why? Does it repair any build error in 4.12? I don't think so. It
will help for further development (e.g. removing the explicit include
paths and libraries added to the qemu configure call), but this won't
happen in 4.12.
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tools: add link path flag for local build to pkg-config files
2019-02-22 12:02 ` Juergen Gross
@ 2019-02-22 12:04 ` Wei Liu
0 siblings, 0 replies; 6+ messages in thread
From: Wei Liu @ 2019-02-22 12:04 UTC (permalink / raw)
To: Juergen Gross; +Cc: xen-devel, Wei Liu, Ian Jackson
On Fri, Feb 22, 2019 at 01:02:51PM +0100, Juergen Gross wrote:
> On 22/02/2019 12:52, Wei Liu wrote:
> > On Thu, Feb 21, 2019 at 06:36:13PM +0100, Juergen Gross wrote:
> >> The qemu build process is requiring the link path of Xen libraries
> >> to be specified both with -L and -Wl,-rpath-link. Add the -L flag
> >> to the local pkg-config files.
> >>
> >> At the same time let the pkg-config files depend on the Makefile
> >> creating them, too.
> >>
> >> Signed-off-by: Juergen Gross <jgross@suse.com>
> >
> > Juergen, do you want this in 4.12?
>
> Hmm, why? Does it repair any build error in 4.12? I don't think so. It
> will help for further development (e.g. removing the explicit include
> paths and libraries added to the qemu configure call), but this won't
> happen in 4.12.
Thanks for confirming.
Wei.
>
>
> Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-02-22 12:04 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-21 17:36 [PATCH] tools: add link path flag for local build to pkg-config files Juergen Gross
2019-02-21 17:42 ` Wei Liu
2019-02-21 17:43 ` Wei Liu
2019-02-22 11:52 ` Wei Liu
2019-02-22 12:02 ` Juergen Gross
2019-02-22 12:04 ` Wei Liu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.