From: Dan Carpenter <dan.carpenter@oracle.com> To: Andrew Morton <akpm@linux-foundation.org> Cc: "Luis R. Rodriguez" <mcgrof@kernel.org>, Randy Dunlap <rdunlap@infradead.org>, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org> Subject: Re: [PATCH 2/2] test_firmware: silence underflow warning in test_dev_config_update_u8() Date: Fri, 22 Feb 2019 10:29:14 +0300 [thread overview] Message-ID: <20190222072913.GH1711@kadam> (raw) In-Reply-To: <20190221115426.f616100906d989eda93d66dc@linux-foundation.org> I've looked at this some more and I don't think it's a good idea to change the type of U8_MAX. Right now INT_MAX is int and USHRT_MAX is unsigned short etc. That's the only intuitive thing for them to be. regards, dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com> To: Andrew Morton <akpm@linux-foundation.org> Cc: "Luis R. Rodriguez" <mcgrof@kernel.org>, Randy Dunlap <rdunlap@infradead.org>, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org> Subject: Re: [PATCH 2/2] test_firmware: silence underflow warning in test_dev_config_update_u8() Date: Fri, 22 Feb 2019 07:29:14 +0000 [thread overview] Message-ID: <20190222072913.GH1711@kadam> (raw) In-Reply-To: <20190221115426.f616100906d989eda93d66dc@linux-foundation.org> I've looked at this some more and I don't think it's a good idea to change the type of U8_MAX. Right now INT_MAX is int and USHRT_MAX is unsigned short etc. That's the only intuitive thing for them to be. regards, dan carpenter
next prev parent reply other threads:[~2019-02-22 7:29 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-02-21 18:37 [PATCH 1/2] test_firmware: remove some dead code Dan Carpenter 2019-02-21 18:37 ` Dan Carpenter 2019-02-21 18:38 ` [PATCH 2/2] test_firmware: silence underflow warning in test_dev_config_update_u8() Dan Carpenter 2019-02-21 18:38 ` Dan Carpenter 2019-02-21 18:54 ` Andrew Morton 2019-02-21 18:54 ` Andrew Morton 2019-02-21 19:18 ` Dan Carpenter 2019-02-21 19:18 ` Dan Carpenter 2019-02-21 19:54 ` Andrew Morton 2019-02-21 19:54 ` Andrew Morton 2019-02-22 7:29 ` Dan Carpenter [this message] 2019-02-22 7:29 ` Dan Carpenter
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190222072913.GH1711@kadam \ --to=dan.carpenter@oracle.com \ --cc=akpm@linux-foundation.org \ --cc=gregkh@linuxfoundation.org \ --cc=kernel-janitors@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mcgrof@kernel.org \ --cc=rdunlap@infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.