All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v4] Add travis-ci config file
@ 2019-02-22  8:17 Alexander Graf
  2019-02-22 13:22 ` Daniel Kiper
  0 siblings, 1 reply; 3+ messages in thread
From: Alexander Graf @ 2019-02-22  8:17 UTC (permalink / raw)
  To: grub-devel; +Cc: Daniel Kiper, leif.lindholm, Paul Menzel

There is a really convenient service for open source project from Travis
CI: They allow for free CI testing using their infrastructure.

Grub has had issues with broken builds for various targets for a long time
already. The main reason is a lack of CI to just do smoke tests on whether
all targets still at least compile.

This patch adds a travis config file which builds (almost) all currently
available targets.

On top of that, this travis config also runs a small execution test on the
x86_64-efi target.

All of this config file can easily be extended further on. It probably makes
sense to do something similar to the u-boot test infrastructure that
communicates with the payload properly. Going forward, we also will want to
do more qemu runtime checks for other targets.

Currently, with this config alone, I already see about half of the available
targets as broken. So it's definitely desperately needed :).

Signed-off-by: Alexander Graf <agraf@suse.de>

---

v1 -> v2:

  - Fix comment about toolchain variable

v2 -> v3:

  - s/grub/GRUB/
  - remove unneeded packages
  - comment fixes
  - determine number of jobs dynamically
  - sort targets alphabetically

v3 -> v4:

  - reduce package list futher
  - sort package list alphabetically
---
 .travis.yml | 109 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 109 insertions(+)
 create mode 100644 .travis.yml

diff --git a/.travis.yml b/.travis.yml
new file mode 100644
index 000000000..a66143cba
--- /dev/null
+++ b/.travis.yml
@@ -0,0 +1,109 @@
+# SPDX-License-Identifier: GPL-3.0+
+# Originally Copyright Roger Meier <r.meier@siemens.com>
+# Adapted for GRUB by Alexander Graf <agraf@suse.de>
+
+# build GRUB on Travis CI - https://travis-ci.org/
+
+dist: xenial
+
+language: c
+
+addons:
+  apt:
+    packages:
+    - build-essential
+    - device-tree-compiler
+    - libsdl1.2-dev
+    - lzop
+    - ovmf
+    - python
+    - qemu-system
+    - unifont
+
+env:
+  global:
+    # Include all cross toolchain paths, so we can just call them later down
+    - PATH=/tmp/qemu-install/bin:/tmp/grub/bin:/usr/bin:/bin:/tmp/cross/gcc-8.1.0-nolibc/aarch64-linux/bin:/tmp/cross/gcc-8.1.0-nolibc/arm-linux-gnueabi/bin:/tmp/cross/gcc-8.1.0-nolibc/ia64-linux/bin:/tmp/cross/gcc-8.1.0-nolibc/mips64-linux/bin:/tmp/cross/gcc-8.1.0-nolibc/powerpc64-linux/bin:/tmp/cross/gcc-8.1.0-nolibc/riscv32-linux/bin:/tmp/cross/gcc-8.1.0-nolibc/riscv64-linux/bin:/tmp/cross/gcc-8.1.0-nolibc/sparc64-linux/bin
+
+before_script:
+  # Install necessary toolchains based on $CROSS_TARGETS variable
+  - mkdir /tmp/cross
+  # These give us binaries like /tmp/cross/gcc-8.1.0-nolibc/ia64-linux/bin/ia64-linux-gcc
+  - for i in $CROSS_TARGETS; do
+        ( cd /tmp/cross; wget -t 3 -O - https://mirrors.kernel.org/pub/tools/crosstool/files/bin/x86_64/8.1.0/x86_64-gcc-8.1.0-nolibc-$i.tar.xz | tar xJ );
+    done
+
+script:
+  # Comments must be outside the command strings below, or the Travis parser
+  # will get confused.
+  - ./autogen.sh
+
+  # Build all selected GRUB targets:
+  - for target in $GRUB_TARGETS; do
+      plat=${target#*-};
+      arch=${target%-*};
+      [ "$arch" = "arm64" ] && arch=aarch64-linux;
+      [ "$arch" = "arm" ] && arch=arm-linux-gnueabi;
+      [ "$arch" = "ia64" ] && arch=ia64-linux;
+      [ "$arch" = "mipsel" ] && arch=mips64-linux;
+      [ "$arch" = "powerpc" ] && arch=powerpc64-linux;
+      [ "$arch" = "riscv32" ] && arch=riscv32-linux;
+      [ "$arch" = "riscv64" ] && arch=riscv64-linux;
+      [ "$arch" = "sparc64" ] && arch=sparc64-linux;
+      echo "Building $target";
+      mkdir obj-$target;
+      JOBS=`getconf _NPROCESSORS_ONLN 2> /dev/null || echo 1`;
+      [ "$JOBS" == 1 ] || JOBS=$(($JOBS + 1));
+      ( cd obj-$target && ../configure --target=$arch --with-platform=$plat --prefix=/tmp/grub && make -j$JOBS && make -j$JOBS install ) &> log || ( cat log; false );
+    done
+
+  # Our test canary
+  - echo -e "insmod echo\\ninsmod reboot\\necho hello world\\nreboot" > grub.cfg
+
+  # Assemble images and possibly run them
+  - for target in $GRUB_TARGETS; do grub-mkimage -c grub.cfg -p / -O $target -o grub-$target echo reboot normal; done
+
+  # Run images we know how to run
+  - if [[ "$GRUB_TARGETS" == *"x86_64-efi"* ]]; then qemu-system-x86_64 -bios /usr/share/ovmf/OVMF.fd -m 512 -no-reboot -nographic -net nic -net user,tftp=.,bootfile=grub-x86_64-efi | tee grub.log && grep "hello world" grub.log; fi
+
+matrix:
+  include:
+  # each env setting here is a dedicated build
+    - name: "x86_64"
+      env:
+        - GRUB_TARGETS="x86_64-efi x86_64-xen"
+    - name: "i386"
+      env:
+        - GRUB_TARGETS="i386-coreboot i386-efi i386-ieee1275 i386-multiboot i386-pc i386-qemu i386-xen i386-xen_pvh"
+    - name: "powerpc"
+      env:
+        - GRUB_TARGETS="powerpc-ieee1275"
+        - CROSS_TARGETS=powerpc64-linux"
+    - name: "sparc64"
+      env:
+        - GRUB_TARGETS="sparc64-ieee1275"
+        - CROSS_TARGETS=sparc64-linux"
+    - name: "ia64"
+      env:
+        - GRUB_TARGETS="ia64-efi"
+        - CROSS_TARGETS=ia64-linux"
+    - name: "mips"
+      env:
+        - GRUB_TARGETS="mips-arc mipsel-arc mipsel-qemu_mips mips-qemu_mips"
+        - CROSS_TARGETS=mips64-linux"
+    - name: "arm"
+      env:
+        - GRUB_TARGETS="arm-coreboot arm-efi arm-uboot"
+        - CROSS_TARGETS="arm-linux-gnueabi"
+    - name: "arm64"
+      env:
+        - GRUB_TARGETS="arm64-efi"
+        - CROSS_TARGETS=aarch64-linux"
+    - name: "riscv32"
+      env:
+        - GRUB_TARGETS="riscv32-efi"
+        - CROSS_TARGETS=riscv32-linux"
+    - name: "riscv64"
+      env:
+        - GRUB_TARGETS="riscv64-efi"
+        - CROSS_TARGETS=riscv64-linux"
-- 
2.16.4



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v4] Add travis-ci config file
  2019-02-22  8:17 [PATCH v4] Add travis-ci config file Alexander Graf
@ 2019-02-22 13:22 ` Daniel Kiper
  2019-02-23 15:14   ` Alexander Graf
  0 siblings, 1 reply; 3+ messages in thread
From: Daniel Kiper @ 2019-02-22 13:22 UTC (permalink / raw)
  To: Alexander Graf; +Cc: grub-devel, leif.lindholm, Paul Menzel

On Fri, Feb 22, 2019 at 09:17:46AM +0100, Alexander Graf wrote:
> There is a really convenient service for open source project from Travis
> CI: They allow for free CI testing using their infrastructure.
>
> Grub has had issues with broken builds for various targets for a long time
> already. The main reason is a lack of CI to just do smoke tests on whether
> all targets still at least compile.
>
> This patch adds a travis config file which builds (almost) all currently
> available targets.
>
> On top of that, this travis config also runs a small execution test on the
> x86_64-efi target.
>
> All of this config file can easily be extended further on. It probably makes
> sense to do something similar to the u-boot test infrastructure that
> communicates with the payload properly. Going forward, we also will want to
> do more qemu runtime checks for other targets.
>
> Currently, with this config alone, I already see about half of the available
> targets as broken. So it's definitely desperately needed :).
>
> Signed-off-by: Alexander Graf <agraf@suse.de>

In general Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>

But...

> ---
>
> v1 -> v2:
>
>   - Fix comment about toolchain variable
>
> v2 -> v3:
>
>   - s/grub/GRUB/
>   - remove unneeded packages
>   - comment fixes
>   - determine number of jobs dynamically
>   - sort targets alphabetically
>
> v3 -> v4:
>
>   - reduce package list futher
>   - sort package list alphabetically
> ---
>  .travis.yml | 109 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 109 insertions(+)
>  create mode 100644 .travis.yml
>
> diff --git a/.travis.yml b/.travis.yml
> new file mode 100644
> index 000000000..a66143cba
> --- /dev/null
> +++ b/.travis.yml
> @@ -0,0 +1,109 @@
> +# SPDX-License-Identifier: GPL-3.0+
> +# Originally Copyright Roger Meier <r.meier@siemens.com>
> +# Adapted for GRUB by Alexander Graf <agraf@suse.de>
> +
> +# build GRUB on Travis CI - https://travis-ci.org/
> +
> +dist: xenial
> +
> +language: c
> +
> +addons:
> +  apt:
> +    packages:
> +    - build-essential
> +    - device-tree-compiler

Out of curiosity, are build-essential and device-tree-compiler needed to
test GRUB or just leftovers by mistake?

Daniel


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v4] Add travis-ci config file
  2019-02-22 13:22 ` Daniel Kiper
@ 2019-02-23 15:14   ` Alexander Graf
  0 siblings, 0 replies; 3+ messages in thread
From: Alexander Graf @ 2019-02-23 15:14 UTC (permalink / raw)
  To: Daniel Kiper; +Cc: grub-devel, leif.lindholm, Paul Menzel



On 22.02.19 14:22, Daniel Kiper wrote:
> On Fri, Feb 22, 2019 at 09:17:46AM +0100, Alexander Graf wrote:
>> There is a really convenient service for open source project from Travis
>> CI: They allow for free CI testing using their infrastructure.
>>
>> Grub has had issues with broken builds for various targets for a long time
>> already. The main reason is a lack of CI to just do smoke tests on whether
>> all targets still at least compile.
>>
>> This patch adds a travis config file which builds (almost) all currently
>> available targets.
>>
>> On top of that, this travis config also runs a small execution test on the
>> x86_64-efi target.
>>
>> All of this config file can easily be extended further on. It probably makes
>> sense to do something similar to the u-boot test infrastructure that
>> communicates with the payload properly. Going forward, we also will want to
>> do more qemu runtime checks for other targets.
>>
>> Currently, with this config alone, I already see about half of the available
>> targets as broken. So it's definitely desperately needed :).
>>
>> Signed-off-by: Alexander Graf <agraf@suse.de>
> 
> In general Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
> 
> But...
> 
>> ---
>>
>> v1 -> v2:
>>
>>   - Fix comment about toolchain variable
>>
>> v2 -> v3:
>>
>>   - s/grub/GRUB/
>>   - remove unneeded packages
>>   - comment fixes
>>   - determine number of jobs dynamically
>>   - sort targets alphabetically
>>
>> v3 -> v4:
>>
>>   - reduce package list futher
>>   - sort package list alphabetically
>> ---
>>  .travis.yml | 109 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 109 insertions(+)
>>  create mode 100644 .travis.yml
>>
>> diff --git a/.travis.yml b/.travis.yml
>> new file mode 100644
>> index 000000000..a66143cba
>> --- /dev/null
>> +++ b/.travis.yml
>> @@ -0,0 +1,109 @@
>> +# SPDX-License-Identifier: GPL-3.0+
>> +# Originally Copyright Roger Meier <r.meier@siemens.com>
>> +# Adapted for GRUB by Alexander Graf <agraf@suse.de>
>> +
>> +# build GRUB on Travis CI - https://travis-ci.org/
>> +
>> +dist: xenial
>> +
>> +language: c
>> +
>> +addons:
>> +  apt:
>> +    packages:
>> +    - build-essential
>> +    - device-tree-compiler
> 
> Out of curiosity, are build-essential and device-tree-compiler needed to
> test GRUB or just leftovers by mistake?

I think build-essential is a nop (already installed) and
device-tree-compiler an oversight.

Off to v5 ...


Alex


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-02-23 15:14 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-22  8:17 [PATCH v4] Add travis-ci config file Alexander Graf
2019-02-22 13:22 ` Daniel Kiper
2019-02-23 15:14   ` Alexander Graf

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.