* [PATCH 0/2] Staging: mt7621-dma: Fix checkpatch issues
@ 2019-02-23 8:19 Bhanusree Pola
2019-02-23 8:19 ` [PATCH 1/2] Staging: mt761-dma: Alignment should match open paranthesis Bhanusree Pola
2019-02-23 8:19 ` [PATCH 2/2] Staging: mt7621_dma: Prefer unsigned int over just unsigned Bhanusree Pola
0 siblings, 2 replies; 6+ messages in thread
From: Bhanusree Pola @ 2019-02-23 8:19 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Greg Kroah-Hartman, Matthias Brugger
This patch series cleans up the following checkpatch.pl issues:
CHECK: Alignment should match open parenthesis
WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
Bhanusree Pola (2):
Staging: mt761-dma: Alignment should match open paranthesis
Staging: mt7621_dma: Prefer unsigned int over just unsigned
drivers/staging/mt7621-dma/mtk-hsdma.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
--
2.17.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] Staging: mt761-dma: Alignment should match open paranthesis
2019-02-23 8:19 [PATCH 0/2] Staging: mt7621-dma: Fix checkpatch issues Bhanusree Pola
@ 2019-02-23 8:19 ` Bhanusree Pola
2019-02-23 8:19 ` [PATCH 2/2] Staging: mt7621_dma: Prefer unsigned int over just unsigned Bhanusree Pola
1 sibling, 0 replies; 6+ messages in thread
From: Bhanusree Pola @ 2019-02-23 8:19 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Greg Kroah-Hartman, Matthias Brugger
Parameters are aligned such that it matches open paranthesis.
Issue found with checkpatch.pl
Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
---
drivers/staging/mt7621-dma/mtk-hsdma.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c b/drivers/staging/mt7621-dma/mtk-hsdma.c
index d67a2504adb1..54bf89e2f629 100644
--- a/drivers/staging/mt7621-dma/mtk-hsdma.c
+++ b/drivers/staging/mt7621-dma/mtk-hsdma.c
@@ -242,7 +242,7 @@ static void hsdma_dump_desc(struct mtk_hsdam_engine *hsdma,
int i;
dev_dbg(hsdma->ddev.dev, "tx idx: %d, rx idx: %d\n",
- chan->tx_idx, chan->rx_idx);
+ chan->tx_idx, chan->rx_idx);
for (i = 0; i < HSDMA_DESCS_NUM; i++) {
tx_desc = &chan->tx_ring[i];
@@ -576,8 +576,8 @@ static void mtk_hsdam_free_desc(struct mtk_hsdam_engine *hsdma,
{
if (chan->tx_ring) {
dma_free_coherent(hsdma->ddev.dev,
- 2 * HSDMA_DESCS_NUM * sizeof(*chan->tx_ring),
- chan->tx_ring, chan->desc_addr);
+ 2 * HSDMA_DESCS_NUM * sizeof(*chan->tx_ring),
+ chan->tx_ring, chan->desc_addr);
chan->tx_ring = NULL;
chan->rx_ring = NULL;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] Staging: mt7621_dma: Prefer unsigned int over just unsigned
2019-02-23 8:19 [PATCH 0/2] Staging: mt7621-dma: Fix checkpatch issues Bhanusree Pola
2019-02-23 8:19 ` [PATCH 1/2] Staging: mt761-dma: Alignment should match open paranthesis Bhanusree Pola
@ 2019-02-23 8:19 ` Bhanusree Pola
2019-02-23 14:07 ` [Outreachy kernel] " Julia Lawall
1 sibling, 1 reply; 6+ messages in thread
From: Bhanusree Pola @ 2019-02-23 8:19 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Greg Kroah-Hartman, Matthias Brugger
Fixes checkpatch.pl warning:
WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
---
drivers/staging/mt7621-dma/mtk-hsdma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c b/drivers/staging/mt7621-dma/mtk-hsdma.c
index 54bf89e2f629..fa7631cfbb78 100644
--- a/drivers/staging/mt7621-dma/mtk-hsdma.c
+++ b/drivers/staging/mt7621-dma/mtk-hsdma.c
@@ -191,7 +191,7 @@ static inline u32 mtk_hsdma_read(struct mtk_hsdam_engine *hsdma, u32 reg)
}
static inline void mtk_hsdma_write(struct mtk_hsdam_engine *hsdma,
- unsigned reg, u32 val)
+ unsigned int reg, u32 val)
{
writel(val, hsdma->base + reg);
}
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] [PATCH 2/2] Staging: mt7621_dma: Prefer unsigned int over just unsigned
2019-02-23 8:19 ` [PATCH 2/2] Staging: mt7621_dma: Prefer unsigned int over just unsigned Bhanusree Pola
@ 2019-02-23 14:07 ` Julia Lawall
2019-02-23 14:16 ` Bhanusree Mahesh
0 siblings, 1 reply; 6+ messages in thread
From: Julia Lawall @ 2019-02-23 14:07 UTC (permalink / raw)
To: Bhanusree Pola; +Cc: outreachy-kernel, Greg Kroah-Hartman, Matthias Brugger
On Sat, 23 Feb 2019, Bhanusree Pola wrote:
> Fixes checkpatch.pl warning:
> WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
Log messages are supposed to be in the imperative. So here it should be
"Fix ...". But it would be even better to come up with a description that
says something other than Fix. Explain what you have done and why.
julia
>
> Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
> ---
> drivers/staging/mt7621-dma/mtk-hsdma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c b/drivers/staging/mt7621-dma/mtk-hsdma.c
> index 54bf89e2f629..fa7631cfbb78 100644
> --- a/drivers/staging/mt7621-dma/mtk-hsdma.c
> +++ b/drivers/staging/mt7621-dma/mtk-hsdma.c
> @@ -191,7 +191,7 @@ static inline u32 mtk_hsdma_read(struct mtk_hsdam_engine *hsdma, u32 reg)
> }
>
> static inline void mtk_hsdma_write(struct mtk_hsdam_engine *hsdma,
> - unsigned reg, u32 val)
> + unsigned int reg, u32 val)
> {
> writel(val, hsdma->base + reg);
> }
> --
> 2.17.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190223081941.9629-3-bhanusreemahesh%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] [PATCH 2/2] Staging: mt7621_dma: Prefer unsigned int over just unsigned
2019-02-23 14:07 ` [Outreachy kernel] " Julia Lawall
@ 2019-02-23 14:16 ` Bhanusree Mahesh
2019-02-23 14:22 ` Julia Lawall
0 siblings, 1 reply; 6+ messages in thread
From: Bhanusree Mahesh @ 2019-02-23 14:16 UTC (permalink / raw)
To: Julia Lawall; +Cc: outreachy-kernel, Greg Kroah-Hartman, Matthias Brugger
On Sat, 23 Feb 2019 at 19:37, Julia Lawall <julia.lawall@lip6.fr> wrote:
>
>
>
> On Sat, 23 Feb 2019, Bhanusree Pola wrote:
>
> > Fixes checkpatch.pl warning:
> > WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
>
> Log messages are supposed to be in the imperative. So here it should be
> "Fix ...". But it would be even better to come up with a description that
> says something other than Fix. Explain what you have done and why.
>
should i change the log message and resend it ?
> julia
>
> >
> > Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
> > ---
> > drivers/staging/mt7621-dma/mtk-hsdma.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c b/drivers/staging/mt7621-dma/mtk-hsdma.c
> > index 54bf89e2f629..fa7631cfbb78 100644
> > --- a/drivers/staging/mt7621-dma/mtk-hsdma.c
> > +++ b/drivers/staging/mt7621-dma/mtk-hsdma.c
> > @@ -191,7 +191,7 @@ static inline u32 mtk_hsdma_read(struct mtk_hsdam_engine *hsdma, u32 reg)
> > }
> >
> > static inline void mtk_hsdma_write(struct mtk_hsdam_engine *hsdma,
> > - unsigned reg, u32 val)
> > + unsigned int reg, u32 val)
> > {
> > writel(val, hsdma->base + reg);
> > }
> > --
> > 2.17.1
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190223081941.9629-3-bhanusreemahesh%40gmail.com.
> > For more options, visit https://groups.google.com/d/optout.
> >
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/alpine.DEB.2.21.1902231506310.2551%40hadrien.
> For more options, visit https://groups.google.com/d/optout.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] [PATCH 2/2] Staging: mt7621_dma: Prefer unsigned int over just unsigned
2019-02-23 14:16 ` Bhanusree Mahesh
@ 2019-02-23 14:22 ` Julia Lawall
0 siblings, 0 replies; 6+ messages in thread
From: Julia Lawall @ 2019-02-23 14:22 UTC (permalink / raw)
To: Bhanusree Mahesh; +Cc: outreachy-kernel, Greg Kroah-Hartman, Matthias Brugger
On Sat, 23 Feb 2019, Bhanusree Mahesh wrote:
> On Sat, 23 Feb 2019 at 19:37, Julia Lawall <julia.lawall@lip6.fr> wrote:
> >
> >
> >
> > On Sat, 23 Feb 2019, Bhanusree Pola wrote:
> >
> > > Fixes checkpatch.pl warning:
> > > WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
> >
> > Log messages are supposed to be in the imperative. So here it should be
> > "Fix ...". But it would be even better to come up with a description that
> > says something other than Fix. Explain what you have done and why.
> >
> should i change the log message and resend it ?
Yes please.
julia
>
> > julia
> >
> > >
> > > Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
> > > ---
> > > drivers/staging/mt7621-dma/mtk-hsdma.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c b/drivers/staging/mt7621-dma/mtk-hsdma.c
> > > index 54bf89e2f629..fa7631cfbb78 100644
> > > --- a/drivers/staging/mt7621-dma/mtk-hsdma.c
> > > +++ b/drivers/staging/mt7621-dma/mtk-hsdma.c
> > > @@ -191,7 +191,7 @@ static inline u32 mtk_hsdma_read(struct mtk_hsdam_engine *hsdma, u32 reg)
> > > }
> > >
> > > static inline void mtk_hsdma_write(struct mtk_hsdam_engine *hsdma,
> > > - unsigned reg, u32 val)
> > > + unsigned int reg, u32 val)
> > > {
> > > writel(val, hsdma->base + reg);
> > > }
> > > --
> > > 2.17.1
> > >
> > > --
> > > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190223081941.9629-3-bhanusreemahesh%40gmail.com.
> > > For more options, visit https://groups.google.com/d/optout.
> > >
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/alpine.DEB.2.21.1902231506310.2551%40hadrien.
> > For more options, visit https://groups.google.com/d/optout.
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/CAB0Mk-Nr3GrXEnVE4pdQG6snUpXq3pOqx%3D19nNpZYCDLEtcF4Q%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-02-23 14:22 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-23 8:19 [PATCH 0/2] Staging: mt7621-dma: Fix checkpatch issues Bhanusree Pola
2019-02-23 8:19 ` [PATCH 1/2] Staging: mt761-dma: Alignment should match open paranthesis Bhanusree Pola
2019-02-23 8:19 ` [PATCH 2/2] Staging: mt7621_dma: Prefer unsigned int over just unsigned Bhanusree Pola
2019-02-23 14:07 ` [Outreachy kernel] " Julia Lawall
2019-02-23 14:16 ` Bhanusree Mahesh
2019-02-23 14:22 ` Julia Lawall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.