All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] net: ax25: Add SPDX License to fix missing License warning
@ 2019-02-23 11:11 Jules Irenge
  2019-02-23 12:58 ` Greg KH
  2019-02-23 13:20 ` [Outreachy kernel] " Julia Lawall
  0 siblings, 2 replies; 3+ messages in thread
From: Jules Irenge @ 2019-02-23 11:11 UTC (permalink / raw)
  To: jreuter
  Cc: linux-hams, linux-kernel, davem, ralf, netdev, outreachy-kernel,
	gregkh, jbi.octave

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 net/ax25/af_ax25.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/ax25/af_ax25.c b/net/ax25/af_ax25.c
index 5d01edf8d819..5048790a75f6 100644
--- a/net/ax25/af_ax25.c
+++ b/net/ax25/af_ax25.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0
 /*
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
-- 
2.20.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] net: ax25: Add SPDX License to fix missing License warning
  2019-02-23 11:11 [PATCH] net: ax25: Add SPDX License to fix missing License warning Jules Irenge
@ 2019-02-23 12:58 ` Greg KH
  2019-02-23 13:20 ` [Outreachy kernel] " Julia Lawall
  1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2019-02-23 12:58 UTC (permalink / raw)
  To: Jules Irenge
  Cc: jreuter, linux-hams, linux-kernel, davem, ralf, netdev, outreachy-kernel

On Sat, Feb 23, 2019 at 11:11:00AM +0000, Jules Irenge wrote:
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>

I know I never take patches without any changelog text :(


> ---
>  net/ax25/af_ax25.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/net/ax25/af_ax25.c b/net/ax25/af_ax25.c
> index 5d01edf8d819..5048790a75f6 100644
> --- a/net/ax25/af_ax25.c
> +++ b/net/ax25/af_ax25.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0

That is the incorrect license of this file!

NEVER add or modify a SPDX line if you do not really really really know
what you are doing.  Putting the wrong license tag on a file is worse
than not having any tag at all.

BE VERY CAREFUL ABOUT THESE THINGS, they matter.  If you get them wrong,
lawyers get very grumpy :)

thanks,

greg k-h


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Outreachy kernel] [PATCH] net: ax25: Add SPDX License to fix missing License warning
  2019-02-23 11:11 [PATCH] net: ax25: Add SPDX License to fix missing License warning Jules Irenge
  2019-02-23 12:58 ` Greg KH
@ 2019-02-23 13:20 ` Julia Lawall
  1 sibling, 0 replies; 3+ messages in thread
From: Julia Lawall @ 2019-02-23 13:20 UTC (permalink / raw)
  To: Jules Irenge; +Cc: outreachy-kernel

For the outreachy application period you should work on drivers/staging.
If you want to work on something else, you shouldn't CC the mailing list,
and you take the risk that your change won't be applied before th end fo
the application period.

julia

On Sat, 23 Feb 2019, Jules Irenge wrote:

> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> ---
>  net/ax25/af_ax25.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/net/ax25/af_ax25.c b/net/ax25/af_ax25.c
> index 5d01edf8d819..5048790a75f6 100644
> --- a/net/ax25/af_ax25.c
> +++ b/net/ax25/af_ax25.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0
>  /*
>   * This program is free software; you can redistribute it and/or modify
>   * it under the terms of the GNU General Public License as published by
> --
> 2.20.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190223111100.13983-1-jbi.octave%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-02-23 13:20 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-23 11:11 [PATCH] net: ax25: Add SPDX License to fix missing License warning Jules Irenge
2019-02-23 12:58 ` Greg KH
2019-02-23 13:20 ` [Outreachy kernel] " Julia Lawall

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.