* [Buildroot] [PATCH 0/3] Some more games: XorCurses, ASCII-Invaders and Frotz
@ 2019-02-23 20:56 Thomas Huth
2019-02-23 20:56 ` [Buildroot] [PATCH 1/3] package/xorcurses: new package Thomas Huth
` (3 more replies)
0 siblings, 4 replies; 11+ messages in thread
From: Thomas Huth @ 2019-02-23 20:56 UTC (permalink / raw)
To: buildroot
Hi everybody!
This is my first patch contribution to the buildroot project ...
I used buildroot for building most of the images for he QEMU advent
calendar 2018 (see https://www.qemu-advent-calendar.org/2018/ ).
That would not have been possible without buildroot, so thanks a lot
for this great build environment!
Anyway, I've now gone through the package files that I've written
for that project, and I think some of them might maybe be interesting
for integrating them into the official buildroot tree, too. Please
have a look at the following patches, and let me know what you think.
(I also got some more package files on my hard disk, but they need some
more polishing, so I would like to get some feedback on these three
patches first)
Thomas Huth (3):
package/xorcurses: new package
package/ascii-invaders: new package
package/frotz: new package
package/Config.in | 3 ++
package/ascii-invaders/Config.in | 5 ++++
package/ascii-invaders/ascii-invaders.hash | 2 ++
package/ascii-invaders/ascii-invaders.mk | 23 ++++++++++++++++
package/frotz/Config.in | 7 +++++
package/frotz/frotz.hash | 2 ++
package/frotz/frotz.mk | 32 ++++++++++++++++++++++
package/xorcurses/Config.in | 13 +++++++++
package/xorcurses/xorcurses.hash | 2 ++
package/xorcurses/xorcurses.mk | 25 +++++++++++++++++
10 files changed, 114 insertions(+)
create mode 100644 package/ascii-invaders/Config.in
create mode 100644 package/ascii-invaders/ascii-invaders.hash
create mode 100644 package/ascii-invaders/ascii-invaders.mk
create mode 100644 package/frotz/Config.in
create mode 100644 package/frotz/frotz.hash
create mode 100644 package/frotz/frotz.mk
create mode 100644 package/xorcurses/Config.in
create mode 100644 package/xorcurses/xorcurses.hash
create mode 100644 package/xorcurses/xorcurses.mk
--
2.17.2
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH 1/3] package/xorcurses: new package
2019-02-23 20:56 [Buildroot] [PATCH 0/3] Some more games: XorCurses, ASCII-Invaders and Frotz Thomas Huth
@ 2019-02-23 20:56 ` Thomas Huth
2019-03-16 16:57 ` Gilles Talis
2019-02-23 20:56 ` [Buildroot] [PATCH 2/3] package/ascii-invaders: " Thomas Huth
` (2 subsequent siblings)
3 siblings, 1 reply; 11+ messages in thread
From: Thomas Huth @ 2019-02-23 20:56 UTC (permalink / raw)
To: buildroot
From: Thomas Huth <thuth@redhat.com>
XorCurses is a remake of the 8-bit game 'Xor' by Astral Software.
Your task is to roam around a series of mazes where you have to collect
all blue masks before finding the exit. You have two 'shields' (players)
and you can use either one at any time and switch between them. While
the first level is simply a matter of navigation, the following levels
introduce further objects like bombs and teleports, which have to be
used right to solve the puzzles.
Signed-off-by: Thomas Huth <huth@tuxfamily.org>
---
package/Config.in | 1 +
package/xorcurses/Config.in | 13 +++++++++++++
package/xorcurses/xorcurses.hash | 2 ++
package/xorcurses/xorcurses.mk | 25 +++++++++++++++++++++++++
4 files changed, 41 insertions(+)
create mode 100644 package/xorcurses/Config.in
create mode 100644 package/xorcurses/xorcurses.hash
create mode 100644 package/xorcurses/xorcurses.mk
diff --git a/package/Config.in b/package/Config.in
index cc232b9fba..490cbdb216 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -258,6 +258,7 @@ menu "Games"
source "package/stella/Config.in"
source "package/supertux/Config.in"
source "package/supertuxkart/Config.in"
+ source "package/xorcurses/Config.in"
endmenu
menu "Graphic libraries and applications (graphic/text)"
diff --git a/package/xorcurses/Config.in b/package/xorcurses/Config.in
new file mode 100644
index 0000000000..0af161fec9
--- /dev/null
+++ b/package/xorcurses/Config.in
@@ -0,0 +1,13 @@
+config BR2_PACKAGE_XORCURSES
+ bool "xorcurses"
+ select BR2_PACKAGE_NCURSES
+ help
+ XorCurses is a remake of the 8-bit game 'Xor' by Astral Software.
+ Your task is to roam around a series of mazes where you have to collect
+ all blue masks before finding the exit. You have two 'shields' (players)
+ and you can use either one at any time and switch between them. While
+ the first level is simply a matter of navigation, the following levels
+ introduce further objects like bombs and teleports, which have to be
+ used right to solve the puzzles.
+ Note that the game needs a terminal with colors, i.e. make sure that
+ the TERM environment variable is set to "linux" ("vt100" won't work).
diff --git a/package/xorcurses/xorcurses.hash b/package/xorcurses/xorcurses.hash
new file mode 100644
index 0000000000..49d3a0c3b9
--- /dev/null
+++ b/package/xorcurses/xorcurses.hash
@@ -0,0 +1,2 @@
+# Locally calculated
+sha512 1782ebf6ae8798b32e0a8e5e20e6d0b44eb619f6e7f015735c6e86205bd545da108c36bff1c9cfc9e9b44dee8f90bacb9df70436991f57f51c2c87e94b3a4725 XorCurses-0.2.2.tar.bz2
diff --git a/package/xorcurses/xorcurses.mk b/package/xorcurses/xorcurses.mk
new file mode 100644
index 0000000000..4bc132c5e8
--- /dev/null
+++ b/package/xorcurses/xorcurses.mk
@@ -0,0 +1,25 @@
+################################################################################
+#
+# XorCurses
+#
+################################################################################
+
+XORCURSES_VERSION = 0.2.2
+XORCURSES_LICENSE = GPL-3.0
+XORCURSES_SOURCE = XorCurses-$(XORCURSES_VERSION).tar.bz2
+XORCURSES_SITE = http://www.jwm-art.net/art/archive
+XORCURSES_INSTALL_TARGET = YES
+XORCURSES_DEPENDENCIES = ncurses
+
+define XORCURSES_BUILD_CMDS
+ $(MAKE) -C $(@D) $(TARGET_CONFIGURE_OPTS) \
+ CFLAGS="-O2 -DDATADIR='\"/usr/share/xorcurses\"' -DVERSION='\"$(XORCURSES_VERSION)\"'"
+endef
+
+define XORCURSES_INSTALL_TARGET_CMDS
+ $(INSTALL) -D -m 0755 $(@D)/xorcurses $(TARGET_DIR)/usr/bin/
+ mkdir -p $(TARGET_DIR)/usr/share/xorcurses/maps
+ $(INSTALL) -D -m 0755 $(@D)/maps/*.xcm $(TARGET_DIR)/usr/share/xorcurses/maps/
+endef
+
+$(eval $(generic-package))
--
2.17.2
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH 2/3] package/ascii-invaders: new package
2019-02-23 20:56 [Buildroot] [PATCH 0/3] Some more games: XorCurses, ASCII-Invaders and Frotz Thomas Huth
2019-02-23 20:56 ` [Buildroot] [PATCH 1/3] package/xorcurses: new package Thomas Huth
@ 2019-02-23 20:56 ` Thomas Huth
2019-03-16 17:04 ` Gilles Talis
2019-02-23 20:56 ` [Buildroot] [PATCH 3/3] package/frotz: " Thomas Huth
2019-03-07 11:16 ` [Buildroot] [PATCH 0/3] Some more games: XorCurses, ASCII-Invaders and Frotz Thomas Huth
3 siblings, 1 reply; 11+ messages in thread
From: Thomas Huth @ 2019-02-23 20:56 UTC (permalink / raw)
To: buildroot
An ASCII-art game like Space Invaders using ncurses.
Signed-off-by: Thomas Huth <huth@tuxfamily.org>
---
package/Config.in | 1 +
package/ascii-invaders/Config.in | 5 +++++
package/ascii-invaders/ascii-invaders.hash | 2 ++
package/ascii-invaders/ascii-invaders.mk | 23 ++++++++++++++++++++++
4 files changed, 31 insertions(+)
create mode 100644 package/ascii-invaders/Config.in
create mode 100644 package/ascii-invaders/ascii-invaders.hash
create mode 100644 package/ascii-invaders/ascii-invaders.mk
diff --git a/package/Config.in b/package/Config.in
index 490cbdb216..16789fcd7c 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -239,6 +239,7 @@ comment "Themes"
endmenu
menu "Games"
+ source "package/ascii-invaders/Config.in"
source "package/chocolate-doom/Config.in"
source "package/doom-wad/Config.in"
source "package/flare-engine/Config.in"
diff --git a/package/ascii-invaders/Config.in b/package/ascii-invaders/Config.in
new file mode 100644
index 0000000000..e68d48bed0
--- /dev/null
+++ b/package/ascii-invaders/Config.in
@@ -0,0 +1,5 @@
+config BR2_PACKAGE_ASCII_INVADERS
+ bool "ascii_invaders"
+ select BR2_PACKAGE_NCURSES
+ help
+ An ASCII-art game like Space Invaders using ncurses.
diff --git a/package/ascii-invaders/ascii-invaders.hash b/package/ascii-invaders/ascii-invaders.hash
new file mode 100644
index 0000000000..6c98401c36
--- /dev/null
+++ b/package/ascii-invaders/ascii-invaders.hash
@@ -0,0 +1,2 @@
+# Locally calculated
+sha512 326708ffc2c277e04575920c58f6a267e0bf46f8d2a3dbca9b5c317fb01006d4f673ab35f92f292549cc52dbee4400a84c85478eb81b9bd7703689a705547bc7 v1.0.1.tar.gz
diff --git a/package/ascii-invaders/ascii-invaders.mk b/package/ascii-invaders/ascii-invaders.mk
new file mode 100644
index 0000000000..cb5aeaff27
--- /dev/null
+++ b/package/ascii-invaders/ascii-invaders.mk
@@ -0,0 +1,23 @@
+##############################################################################
+#
+# ASCII-Invaders
+#
+##############################################################################
+
+ASCII_INVADERS_VERSION = 1.0.1
+ASCII_INVADERS_SOURCE = v$(ASCII_INVADERS_VERSION).tar.gz
+ASCII_INVADERS_SITE = https://github.com/macdice/ascii-invaders/archive
+ASCII_INVADERS_INSTALL_TARGET = YES
+ASCII_INVADERS_DEPENDENCIES = ncurses
+ASCII_INVADERS_LICENSE = GPL-2.0+
+ASCII_INVADERS_LICENSE_FILES = LICENSE
+
+define ASCII_INVADERS_BUILD_CMDS
+ (cd $(@D) ; $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D))
+endef
+
+define ASCII_INVADERS_INSTALL_TARGET_CMDS
+ $(INSTALL) -D -m 0755 $(@D)/ascii_invaders $(TARGET_DIR)/usr/bin
+endef
+
+$(eval $(generic-package))
--
2.17.2
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH 3/3] package/frotz: new package
2019-02-23 20:56 [Buildroot] [PATCH 0/3] Some more games: XorCurses, ASCII-Invaders and Frotz Thomas Huth
2019-02-23 20:56 ` [Buildroot] [PATCH 1/3] package/xorcurses: new package Thomas Huth
2019-02-23 20:56 ` [Buildroot] [PATCH 2/3] package/ascii-invaders: " Thomas Huth
@ 2019-02-23 20:56 ` Thomas Huth
2019-03-16 17:15 ` Gilles Talis
2019-03-07 11:16 ` [Buildroot] [PATCH 0/3] Some more games: XorCurses, ASCII-Invaders and Frotz Thomas Huth
3 siblings, 1 reply; 11+ messages in thread
From: Thomas Huth @ 2019-02-23 20:56 UTC (permalink / raw)
To: buildroot
Frotz is an interpreter for old Infocom adventures and other Z-code games.
Signed-off-by: Thomas Huth <huth@tuxfamily.org>
---
package/Config.in | 1 +
package/frotz/Config.in | 7 +++++++
package/frotz/frotz.hash | 2 ++
package/frotz/frotz.mk | 32 ++++++++++++++++++++++++++++++++
4 files changed, 42 insertions(+)
create mode 100644 package/frotz/Config.in
create mode 100644 package/frotz/frotz.hash
create mode 100644 package/frotz/frotz.mk
diff --git a/package/Config.in b/package/Config.in
index 16789fcd7c..d6f7ba0d75 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -244,6 +244,7 @@ menu "Games"
source "package/doom-wad/Config.in"
source "package/flare-engine/Config.in"
source "package/flare-game/Config.in"
+ source "package/frotz/Config.in"
source "package/gnuchess/Config.in"
source "package/lbreakout2/Config.in"
source "package/ltris/Config.in"
diff --git a/package/frotz/Config.in b/package/frotz/Config.in
new file mode 100644
index 0000000000..4b3039613f
--- /dev/null
+++ b/package/frotz/Config.in
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_FROTZ
+ bool "frotz"
+ select BR2_PACKAGE_NCURSES
+ help
+ Frotz is an interpreter for old Infocom adventure games and other Z-code
+ games. Note that frotz can not be run as root. You must add a normal user
+ to your buildroot configuration to be able to use it.
diff --git a/package/frotz/frotz.hash b/package/frotz/frotz.hash
new file mode 100644
index 0000000000..b441bffc31
--- /dev/null
+++ b/package/frotz/frotz.hash
@@ -0,0 +1,2 @@
+# Locally calculated
+sha512 c3aeb1bca227db7b759be880c1fe14e3d46c79eae3f2891d2472ff1e1b17b2153b2e400d537d54dce68011079e230fe8176ebb7547b2ecbc30e44f2b7423c285 frotz-2.44.tar.bz2
diff --git a/package/frotz/frotz.mk b/package/frotz/frotz.mk
new file mode 100644
index 0000000000..7f31e7d89b
--- /dev/null
+++ b/package/frotz/frotz.mk
@@ -0,0 +1,32 @@
+##############################################################################
+#
+# Frotz - the Z-code interpreter
+#
+##############################################################################
+
+FROTZ_VERSION = 2.44
+FROTZ_SOURCE = frotz-$(FROTZ_VERSION).tar.bz2
+FROTZ_SITE = https://gitlab.com/DavidGriffith/frotz/-/archive/$(FROTZ_VERSION)
+FROTZ_INSTALL_TARGET = YES
+FROTZ_DEPENDENCIES = ncurses
+FROTZ_LICENSE = GPL-2.0+
+FROTZ_LICENSE_FILES = COPYING
+
+define FROTZ_POST_EXTRACT_FIXUP
+ (cd $(@D); \
+ sed -i 's/$ ar rc/ \$$\(AR\) rc/g' $(@D)/Makefile ; \
+ sed -i 's/$ ranlib/ \$$\(RANLIB\)/g' $(@D)/Makefile ; \
+ sed -i 's/$ strip/ \$$\(STRIP\)/g' $(@D)/Makefile )
+endef
+FROTZ_POST_EXTRACT_HOOKS += FROTZ_POST_EXTRACT_FIXUP
+
+define FROTZ_BUILD_CMDS
+ $(MAKE) $(TARGET_CONFIGURE_OPTS) PREFIX=/usr CONFIG_DIR=/etc -C $(@D)
+endef
+
+define FROTZ_INSTALL_TARGET_CMDS
+ $(INSTALL) -D -m 0755 $(@D)/frotz $(TARGET_DIR)/usr/bin
+ $(INSTALL) -D -m 0644 $(@D)/doc/frotz.6 $(TARGET_DIR)/usr/man/man6
+endef
+
+$(eval $(generic-package))
--
2.17.2
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH 0/3] Some more games: XorCurses, ASCII-Invaders and Frotz
2019-02-23 20:56 [Buildroot] [PATCH 0/3] Some more games: XorCurses, ASCII-Invaders and Frotz Thomas Huth
` (2 preceding siblings ...)
2019-02-23 20:56 ` [Buildroot] [PATCH 3/3] package/frotz: " Thomas Huth
@ 2019-03-07 11:16 ` Thomas Huth
2019-03-17 15:16 ` Thomas Petazzoni
3 siblings, 1 reply; 11+ messages in thread
From: Thomas Huth @ 2019-03-07 11:16 UTC (permalink / raw)
To: buildroot
On 23/02/2019 21.56, Thomas Huth wrote:
> Hi everybody!
> This is my first patch contribution to the buildroot project ...
> I used buildroot for building most of the images for he QEMU advent
> calendar 2018 (see https://www.qemu-advent-calendar.org/2018/ ).
> That would not have been possible without buildroot, so thanks a lot
> for this great build environment!
>
> Anyway, I've now gone through the package files that I've written
> for that project, and I think some of them might maybe be interesting
> for integrating them into the official buildroot tree, too. Please
> have a look at the following patches, and let me know what you think.
> (I also got some more package files on my hard disk, but they need some
> more polishing, so I would like to get some feedback on these three
> patches first)
>
> Thomas Huth (3):
> package/xorcurses: new package
> package/ascii-invaders: new package
> package/frotz: new package
*ping*
Any comments? Are the patches not suitable for buildroot? No problem,
just let me know and I'll shut up ;-) ... or is it that just nobody has
enough spare time for a review?
Cheers,
Thomas
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH 1/3] package/xorcurses: new package
2019-02-23 20:56 ` [Buildroot] [PATCH 1/3] package/xorcurses: new package Thomas Huth
@ 2019-03-16 16:57 ` Gilles Talis
2019-04-22 5:55 ` Thomas Huth
0 siblings, 1 reply; 11+ messages in thread
From: Gilles Talis @ 2019-03-16 16:57 UTC (permalink / raw)
To: buildroot
Hello Thomas,
Thanks for your contribution. Please find some comments below.
Le sam. 23 f?vr. 2019 ? 21:57, Thomas Huth <huth@tuxfamily.org> a ?crit :
>
> From: Thomas Huth <thuth@redhat.com>
>
> XorCurses is a remake of the 8-bit game 'Xor' by Astral Software.
> Your task is to roam around a series of mazes where you have to collect
> all blue masks before finding the exit. You have two 'shields' (players)
> and you can use either one at any time and switch between them. While
> the first level is simply a matter of navigation, the following levels
> introduce further objects like bombs and teleports, which have to be
> used right to solve the puzzles.
>
> Signed-off-by: Thomas Huth <huth@tuxfamily.org>
> ---
> package/Config.in | 1 +
> package/xorcurses/Config.in | 13 +++++++++++++
> package/xorcurses/xorcurses.hash | 2 ++
> package/xorcurses/xorcurses.mk | 25 +++++++++++++++++++++++++
You also need to create an entry in the DEVELOPERS file for your name
and this package.
> 4 files changed, 41 insertions(+)
> create mode 100644 package/xorcurses/Config.in
> create mode 100644 package/xorcurses/xorcurses.hash
> create mode 100644 package/xorcurses/xorcurses.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index cc232b9fba..490cbdb216 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -258,6 +258,7 @@ menu "Games"
> source "package/stella/Config.in"
> source "package/supertux/Config.in"
> source "package/supertuxkart/Config.in"
> + source "package/xorcurses/Config.in"
> endmenu
>
> menu "Graphic libraries and applications (graphic/text)"
> diff --git a/package/xorcurses/Config.in b/package/xorcurses/Config.in
> new file mode 100644
> index 0000000000..0af161fec9
> --- /dev/null
> +++ b/package/xorcurses/Config.in
> @@ -0,0 +1,13 @@
> +config BR2_PACKAGE_XORCURSES
> + bool "xorcurses"
> + select BR2_PACKAGE_NCURSES
> + help
> + XorCurses is a remake of the 8-bit game 'Xor' by Astral Software.
> + Your task is to roam around a series of mazes where you have to collect
> + all blue masks before finding the exit. You have two 'shields' (players)
> + and you can use either one at any time and switch between them. While
> + the first level is simply a matter of navigation, the following levels
> + introduce further objects like bombs and teleports, which have to be
> + used right to solve the puzzles.
> + Note that the game needs a terminal with colors, i.e. make sure that
> + the TERM environment variable is set to "linux" ("vt100" won't work).
There are some coding style issues in this file. Please run the
following command:
./utils/check-package package/xorcurses/*
to fix the warnings.
You also need to mention the upstream URL of this package as part of
the help text.
You might not need to have a help text that long. Just the first line
should be enough.
> diff --git a/package/xorcurses/xorcurses.hash b/package/xorcurses/xorcurses.hash
> new file mode 100644
> index 0000000000..49d3a0c3b9
> --- /dev/null
> +++ b/package/xorcurses/xorcurses.hash
> @@ -0,0 +1,2 @@
> +# Locally calculated
> +sha512 1782ebf6ae8798b32e0a8e5e20e6d0b44eb619f6e7f015735c6e86205bd545da108c36bff1c9cfc9e9b44dee8f90bacb9df70436991f57f51c2c87e94b3a4725 XorCurses-0.2.2.tar.bz2
You also need to provide the hash for the license file.
> diff --git a/package/xorcurses/xorcurses.mk b/package/xorcurses/xorcurses.mk
> new file mode 100644
> index 0000000000..4bc132c5e8
> --- /dev/null
> +++ b/package/xorcurses/xorcurses.mk
> @@ -0,0 +1,25 @@
> +################################################################################
> +#
> +# XorCurses
> +#
> +################################################################################
> +
> +XORCURSES_VERSION = 0.2.2
> +XORCURSES_LICENSE = GPL-3.0
> +XORCURSES_SOURCE = XorCurses-$(XORCURSES_VERSION).tar.bz2
> +XORCURSES_SITE = http://www.jwm-art.net/art/archive
> +XORCURSES_INSTALL_TARGET = YES
this is the default value, so not needed.
> +XORCURSES_DEPENDENCIES = ncurses
> +
> +define XORCURSES_BUILD_CMDS
> + $(MAKE) -C $(@D) $(TARGET_CONFIGURE_OPTS) \
> + CFLAGS="-O2 -DDATADIR='\"/usr/share/xorcurses\"' -DVERSION='\"$(XORCURSES_VERSION)\"'"
You mght want to keep the default CFLAGS by doing this
CFLAGS="$(TARGET_CFLAGS) -O2 ...."
> +endef
> +
> +define XORCURSES_INSTALL_TARGET_CMDS
> + $(INSTALL) -D -m 0755 $(@D)/xorcurses $(TARGET_DIR)/usr/bin/
It should be $(INSTALL) -D -m 0755 $(@D)/xorcurses
$(TARGET_DIR)/usr/bin/xorcurses
> + mkdir -p $(TARGET_DIR)/usr/share/xorcurses/maps
> + $(INSTALL) -D -m 0755 $(@D)/maps/*.xcm $(TARGET_DIR)/usr/share/xorcurses/maps/
If these are not executable files, it would be better to change their
access permission mode.
> +endef
> +
> +$(eval $(generic-package))
> --
> 2.17.2
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
As a rule of thumb, it is recommended to test your package with the
test-pkg tool. This will allow you to spot some issues when building
in different configurations.
Please look into the buildroot user manual, under the "How to test
your package" for more details.
Thanks!
Gilles.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH 2/3] package/ascii-invaders: new package
2019-02-23 20:56 ` [Buildroot] [PATCH 2/3] package/ascii-invaders: " Thomas Huth
@ 2019-03-16 17:04 ` Gilles Talis
0 siblings, 0 replies; 11+ messages in thread
From: Gilles Talis @ 2019-03-16 17:04 UTC (permalink / raw)
To: buildroot
Hello Thomas,
Le sam. 23 f?vr. 2019 ? 21:57, Thomas Huth <huth@tuxfamily.org> a ?crit :
>
> An ASCII-art game like Space Invaders using ncurses.
>
> Signed-off-by: Thomas Huth <huth@tuxfamily.org>
> ---
> package/Config.in | 1 +
> package/ascii-invaders/Config.in | 5 +++++
> package/ascii-invaders/ascii-invaders.hash | 2 ++
> package/ascii-invaders/ascii-invaders.mk | 23 ++++++++++++++++++++++
Please also add an entry in the DEVELOPERS file for this package.
> 4 files changed, 31 insertions(+)
> create mode 100644 package/ascii-invaders/Config.in
> create mode 100644 package/ascii-invaders/ascii-invaders.hash
> create mode 100644 package/ascii-invaders/ascii-invaders.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index 490cbdb216..16789fcd7c 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -239,6 +239,7 @@ comment "Themes"
> endmenu
>
> menu "Games"
> + source "package/ascii-invaders/Config.in"
> source "package/chocolate-doom/Config.in"
> source "package/doom-wad/Config.in"
> source "package/flare-engine/Config.in"
> diff --git a/package/ascii-invaders/Config.in b/package/ascii-invaders/Config.in
> new file mode 100644
> index 0000000000..e68d48bed0
> --- /dev/null
> +++ b/package/ascii-invaders/Config.in
> @@ -0,0 +1,5 @@
> +config BR2_PACKAGE_ASCII_INVADERS
> + bool "ascii_invaders"
> + select BR2_PACKAGE_NCURSES
> + help
> + An ASCII-art game like Space Invaders using ncurses.
Please add the upstream URL as part of the package help text.
> diff --git a/package/ascii-invaders/ascii-invaders.hash b/package/ascii-invaders/ascii-invaders.hash
> new file mode 100644
> index 0000000000..6c98401c36
> --- /dev/null
> +++ b/package/ascii-invaders/ascii-invaders.hash
> @@ -0,0 +1,2 @@
> +# Locally calculated
> +sha512 326708ffc2c277e04575920c58f6a267e0bf46f8d2a3dbca9b5c317fb01006d4f673ab35f92f292549cc52dbee4400a84c85478eb81b9bd7703689a705547bc7 v1.0.1.tar.gz
Please add the hash value for the license file.
> diff --git a/package/ascii-invaders/ascii-invaders.mk b/package/ascii-invaders/ascii-invaders.mk
> new file mode 100644
> index 0000000000..cb5aeaff27
> --- /dev/null
> +++ b/package/ascii-invaders/ascii-invaders.mk
> @@ -0,0 +1,23 @@
> +##############################################################################
This should be 80 hashes
> +#
> +# ASCII-Invaders
> +#
> +##############################################################################
Same here. 80 hashes.
Please run the following command to fix the formatting issues:
./utils/check-package package/ascii-invaders/*
> +
> +ASCII_INVADERS_VERSION = 1.0.1
> +ASCII_INVADERS_SOURCE = v$(ASCII_INVADERS_VERSION).tar.gz
> +ASCII_INVADERS_SITE = https://github.com/macdice/ascii-invaders/archive
> +ASCII_INVADERS_INSTALL_TARGET = YES
Default value, not required.
> +ASCII_INVADERS_DEPENDENCIES = ncurses
> +ASCII_INVADERS_LICENSE = GPL-2.0+
> +ASCII_INVADERS_LICENSE_FILES = LICENSE
> +
> +define ASCII_INVADERS_BUILD_CMDS
> + (cd $(@D) ; $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D))
The cd $(@D) is not needed here.
> +endef
> +
> +define ASCII_INVADERS_INSTALL_TARGET_CMDS
> + $(INSTALL) -D -m 0755 $(@D)/ascii_invaders $(TARGET_DIR)/usr/bin
It should be $(INSTALL) -D -m 0755 $(@D)/ascii_invaders
$(TARGET_DIR)/usr/bin/ascii_invaders
> +endef
> +
> +$(eval $(generic-package))
> --
> 2.17.2
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Please refer to the "How to test your package" section of Buildroot
user manual to verify that it can build at least in the 6 default
build configurations.
thanks!
Gilles.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH 3/3] package/frotz: new package
2019-02-23 20:56 ` [Buildroot] [PATCH 3/3] package/frotz: " Thomas Huth
@ 2019-03-16 17:15 ` Gilles Talis
0 siblings, 0 replies; 11+ messages in thread
From: Gilles Talis @ 2019-03-16 17:15 UTC (permalink / raw)
To: buildroot
Hello Thomas,
Le sam. 23 f?vr. 2019 ? 21:57, Thomas Huth <huth@tuxfamily.org> a ?crit :
>
> Frotz is an interpreter for old Infocom adventures and other Z-code games.
>
> Signed-off-by: Thomas Huth <huth@tuxfamily.org>
> ---
> package/Config.in | 1 +
> package/frotz/Config.in | 7 +++++++
> package/frotz/frotz.hash | 2 ++
> package/frotz/frotz.mk | 32 ++++++++++++++++++++++++++++++++
Please add an entry to the DEVELOPERS file for this package.
> 4 files changed, 42 insertions(+)
> create mode 100644 package/frotz/Config.in
> create mode 100644 package/frotz/frotz.hash
> create mode 100644 package/frotz/frotz.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index 16789fcd7c..d6f7ba0d75 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -244,6 +244,7 @@ menu "Games"
> source "package/doom-wad/Config.in"
> source "package/flare-engine/Config.in"
> source "package/flare-game/Config.in"
> + source "package/frotz/Config.in"
> source "package/gnuchess/Config.in"
> source "package/lbreakout2/Config.in"
> source "package/ltris/Config.in"
> diff --git a/package/frotz/Config.in b/package/frotz/Config.in
> new file mode 100644
> index 0000000000..4b3039613f
> --- /dev/null
> +++ b/package/frotz/Config.in
> @@ -0,0 +1,7 @@
> +config BR2_PACKAGE_FROTZ
> + bool "frotz"
> + select BR2_PACKAGE_NCURSES
> + help
> + Frotz is an interpreter for old Infocom adventure games and other Z-code
> + games. Note that frotz can not be run as root. You must add a normal user
> + to your buildroot configuration to be able to use it.
This file has some formatting issues. Please run the
./utils/check-package to fix them.
You need to add the upstream URL for this package as part of the help text.
> diff --git a/package/frotz/frotz.hash b/package/frotz/frotz.hash
> new file mode 100644
> index 0000000000..b441bffc31
> --- /dev/null
> +++ b/package/frotz/frotz.hash
> @@ -0,0 +1,2 @@
> +# Locally calculated
> +sha512 c3aeb1bca227db7b759be880c1fe14e3d46c79eae3f2891d2472ff1e1b17b2153b2e400d537d54dce68011079e230fe8176ebb7547b2ecbc30e44f2b7423c285 frotz-2.44.tar.bz2
Please add hash value for the license file.
> diff --git a/package/frotz/frotz.mk b/package/frotz/frotz.mk
> new file mode 100644
> index 0000000000..7f31e7d89b
> --- /dev/null
> +++ b/package/frotz/frotz.mk
> @@ -0,0 +1,32 @@
> +##############################################################################
It should be 80 hashes
> +#
> +# Frotz - the Z-code interpreter
Just "frotz" is enough
> +#
> +##############################################################################
Should be 80 hashes.
> +
> +FROTZ_VERSION = 2.44
> +FROTZ_SOURCE = frotz-$(FROTZ_VERSION).tar.bz2
> +FROTZ_SITE = https://gitlab.com/DavidGriffith/frotz/-/archive/$(FROTZ_VERSION)
> +FROTZ_INSTALL_TARGET = YES
Default value. Not needed.
> +FROTZ_DEPENDENCIES = ncurses
> +FROTZ_LICENSE = GPL-2.0+
> +FROTZ_LICENSE_FILES = COPYING
> +
> +define FROTZ_POST_EXTRACT_FIXUP
> + (cd $(@D); \
This is not needed.
> + sed -i 's/$ ar rc/ \$$\(AR\) rc/g' $(@D)/Makefile ; \
> + sed -i 's/$ ranlib/ \$$\(RANLIB\)/g' $(@D)/Makefile ; \
> + sed -i 's/$ strip/ \$$\(STRIP\)/g' $(@D)/Makefile )
> +endef
> +FROTZ_POST_EXTRACT_HOOKS += FROTZ_POST_EXTRACT_FIXUP
> +
> +define FROTZ_BUILD_CMDS
> + $(MAKE) $(TARGET_CONFIGURE_OPTS) PREFIX=/usr CONFIG_DIR=/etc -C $(@D)
> +endef
> +
> +define FROTZ_INSTALL_TARGET_CMDS
> + $(INSTALL) -D -m 0755 $(@D)/frotz $(TARGET_DIR)/usr/bin
it should be $(INSTALL) -D -m 0755 $(@D)/frotz $(TARGET_DIR)/usr/bin/frotz
> + $(INSTALL) -D -m 0644 $(@D)/doc/frotz.6 $(TARGET_DIR)/usr/man/man6
We do not install documentation in buildroot to try and keep the final
firmware small.
> +endef
> +
> +$(eval $(generic-package))
> --
> 2.17.2
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Please verify that your package at least build for the default
configurations by referring to the "How to test your package" in the
buildroot user manual.
thanks!
Gilles.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH 0/3] Some more games: XorCurses, ASCII-Invaders and Frotz
2019-03-07 11:16 ` [Buildroot] [PATCH 0/3] Some more games: XorCurses, ASCII-Invaders and Frotz Thomas Huth
@ 2019-03-17 15:16 ` Thomas Petazzoni
0 siblings, 0 replies; 11+ messages in thread
From: Thomas Petazzoni @ 2019-03-17 15:16 UTC (permalink / raw)
To: buildroot
Hello,
On Thu, 7 Mar 2019 12:16:20 +0100
Thomas Huth <huth@tuxfamily.org> wrote:
> Any comments? Are the patches not suitable for buildroot? No problem,
> just let me know and I'll shut up ;-) ... or is it that just nobody has
> enough spare time for a review?
Gilles Talis did a review of your patches on March 16. When you have
some time, could you take into account your comments, and send a v2 of
this patch series ?
In the mean time, I'll mark the patches as "Changes Requested" in
patchwork (our patch tracking tool).
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH 1/3] package/xorcurses: new package
2019-03-16 16:57 ` Gilles Talis
@ 2019-04-22 5:55 ` Thomas Huth
2019-06-03 18:22 ` Gilles Talis
0 siblings, 1 reply; 11+ messages in thread
From: Thomas Huth @ 2019-04-22 5:55 UTC (permalink / raw)
To: buildroot
Am Sat, 16 Mar 2019 17:57:28 +0100
schrieb Gilles Talis <gilles.talis@gmail.com>:
> Hello Thomas,
>
> Thanks for your contribution. Please find some comments below.
Hi Gilles,
thanks a lot for your review! I finally found some spare time to look
into this again, but I have some questions below...
> Le sam. 23 f?vr. 2019 ? 21:57, Thomas Huth <huth@tuxfamily.org> a
> ?crit :
[...]
> > diff --git a/package/xorcurses/xorcurses.hash
> > b/package/xorcurses/xorcurses.hash new file mode 100644
> > index 0000000000..49d3a0c3b9
> > --- /dev/null
> > +++ b/package/xorcurses/xorcurses.hash
> > @@ -0,0 +1,2 @@
> > +# Locally calculated
> > +sha512
> > 1782ebf6ae8798b32e0a8e5e20e6d0b44eb619f6e7f015735c6e86205bd545da108c36bff1c9cfc9e9b44dee8f90bacb9df70436991f57f51c2c87e94b3a4725
> > XorCurses-0.2.2.tar.bz2
> You also need to provide the hash for the license file.
There does not seem to be a license file in the tarball here, they just
mention in the README that the game is licensed under the GPL. I guess
I can skip the hash for the license file in this case?
Thomas
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH 1/3] package/xorcurses: new package
2019-04-22 5:55 ` Thomas Huth
@ 2019-06-03 18:22 ` Gilles Talis
0 siblings, 0 replies; 11+ messages in thread
From: Gilles Talis @ 2019-06-03 18:22 UTC (permalink / raw)
To: buildroot
Hello Thomas,
Le lun. 22 avr. 2019 ? 07:56, Thomas Huth <huth@tuxfamily.org> a ?crit :
>
> Am Sat, 16 Mar 2019 17:57:28 +0100
> schrieb Gilles Talis <gilles.talis@gmail.com>:
>
> > Hello Thomas,
> >
> > Thanks for your contribution. Please find some comments below.
>
> Hi Gilles,
>
> thanks a lot for your review! I finally found some spare time to look
> into this again, but I have some questions below...
All apologies for not coming back sooner on your patch.
> There does not seem to be a license file in the tarball here, they just
> mention in the README that the game is licensed under the GPL. I guess
> I can skip the hash for the license file in this case?
This is correct. If there's no actual license file, you can skip the
hash for it.
thanks
Gilles.
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2019-06-03 18:22 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-23 20:56 [Buildroot] [PATCH 0/3] Some more games: XorCurses, ASCII-Invaders and Frotz Thomas Huth
2019-02-23 20:56 ` [Buildroot] [PATCH 1/3] package/xorcurses: new package Thomas Huth
2019-03-16 16:57 ` Gilles Talis
2019-04-22 5:55 ` Thomas Huth
2019-06-03 18:22 ` Gilles Talis
2019-02-23 20:56 ` [Buildroot] [PATCH 2/3] package/ascii-invaders: " Thomas Huth
2019-03-16 17:04 ` Gilles Talis
2019-02-23 20:56 ` [Buildroot] [PATCH 3/3] package/frotz: " Thomas Huth
2019-03-16 17:15 ` Gilles Talis
2019-03-07 11:16 ` [Buildroot] [PATCH 0/3] Some more games: XorCurses, ASCII-Invaders and Frotz Thomas Huth
2019-03-17 15:16 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.