All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3 0/2] Staging: fbtft: Fix Various Checkpatch issues
@ 2019-02-25 16:05 Bhanusree Pola
  2019-02-25 16:05 ` [PATCH v3 1/2] Staging: fbtft: Extra blank line not required before '}' Bhanusree Pola
  2019-02-25 16:05 ` [PATCH v3 2/2] Staging: fbtft: Fix line over 80 characters Bhanusree Pola
  0 siblings, 2 replies; 3+ messages in thread
From: Bhanusree Pola @ 2019-02-25 16:05 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: Greg Kroah-Hartman

This series cleans the following checkpatch.pl issues:

CHECK: Extra blank line not required before closing brace '}'
WARNING:line over 80 characters

v2:
 [PATCH 1/2]: Commit log is made imperative
 [PATCH 2/2]: Commit log is made imperative
v3:
 [PATCH 2/2]: Commit log modified

Bhanusree Pola (2):
  Staging: fbtft: Extra blank line not required before '}'
  Staging: fbtft: Fix line over 80 characters

 drivers/staging/fbtft/fbtft-core.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

-- 
2.17.1



^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH v3 1/2] Staging: fbtft: Extra blank line not required before '}'
  2019-02-25 16:05 [PATCH v3 0/2] Staging: fbtft: Fix Various Checkpatch issues Bhanusree Pola
@ 2019-02-25 16:05 ` Bhanusree Pola
  2019-02-25 16:05 ` [PATCH v3 2/2] Staging: fbtft: Fix line over 80 characters Bhanusree Pola
  1 sibling, 0 replies; 3+ messages in thread
From: Bhanusree Pola @ 2019-02-25 16:05 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: Greg Kroah-Hartman

Remove unnecesessary extra blank line before the closing brace,
to solve the checkpatch.pl check:
CHECK: Extra blank line not required before closing brace '}'

Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
---
 drivers/staging/fbtft/fbtft-core.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c
index de3f431abc15..9d78ce6e819f 100644
--- a/drivers/staging/fbtft/fbtft-core.c
+++ b/drivers/staging/fbtft/fbtft-core.c
@@ -87,7 +87,6 @@ static int fbtft_request_one_gpio(struct fbtft_par *par,
 			dev_err(dev,
 				"Failed to request %s GPIO:%d\n", name, ret);
 			return ret;
-
 		}
 		fbtft_par_dbg(DEBUG_REQUEST_GPIOS, par, "%s: '%s' GPIO\n",
 			      __func__, name);
-- 
2.17.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH v3 2/2] Staging: fbtft: Fix line over 80 characters
  2019-02-25 16:05 [PATCH v3 0/2] Staging: fbtft: Fix Various Checkpatch issues Bhanusree Pola
  2019-02-25 16:05 ` [PATCH v3 1/2] Staging: fbtft: Extra blank line not required before '}' Bhanusree Pola
@ 2019-02-25 16:05 ` Bhanusree Pola
  1 sibling, 0 replies; 3+ messages in thread
From: Bhanusree Pola @ 2019-02-25 16:05 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: Greg Kroah-Hartman

Fix the checkpatch.pl warning:
WARNING:line over 80 characters
Move Parameters to the next lines with proper alignment

Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
---
 drivers/staging/fbtft/fbtft-core.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c
index 9d78ce6e819f..9b07badf4c6c 100644
--- a/drivers/staging/fbtft/fbtft-core.c
+++ b/drivers/staging/fbtft/fbtft-core.c
@@ -436,9 +436,9 @@ static unsigned int chan_to_field(unsigned int chan, struct fb_bitfield *bf)
 	return chan << bf->offset;
 }
 
-static int fbtft_fb_setcolreg(unsigned int regno, unsigned int red, unsigned int green,
-			      unsigned int blue, unsigned int transp,
-			      struct fb_info *info)
+static int fbtft_fb_setcolreg(unsigned int regno, unsigned int red,
+			      unsigned int green, unsigned int blue,
+			      unsigned int transp, struct fb_info *info)
 {
 	unsigned int val;
 	int ret = 1;
-- 
2.17.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-02-25 16:05 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-25 16:05 [PATCH v3 0/2] Staging: fbtft: Fix Various Checkpatch issues Bhanusree Pola
2019-02-25 16:05 ` [PATCH v3 1/2] Staging: fbtft: Extra blank line not required before '}' Bhanusree Pola
2019-02-25 16:05 ` [PATCH v3 2/2] Staging: fbtft: Fix line over 80 characters Bhanusree Pola

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.