* [Qemu-devel] [PATCH v2] iotests: drop unnecessary accel=kvm in 238
@ 2019-02-21 10:11 Stefan Hajnoczi
2019-02-21 10:24 ` Thomas Huth
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Hajnoczi @ 2019-02-21 10:11 UTC (permalink / raw)
To: qemu-devel
Cc: Kevin Wolf, qemu-block, Max Reitz, Vladimir Sementsov-Ogievskiy,
Stefan Hajnoczi, Thomas Huth
Test 238 does not require the kvm accelerator. TCG works fine.
Use the default accelerator instead of requiring kvm.
Suggested-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
Vladimir, I have dropped the 235 change because I don't have time to
figure out the kvm/tcg vs qtest differences or add a skip function.
Sorry!
tests/qemu-iotests/238 | 1 -
1 file changed, 1 deletion(-)
diff --git a/tests/qemu-iotests/238 b/tests/qemu-iotests/238
index f81ee1112f..e490bb4298 100755
--- a/tests/qemu-iotests/238
+++ b/tests/qemu-iotests/238
@@ -33,7 +33,6 @@ else:
virtio_scsi_device = 'virtio-scsi-pci'
vm = QEMUMachine(iotests.qemu_prog)
-vm.add_args('-machine', 'accel=kvm')
vm.launch()
log(vm.qmp('blockdev-add', node_name='hd0', driver='null-co'))
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH v2] iotests: drop unnecessary accel=kvm in 238
2019-02-21 10:11 [Qemu-devel] [PATCH v2] iotests: drop unnecessary accel=kvm in 238 Stefan Hajnoczi
@ 2019-02-21 10:24 ` Thomas Huth
2019-02-25 16:19 ` Stefan Hajnoczi
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Huth @ 2019-02-21 10:24 UTC (permalink / raw)
To: Stefan Hajnoczi, qemu-devel
Cc: Kevin Wolf, qemu-block, Max Reitz, Vladimir Sementsov-Ogievskiy
On 21/02/2019 11.11, Stefan Hajnoczi wrote:
> Test 238 does not require the kvm accelerator. TCG works fine.
>
> Use the default accelerator instead of requiring kvm.
>
> Suggested-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> Vladimir, I have dropped the 235 change because I don't have time to
> figure out the kvm/tcg vs qtest differences or add a skip function.
> Sorry!
>
> tests/qemu-iotests/238 | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tests/qemu-iotests/238 b/tests/qemu-iotests/238
> index f81ee1112f..e490bb4298 100755
> --- a/tests/qemu-iotests/238
> +++ b/tests/qemu-iotests/238
> @@ -33,7 +33,6 @@ else:
> virtio_scsi_device = 'virtio-scsi-pci'
>
> vm = QEMUMachine(iotests.qemu_prog)
> -vm.add_args('-machine', 'accel=kvm')
Would it be feasible to change it into "accel=qtest" instead? ... then
this test would also work when QEMU has been compiled with --disable-tcg
and when KVM is not available...
Thomas
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH v2] iotests: drop unnecessary accel=kvm in 238
2019-02-21 10:24 ` Thomas Huth
@ 2019-02-25 16:19 ` Stefan Hajnoczi
0 siblings, 0 replies; 3+ messages in thread
From: Stefan Hajnoczi @ 2019-02-25 16:19 UTC (permalink / raw)
To: Thomas Huth
Cc: qemu-devel, Kevin Wolf, qemu-block, Max Reitz,
Vladimir Sementsov-Ogievskiy
[-- Attachment #1: Type: text/plain, Size: 1257 bytes --]
On Thu, Feb 21, 2019 at 11:24:12AM +0100, Thomas Huth wrote:
> On 21/02/2019 11.11, Stefan Hajnoczi wrote:
> > Test 238 does not require the kvm accelerator. TCG works fine.
> >
> > Use the default accelerator instead of requiring kvm.
> >
> > Suggested-by: Thomas Huth <thuth@redhat.com>
> > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> > ---
> > Vladimir, I have dropped the 235 change because I don't have time to
> > figure out the kvm/tcg vs qtest differences or add a skip function.
> > Sorry!
> >
> > tests/qemu-iotests/238 | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/tests/qemu-iotests/238 b/tests/qemu-iotests/238
> > index f81ee1112f..e490bb4298 100755
> > --- a/tests/qemu-iotests/238
> > +++ b/tests/qemu-iotests/238
> > @@ -33,7 +33,6 @@ else:
> > virtio_scsi_device = 'virtio-scsi-pci'
> >
> > vm = QEMUMachine(iotests.qemu_prog)
> > -vm.add_args('-machine', 'accel=kvm')
>
> Would it be feasible to change it into "accel=qtest" instead? ... then
> this test would also work when QEMU has been compiled with --disable-tcg
> and when KVM is not available...
Sure. I have tested that qtest still triggered the bug when the fix was
merged.
Will fix in v3.
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-25 16:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-21 10:11 [Qemu-devel] [PATCH v2] iotests: drop unnecessary accel=kvm in 238 Stefan Hajnoczi
2019-02-21 10:24 ` Thomas Huth
2019-02-25 16:19 ` Stefan Hajnoczi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.