[PATCH v2] Staging: vt6655: Fix check - Lines should not end with a '('

[PATCH v2] Staging: vt6655: Fix check - Lines should not end with a '('

[Madhumitha Prabakaran]

Improve readibility

Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
---
Changes in v2
 -Make a commit message imperative.
 -Use multiple lines to improve readibility

 drivers/staging/vt6655/baseband.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/vt6655/baseband.c b/drivers/staging/vt6655/baseband.c
index d8321e7fd68b..35bbff807df9 100644
--- a/drivers/staging/vt6655/baseband.c
+++ b/drivers/staging/vt6655/baseband.c
@@ -1704,8 +1704,10 @@ static const unsigned short awcFrameTime[MAX_RATE] = {
  * Return Value: FrameTime
  *
  */
-unsigned int BBuGetFrameTime(unsigned char byPreambleType,				unsigned char byPktType,
-	unsigned int cbFrameLength,							unsigned short wRate)
+unsigned int BBuGetFrameTime(unsigned char byPreambleType,
+	unsigned char byPktType,
+	unsigned int cbFrameLength,
+	unsigned short wRate)
 {
 	unsigned int uFrameTime;
 	unsigned int uPreamble;
-- 
2.17.1

Re: [Outreachy kernel] [PATCH v2] Staging: vt6655: Fix check - Lines should not end with a '('

[Julia Lawall]

On Mon, 25 Feb 2019, Madhumitha Prabakaran wrote:

> Improve readibility
>
> Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
> ---
> Changes in v2
>  -Make a commit message imperative.
>  -Use multiple lines to improve readibility
>
>  drivers/staging/vt6655/baseband.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/vt6655/baseband.c b/drivers/staging/vt6655/baseband.c
> index d8321e7fd68b..35bbff807df9 100644
> --- a/drivers/staging/vt6655/baseband.c
> +++ b/drivers/staging/vt6655/baseband.c
> @@ -1704,8 +1704,10 @@ static const unsigned short awcFrameTime[MAX_RATE] = {
>   * Return Value: FrameTime
>   *
>   */
> -unsigned int BBuGetFrameTime(unsigned char byPreambleType,				unsigned char byPktType,
> -	unsigned int cbFrameLength,							unsigned short wRate)
> +unsigned int BBuGetFrameTime(unsigned char byPreambleType,
> +	unsigned char byPktType,
> +	unsigned int cbFrameLength,
> +	unsigned short wRate)

This is just inviting another patch to line up the parameters to the right
of the (.  I would have expected that checkpatch would have complained
about this.

>  {
>  	unsigned int uFrameTime;
>  	unsigned int uPreamble;

This looks ripe for some other changes - not using camel case and not
encoding types in variable names (the u).

julia

> --
> 2.17.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190225171403.393-1-madhumithabiw%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [Outreachy kernel] [PATCH v2] Staging: vt6655: Fix check - Lines should not end with a '('

[Madhumthia Prabakaran]

On Mon, Feb 25, 2019 at 09:56:23PM +0100, Julia Lawall wrote:
> 
> 
> On Mon, 25 Feb 2019, Madhumitha Prabakaran wrote:
> 
> > Improve readibility
> >
> > Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
> > ---
> > Changes in v2
> >  -Make a commit message imperative.
> >  -Use multiple lines to improve readibility
> >
> >  drivers/staging/vt6655/baseband.c | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/vt6655/baseband.c b/drivers/staging/vt6655/baseband.c
> > index d8321e7fd68b..35bbff807df9 100644
> > --- a/drivers/staging/vt6655/baseband.c
> > +++ b/drivers/staging/vt6655/baseband.c
> > @@ -1704,8 +1704,10 @@ static const unsigned short awcFrameTime[MAX_RATE] = {
> >   * Return Value: FrameTime
> >   *
> >   */
> > -unsigned int BBuGetFrameTime(unsigned char byPreambleType,				unsigned char byPktType,
> > -	unsigned int cbFrameLength,							unsigned short wRate)
> > +unsigned int BBuGetFrameTime(unsigned char byPreambleType,
> > +	unsigned char byPktType,
> > +	unsigned int cbFrameLength,
> > +	unsigned short wRate)
> 
> This is just inviting another patch to line up the parameters to the right
> of the (.  I would have expected that checkpatch would have complained
> about this.
> 
> >  {
> >  	unsigned int uFrameTime;
> >  	unsigned int uPreamble;
> 
> This looks ripe for some other changes - not using camel case and not
> encoding types in variable names (the u).
> 
> julia
> 
> > --
> > 2.17.1
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190225171403.393-1-madhumithabiw%40gmail.com.
> > For more options, visit https://groups.google.com/d/optout.
> >
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/alpine.DEB.2.21.1902252154390.2481%40hadrien.
> For more options, visit https://groups.google.com/d/optout.
I will fix it and change the commit message 

Madhumitha